coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[S] Change in coreboot[master]: drivers/intel/fsp2_0: Print `mrc_cache` size in decimal
by Eric Lai (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Subrata Banik, Andrey Petrov. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73490 ) Change subject: drivers/intel/fsp2_0: Print `mrc_cache` size in decimal ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69feeb36423e47a5992c9f27d9a7042803a492cd Gerrit-Change-Number: 73490 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 08:34:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/intel/fsp2_0: Print `mrc_cache` size in decimal
by Subrata Banik (Code Review) 06 Mar '23

06 Mar '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73490 ) Change subject: drivers/intel/fsp2_0: Print `mrc_cache` size in decimal ...................................................................... drivers/intel/fsp2_0: Print `mrc_cache` size in decimal This patch updates the print msg of mrc_cache size from hex to decimal for easier understanding while debugging the issue. TEST=Able to build and boot google/rex. Without this patch: [SPEW ] MRC cache found, size ee75 With this patch: [SPEW ] MRC cache found, size 61045 bytes Change-Id: I69feeb36423e47a5992c9f27d9a7042803a492cd Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/drivers/intel/fsp2_0/memory_init.c 1 file changed, 24 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/73490/1 diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c index 740b9c6..bb8249f 100644 --- a/src/drivers/intel/fsp2_0/memory_init.c +++ b/src/drivers/intel/fsp2_0/memory_init.c @@ -86,7 +86,7 @@ /* MRC cache found */ arch_upd->NvsBufferPtr = (uintptr_t)data; - printk(BIOS_SPEW, "MRC cache found, size %zx\n", mrc_size); + printk(BIOS_SPEW, "MRC cache found, size %ld bytes\n", mrc_size); } static enum cb_err check_region_overlap(const struct memranges *ranges, -- To view, visit https://review.coreboot.org/c/coreboot/+/73490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69feeb36423e47a5992c9f27d9a7042803a492cd Gerrit-Change-Number: 73490 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: [WIP] mb/google/kukui: Add Samsung K3UBE3D4AB-MGCL 4GB and Hynix H54G...
by Sheng-Liang Pan (Code Review) 06 Mar '23

06 Mar '23

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73469 ) Change subject: [WIP] mb/google/kukui: Add Samsung K3UBE3D4AB-MGCL 4GB and Hynix H54G68CYRBX248 8GB support for Pico ...................................................................... Patch Set 2: Code-Review-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/73469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 Gerrit-Change-Number: 73469 Gerrit-PatchSet: 2 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Mar 2023 08:20:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM
by Yu-Ping Wu (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: cong yang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73443 ) Change subject: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM ...................................................................... Patch Set 4: (3 comments) File src/mainboard/google/geralt/display.c: https://review.coreboot.org/c/coreboot/+/73443/comment/3512c8c0_9eb01d1d PS4, Line 24: void tps65132s_program_eeprom(void) Move this below `configure_display()` to be consistent with the order in display.h. https://review.coreboot.org/c/coreboot/+/73443/comment/1484df07_1010dc5b PS4, Line 40: !(value == 0x11 && value1 == 0x11) value != 0x11 || value1 != 0x11 File src/mainboard/google/geralt/panel_geralt.c: https://review.coreboot.org/c/coreboot/+/73443/comment/40e23e98_4e240ee8 PS4, Line 32: tps65132s_program_eeprom(); One blank line below. -- To view, visit https://review.coreboot.org/c/coreboot/+/73443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29236818444cac84d42386a371cd8934048ff948 Gerrit-Change-Number: 73443 Gerrit-PatchSet: 4 Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 08:19:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [WIP] mb/google/kukui: Add Samsung K3UBE3D4AB-MGCL 4GB and Hynix H54G...
by Sheng-Liang Pan (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Sheng-Liang Pan. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73469 to look at the new patch set (#2). Change subject: [WIP] mb/google/kukui: Add Samsung K3UBE3D4AB-MGCL 4GB and Hynix H54G68CYRBX248 8GB support for Pico ...................................................................... [WIP] mb/google/kukui: Add Samsung K3UBE3D4AB-MGCL 4GB and Hynix H54G68CYRBX248 8GB support for Pico leverage sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB SPD for K4UBE3D4AB-MGCL 4GB and sdram-lpddr4x-H9HCNNNFAMMLXR-NEE-8GB for H54G68CYRBX248 8GB BUG=none BRANCH=kukui TEST=emerge-jacuzzi coreboot Signed-off-by: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 --- M src/mainboard/google/kukui/sdram_configs.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/73469/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 Gerrit-Change-Number: 73469 Gerrit-PatchSet: 2 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: [WIP] mb/google/kukui: Add Samsung K3UBE3D4AB-MGCL 4GB and Hynix H54G...
by build bot (Jenkins) (Code Review) 06 Mar '23

06 Mar '23

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73469 ) Change subject: [WIP] mb/google/kukui: Add Samsung K3UBE3D4AB-MGCL 4GB and Hynix H54G68CYRBX248 8GB support for Pico ...................................................................... Patch Set 1: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171474): https://review.coreboot.org/c/coreboot/+/73469/comment/04b0d922_e76ea98d PS1, Line 6: Possible long commit subject (prefer a maximum 65 characters) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171474): https://review.coreboot.org/c/coreboot/+/73469/comment/0a4186c0_59b7808c PS1, Line 9: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/73469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 Gerrit-Change-Number: 73469 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Mar 2023 07:53:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [WIP] mb/google/kukui: Add Samsung K3UBE3D4AB-MGCL 4GB and Hynix H54G...
by Sheng-Liang Pan (Code Review) 06 Mar '23

06 Mar '23

Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73469 ) Change subject: [WIP] mb/google/kukui: Add Samsung K3UBE3D4AB-MGCL 4GB and Hynix H54G68CYRBX248 8GB support for Pico ...................................................................... [WIP] mb/google/kukui: Add Samsung K3UBE3D4AB-MGCL 4GB and Hynix H54G68CYRBX248 8GB support for Pico leverage sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB SPD configuration for K4UBE3D4AB-MGCL 4GB and sdram-lpddr4x-H9HCNNNFAMMLXR-NEE-8GB for H54G68CYRBX248 8GB BUG= BRANCH=kukui TEST=emerge-jacuzzi coreboot Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 --- M src/mainboard/google/kukui/sdram_configs.c 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/73469/1 diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c index 5938785..0258dad 100644 --- a/src/mainboard/google/kukui/sdram_configs.c +++ b/src/mainboard/google/kukui/sdram_configs.c @@ -59,6 +59,8 @@ [0x39] = "sdram-lpddr4x-MT53E2G32D4NQ-046-8GB", [0x3a] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", [0x3b] = "sdram-lpddr4x-H9HCNNNFAMMLXR-NEE-8GB", + [0x3c] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB", + [0x3d] = "sdram-lpddr4x-H9HCNNNFAMMLXR-NEE-8GB", /* Table shared by Kappa and its variants, offset = 0x40 */ [0x40] = "sdram-lpddr4x-K4UBE3D4AA-MGCR-4GB", -- To view, visit https://review.coreboot.org/c/coreboot/+/73469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5b484b5324ba39dbb220f12bdb8344ecb5c4da5 Gerrit-Change-Number: 73469 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Extend sd_hold for touchpad/touchscreen
by Tyler Wang (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Ren Kuo, Reka Norman, Nick Vaccaro. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73349 ) Change subject: mb/google/nissa/var/craask: Extend sd_hold for touchpad/touchscreen ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/73349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec2f72da80ffe8d4dd494caabbe1a97e52a81e78 Gerrit-Change-Number: 73349 Gerrit-PatchSet: 4 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quantatw.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quantatw.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quantatw.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 06:28:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Extend sd_hold for touchpad/touchscreen
by Tyler Wang (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: David Wu, Ren Kuo. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73349 ) Change subject: mb/google/nissa/var/craask: Extend sd_hold for touchpad/touchscreen ...................................................................... Patch Set 4: -Code-Review This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/73349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec2f72da80ffe8d4dd494caabbe1a97e52a81e78 Gerrit-Change-Number: 73349 Gerrit-PatchSet: 4 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 06:22:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp: add function declarations in ramstage for SPR-SP
by Johnny Lin (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Jonathan Zhang, TimLiu-SMCI, David Hendricks, Christian Walter, Jian-Ming Wang, Arthur Heymans, Shelly Chang, Tim Chu. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72618 ) Change subject: soc/intel/xeon_sp: add function declarations in ramstage for SPR-SP ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Patchset: PS1: > Can this be squashed into CB:72443? Good idea. Done. PS1: We can abandon it, it's squashed into CB:72443 patchset 10. -- To view, visit https://review.coreboot.org/c/coreboot/+/72618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I345ec6269bd47046cc704986c6fcaff1e9678ff3 Gerrit-Change-Number: 72618 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 06:11:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023