Attention is currently required from: cong yang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73443 )
Change subject: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/73443
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29236818444cac84d42386a371cd8934048ff948
Gerrit-Change-Number: 73443
Gerrit-PatchSet: 5
Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 09:12:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
John Su has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/73489 )
Change subject: spd/lp5: Add new memory part to LP5 list
......................................................................
spd/lp5: Add new memory part to LP5 list
Add MICRON memory part MT62F1G32D2DS-023 and MT62F2G32D4DS-023 to LP5 global list. Attributes are derived from data sheets. Also, regenerate
the SPD files for SoC using the newly added parts.
BUG=b:271188237
TEST=util/spd_tools/bin/spd_gen spd/lp5/memory_parts.json lp5
Change-Id: I6675a68b7a515bd6d21db3ea2da762b06dee017a
Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com>
---
M spd/lp5/memory_parts.json
M spd/lp5/set-0/parts_spd_manifest.generated.txt
M spd/lp5/set-1/parts_spd_manifest.generated.txt
3 files changed, 42 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/73489/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/73489
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6675a68b7a515bd6d21db3ea2da762b06dee017a
Gerrit-Change-Number: 73489
Gerrit-PatchSet: 2
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73489 )
Change subject: spd/lp5: Add new memory part to LP5 list
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171478):
https://review.coreboot.org/c/coreboot/+/73489/comment/f5f5e730_7ee0d8c6
PS1, Line 8:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171478):
https://review.coreboot.org/c/coreboot/+/73489/comment/763b470d_a3d04532
PS1, Line 9: Add MICRON memory part MT62F1G32D2DS-023 and MT62F2G32D4DS-023 to LP5 global
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/73489
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6675a68b7a515bd6d21db3ea2da762b06dee017a
Gerrit-Change-Number: 73489
Gerrit-PatchSet: 1
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 06 Mar 2023 08:53:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Yu-Ping Wu.
cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73443 )
Change subject: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM
......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/geralt/display.c:
https://review.coreboot.org/c/coreboot/+/73443/comment/5b2cfab5_4bf315f9
PS4, Line 24: void tps65132s_program_eeprom(void)
> Move this below `configure_display()` to be consistent with the order in display.h.
Done
https://review.coreboot.org/c/coreboot/+/73443/comment/53110a79_96ca77ae
PS4, Line 40: !(value == 0x11 && value1 == 0x11)
> value != 0x11 || value1 != 0x11
Done
File src/mainboard/google/geralt/panel_geralt.c:
https://review.coreboot.org/c/coreboot/+/73443/comment/339ad825_c99dcd1b
PS4, Line 32: tps65132s_program_eeprom();
> One blank line below.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/73443
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29236818444cac84d42386a371cd8934048ff948
Gerrit-Change-Number: 73443
Gerrit-PatchSet: 5
Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 08:43:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Ren Kuo, Reka Norman, Tyler Wang, Nick Vaccaro.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73349 )
Change subject: mb/google/nissa/var/craask: Extend sd_hold for touchpad/touchscreen
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/73349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec2f72da80ffe8d4dd494caabbe1a97e52a81e78
Gerrit-Change-Number: 73349
Gerrit-PatchSet: 4
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quantatw.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quantatw.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quantatw.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 08:38:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: cong yang.
Hello build bot (Jenkins), Rex-BC Chen, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73443
to look at the new patch set (#5).
Change subject: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM
......................................................................
mb/google/geralt: Set +-5.7V to TPS65132s EEPROM
It is necessary to increase the AVDD/AVEE of TPS65132s PMIC to +-5.7V
for powering on BOE_TV110C9M_LL0. So we set the default value to +-5.7V
and program the value to the EEPROM when configuring the display at the
first time. In this way, TPS65132s could load the correct setting from
the EEPROM after booting into kernel.
BUG=b:268292556
TEST=test firmware display pass and AVDD/AVEE is +-5.7V on Geralt.
Change-Id: I29236818444cac84d42386a371cd8934048ff948
Signed-off-by: yangcong <yangcong5(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/geralt/display.c
M src/mainboard/google/geralt/display.h
M src/mainboard/google/geralt/panel_geralt.c
3 files changed, 70 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/73443/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/73443
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29236818444cac84d42386a371cd8934048ff948
Gerrit-Change-Number: 73443
Gerrit-PatchSet: 5
Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset