coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[M] Change in coreboot[master]: mb/google/hades: Change memory to SODIMM
by Eric Lai (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73389 ) Change subject: mb/google/hades: Change memory to SODIMM ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/baseboard/hades/memory.c: https://review.coreboot.org/c/coreboot/+/73389/comment/33af535d_15f6ad46 PS2, Line 9: .type = MEM_TYPE_DDR4, > the SODIMMs should be DDR5 parts Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ec79c3d8f1147a875c4d04017bb50347121ebb Gerrit-Change-Number: 73389 Gerrit-PatchSet: 3 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 12:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/{brya,hdaes}/include/ec: Add EC_HOST_EVENT_GPU
by Eric Lai (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Daisuke Nojiri, Tarun Tuli, Caveh Jalali, Nick Vaccaro. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73217 ) Change subject: mb/{brya,hdaes}/include/ec: Add EC_HOST_EVENT_GPU ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/73217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d7bf52efa9572e1bbd2f307420e09a7398a1ca9 Gerrit-Change-Number: 73217 Gerrit-PatchSet: 11 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 12:43:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/hades: Change memory to SODIMM
by Tarun Tuli (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Eric Lai. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73389 ) Change subject: mb/google/hades: Change memory to SODIMM ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/baseboard/hades/memory.c: https://review.coreboot.org/c/coreboot/+/73389/comment/4aea7de5_9ca81d2c PS2, Line 9: .type = MEM_TYPE_DDR4, the SODIMMs should be DDR5 parts -- To view, visit https://review.coreboot.org/c/coreboot/+/73389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ec79c3d8f1147a875c4d04017bb50347121ebb Gerrit-Change-Number: 73389 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 12:37:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/{brya,hdaes}/include/ec: Add EC_HOST_EVENT_GPU
by Tarun Tuli (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Daisuke Nojiri, Caveh Jalali, Nick Vaccaro, Eric Lai. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73217 ) Change subject: mb/{brya,hdaes}/include/ec: Add EC_HOST_EVENT_GPU ...................................................................... Patch Set 11: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73217/comment/fe83faf2_e9897ddb PS8, Line 7: mb/brya/variant/bb/{brya,hades}/include/ec > mb/{brya,hades}/include/ec: Done File src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h: https://review.coreboot.org/c/coreboot/+/73217/comment/3dc7015e_fb92bf15 PS8, Line 19: EC_HOST_EVENT_GPU > You can guard with Kconfig for brya? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d7bf52efa9572e1bbd2f307420e09a7398a1ca9 Gerrit-Change-Number: 73217 Gerrit-PatchSet: 11 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 12:20:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/{brya,hdaes}/include/ec: Add EC_HOST_EVENT_GPU
by Tarun Tuli (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Daisuke Nojiri, Tarun Tuli, Caveh Jalali, Nick Vaccaro. Hello Daisuke Nojiri, build bot (Jenkins), Caveh Jalali, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73217 to look at the new patch set (#11). Change subject: mb/{brya,hdaes}/include/ec: Add EC_HOST_EVENT_GPU ...................................................................... mb/{brya,hdaes}/include/ec: Add EC_HOST_EVENT_GPU EC_HOST_EVENT_GPU was renamed from EC_HOST_EVENT_USB_CHARGER and thought to no longer be used. It was subsequently removed in I9e3e0e9b45385766343489ae2d8fc43fb0954923 Add back the mask for this event as it is infact required on certain Brya (Agah) and Hades variants. Signed-off-by: Tarun Tuli <taruntuli(a)google.com> BUG=b:216485035,b:258126464,b:266631157 BRANCH=none TEST=D-notifier events are received again from EC Change-Id: I9d7bf52efa9572e1bbd2f307420e09a7398a1ca9 --- M src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h M src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/ec.h 2 files changed, 32 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/73217/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/73217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d7bf52efa9572e1bbd2f307420e09a7398a1ca9 Gerrit-Change-Number: 73217 Gerrit-PatchSet: 11 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/brya/include/ec: Add EC_HOST_EVENT_GPU
by Tarun Tuli (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Daisuke Nojiri, Tarun Tuli, Caveh Jalali, Nick Vaccaro. Hello Daisuke Nojiri, build bot (Jenkins), Caveh Jalali, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73217 to look at the new patch set (#10). Change subject: mb/brya/include/ec: Add EC_HOST_EVENT_GPU ...................................................................... mb/brya/include/ec: Add EC_HOST_EVENT_GPU EC_HOST_EVENT_GPU was renamed from EC_HOST_EVENT_USB_CHARGER and thought to no longer be used. It was subsequently removed in I9e3e0e9b45385766343489ae2d8fc43fb0954923 Add back the mask for this event as it is infact required on certain Brya (Agah) and Hades variants. Signed-off-by: Tarun Tuli <taruntuli(a)google.com> BUG=b:216485035,b:258126464,b:266631157 BRANCH=none TEST=D-notifier events are received again from EC Change-Id: I9d7bf52efa9572e1bbd2f307420e09a7398a1ca9 --- M src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h M src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/ec.h 2 files changed, 32 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/73217/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/73217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d7bf52efa9572e1bbd2f307420e09a7398a1ca9 Gerrit-Change-Number: 73217 Gerrit-PatchSet: 10 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Kevin Keijzer (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Paul Menzel, Angel Pons, Arthur Heymans, Nicholas Chin, Fabian Groffen, Elyes Haouas. Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... Patch Set 8: Code-Review+1 (6 comments) File src/mainboard/asrock/b75m-itx/board_info.txt: https://review.coreboot.org/c/coreboot/+/73097/comment/64253804_4afdeefd PS7, Line 2: http > https Done File src/mainboard/asrock/b75m-itx/cmos.layout: https://review.coreboot.org/c/coreboot/+/73097/comment/a9e4b39f_a294e6ea PS7, Line 86: cpu_fan_header > cpu_fan_tach_src Done File src/mainboard/asrock/b75m-itx/devicetree.cb: https://review.coreboot.org/c/coreboot/+/73097/comment/62d1ac8b_b050bdf6 PS7, Line 7: register "gpu_panel_port_select" = "PANEL_PORT_LVDS" : register "gpu_panel_power_cycle_delay" = "4" > This seems incorrect. It can be dropped. Done https://review.coreboot.org/c/coreboot/+/73097/comment/dbc7591e_2d0973d1 PS7, Line 14: device pci 01.0 off end > This should be enabled, the board has a PCIe x16 slot. Done https://review.coreboot.org/c/coreboot/+/73097/comment/55f0b12d_cf9f23eb PS7, Line 19: register "docking_supported" = "0" > The devicetree "registers" translate to a C struct initialiser. […] Done https://review.coreboot.org/c/coreboot/+/73097/comment/ccf722e0_bbc766ac PS7, Line 23: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" : register "pcie_port_coalesce" = "false" > See reasoning above, these can be dropped as well. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 8 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 06 Mar 2023 11:09:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Kevin Keijzer (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Kevin Keijzer, Paul Menzel, Arthur Heymans, Nicholas Chin, Fabian Groffen, Elyes Haouas. Kevin Keijzer has uploaded a new patch set (#8) to the change originally created by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX This board is based off b75pro3-m, which is very similar. Compared to it, it just lacks a COM1 header, and the secondary ASMedia SATA3 controller. Tested with: CPUs: - Core i5-3330 - Core i5-3470 - Core i7-3770 RAM: - single bank 4GB CL11 - two banks 4+4GB CL9 - two banks 8+8GB CL10 OS: - Gentoo Linux LiveUSB, KDE desktop (Linux 5.15.72) Working: - GRUB2 payload with embedded default config for boot from USB, disk - UEFI EDK2 payload - Intel ME stripped - Native raminit - Integrated graphics with libgfxinit (HDMI, DVI and VGA) - (boot from) SATA2, SATA3, ports - Rear USB 2 and 3 ports (supports boot) - Internal USB 3.0 ports - Realtek GbE NIC - 2.0 channel audio via lineout jack output - ACPI (power button triggers OS event) Untested: - Internal USB 2.0 ports - eSATA port - 7.1 channel audio Signed-off-by: Fabian Groffen <grobian(a)gentoo.org> Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb --- A src/mainboard/asrock/b75m-itx/Kconfig A src/mainboard/asrock/b75m-itx/Kconfig.name A src/mainboard/asrock/b75m-itx/Makefile.inc A src/mainboard/asrock/b75m-itx/acpi/ec.asl A src/mainboard/asrock/b75m-itx/acpi/platform.asl A src/mainboard/asrock/b75m-itx/acpi/superio.asl A src/mainboard/asrock/b75m-itx/board_info.txt A src/mainboard/asrock/b75m-itx/cmos.default A src/mainboard/asrock/b75m-itx/cmos.layout A src/mainboard/asrock/b75m-itx/data.vbt A src/mainboard/asrock/b75m-itx/devicetree.cb A src/mainboard/asrock/b75m-itx/dsdt.asl A src/mainboard/asrock/b75m-itx/early_init.c A src/mainboard/asrock/b75m-itx/gma-mainboard.ads A src/mainboard/asrock/b75m-itx/gpio.c A src/mainboard/asrock/b75m-itx/hda_verb.c A src/mainboard/asrock/b75m-itx/mainboard.c 17 files changed, 613 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/73097/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 8 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Angel Pons (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Kevin Keijzer, Paul Menzel, Arthur Heymans, Nicholas Chin, Fabian Groffen, Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... Patch Set 7: Code-Review+1 (7 comments) File src/mainboard/asrock/b75m-itx/board_info.txt: https://review.coreboot.org/c/coreboot/+/73097/comment/3eaaf06e_43d6d7cb PS7, Line 2: http https File src/mainboard/asrock/b75m-itx/cmos.layout: https://review.coreboot.org/c/coreboot/+/73097/comment/f2c721c0_d211a5cf PS7, Line 86: cpu_fan_header cpu_fan_tach_src File src/mainboard/asrock/b75m-itx/devicetree.cb: https://review.coreboot.org/c/coreboot/+/73097/comment/ed03f998_d0892d7a PS2, Line 84: device pci 1e.0 on # PCI bridge : subsystemid 0x1849 0x244e : end > Done Vendor firmware may do things wrong. File src/mainboard/asrock/b75m-itx/devicetree.cb: https://review.coreboot.org/c/coreboot/+/73097/comment/cffd80eb_d6228d55 PS7, Line 7: register "gpu_panel_port_select" = "PANEL_PORT_LVDS" : register "gpu_panel_power_cycle_delay" = "4" This seems incorrect. It can be dropped. https://review.coreboot.org/c/coreboot/+/73097/comment/0b69e794_f679af9b PS7, Line 14: device pci 01.0 off end This should be enabled, the board has a PCIe x16 slot. https://review.coreboot.org/c/coreboot/+/73097/comment/ee4c721a_57a47bce PS7, Line 19: register "docking_supported" = "0" The devicetree "registers" translate to a C struct initialiser. Given that any not-explicitly-initialised members default to 0, you can drop this. https://review.coreboot.org/c/coreboot/+/73097/comment/86159767_a027c5bb PS7, Line 23: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" : register "pcie_port_coalesce" = "false" See reasoning above, these can be dropped as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 7 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 06 Mar 2023 10:56:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Fabian Groffen <grobian(a)gentoo.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: spd/lp5: Add new memory part to LP5 list
by Subrata Banik (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Frank Wu, John Su, Dtrain Hsu, Eric Lai, Karthik Ramasubramanian. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73489 ) Change subject: spd/lp5: Add new memory part to LP5 list ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6675a68b7a515bd6d21db3ea2da762b06dee017a Gerrit-Change-Number: 73489 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 10:37:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023