coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[M] Change in coreboot[master]: mb/google/hades: Change memory to SODIMM
by Eric Lai (Code Review) 06 Mar '23

06 Mar '23

Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73389 ) Change subject: mb/google/hades: Change memory to SODIMM ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Will try and get these tested ahead of time on RVP with DDR5 Not quite sure the DDR5 SPD CL is ready or not. I think Meera's one still pending? CB:52731 -- To view, visit https://review.coreboot.org/c/coreboot/+/73389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ec79c3d8f1147a875c4d04017bb50347121ebb Gerrit-Change-Number: 73389 Gerrit-PatchSet: 3 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 06 Mar 2023 14:46:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: amdfwtool: Add combo index and combo config table
by Bao Zheng (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Zheng Bao. Hello Zheng Bao, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/73496 to review the following change. Change subject: amdfwtool: Add combo index and combo config table ...................................................................... amdfwtool: Add combo index and combo config table For now, combo index is 0, and only first entry in config table is used. Next the index will grow. Change-Id: I00609d91defc08e17f937ac8339575f84b1bd37c Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h 2 files changed, 37 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/73496/1 diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 1fcf8a0..554c91a 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -2161,6 +2161,8 @@ psp_directory_table *pspdir2 = NULL; psp_directory_table *pspdir2_b = NULL; psp_combo_directory *psp_combo_dir = NULL, *bhd_combo_dir = NULL; + char *combo_config[4] = { 0 }; + int combo_index = 0; int fuse_defined = 0; int targetfd; char *output = NULL, *config = NULL; @@ -2551,15 +2553,22 @@ bhd_combo_dir = new_combo_dir(&ctx); } - if (config) { - config_handle = fopen(config, "r"); + if (config) + combo_config[0] = config; + + combo_index = 0; + + /* for non-combo image, combo_config[0] == config */ + if (combo_config[combo_index]) { + config_handle = fopen(combo_config[combo_index], "r"); if (config_handle == NULL) { fprintf(stderr, "Can not open file %s for reading: %s\n", - config, strerror(errno)); + combo_config[combo_index], strerror(errno)); exit(1); } if (process_config(config_handle, &cb_config, list_deps) == 0) { - fprintf(stderr, "Configuration file %s parsing error\n", config); + fprintf(stderr, "Configuration file %s parsing error\n", + combo_config[combo_index]); fclose(config_handle); exit(1); } @@ -2619,12 +2628,13 @@ } else { fill_psp_directory_to_efs(amd_romsig, psp_combo_dir, &ctx, &cb_config); /* 0 -Compare PSP ID, 1 -Compare chip family ID */ - psp_combo_dir->entries[0].id_sel = 0; - psp_combo_dir->entries[0].id = get_psp_id(cb_config.soc_id); - psp_combo_dir->entries[0].lvl2_addr = + assert_fw_entry(combo_index, MAX_COMBO_ENTRIES, &ctx); + psp_combo_dir->entries[combo_index].id_sel = 0; + psp_combo_dir->entries[combo_index].id = get_psp_id(cb_config.soc_id); + psp_combo_dir->entries[combo_index].lvl2_addr = BUFF_TO_RUN_MODE(ctx, pspdir, AMD_ADDR_REL_BIOS); - fill_dir_header(psp_combo_dir, 1, PSP2_COOKIE, &ctx); + fill_dir_header(psp_combo_dir, combo_index + 1, PSP2_COOKIE, &ctx); } if (have_bios_tables(amd_bios_table)) { @@ -2664,12 +2674,13 @@ fill_bios_directory_to_efs(amd_romsig, biosdir, &ctx, &cb_config); } else { fill_bios_directory_to_efs(amd_romsig, bhd_combo_dir, &ctx, &cb_config); - bhd_combo_dir->entries[0].id_sel = 0; - bhd_combo_dir->entries[0].id = get_psp_id(cb_config.soc_id); - bhd_combo_dir->entries[0].lvl2_addr = + assert_fw_entry(combo_index, MAX_COMBO_ENTRIES, &ctx); + bhd_combo_dir->entries[combo_index].id_sel = 0; + bhd_combo_dir->entries[combo_index].id = get_psp_id(cb_config.soc_id); + bhd_combo_dir->entries[combo_index].lvl2_addr = BUFF_TO_RUN_MODE(ctx, biosdir, AMD_ADDR_REL_BIOS); - fill_dir_header(bhd_combo_dir, 1, BHD2_COOKIE, &ctx); + fill_dir_header(bhd_combo_dir, combo_index + 1, BHD2_COOKIE, &ctx); } } diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h index 2ccb3e9..42a2c1d 100644 --- a/util/amdfwtool/amdfwtool.h +++ b/util/amdfwtool/amdfwtool.h @@ -237,7 +237,7 @@ psp_combo_entry entries[]; } __attribute__((packed, aligned(16))) psp_combo_directory; -#define MAX_COMBO_ENTRIES 1 +#define MAX_COMBO_ENTRIES 2 typedef struct _bios_directory_hdr { uint32_t cookie; -- To view, visit https://review.coreboot.org/c/coreboot/+/73496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00609d91defc08e17f937ac8339575f84b1bd37c Gerrit-Change-Number: 73496 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: amdfwtool: Resequence some steps for the loop for combo
by Bao Zheng (Code Review) 06 Mar '23

06 Mar '23

Hello build bot (Jenkins), Zheng Bao, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/66784 to look at the new patch set (#2). Change subject: amdfwtool: Resequence some steps for the loop for combo ...................................................................... amdfwtool: Resequence some steps for the loop for combo To support combo, there will be a loop to iterate. Some steps will be padded into a loop. Move them together so it is easier to review and write code later. Each entry of combo has its own fw.cfg. Processing the fw.cfg and other statements relied on it should be put into the loop. Setting the EFS table should be moved downward outside of the loop. Address mode will not be available before processing fw.cfg. Set it as phyisical address mode at beginning for old family SOC. The loop will be from L2553 to L2676. TEST=binary identical test on amd/birman amd/majolica amd/gardenia amd/mandolin pcengines/apu2 Change-Id: Ie4543fe18d77bfbaf9d34914e6f27b5ba8791d28 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c 1 file changed, 74 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/66784/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/66784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4543fe18d77bfbaf9d34914e6f27b5ba8791d28 Gerrit-Change-Number: 66784 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: amdfwtool: easy for review
by Bao Zheng (Code Review) 06 Mar '23

06 Mar '23

Bao Zheng has restored this change. ( https://review.coreboot.org/c/coreboot/+/66784 ) Change subject: amdfwtool: easy for review ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/66784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4543fe18d77bfbaf9d34914e6f27b5ba8791d28 Gerrit-Change-Number: 66784 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

[S] Change in coreboot[master]: soc/amd/phoenix: Allow the amdfw.rom to be split into two parts
by Bao Zheng (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Zheng Bao, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72703 ) Change subject: soc/amd/phoenix: Allow the amdfw.rom to be split into two parts ...................................................................... Patch Set 11: (1 comment) File src/soc/amd/phoenix/Makefile.inc: https://review.coreboot.org/c/coreboot/+/72703/comment/de6f2d86_d5903c79 PS9, Line 212: OPT_AMDFW_BODY_LOCATION=$(if $(FMAP_AMDFW_BODY_LOCATION), --body-location $(FMAP_AMDFW_BODY_LOCATION)) > The `$(if $(FMAP_AMDFW_BODY_LOCATION)` is not needed with `$(call add_opt_prefix` […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72703 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8b318f71632a2c9b97ce67486374dc24d23e63e Gerrit-Change-Number: 72703 Gerrit-PatchSet: 11 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 14:27:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/raptor-cs/talos-2: add basic mainboard structure
by Krystian Hebel (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Michał Żygowski, Sergii Dmytruk, ron minnich. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67063 ) Change subject: mb/raptor-cs/talos-2: add basic mainboard structure ...................................................................... Patch Set 5: (1 comment) File src/mainboard/raptor-cs/talos-2/bootblock.c: https://review.coreboot.org/c/coreboot/+/67063/comment/5724ad24_525da64d PS5, Line 56: aspeed_early_config(serial_dev, vuart_init, ARRAY_SIZE(vuart_init)); I think we should skip this file altogether. Based on https://github.com/open-power/docs/issues/25 UART is already properly set up by BMC. -- To view, visit https://review.coreboot.org/c/coreboot/+/67063 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c4f74c7b27c8bb5599d68305adf369ddc6fcc70 Gerrit-Change-Number: 67063 Gerrit-PatchSet: 5 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 14:25:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/phoenix: Allow the amdfw.rom to be split into two parts
by Bao Zheng (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Bao Zheng, Jason Glenesk, Matt DeVillier, Zheng Bao, Karthik Ramasubramanian, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Matt DeVillier, Zheng Bao, Fred Reitberger, Karthik Ramasubramanian, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72703 to look at the new patch set (#11). Change subject: soc/amd/phoenix: Allow the amdfw.rom to be split into two parts ...................................................................... soc/amd/phoenix: Allow the amdfw.rom to be split into two parts Split the big PSP FW data into two parts, head and body. The head needs to be located at original specific location. The body address is more flexible. So the big body will not cover other needed FWs like EC. Give the body a specific named AMDFWBODY, which should be defined in flashmap. This is one of series of patches to support 32/64M flash. BUG=b:255374782 Change-Id: Ia8b318f71632a2c9b97ce67486374dc24d23e63e Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M src/soc/amd/phoenix/Makefile.inc 1 file changed, 35 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/72703/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/72703 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8b318f71632a2c9b97ce67486374dc24d23e63e Gerrit-Change-Number: 72703 Gerrit-PatchSet: 11 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/*/acpi: drop unnecessary duty_offset/duty_width field writes
by Fred Reitberger (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73421 ) Change subject: soc/amd/*/acpi: drop unnecessary duty_offset/duty_width field writes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib63b24891d44298841153dfc500b030619e1a5ea Gerrit-Change-Number: 73421 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 14:20:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/picasso/acpi: don't announce unimplemented duty cycle control
by Fred Reitberger (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73420 ) Change subject: soc/amd/picasso/acpi: don't announce unimplemented duty cycle control ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73420 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74645e5c4e54a2ad6bc7f9e72f5f656027a79860 Gerrit-Change-Number: 73420 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 14:19:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: amdfwtool: combo: Add combo feature for BIOS table
by Bao Zheng (Code Review) 06 Mar '23

06 Mar '23

Attention is currently required from: Zheng Bao, Fred Reitberger, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66856 ) Change subject: amdfwtool: combo: Add combo feature for BIOS table ...................................................................... Patch Set 9: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/66856/comment/76dab234_104fa427 PS8, Line 2605: adjust_current_pointer(&ctx, 0, 0x1000U); /* TODO: is it necessary? */ > Is this TODO necessary? Is it just to align on a 4K boundary? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/66856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0523a4a0e1f31969e4bbaa6062dcc0f2d6da420 Gerrit-Change-Number: 66856 Gerrit-PatchSet: 9 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 06 Mar 2023 14:11:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023