coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[S] Change in coreboot[master]: mb/google/brya/var/taeko: Enable Fast VMode for taeko
by Joey Peng (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Tarun Tuli, Joey Peng, Nick Vaccaro, Bob Moragues. Hello Tarun Tuli, Nick Vaccaro, Bob Moragues, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73373 to look at the new patch set (#2). Change subject: mb/google/brya/var/taeko: Enable Fast VMode for taeko ...................................................................... mb/google/brya/var/taeko: Enable Fast VMode for taeko Fast VMode makes the SoC throttle when the current exceeds the I_TRIP threshold. BUG=b:270242461 BRANCH=firmware-brya-14505.B TEST=Verify that the feature is enabled by reading from fsp log Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Change-Id: I82c2016d9dfb39ff7b372815737d4ae62875340c --- M src/mainboard/google/brya/variants/taeko/overridetree.cb 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/73373/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82c2016d9dfb39ff7b372815737d4ae62875340c Gerrit-Change-Number: 73373 Gerrit-PatchSet: 2 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM
by build bot (Jenkins) (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Rex-BC Chen, cong yang, Yu-Ping Wu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73443 ) Change subject: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM ...................................................................... Patch Set 2: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171464): https://review.coreboot.org/c/coreboot/+/73443/comment/9022cd88_70e5860a PS2, Line 8: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171464): https://review.coreboot.org/c/coreboot/+/73443/comment/308a02e6_39ee4b12 PS2, Line 10: powering on BOE_TV110C9M_LL0. So we set the default value to +-5.7V and Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/73443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29236818444cac84d42386a371cd8934048ff948 Gerrit-Change-Number: 73443 Gerrit-PatchSet: 2 Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 03:36:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM
by cong yang (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Rex-BC Chen, cong yang, Yu-Ping Wu. Hello build bot (Jenkins), Rex-BC Chen, Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73443 to look at the new patch set (#2). Change subject: mb/google/geralt: Set +-5.7V to TPS65132s EEPROM ...................................................................... mb/google/geralt: Set +-5.7V to TPS65132s EEPROM It is necessary to increase the AVDD/AVEE of TPS65132s PMIC to +-5.7V for powering on BOE_TV110C9M_LL0. So we set the default value to +-5.7V and program the value to the EEPROM when configuring the display at the first time. In this way, TPS65132s could load the correct setting from the EEPROM after booting into kernel. BUG=b:268292556 TEST=test firmware display pass and AVDD/AVEE is +-5.7V on Geralt. Change-Id: I29236818444cac84d42386a371cd8934048ff948 Signed-off-by: yangcong <yangcong5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/geralt/display.c M src/mainboard/google/geralt/display.h M src/mainboard/google/geralt/panel_geralt.c 3 files changed, 69 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/73443/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29236818444cac84d42386a371cd8934048ff948 Gerrit-Change-Number: 73443 Gerrit-PatchSet: 2 Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brya/var/taeko: Enable Fast VMode for taeko
by Eric Lai (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Tarun Tuli, Joey Peng, Nick Vaccaro, Bob Moragues. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73373 ) Change subject: mb/google/brya/var/taeko: Enable Fast VMode for taeko ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/73373/comment/31c4759c_971e1acd PS1, Line 9: nmakes makes -- To view, visit https://review.coreboot.org/c/coreboot/+/73373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82c2016d9dfb39ff7b372815737d4ae62875340c Gerrit-Change-Number: 73373 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-Comment-Date: Mon, 06 Mar 2023 03:20:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/taeko: Enable Fast VMode for taeko
by Joey Peng (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Nick Vaccaro, Bob Moragues. Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73373 ) Change subject: mb/google/brya/var/taeko: Enable Fast VMode for taeko ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/73373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82c2016d9dfb39ff7b372815737d4ae62875340c Gerrit-Change-Number: 73373 Gerrit-PatchSet: 1 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-Comment-Date: Mon, 06 Mar 2023 03:17:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/taeko: use RPL FSP headers
by Joey Peng (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Nick Vaccaro, Bob Moragues. Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73371 ) Change subject: mb/google/brya/var/taeko: use RPL FSP headers ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/73371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic97400555dabb237325e7c4a8d5edcbb4779cdb1 Gerrit-Change-Number: 73371 Gerrit-PatchSet: 3 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-Comment-Date: Mon, 06 Mar 2023 03:17:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt:set tps65132s program eeprom
by Yidi Lin (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Rex-BC Chen, cong yang, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73443 ) Change subject: mb/google/geralt:set tps65132s program eeprom ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73443/comment/bf46c192_923d2efa PS1, Line 7: mb/google/geralt:set tps65132s program eeprom mb/google/geralt: Set +-5.7V to TPS65132s EEPROM https://review.coreboot.org/c/coreboot/+/73443/comment/7f6665b5_9d4c5d4a PS1, Line 9: For Geralt,it is necessary to increase the AVDD/AVEE of : TPS65132S PMIC to +-5.7V,so write the default value in : eeprom to +-5.7V when configure display for the first : time. In this way,the default voltage is +-5.7V when you : start or enter the kernel next time. It is necessary to increase the AVDD/AVEE of TPS65132s PMIC to +-5.7V for powering on BOE_TV110C9M_LL0. So we set the default value to +-5.7V and program the value to the EEPROM when configuring the display at the first time. In this way, TPS65132s could load the correct setting from the EEPROM after booting into kenrel. File src/mainboard/google/geralt/display.c: https://review.coreboot.org/c/coreboot/+/73443/comment/d29350ae_679cb457 PS1, Line 44: 0x1F) < 0) move to next line https://review.coreboot.org/c/coreboot/+/73443/comment/7a284f16_c4677bc8 PS1, Line 73: tps65132s_program_eeprom(); Only the project with MIPI panel needs this setting. Call this function in `power_on_mipi_boe_tv110c9m_ll0` -- To view, visit https://review.coreboot.org/c/coreboot/+/73443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I29236818444cac84d42386a371cd8934048ff948 Gerrit-Change-Number: 73443 Gerrit-PatchSet: 1 Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 02:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Move SPL setting to variants
by Frank Wu (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Van Chen, John Su, Chao Gui, Dtrain Hsu, Jason Nien, EricKY Cheng, Chris Wang, Martin Roth, Amanda Hwang, Patrick Huang. Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73426 ) Change subject: mb/google/skyrim: Move SPL setting to variants ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b9779600cfa8c7581732e936a714728fd618d20 Gerrit-Change-Number: 73426 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Huang <patrick.huang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Chao Gui <chaogui(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Attention: Patrick Huang <patrick.huang(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 01:59:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: DEMO:CEZANNE: Add --use-combo
by Bao Zheng (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Martin L Roth. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73326 ) Change subject: DEMO:CEZANNE: Add --use-combo ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > This CL itself is not going to be merged. For the changes based on it, we need to […] binary identical test, and other tests. -- To view, visit https://review.coreboot.org/c/coreboot/+/73326 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I106344f4100934095a6f5b4e7fd9c4f0c0c3874a Gerrit-Change-Number: 73326 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 01:55:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: DEMO:CEZANNE: Add --use-combo
by Bao Zheng (Code Review) 05 Mar '23

05 Mar '23

Attention is currently required from: Martin L Roth. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73326 ) Change subject: DEMO:CEZANNE: Add --use-combo ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I don't understand the subject of the commit message. Is this supposed to be merged? […] This CL itself is not going to be merged. For the changes based on it, we need to do the binary identical test, which is meanful when the combo flag is set. -- To view, visit https://review.coreboot.org/c/coreboot/+/73326 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I106344f4100934095a6f5b4e7fd9c4f0c0c3874a Gerrit-Change-Number: 73326 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 01:53:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023