coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[S] Change in coreboot[master]: soc/amd/common/block/gfx: Use TPM-stored hash for vbios cache validation
by Matt DeVillier (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Martin Roth, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72402 to look at the new patch set (#6). Change subject: soc/amd/common/block/gfx: Use TPM-stored hash for vbios cache validation ...................................................................... soc/amd/common/block/gfx: Use TPM-stored hash for vbios cache validation Write the SHA256 hash of the cached VBIOS data when saving to FMAP, and use it to validate the data read from FMAP on subsequent boots. Add TPM2 as a dependency to the selection of VBIOS_CACHE_IN_FMAP. BUG=b:255812886 TEST=tested with rest of patch train Change-Id: I9c8f23b000b90a1072aeb7a57d3b7b2b2bc626dc Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M src/soc/amd/common/block/graphics/Kconfig M src/soc/amd/common/block/graphics/graphics.c 2 files changed, 25 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/72402/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/72402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c8f23b000b90a1072aeb7a57d3b7b2b2bc626dc Gerrit-Change-Number: 72402 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: Revert "UPSTREAM: mb/google/rex: Enable SaGv"
by Tarun Tuli (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Vikrant Jadeja, Subrata Banik, Kapil Porwal, Balaji Manigandan, Ronak Kanabar. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72774 ) Change subject: Revert "UPSTREAM: mb/google/rex: Enable SaGv" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcc36515f7550c183c40e5af94684f5c3e39a7a Gerrit-Change-Number: 72774 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Vikrant Jadeja Gerrit-Attention: Vikrant Jadeja Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 21:31:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "UPSTREAM: mb/google/rex: Enable SaGv"
by Subrata Banik (Code Review) 03 Feb '23

03 Feb '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72774 ) Change subject: Revert "UPSTREAM: mb/google/rex: Enable SaGv" ...................................................................... Revert "UPSTREAM: mb/google/rex: Enable SaGv" Enabling `SaGv` along with FSP v2473 is causing blank display issue. Mostly likely we shouldn't enable SaGv yet on Intel MeteorLake. BUG=b:267446159 TEST=Able to see ChromeOS UI in consecutive boot. This reverts commit 4dce7cda9e4cbdf29688157239e96fd7b5a25ec6. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ifbcc36515f7550c183c40e5af94684f5c3e39a7a --- M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/72774/1 diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb index f14699f..a3225ca 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb +++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb @@ -20,8 +20,6 @@ # Enable CNVi BT register "cnvi_bt_core" = "true" - register "sagv" = "SAGV_ENABLED" - register "serial_io_uart_mode" = "{ [PchSerialIoIndexUART0] = PchSerialIoPci, [PchSerialIoIndexUART1] = PchSerialIoDisabled, -- To view, visit https://review.coreboot.org/c/coreboot/+/72774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcc36515f7550c183c40e5af94684f5c3e39a7a Gerrit-Change-Number: 72774 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/scripts/testsoc: Pass arguments to abuild
by Fred Reitberger (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Martin L Roth. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72766 ) Change subject: util/scripts/testsoc: Pass arguments to abuild ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2bc8d656022560ed1eebf6eee0512d3633ebe84 Gerrit-Change-Number: 72766 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 21:06:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/scripts/testsoc: Pass arguments to abuild
by Matt DeVillier (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Martin L Roth, Fred Reitberger. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72766 ) Change subject: util/scripts/testsoc: Pass arguments to abuild ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2bc8d656022560ed1eebf6eee0512d3633ebe84 Gerrit-Change-Number: 72766 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 21:04:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src: Move POST_BOOTBLOCK_CAR to common postcodes and use it
by Martin L Roth (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Felix Singer, Elyes Haouas. Hello Felix Singer, Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71596 to look at the new patch set (#3). Change subject: src: Move POST_BOOTBLOCK_CAR to common postcodes and use it ...................................................................... src: Move POST_BOOTBLOCK_CAR to common postcodes and use it This moves the definition for POST_BOOTBLOCK_CAR from the intel-specific postcodes into the common postcode list, and uses it for the cache-as-RAM init as needed. Because POST_BOOTBLOCK_CAR was set to 0x20 in some spots and 0x21 in most of the others, the values were consolidated into 0x21. This will change the value on some platforms. Any conflicts should get sorted out later in the conversion process. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I8527334e679a23006b77a5645f919aea76dd4926 --- M src/commonlib/include/commonlib/console/post_codes.h M src/cpu/qemu-x86/cache_as_ram_bootblock.S M src/drivers/intel/fsp1_1/cache_as_ram.S M src/include/cpu/intel/post_codes.h M src/soc/intel/common/block/include/intelblocks/post_codes.h 5 files changed, 28 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/71596/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/71596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8527334e679a23006b77a5645f919aea76dd4926 Gerrit-Change-Number: 71596 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: ec/google/chromeec: Update ec_commands.h
by Jon Murphy (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Subrata Banik, Caveh Jalali, Nick Vaccaro, Boris Mittelberg. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72640 ) Change subject: ec/google/chromeec: Update ec_commands.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ce15e1af40cc54a6cf2ebd6f5d5adf8953dee60 Gerrit-Change-Number: 72640 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 20:33:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: ec/google/chromeec: clang-format ec_commands.h
by Jon Murphy (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Subrata Banik, Caveh Jalali, Nick Vaccaro, Boris Mittelberg. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72639 ) Change subject: ec/google/chromeec: clang-format ec_commands.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbd6d00922dc5fd4c44ee109d54cea612e15db06 Gerrit-Change-Number: 72639 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 20:24:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/sconfig: Remove lapic devices from devicetree parsers
by Jonathan Zhang (Code Review) 03 Feb '23

03 Feb '23

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69378 ) Change subject: util/sconfig: Remove lapic devices from devicetree parsers ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: This one breaks Craterlake. I had to revert it locally otherwise it boots so slowly (at systemd execution), that I had to stop the booting. Once reverted, it boots to OS quickly as expected. -- To view, visit https://review.coreboot.org/c/coreboot/+/69378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0746eb808a2956ac75f76c8189a9ecf190e33ce9 Gerrit-Change-Number: 69378 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 20:23:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/abuild: Add flags to allow abuild to skip boards
by Martin L Roth (Code Review) 03 Feb '23

03 Feb '23

Attention is currently required from: Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71730 ) Change subject: util/abuild: Add flags to allow abuild to skip boards ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > abuild accepts the argument, but at least with the bool `NO_GFX_INIT` it does not seem to work: […] Sorry, I had a couple of bugs that caused the failures - Those particular bugs are fixed now. :-/ I'm pretty sure it still won't work with what-jenkins-does excluding NO_GFX_INIT because that only gets set if the payload is set to SeaBIOS, and what-jenkins-does always sets the payload to none. So it will still build all of the platforms unless something is modified. File util/abuild/abuild: https://review.coreboot.org/c/coreboot/+/71730/comment/dd7a6483_a0909414 PS2, Line 639: [--skip <value>] Skip building boards with this Kconfig set > `--skip_set` and `--skip_unset`? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43336484cf25f83065ec7facf45c123d831024b5 Gerrit-Change-Number: 71730 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 03 Feb 2023 20:23:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023