Attention is currently required from: Felix Singer, Martin Roth.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79523?usp=email )
Change subject: libpayload: Remove shell for loops in install Makefile target
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79523/comment/35ea20d1_f8d8c86d :
PS2, Line 10: and
> are
Done
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79523/comment/401f43b7_666acc54 :
PS2, Line 130: find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} \;
> I think we could combine both lines with `install -D`, which creates the required directories.
I think this wasn't done because -D is a GNU extension. Not sure if anybody still cares, though...
--
To view, visit https://review.coreboot.org/c/coreboot/+/79523?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210
Gerrit-Change-Number: 79523
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Fri, 29 Dec 2023 22:57:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Lennart Eichhorn, Michael Niewöhner.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79416?usp=email )
Change subject: util/liveiso: Update to 23.11 release
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79416?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibf72c37205017b27012064b311a9510136351c0f
Gerrit-Change-Number: 79416
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Lennart Eichhorn <lennarteichhorn(a)gmail.com>
Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Lennart Eichhorn <lennarteichhorn(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Fri, 29 Dec 2023 22:24:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Lennart Eichhorn, Michael Niewöhner.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79416?usp=email )
Change subject: util/liveiso: Update to 23.11 release
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79416?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibf72c37205017b27012064b311a9510136351c0f
Gerrit-Change-Number: 79416
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Lennart Eichhorn <lennarteichhorn(a)gmail.com>
Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Lennart Eichhorn <lennarteichhorn(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Fri, 29 Dec 2023 22:21:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Leon Groß, Martin L Roth, Zebreus.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79316?usp=email )
Change subject: util/docker/fedora: Add Dockerfile.base
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79316?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d04c570f91215f534f173db2ae559b64b58012f
Gerrit-Change-Number: 79316
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Leon Groß <leon.gross(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Leon Groß <leon.gross(a)9elements.com>
Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Comment-Date: Fri, 29 Dec 2023 22:14:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Patrick Georgi.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79523?usp=email )
Change subject: libpayload: Remove shell for loops in install Makefile target
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79523/comment/ec979be2_35519a16 :
PS2, Line 10: and
are
--
To view, visit https://review.coreboot.org/c/coreboot/+/79523?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210
Gerrit-Change-Number: 79523
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Dec 2023 20:28:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Patrick Georgi.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79523?usp=email )
Change subject: libpayload: Remove shell for loops in install Makefile target
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79523/comment/32c14977_3d51e02a :
PS2, Line 130: find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} \;
I think we could combine both lines with `install -D`, which creates the required directories.
https://review.coreboot.org/c/coreboot/+/79523/comment/48af064e_c09ea32b :
PS2, Line 131: cd $(coreboottop)/src/commonlib/bsd && find include -type d -exec install -m755 -d $(DESTDIR)/libpayload/{} \;
: c
same here
--
To view, visit https://review.coreboot.org/c/coreboot/+/79523?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210
Gerrit-Change-Number: 79523
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Dec 2023 20:26:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Patrick Rudolph.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79751?usp=email )
Change subject: northbridge/intel/sandybridge/raminit: Prepare MRC path for x86_64
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79751?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id755e7381c5a94360e3511c53432d68b7687df67
Gerrit-Change-Number: 79751
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 29 Dec 2023 16:48:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79752?usp=email )
Change subject: cpu/x86/64bit/mode_switch: Simplify assembly code
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79752?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I30809453a1800ba3c0df60acd7eca778841c520f
Gerrit-Change-Number: 79752
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Fri, 29 Dec 2023 16:39:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment