Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49168 )
Change subject: sb/intel/bd82x6x: Rework PCH ID cache
......................................................................
sb/intel/bd82x6x: Rework PCH ID cache
Work around a romstage restriction. Globals (or static variables) cannot
be initialized to a non-zero value because there's no data section. Note
that the revision ID for stepping A0 is zero, so `pch_silicon_revision`
will no longer use the cached value for this PCH stepping. Since it is a
pre-production stepping, it is most likely not used anywhere anymore.
Change-Id: I07663d151cbc2d2ed7e4813bf870de52848753fd
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/southbridge/intel/bd82x6x/common.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/49168/1
diff --git a/src/southbridge/intel/bd82x6x/common.c b/src/southbridge/intel/bd82x6x/common.c
index 7480174..0094db6 100644
--- a/src/southbridge/intel/bd82x6x/common.c
+++ b/src/southbridge/intel/bd82x6x/common.c
@@ -13,9 +13,9 @@
int pch_silicon_revision(void)
{
- static int pch_revision_id = -1;
+ static int pch_revision_id = 0;
- if (pch_revision_id < 0)
+ if (!pch_revision_id)
pch_revision_id = pci_read_config8(PCH_LPC_DEV, PCI_REVISION_ID);
return pch_revision_id;
@@ -23,9 +23,9 @@
int pch_silicon_type(void)
{
- static int pch_type = -1;
+ static int pch_type = 0;
- if (pch_type < 0)
+ if (!pch_type)
pch_type = pci_read_config8(PCH_LPC_DEV, PCI_DEVICE_ID + 1);
return pch_type;
--
To view, visit https://review.coreboot.org/c/coreboot/+/49168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07663d151cbc2d2ed7e4813bf870de52848753fd
Gerrit-Change-Number: 49168
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange
Attention is currently required from: Ravi Mistry.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69260?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: superio/fintek/f71808a/f71808a_hwm.c: Fix writing to hardware monitor registers
......................................................................
Patch Set 3:
(1 comment)
File src/superio/fintek/f71808a/f71808a_hwm.c:
https://review.coreboot.org/c/coreboot/+/69260/comment/4dfc7c80_2740bfc1 :
PS3, Line 57: pnp_write_index
i'd use pnp_write_hwm5_index in this file instead of adjusting the port, since we already have this specific helper function for this case
--
To view, visit https://review.coreboot.org/c/coreboot/+/69260?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13e91e9900cfd151d143af4530d18ece2dbbe647
Gerrit-Change-Number: 69260
Gerrit-PatchSet: 3
Gerrit-Owner: Ravi Mistry
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Ravi Mistry
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Ravi Mistry
Gerrit-Comment-Date: Sun, 31 Dec 2023 20:01:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Felix Held has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/79677?usp=email )
Change subject: nb/amd/pi/00730F01/northbridge: skip IVRS when IOMMU is disabled
......................................................................
nb/amd/pi/00730F01/northbridge: skip IVRS when IOMMU is disabled
Don't generate the IVRS ACPI table if the IOMMU PCI device isn't enabled
in the devicetree.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I5e7f976011da92c0ca69decdca7aa77de24b6a2a
---
M src/northbridge/amd/pi/00730F01/northbridge.c
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/79677/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/79677?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e7f976011da92c0ca69decdca7aa77de24b6a2a
Gerrit-Change-Number: 79677
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Patrick Georgi.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79523?usp=email )
Change subject: libpayload: Remove shell for loops in install Makefile target
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79523/comment/8ca3443c_56132c5d :
PS2, Line 130: find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} \;
> I think this wasn't done because -D is a GNU extension. Not sure if anybody still cares, though...
Done
https://review.coreboot.org/c/coreboot/+/79523/comment/2b1a3e9e_ea422f9f :
PS2, Line 131: cd $(coreboottop)/src/commonlib/bsd && find include -type d -exec install -m755 -d $(DESTDIR)/libpayload/{} \;
: c
> same here
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79523?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210
Gerrit-Change-Number: 79523
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Comment-Date: Sun, 31 Dec 2023 18:45:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: comment