coreboot-gerrit December 2023

coreboot-gerrit@coreboot.org

1 participants
2354 discussions

[S] Change in coreboot[main]: util/docker/fedora: Add Dockerfile.base
by Maximilian Brune (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Felix Singer, Leon Groß, Martin L Roth, Zebreus. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79316?usp=email ) Change subject: util/docker/fedora: Add Dockerfile.base ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79316?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d04c570f91215f534f173db2ae559b64b58012f Gerrit-Change-Number: 79316 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Leon Groß <leon.gross(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Leon Groß <leon.gross(a)9elements.com> Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Comment-Date: Fri, 29 Dec 2023 22:14:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload: Remove shell for loops in install Makefile target
by Felix Singer (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Martin Roth, Patrick Georgi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79523?usp=email ) Change subject: libpayload: Remove shell for loops in install Makefile target ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79523/comment/ec979be2_35519a16 : PS2, Line 10: and are -- To view, visit https://review.coreboot.org/c/coreboot/+/79523?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210 Gerrit-Change-Number: 79523 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Dec 2023 20:28:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload: Remove shell for loops in install Makefile target
by Felix Singer (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Martin Roth, Patrick Georgi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79523?usp=email ) Change subject: libpayload: Remove shell for loops in install Makefile target ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File payloads/libpayload/Makefile.inc: https://review.coreboot.org/c/coreboot/+/79523/comment/32c14977_3d51e02a : PS2, Line 130: find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} \; I think we could combine both lines with `install -D`, which creates the required directories. https://review.coreboot.org/c/coreboot/+/79523/comment/48af064e_c09ea32b : PS2, Line 131: cd $(coreboottop)/src/commonlib/bsd && find include -type d -exec install -m755 -d $(DESTDIR)/libpayload/{} \; : c same here -- To view, visit https://review.coreboot.org/c/coreboot/+/79523?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210 Gerrit-Change-Number: 79523 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Fri, 29 Dec 2023 20:26:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: northbridge/intel/sandybridge/raminit: Prepare MRC path for x86_64
by Jérémy Compostella (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Angel Pons, Patrick Rudolph. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79751?usp=email ) Change subject: northbridge/intel/sandybridge/raminit: Prepare MRC path for x86_64 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79751?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id755e7381c5a94360e3511c53432d68b7687df67 Gerrit-Change-Number: 79751 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 29 Dec 2023 16:48:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: cpu/x86/64bit/mode_switch: Simplify assembly code
by Jérémy Compostella (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Patrick Rudolph. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79752?usp=email ) Change subject: cpu/x86/64bit/mode_switch: Simplify assembly code ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79752?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I30809453a1800ba3c0df60acd7eca778841c520f Gerrit-Change-Number: 79752 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Fri, 29 Dec 2023 16:39:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Enable SSE2 accelerated RSA sign. verification
by Jérémy Compostella (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79291?usp=email ) Change subject: soc/intel/meteorlake: Enable SSE2 accelerated RSA sign. verification ...................................................................... Patch Set 10: (1 comment) Patchset: PS4: > > > unfortunately, I don't see any savings after picking this cl. > > > > Are you sure you have the vboot repository up-to-date in your build environment ? > > except this CL, all other Cls are now landed in downstream (including coreboot, vboot project). I have picked this CL and performed 20 cycles. I don't see 5ms savings in run to run variation. I don't what to say because I do. What about the 505-506 interval ? Do you at least observe a saving with that patch ? -- To view, visit https://review.coreboot.org/c/coreboot/+/79291?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I382e62a765dbf2027c4ac54d6eb19a9542a8c302 Gerrit-Change-Number: 79291 Gerrit-PatchSet: 10 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Fri, 29 Dec 2023 16:31:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/hp/compaq_elite_8300_usdt: Add VBT
by Arthur Heymans (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Riku Viitanen. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79430?usp=email ) Change subject: mb/hp/compaq_elite_8300_usdt: Add VBT ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79430?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd999d30d6e8fea1368afae67f4dc1c3039d3ae1 Gerrit-Change-Number: 79430 Gerrit-PatchSet: 6 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Fri, 29 Dec 2023 15:45:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/hp/compaq_elite_8300_usdt: Add VBT
by Riku Viitanen (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Arthur Heymans. Riku Viitanen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79430?usp=email ) Change subject: mb/hp/compaq_elite_8300_usdt: Add VBT ...................................................................... Patch Set 6: (1 comment) File src/mainboard/hp/compaq_elite_8300_usdt/Kconfig: https://review.coreboot.org/c/coreboot/+/79430/comment/c2e2ee63_3303b543 : PS5, Line 34: config INTEL_GMA_VBT_FILE > Not needed as this already is the default Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79430?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd999d30d6e8fea1368afae67f4dc1c3039d3ae1 Gerrit-Change-Number: 79430 Gerrit-PatchSet: 6 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 29 Dec 2023 15:40:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/hp/compaq_elite_8300_usdt: Add VBT
by Riku Viitanen (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Riku Viitanen. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79430?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/hp/compaq_elite_8300_usdt: Add VBT ...................................................................... mb/hp/compaq_elite_8300_usdt: Add VBT Extracted from a system running OEM BIOS v03.08 (latest as of now). Build-tested and boots Linux (through SeaBIOS). Command used: intelvbttool --inlegacy --outvbt data.vbt Change-Id: Ibd999d30d6e8fea1368afae67f4dc1c3039d3ae1 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- M src/mainboard/hp/compaq_elite_8300_usdt/Kconfig A src/mainboard/hp/compaq_elite_8300_usdt/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/79430/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/79430?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd999d30d6e8fea1368afae67f4dc1c3039d3ae1 Gerrit-Change-Number: 79430 Gerrit-PatchSet: 6 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/hp/compaq_elite_8300_usdt: Add VBT
by Arthur Heymans (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Riku Viitanen. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79430?usp=email ) Change subject: mb/hp/compaq_elite_8300_usdt: Add VBT ...................................................................... Patch Set 5: (1 comment) File src/mainboard/hp/compaq_elite_8300_usdt/Kconfig: https://review.coreboot.org/c/coreboot/+/79430/comment/78866610_a5f4d354 : PS5, Line 34: config INTEL_GMA_VBT_FILE Not needed as this already is the default -- To view, visit https://review.coreboot.org/c/coreboot/+/79430?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd999d30d6e8fea1368afae67f4dc1c3039d3ae1 Gerrit-Change-Number: 79430 Gerrit-PatchSet: 5 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Fri, 29 Dec 2023 15:02:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
236
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2023