coreboot-gerrit December 2023

coreboot-gerrit@coreboot.org

1 participants
2354 discussions

[S] Change in coreboot[main]: vendorcode/google/chromeos: Add API for Chromebook Plus check
by Subrata Banik (Code Review) 31 Dec '23

31 Dec '23

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79763?usp=email ) Change subject: vendorcode/google/chromeos: Add API for Chromebook Plus check ...................................................................... vendorcode/google/chromeos: Add API for Chromebook Plus check This patch implements an API which relies on the chromeos_get_factory_config() function to retrieve the factory config value. This information is useful to determine whether a ChromeOS device is branded as a Chromebook Plus based on specific bit flags: - Bit 4 (0x10): Indicates whether the device chassis has the "chromebook-plus" branding. - Bits 3-0 (0x1): Must be 0x1 to signify compliance with Chromebook Plus hardware specifications. BUG=b:317880956 TEST=Able to verify that google/screebo is branded as Chromebook Plus. Change-Id: Iebaed1c60e34af4cc36316f1f87a89df778b0857 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79763 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> --- M src/vendorcode/google/chromeos/chromeos.h M src/vendorcode/google/chromeos/tpm_factory_config.c 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/vendorcode/google/chromeos/chromeos.h b/src/vendorcode/google/chromeos/chromeos.h index c14af31..0c5e4f7 100644 --- a/src/vendorcode/google/chromeos/chromeos.h +++ b/src/vendorcode/google/chromeos/chromeos.h @@ -32,6 +32,18 @@ * Return `-1` in case of error. */ int64_t chromeos_get_factory_config(void); +/* + * Determines whether a ChromeOS device is branded as a Chromebook Plus + * based on specific bit flags: + * + * - Bit 4 (0x10): Indicates whether the device chassis has the + * "chromebook-plus" branding. + * - Bits 3-0 (0x1): Must be 0x1 to signify compliance with Chromebook Plus + * hardware specifications. + * + * To be considered a Chromebook Plus, either of these conditions needs to be met. + */ +bool chromeos_device_branded_plus(void); /* * Declaration for mainboards to use to generate ACPI-specific ChromeOS needs. diff --git a/src/vendorcode/google/chromeos/tpm_factory_config.c b/src/vendorcode/google/chromeos/tpm_factory_config.c index 3b68020..4f8801a 100644 --- a/src/vendorcode/google/chromeos/tpm_factory_config.c +++ b/src/vendorcode/google/chromeos/tpm_factory_config.c @@ -2,8 +2,13 @@ #include <console/console.h> #include <security/tpm/tss.h> +#include <types.h> #include <vendorcode/google/chromeos/chromeos.h> +#define CHROMEBOOK_PLUS_HARD_BRANDED BIT(4) +#define CHROMEBOOK_PLUS_SOFT_BRANDED BIT(0) +#define CHROMEBOOK_PLUS_DEVICE (CHROMEBOOK_PLUS_HARD_BRANDED | CHROMEBOOK_PLUS_SOFT_BRANDED) + int64_t chromeos_get_factory_config(void) { static int64_t factory_config = -1; @@ -29,3 +34,24 @@ return factory_config; } + +/* + * Determines whether a ChromeOS device is branded as a Chromebook Plus + * based on specific bit flags: + * + * - Bit 4 (0x10): Indicates whether the device chassis has the + * "chromebook-plus" branding. + * - Bits 3-0 (0x1): Must be 0x1 to signify compliance with Chromebook Plus + * hardware specifications. + * + * To be considered a Chromebook Plus, either of these conditions needs to be met. + */ +bool chromeos_device_branded_plus(void) +{ + int64_t factory_config = chromeos_get_factory_config(); + + if (factory_config < 0) + return false; + + return factory_config & CHROMEBOOK_PLUS_DEVICE; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/79763?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iebaed1c60e34af4cc36316f1f87a89df778b0857 Gerrit-Change-Number: 79763 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: vendorcode/google/chromeos: Add API to read factory config
by Subrata Banik (Code Review) 31 Dec '23

31 Dec '23

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email ) Change subject: vendorcode/google/chromeos: Add API to read factory config ...................................................................... vendorcode/google/chromeos: Add API to read factory config This code leverages the TPM vendor-specific function tlcl_cr50_get_factory_config() to fetch the device's factory configuration. BUG=b:317880956 TEST=Able to retrieve the factory config from google/screebo. Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79737 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> --- M src/vendorcode/google/chromeos/Makefile.inc M src/vendorcode/google/chromeos/chromeos.h A src/vendorcode/google/chromeos/tpm_factory_config.c 3 files changed, 38 insertions(+), 0 deletions(-) Approvals: Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/vendorcode/google/chromeos/Makefile.inc b/src/vendorcode/google/chromeos/Makefile.inc index fbfd7a4..dce4d9c 100644 --- a/src/vendorcode/google/chromeos/Makefile.inc +++ b/src/vendorcode/google/chromeos/Makefile.inc @@ -9,6 +9,7 @@ ramstage-$(CONFIG_HAVE_REGULATORY_DOMAIN) += wrdd.c ramstage-$(CONFIG_USE_SAR) += sar.c ramstage-$(CONFIG_TPM_GOOGLE) += cr50_enable_update.c +ramstage-$(CONFIG_TPM_GOOGLE) += tpm_factory_config.c romstage-$(CONFIG_CHROMEOS_CSE_BOARD_RESET_OVERRIDE) += cse_board_reset.c ramstage-$(CONFIG_CHROMEOS_CSE_BOARD_RESET_OVERRIDE) += cse_board_reset.c diff --git a/src/vendorcode/google/chromeos/chromeos.h b/src/vendorcode/google/chromeos/chromeos.h index cab855d..c14af31 100644 --- a/src/vendorcode/google/chromeos/chromeos.h +++ b/src/vendorcode/google/chromeos/chromeos.h @@ -26,6 +26,12 @@ void cbmem_add_vpd_calibration_data(void); void chromeos_set_me_hash(u32*, int); void chromeos_set_ramoops(void *ram_oops, size_t size); +/* + * The factory config space is a one-time programmable info page. + * For the unprovisioned one, the read will be 0x0. + * Return `-1` in case of error. + */ +int64_t chromeos_get_factory_config(void); /* * Declaration for mainboards to use to generate ACPI-specific ChromeOS needs. diff --git a/src/vendorcode/google/chromeos/tpm_factory_config.c b/src/vendorcode/google/chromeos/tpm_factory_config.c new file mode 100644 index 0000000..3b68020 --- /dev/null +++ b/src/vendorcode/google/chromeos/tpm_factory_config.c @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <console/console.h> +#include <security/tpm/tss.h> +#include <vendorcode/google/chromeos/chromeos.h> + +int64_t chromeos_get_factory_config(void) +{ + static int64_t factory_config = -1; + + if (factory_config >= 0) + return factory_config; + + /* Initialize TPM driver. */ + tpm_result_t rc = tlcl_lib_init(); + if (rc != TPM_SUCCESS) { + printk(BIOS_ERR, "%s:%d - tlcl_lib_init() failed: %#x\n", + __func__, __LINE__, rc); + return -1; + } + + rc = tlcl_cr50_get_factory_config((uint64_t *)&factory_config); + + if (rc != TPM_SUCCESS) { + printk(BIOS_ERR, "%s:%d - tlcl_cr50_get_factory_config() failed: %#x\n", + __func__, __LINE__, rc); + return -1; + } + + return factory_config; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/79737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Gerrit-Change-Number: 79737 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: security/tpm: Retrieve factory configuration for device w/ Google TPM
by Subrata Banik (Code Review) 31 Dec '23

31 Dec '23

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79736?usp=email ) Change subject: security/tpm: Retrieve factory configuration for device w/ Google TPM ...................................................................... security/tpm: Retrieve factory configuration for device w/ Google TPM This patch enables retrieval of factory configuration data from Google TPM devices (both Cr50 and Ti50). This patch utilizes vendor-specific command TPM2_CR50_SUB_CMD_GET_FACTORY_CONFIG (68). The factory config space is a 64-bit, one-time programmable. For the unprovisioned one, the read will be 0x0. BUG=b:317880956 TEST=Able to retrieve the factory config from google/screebo. Change-Id: Ifd0e850770152a03aa46d7f8bbb76f7520a59081 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79736 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/security/tpm/tss/tcg-2.0/tss_structures.h M src/security/tpm/tss/vendor/cr50/cr50.c M src/security/tpm/tss/vendor/cr50/cr50.h 4 files changed, 47 insertions(+), 0 deletions(-) Approvals: Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c index f1b9522..5ade639 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c +++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c @@ -348,6 +348,9 @@ case TPM2_CR50_SUB_CMD_RESET_EC: rc |= obuf_write_be16(ob, *sub_command); break; + case TPM2_CR50_SUB_CMD_GET_FACTORY_CONFIG: + rc |= obuf_write_be16(ob, *sub_command); + break; default: /* Unsupported subcommand. */ printk(BIOS_WARNING, "Unsupported cr50 subcommand: 0x%04x\n", @@ -581,6 +584,8 @@ return ibuf_read_be8(ib, &vcr->boot_mode); case TPM2_CR50_SUB_CMD_RESET_EC: break; + case TPM2_CR50_SUB_CMD_GET_FACTORY_CONFIG: + return ibuf_read_be64(ib, &vcr->factory_config); default: printk(BIOS_ERR, "%s:%d - unsupported vendor command %#04x!\n", diff --git a/src/security/tpm/tss/tcg-2.0/tss_structures.h b/src/security/tpm/tss/tcg-2.0/tss_structures.h index a73f4c4..f2682b1 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_structures.h +++ b/src/security/tpm/tss/tcg-2.0/tss_structures.h @@ -352,6 +352,11 @@ uint8_t recovery_button_state; uint8_t tpm_mode; uint8_t boot_mode; + /* + * bits 63..8 : reserved + * bits 7..0 : factory config + */ + uint64_t factory_config; }; }; diff --git a/src/security/tpm/tss/vendor/cr50/cr50.c b/src/security/tpm/tss/vendor/cr50/cr50.c index 87889d1..31eab2d 100644 --- a/src/security/tpm/tss/vendor/cr50/cr50.c +++ b/src/security/tpm/tss/vendor/cr50/cr50.c @@ -176,3 +176,31 @@ return TPM_SUCCESS; } + +tpm_result_t tlcl_cr50_get_factory_config(uint64_t *factory_config) +{ + struct tpm2_response *response; + uint16_t factory_config_command = TPM2_CR50_SUB_CMD_GET_FACTORY_CONFIG; + *factory_config = 0; + + response = tpm_process_command(TPM2_CR50_VENDOR_COMMAND, &factory_config_command); + + if (!response) + return TPM_IOERROR; + + /* Explicitly inform caller when command is not supported */ + if (response->hdr.tpm_code == VENDOR_RC_NO_SUCH_COMMAND || + response->hdr.tpm_code == VENDOR_RC_NO_SUCH_SUBCOMMAND) + return TPM_CB_NO_SUCH_COMMAND; + + /* Unexpected return code from TPM */ + if (response->hdr.tpm_code) + return TPM_IOERROR; + + /* TPM command completed without error */ + *factory_config = response->vcr.factory_config; + + printk(BIOS_INFO, "Reading factory config = %016" PRIX64 "\n", *factory_config); + + return TPM_SUCCESS; +} diff --git a/src/security/tpm/tss/vendor/cr50/cr50.h b/src/security/tpm/tss/vendor/cr50/cr50.h index edd5083..f7e5c68 100644 --- a/src/security/tpm/tss/vendor/cr50/cr50.h +++ b/src/security/tpm/tss/vendor/cr50/cr50.h @@ -17,6 +17,7 @@ #define TPM2_CR50_SUB_CMD_TPM_MODE (40) #define TPM2_CR50_SUB_CMD_GET_BOOT_MODE (52) #define TPM2_CR50_SUB_CMD_RESET_EC (53) +#define TPM2_CR50_SUB_CMD_GET_FACTORY_CONFIG (68) /* Cr50 vendor-specific error codes. */ #define VENDOR_RC_ERR 0x00000500 @@ -105,4 +106,12 @@ */ tpm_result_t tlcl_cr50_reset_ec(void); +/** + * TPM command to get the factory config. + * + * Returns TPM_* for errors. + * On Success, TPM_SUCCESS if factory config is successfully retrieved. + */ +tpm_result_t tlcl_cr50_get_factory_config(uint64_t *factory_config); + #endif /* CR50_TSS_STRUCTURES_H_ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/79736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd0e850770152a03aa46d7f8bbb76f7520a59081 Gerrit-Change-Number: 79736 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/rex/var/karis: Enhance CNVi and PCIe switching
by Paul Menzel (Code Review) 30 Dec '23

30 Dec '23

Attention is currently required from: David Wu, Dinesh Gehlot, Eran Mitrani, Jack Lai, Jakub Czapiga, Kapil Porwal, Mac Chiang, Tarun, Tyler Wang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79765?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/rex/var/karis: Enhance CNVi and PCIe switching ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79765/comment/89d8836b_d349d396 : PS2, Line 9: Set PCIe related GPIOs to NC if fw_config use "WIFI_CNVI". : Set CNVi related GPIOs to NC if fw_config use "WIFI_PCIE". : Remove "ALC5650_NO_AMP_I2S" case in fw_config_gpio_padbased_override(). : bt_i2s_enable_pads should not relevant to audio codec/amp, and it is : already enabled in "WIFI_CNVI" case. If you enumerate items, please format this as a list. -- To view, visit https://review.coreboot.org/c/coreboot/+/79765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib1a32f1a38ae33cf992b80a3408aa8e2fa3ddab0 Gerrit-Change-Number: 79765 Gerrit-PatchSet: 2 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jack Lai <jack.lai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jack Lai <jack.lai(a)intel.corp-partner.google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Sat, 30 Dec 2023 05:50:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/craaskov: Implement touchscreen power sequencing
by Paul Menzel (Code Review) 30 Dec '23

30 Dec '23

Attention is currently required from: Dtrain Hsu, Kenny Pan, Nick Vaccaro, Rex Chou, Shou-Chieh Hsu, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79764?usp=email ) Change subject: mb/google/nissa/var/craaskov: Implement touchscreen power sequencing ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79764/comment/94ea60af_2a1cfc32 : PS1, Line 2: rex_chou Please use Rex Chou. $ git config --global user.name "Rex Chou" $ git commit --amend -s --author="Rex Chou <rex_chou(a)compal.corp-partner.google.com>" https://review.coreboot.org/c/coreboot/+/79764/comment/18ee0319_7846525f : PS1, Line 18: Change-Id: I85f2bee58582c0f56331d20a2984a3079c967be4 : Signed-off-by: rex_chou <rex_chou(a)compal.corp-partner.google.com> : : Change-Id: I3ca2e2d12a86eaae9e37870a2541c0287e354690 : Two Change-Id tags? -- To view, visit https://review.coreboot.org/c/coreboot/+/79764?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ca2e2d12a86eaae9e37870a2541c0287e354690 Gerrit-Change-Number: 79764 Gerrit-PatchSet: 1 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Kenny Pan <kennypan(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Sat, 30 Dec 2023 05:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload: Remove shell for loops in install Makefile target
by Patrick Georgi (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Felix Singer, Martin Roth. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79523?usp=email ) Change subject: libpayload: Remove shell for loops in install Makefile target ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79523/comment/35ea20d1_f8d8c86d : PS2, Line 10: and > are Done File payloads/libpayload/Makefile.inc: https://review.coreboot.org/c/coreboot/+/79523/comment/401f43b7_666acc54 : PS2, Line 130: find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} \; > I think we could combine both lines with `install -D`, which creates the required directories. I think this wasn't done because -D is a GNU extension. Not sure if anybody still cares, though... -- To view, visit https://review.coreboot.org/c/coreboot/+/79523?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210 Gerrit-Change-Number: 79523 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 29 Dec 2023 22:57:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/liveiso: Update to 23.11 release
by Felix Singer (Code Review) 29 Dec '23

29 Dec '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79416?usp=email ) Change subject: util/liveiso: Update to 23.11 release ...................................................................... util/liveiso: Update to 23.11 release The package 'bluezFull' got superseded by 'bluez'. So just remove the related line since 'bluez' is the default. Change-Id: Ibf72c37205017b27012064b311a9510136351c0f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79416 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Marvin Evers <marvin.n.evers(a)gmail.com> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- M util/liveiso/nixos/build.sh M util/liveiso/nixos/common.nix 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified Marvin Evers: Looks good to me, but someone else must approve diff --git a/util/liveiso/nixos/build.sh b/util/liveiso/nixos/build.sh index a10dad3..9a3889d 100755 --- a/util/liveiso/nixos/build.sh +++ b/util/liveiso/nixos/build.sh @@ -11,4 +11,4 @@ nix-build '<nixpkgs/nixos>' \ -A config.system.build.isoImage \ -I nixos-config=$config \ - -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixos-23.05.tar… + -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixos-23.11.tar… diff --git a/util/liveiso/nixos/common.nix b/util/liveiso/nixos/common.nix index c797463..33a93bc 100644 --- a/util/liveiso/nixos/common.nix +++ b/util/liveiso/nixos/common.nix @@ -8,7 +8,7 @@ <nixpkgs/nixos/modules/installer/cd-dvd/iso-image.nix> ]; - system.stateVersion = "23.05"; + system.stateVersion = "23.11"; isoImage = { makeEfiBootable = true; @@ -64,7 +64,6 @@ bluetooth = { enable = true; powerOnBoot = false; - package = pkgs.bluezFull; }; }; -- To view, visit https://review.coreboot.org/c/coreboot/+/79416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf72c37205017b27012064b311a9510136351c0f Gerrit-Change-Number: 79416 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lennart Eichhorn <lennarteichhorn(a)gmail.com> Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: util/liveiso: Update to 23.11 release
by Maximilian Brune (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Felix Singer, Lennart Eichhorn, Michael Niewöhner. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79416?usp=email ) Change subject: util/liveiso: Update to 23.11 release ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf72c37205017b27012064b311a9510136351c0f Gerrit-Change-Number: 79416 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lennart Eichhorn <lennarteichhorn(a)gmail.com> Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lennart Eichhorn <lennarteichhorn(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 29 Dec 2023 22:24:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/liveiso: Update to 23.11 release
by Maximilian Brune (Code Review) 29 Dec '23

29 Dec '23

Attention is currently required from: Felix Singer, Lennart Eichhorn, Michael Niewöhner. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79416?usp=email ) Change subject: util/liveiso: Update to 23.11 release ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf72c37205017b27012064b311a9510136351c0f Gerrit-Change-Number: 79416 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lennart Eichhorn <lennarteichhorn(a)gmail.com> Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lennart Eichhorn <lennarteichhorn(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 29 Dec 2023 22:21:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/docker/fedora: Add Dockerfile.base
by Felix Singer (Code Review) 29 Dec '23

29 Dec '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79316?usp=email ) Change subject: util/docker/fedora: Add Dockerfile.base ...................................................................... util/docker/fedora: Add Dockerfile.base Following commands were used to test if everything builds: * make crossgcc * make clang * make what-jenkins-does Change-Id: I8d04c570f91215f534f173db2ae559b64b58012f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79316 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- A util/docker/fedora/Dockerfile.base 1 file changed, 44 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Maximilian Brune: Looks good to me, approved diff --git a/util/docker/fedora/Dockerfile.base b/util/docker/fedora/Dockerfile.base new file mode 100644 index 0000000..ff4607c --- /dev/null +++ b/util/docker/fedora/Dockerfile.base @@ -0,0 +1,44 @@ +FROM fedora:latest + +RUN \ + echo "install_weak_deps=False" >> /etc/dnf/dnf.conf && \ + dnf update -y && \ + dnf install -y \ + bash-completion \ + bc \ + bison \ + bzip2 \ + ccache \ + cmake \ + cscope \ + diffutils \ + dtc \ + flex \ + gcc-c++ \ + gcc-gnat \ + git \ + go \ + htop \ + lcov \ + less \ + libusb1 \ + make \ + meson \ + ncurses-devel \ + neovim \ + nss-devel \ + nss-util-devel \ + openssl \ + openssl-devel \ + patch \ + perl-English \ + perl-FindBin \ + perl-Hash-Util \ + perl-Sys-Hostname \ + python3 \ + shellcheck \ + tmux \ + xz \ + zlib-devel && \ + dnf clean all && \ + ln -s /usr/bin/python3 /usr/bin/python -- To view, visit https://review.coreboot.org/c/coreboot/+/79316?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d04c570f91215f534f173db2ae559b64b58012f Gerrit-Change-Number: 79316 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Leon Groß <leon.gross(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
236
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2023