[XS] Change in coreboot[main]: superio/fintek/f71808a/f71808a_hwm.c: Fix writing to hardware monitor... - coreboot-gerrit

31 Dec 2023


      Attention is currently required from: Ravi Mistry.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69260?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: superio/fintek/f71808a/f71808a_hwm.c: Fix writing to hardware monitor registers
......................................................................
Patch Set 3:
(1 comment)
File src/superio/fintek/f71808a/f71808a_hwm.c:
https://review.coreboot.org/c/coreboot/+/69260/comment/4dfc7c80_2740bfc1 :
PS3, Line 57: pnp_write_index
i'd use pnp_write_hwm5_index in this file instead of adjusting the port, since we already have this specific helper function for this case
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69260?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13e91e9900cfd151d143af4530d18ece2dbbe647
Gerrit-Change-Number: 69260
Gerrit-PatchSet: 3
Gerrit-Owner: Ravi Mistry
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Ravi Mistry
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Ravi Mistry
Gerrit-Comment-Date: Sun, 31 Dec 2023 20:01:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment