coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[M] Change in coreboot[main]: src/mainboard/amd/birman: Add a new board variant for Phoenix SOC
by Anand Vaikar (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Anand Vaikar, Felix Held, Fred Reitberger, Jason Glenesk. Hello Felix Held, Fred Reitberger, Jason Glenesk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79243?usp=email to look at the new patch set (#2). Change subject: src/mainboard/amd/birman: Add a new board variant for Phoenix SOC ...................................................................... src/mainboard/amd/birman: Add a new board variant for Phoenix SOC Change-Id: Iabe38b1de33aad4c7ee165bec8eb1d617a4d8cba Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> --- M src/mainboard/amd/birman/Kconfig M src/mainboard/amd/birman/Kconfig.name M src/mainboard/amd/birman/Makefile.inc A src/mainboard/amd/birman/variants/birmanplus/port_descriptors.c 4 files changed, 215 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/79243/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79243?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iabe38b1de33aad4c7ee165bec8eb1d617a4d8cba Gerrit-Change-Number: 79243 Gerrit-PatchSet: 2 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
by Eric Lai (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Nick Vaccaro, Paul Menzel, Robert Chen, Shawn Ku, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email ) Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/variants/quandiso/fw_config.c: https://review.coreboot.org/c/coreboot/+/79173/comment/9f50a120_d6c1de9d : PS4, Line 76: static const struct pad_config disable_usbc1_pins[] = { > Quandiso have both C1 port present daughterboard and non-C1 daughterboard. […] I mean you don't really use the A21 and A22 as AUX, have you try the cc flip? You need add in device tree to let it work as AUX pin like I did. -- To view, visit https://review.coreboot.org/c/coreboot/+/79173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Gerrit-Change-Number: 79173 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 06:32:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
by Robert Chen (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email ) Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/variants/quandiso/fw_config.c: https://review.coreboot.org/c/coreboot/+/79173/comment/d3dd5243_c1302099 : PS4, Line 76: static const struct pad_config disable_usbc1_pins[] = { > but nissa I've add register "typec_aux_bias_pads[1]" = "{.pad_auxp_dc = GPP_A21, . […] Quandiso have both C1 port present daughterboard and non-C1 daughterboard. Disabled it by fw_config to ensure both daughterboard work instead of in gpio table. -- To view, visit https://review.coreboot.org/c/coreboot/+/79173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Gerrit-Change-Number: 79173 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 22 Nov 2023 06:25:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/aspeed/common/ast_drv.h: Use C99 flexible arrays
by Elyes Haouas (Code Review) 22 Nov '23

22 Nov '23

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76844?usp=email ) Change subject: drivers/aspeed/common/ast_drv.h: Use C99 flexible arrays ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76844?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I489347532e00581accaabad9ea4a3e0ad22f78f2 Gerrit-Change-Number: 76844 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: [Please Test] payloads/libpayload/drivers/usb/ehci_private: Use C99 f...
by Elyes Haouas (Code Review) 22 Nov '23

22 Nov '23

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76850?usp=email ) Change subject: [Please Test] payloads/libpayload/drivers/usb/ehci_private: Use C99 flexible arrays ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/76850?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec5bb3da8205326a43bba44630a8fcdcac651184 Gerrit-Change-Number: 76850 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[main]: riscv: add smp support for exception handler
by Maximilian Brune (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Arthur Heymans, Philipp Hug, ron minnich. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68841?usp=email ) Change subject: riscv: add smp support for exception handler ...................................................................... Patch Set 2: (4 comments) File src/arch/riscv/payload.c: https://review.coreboot.org/c/coreboot/+/68841/comment/fdaebb95_3400bca4 : PS2, Line 70: write_csr(mscratch, MACHINE_STACK_TOP()); maybe mention why we save it in a comment. Without looking at this patch it is not really obvious why we save the stack pointer in the mscratch register. File src/arch/riscv/trap_util.S: https://review.coreboot.org/c/coreboot/+/68841/comment/b4ef1f1e_61d3c696 : PS2, Line 12: LOAD x3, 3 * REGBYTES(sp) might be worth to note (in a comment) that x2 is the stack pointer otherwise it is not clear why we don't save/restore it here. https://review.coreboot.org/c/coreboot/+/68841/comment/129ae739_49a19713 : PS2, Line 103: # when exiting coreboot, write sp to mscratch how do we make sure that nothing else writes to MACHINE_TOP_STACK after coreboot is jumping to payload? If we use it here than we effectively overwrite what was written to MACHINE_TOP_STACK after corebot jumped to payload. https://review.coreboot.org/c/coreboot/+/68841/comment/e0385be3_acc8ed2b : PS2, Line 105: bnez sp, 1f # sp == 0, trap come from current program nit: `bnez sp, 1f # sp == 0, trap comes from coreboot` only because I had to think twice before I realized that you meant coreboot with current program (instead of whatever program comes after coreboot) -- To view, visit https://review.coreboot.org/c/coreboot/+/68841?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia1f97b82e329f6358061072f98278cf56b503618 Gerrit-Change-Number: 68841 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 04:58:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: libpayload: Fix the stack and data labels
by Yi Chou (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Julius Werner, Yu-Ping Wu. Yi Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79144?usp=email ) Change subject: libpayload: Fix the stack and data labels ...................................................................... Patch Set 6: (2 comments) File payloads/libpayload/arch/arm/libpayload.ldscript: https://review.coreboot.org/c/coreboot/+/79144/comment/fb733eb2_9dca53bb : PS3, Line 50: *(.rodata.*) > Can we just add `_text`/`_etext`, `_rodata`/`_erodata` and `_bss`/`_ebss` everywhere here as well fo […] Done https://review.coreboot.org/c/coreboot/+/79144/comment/a08bf822_b0215598 : PS3, Line 77: _stack = .; > Be careful, these are actually used, so you need to fix the references in the relevant assembly file […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I589040f4db60b35813ea9f4ba9503244bd7def00 Gerrit-Change-Number: 79144 Gerrit-PatchSet: 6 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 04:52:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: libpayload: Fix the stack and data labels
by Yi Chou (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Yi Chou, Yu-Ping Wu. Hello Julius Werner, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79144?usp=email to look at the new patch set (#6). Change subject: libpayload: Fix the stack and data labels ...................................................................... libpayload: Fix the stack and data labels We should make sure the consistency between _stack/_estack and the other labels. And _data & _edata is also useful to clean up the sensitive data on the data section. BUG=b:248610274 TEST=emerge-cherry libpayload BRANCH=none Cq-Depend: chromium:5052462 Change-Id: I589040f4db60b35813ea9f4ba9503244bd7def00 Signed-off-by: Yi Chou <yich(a)google.com> --- M payloads/libpayload/arch/arm/head.S M payloads/libpayload/arch/arm/libpayload.ldscript M payloads/libpayload/arch/arm64/head.S M payloads/libpayload/arch/arm64/libpayload.ldscript M payloads/libpayload/arch/x86/head.S M payloads/libpayload/arch/x86/libpayload.ldscript 6 files changed, 57 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/79144/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/79144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I589040f4db60b35813ea9f4ba9503244bd7def00 Gerrit-Change-Number: 79144 Gerrit-PatchSet: 6 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: libpayload: Fix the stack and data labels
by Yi Chou (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Yi Chou, Yu-Ping Wu. Hello Julius Werner, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79144?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: libpayload: Fix the stack and data labels ...................................................................... libpayload: Fix the stack and data labels We should make sure the consistency between _stack/_estack and the other labels. And _data & _edata is also useful to clean up the sensitive data on the data section. BUG=b:248610274 TEST=emerge-cherry libpayload BRANCH=none Change-Id: I589040f4db60b35813ea9f4ba9503244bd7def00 Signed-off-by: Yi Chou <yich(a)google.com> --- M payloads/libpayload/arch/arm/head.S M payloads/libpayload/arch/arm/libpayload.ldscript M payloads/libpayload/arch/arm64/head.S M payloads/libpayload/arch/arm64/libpayload.ldscript M payloads/libpayload/arch/x86/head.S M payloads/libpayload/arch/x86/libpayload.ldscript 6 files changed, 57 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/79144/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I589040f4db60b35813ea9f4ba9503244bd7def00 Gerrit-Change-Number: 79144 Gerrit-PatchSet: 4 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
by Eric Lai (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Nick Vaccaro, Paul Menzel, Robert Chen, Shawn Ku, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email ) Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/variants/quandiso/fw_config.c: https://review.coreboot.org/c/coreboot/+/79173/comment/80bf39fa_76af89bb : PS4, Line 76: static const struct pad_config disable_usbc1_pins[] = { > https://review.coreboot. […] but nissa I've add register "typec_aux_bias_pads[1]" = "{.pad_auxp_dc = GPP_A21, .pad_auxn_dc = GPP_A22}"... so you don't use this pin at all. Then you can disable it in gpio table... -- To view, visit https://review.coreboot.org/c/coreboot/+/79173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Gerrit-Change-Number: 79173 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 03:40:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023