coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[L] Change in coreboot[main]: google/*: Clean up Kconfg board selection for Google MTK boards
by Julius Werner (Code Review) 22 Nov '23

22 Nov '23

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ...................................................................... google/*: Clean up Kconfg board selection for Google MTK boards This patch tries to standardize and simplify the Kconfig option layout for Google boards with MediaTek SoCs and align them to the scheme used with other Arm-based Google boards. Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Signed-off-by: Julius Werner <jwerner(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79063 Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yidi Lin <yidilin(a)google.com> --- M src/mainboard/google/asurada/Kconfig M src/mainboard/google/cherry/Kconfig M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/mainboard.c M src/mainboard/google/geralt/Kconfig M src/mainboard/google/geralt/chromeos.c M src/mainboard/google/geralt/mainboard.c M src/mainboard/google/kukui/Kconfig M src/mainboard/google/oak/Kconfig 9 files changed, 102 insertions(+), 194 deletions(-) Approvals: Yu-Ping Wu: Looks good to me, approved build bot (Jenkins): Verified Yidi Lin: Looks good to me, approved diff --git a/src/mainboard/google/asurada/Kconfig b/src/mainboard/google/asurada/Kconfig index 52aefa4..9064b15 100644 --- a/src/mainboard/google/asurada/Kconfig +++ b/src/mainboard/google/asurada/Kconfig @@ -1,8 +1,14 @@ ## SPDX-License-Identifier: GPL-2.0-only -# Umbrella option to be selected by variant boards. config BOARD_GOOGLE_ASURADA_COMMON - def_bool n + def_bool BOARD_GOOGLE_ASURADA || \ + BOARD_GOOGLE_HAYATO || \ + BOARD_GOOGLE_SPHERION + +if BOARD_GOOGLE_ASURADA_COMMON + +config BOARD_SPECIFIC_OPTIONS + def_bool y select RTC select SOC_MEDIATEK_MT8192 select BOARD_ROMSIZE_KB_8192 @@ -24,17 +30,6 @@ select COMMONLIB_STORAGE select COMMONLIB_STORAGE_MMC -config BOARD_GOOGLE_ASURADA - select BOARD_GOOGLE_ASURADA_COMMON - -config BOARD_GOOGLE_HAYATO - select BOARD_GOOGLE_ASURADA_COMMON - -config BOARD_GOOGLE_SPHERION - select BOARD_GOOGLE_ASURADA_COMMON - -if BOARD_GOOGLE_ASURADA_COMMON - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_VBNV_FLASH diff --git a/src/mainboard/google/cherry/Kconfig b/src/mainboard/google/cherry/Kconfig index a99d7a5..e301185 100644 --- a/src/mainboard/google/cherry/Kconfig +++ b/src/mainboard/google/cherry/Kconfig @@ -1,8 +1,14 @@ ## SPDX-License-Identifier: GPL-2.0-only -# Umbrella option to be selected by variant boards. config BOARD_GOOGLE_CHERRY_COMMON - def_bool n + def_bool BOARD_GOOGLE_CHERRY || \ + BOARD_GOOGLE_DOJO || \ + BOARD_GOOGLE_TOMATO + +if BOARD_GOOGLE_CHERRY_COMMON + +config BOARD_SPECIFIC_OPTIONS + def_bool y select RTC select SOC_MEDIATEK_MT8195 select BOARD_ROMSIZE_KB_8192 @@ -23,17 +29,6 @@ select COMMONLIB_STORAGE select COMMONLIB_STORAGE_MMC -config BOARD_GOOGLE_CHERRY - select BOARD_GOOGLE_CHERRY_COMMON - -config BOARD_GOOGLE_DOJO - select BOARD_GOOGLE_CHERRY_COMMON - -config BOARD_GOOGLE_TOMATO - select BOARD_GOOGLE_CHERRY_COMMON - -if BOARD_GOOGLE_CHERRY_COMMON - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_VBNV_FLASH diff --git a/src/mainboard/google/corsola/Kconfig b/src/mainboard/google/corsola/Kconfig index 805a83a..fe6e6d6 100644 --- a/src/mainboard/google/corsola/Kconfig +++ b/src/mainboard/google/corsola/Kconfig @@ -1,8 +1,36 @@ ## SPDX-License-Identifier: GPL-2.0-only -# Umbrella option to be selected by variant boards. config BOARD_GOOGLE_CORSOLA_COMMON - def_bool n + def_bool BOARD_GOOGLE_KINGLER_COMMON || \ + BOARD_GOOGLE_KRABBY_COMMON || \ + BOARD_GOOGLE_STARYU_COMMON + +config BOARD_GOOGLE_KINGLER_COMMON + def_bool BOARD_GOOGLE_KINGLER || \ + BOARD_GOOGLE_PONYTA || \ + BOARD_GOOGLE_STEELIX || \ + BOARD_GOOGLE_VOLTORB + +config BOARD_GOOGLE_KRABBY_COMMON + def_bool BOARD_GOOGLE_CHINCHOU || \ + BOARD_GOOGLE_KRABBY || \ + BOARD_GOOGLE_MAGIKARP || \ + BOARD_GOOGLE_TENTACRUEL + +config BOARD_GOOGLE_STARYU_COMMON + def_bool BOARD_GOOGLE_STARMIE + select MIPI_PANEL_STA_HIMAX83102_J02 + select MIPI_PANEL_STA_ILI9882T + +if BOARD_GOOGLE_CORSOLA_COMMON + +config CORSOLA_SDCARD_INIT + def_bool BOARD_GOOGLE_MAGIKARP || \ + BOARD_GOOGLE_TENTACRUEL || \ + BOARD_GOOGLE_KINGLER_COMMON + +config BOARD_SPECIFIC_OPTIONS + def_bool y select SOC_MEDIATEK_MT8186 select BOARD_ROMSIZE_KB_8192 select MAINBOARD_HAS_CHROMEOS @@ -21,62 +49,19 @@ select MAINBOARD_HAS_TPM2 if VBOOT select MAINBOARD_HAS_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER + select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_CHINCHOU || \ + BOARD_GOOGLE_KINGLER || \ + BOARD_GOOGLE_PONYTA || \ + BOARD_GOOGLE_STEELIX || \ + BOARD_GOOGLE_VOLTORB + select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_KRABBY || \ + BOARD_GOOGLE_MAGIKARP || \ + BOARD_GOOGLE_STEELIX || \ + BOARD_GOOGLE_TENTACRUEL select RTC select FW_CONFIG select FW_CONFIG_SOURCE_CHROMEEC_CBI -config BOARD_GOOGLE_KINGLER_COMMON - def_bool n - select BOARD_GOOGLE_CORSOLA_COMMON - -config BOARD_GOOGLE_KRABBY_COMMON - def_bool n - select BOARD_GOOGLE_CORSOLA_COMMON - -config BOARD_GOOGLE_STARYU_COMMON - def_bool n - select BOARD_GOOGLE_CORSOLA_COMMON - -config BOARD_GOOGLE_KINGLER - select BOARD_GOOGLE_KINGLER_COMMON - select DRIVER_ANALOGIX_ANX7625 - -config BOARD_GOOGLE_PONYTA - select BOARD_GOOGLE_KINGLER_COMMON - select DRIVER_ANALOGIX_ANX7625 - -config BOARD_GOOGLE_STEELIX - select BOARD_GOOGLE_KINGLER_COMMON - select DRIVER_ANALOGIX_ANX7625 - select DRIVER_PARADE_PS8640 - -config BOARD_GOOGLE_VOLTORB - select BOARD_GOOGLE_KINGLER_COMMON - select DRIVER_ANALOGIX_ANX7625 - -config BOARD_GOOGLE_KRABBY - select BOARD_GOOGLE_KRABBY_COMMON - select DRIVER_PARADE_PS8640 - -config BOARD_GOOGLE_CHINCHOU - select BOARD_GOOGLE_KRABBY_COMMON - select DRIVER_ANALOGIX_ANX7625 - -config BOARD_GOOGLE_TENTACRUEL - select BOARD_GOOGLE_KRABBY_COMMON - select DRIVER_PARADE_PS8640 - -config BOARD_GOOGLE_MAGIKARP - select BOARD_GOOGLE_KRABBY_COMMON - select DRIVER_PARADE_PS8640 - -config BOARD_GOOGLE_STARMIE - select BOARD_GOOGLE_STARYU_COMMON - select MIPI_PANEL_STA_HIMAX83102_J02 - select MIPI_PANEL_STA_ILI9882T - -if BOARD_GOOGLE_CORSOLA_COMMON - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_VBNV_FLASH @@ -101,13 +86,6 @@ int default 7 -config SDCARD_INIT - bool - default y if BOARD_GOOGLE_MAGIKARP - default y if BOARD_GOOGLE_TENTACRUEL - default y if BOARD_GOOGLE_KINGLER_COMMON - default n if BOARD_GOOGLE_KRABBY_COMMON - config DRIVER_TPM_SPI_BUS hex default 0x2 diff --git a/src/mainboard/google/corsola/mainboard.c b/src/mainboard/google/corsola/mainboard.c index 69e72d7..a6659a5 100644 --- a/src/mainboard/google/corsola/mainboard.c +++ b/src/mainboard/google/corsola/mainboard.c @@ -42,7 +42,7 @@ { mtk_msdc_configure_emmc(true); - if (CONFIG(SDCARD_INIT)) { + if (CONFIG(CORSOLA_SDCARD_INIT)) { printk(BIOS_INFO, "SD card init\n"); /* External SD Card connected via USB */ diff --git a/src/mainboard/google/geralt/Kconfig b/src/mainboard/google/geralt/Kconfig index c422441..feac88a 100644 --- a/src/mainboard/google/geralt/Kconfig +++ b/src/mainboard/google/geralt/Kconfig @@ -1,17 +1,21 @@ ## SPDX-License-Identifier: GPL-2.0-only -# Umbrella option to be selected by variant boards. config BOARD_GOOGLE_GERALT_COMMON - def_bool n - -config BOARD_GOOGLE_GERALT - select BOARD_GOOGLE_GERALT_COMMON - -config BOARD_GOOGLE_CIRI - select BOARD_GOOGLE_GERALT_COMMON + def_bool BOARD_GOOGLE_CIRI || \ + BOARD_GOOGLE_GERALT if BOARD_GOOGLE_GERALT_COMMON +config GERALT_SDCARD_INIT + def_bool BOARD_GOOGLE_GERALT + +config GERALT_USE_MAX98390 + def_bool BOARD_GOOGLE_CIRI || \ + BOARD_GOOGLE_GERALT + +config GERALT_USE_NAU8318 + def_bool n + config VBOOT select VBOOT_VBNV_FLASH select EC_GOOGLE_CHROMEEC_SWITCHES @@ -66,21 +70,4 @@ hex default 0x50 -config SDCARD_INIT - bool - default y if BOARD_GOOGLE_GERALT - default n if BOARD_GOOGLE_CIRI - -choice - prompt "Speaker AMP for Geralt" - default USE_MAX98390 if BOARD_GOOGLE_GERALT || BOARD_GOOGLE_CIRI - -config USE_MAX98390 - bool "MAX98390" - -config USE_NAU8318 - bool "NAU8318" - -endchoice - endif diff --git a/src/mainboard/google/geralt/chromeos.c b/src/mainboard/google/geralt/chromeos.c index 1144701e..d66b7d5 100644 --- a/src/mainboard/google/geralt/chromeos.c +++ b/src/mainboard/google/geralt/chromeos.c @@ -46,19 +46,19 @@ fill_lp_backlight_gpios(gpios); - if (CONFIG(SDCARD_INIT)) { + if (CONFIG(GERALT_SDCARD_INIT)) { struct lb_gpio sd_card_gpios[] = { {GPIO_SD_CD_ODL.id, ACTIVE_LOW, -1, "SD card detect"}, }; lb_add_gpios(gpios, sd_card_gpios, ARRAY_SIZE(sd_card_gpios)); } - if (CONFIG(USE_MAX98390)) { + if (CONFIG(GERALT_USE_MAX98390)) { struct lb_gpio max98390_gpios[] = { {GPIO_RST_SPKR_L.id, ACTIVE_LOW, -1, "speaker reset"}, }; lb_add_gpios(gpios, max98390_gpios, ARRAY_SIZE(max98390_gpios)); - } else if (CONFIG(USE_NAU8318)) { + } else if (CONFIG(GERALT_USE_NAU8318)) { struct lb_gpio nau8318_gpios[] = { {GPIO_EN_SPKR.id, ACTIVE_HIGH, -1, "speaker enable"}, {GPIO_BEEP_ON_OD.id, ACTIVE_HIGH, -1, "beep enable"}, diff --git a/src/mainboard/google/geralt/mainboard.c b/src/mainboard/google/geralt/mainboard.c index 4042dce..6bb8380 100644 --- a/src/mainboard/google/geralt/mainboard.c +++ b/src/mainboard/google/geralt/mainboard.c @@ -31,7 +31,7 @@ static void configure_audio(void) { - if (CONFIG(USE_MAX98390)) { + if (CONFIG(GERALT_USE_MAX98390)) { printk(BIOS_DEBUG, "Configure MAX98390 audio\n"); mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST); @@ -54,7 +54,7 @@ configure_audio(); - if (CONFIG(SDCARD_INIT)) + if (CONFIG(GERALT_SDCARD_INIT)) mtk_msdc_configure_sdcard(); setup_usb_host(); diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index f5ad431..9649e25 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -1,76 +1,33 @@ ## SPDX-License-Identifier: GPL-2.0-only -# Umbrella option to be selected by variant boards. config BOARD_GOOGLE_KUKUI_COMMON - def_bool n + def_bool BOARD_GOOGLE_FLAPJACK || \ + BOARD_GOOGLE_JACUZZI_COMMON || \ + BOARD_GOOGLE_KAKADU || \ + BOARD_GOOGLE_KATSU || \ + BOARD_GOOGLE_KODAMA || \ + BOARD_GOOGLE_KRANE || \ + BOARD_GOOGLE_KUKUI config BOARD_GOOGLE_JACUZZI_COMMON - def_bool n - select BOARD_GOOGLE_KUKUI_COMMON + def_bool BOARD_GOOGLE_BURNET || \ + BOARD_GOOGLE_COZMO || \ + BOARD_GOOGLE_DAMU || \ + BOARD_GOOGLE_CERISE || \ + BOARD_GOOGLE_ESCHE || \ + BOARD_GOOGLE_FENNEL || \ + BOARD_GOOGLE_JACUZZI || \ + BOARD_GOOGLE_JUNIPER || \ + BOARD_GOOGLE_KAPPA || \ + BOARD_GOOGLE_MAKOMO || \ + BOARD_GOOGLE_MUNNA || \ + BOARD_GOOGLE_PICO || \ + BOARD_GOOGLE_STERN || \ + BOARD_GOOGLE_WILLOW select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI # All Jacuzzi followers are using ANX7625 except the reference board. select DRIVER_ANALOGIX_ANX7625 if !BOARD_GOOGLE_JACUZZI -config BOARD_GOOGLE_KUKUI - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_KRANE - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_KODAMA - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_KAKADU - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_FLAPJACK - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_KATSU - select BOARD_GOOGLE_KUKUI_COMMON - -config BOARD_GOOGLE_JACUZZI - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_JUNIPER - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_KAPPA - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_DAMU - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_CERISE - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_STERN - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_WILLOW - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_ESCHE - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_BURNET - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_FENNEL - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_COZMO - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_MAKOMO - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_MUNNA - select BOARD_GOOGLE_JACUZZI_COMMON - -config BOARD_GOOGLE_PICO - select BOARD_GOOGLE_JACUZZI_COMMON - if BOARD_GOOGLE_KUKUI_COMMON config VBOOT diff --git a/src/mainboard/google/oak/Kconfig b/src/mainboard/google/oak/Kconfig index 900b04b..3eba1f0 100644 --- a/src/mainboard/google/oak/Kconfig +++ b/src/mainboard/google/oak/Kconfig @@ -1,7 +1,14 @@ ## SPDX-License-Identifier: GPL-2.0-only config BOARD_GOOGLE_OAK_COMMON - def_bool n + def_bool BOARD_GOOGLE_ELM || \ + BOARD_GOOGLE_HANA || \ + BOARD_GOOGLE_OAK + +if BOARD_GOOGLE_OAK_COMMON + +config BOARD_SPECIFIC_OPTIONS + def_bool y select SOC_MEDIATEK_MT8173 select BOARD_ROMSIZE_KB_4096 select COMMON_CBFS_SPI_WRAPPER @@ -16,17 +23,6 @@ select MAINBOARD_HAS_CHROMEOS select SPI_FLASH -config BOARD_GOOGLE_OAK - select BOARD_GOOGLE_OAK_COMMON - -config BOARD_GOOGLE_ELM - select BOARD_GOOGLE_OAK_COMMON - -config BOARD_GOOGLE_HANA - select BOARD_GOOGLE_OAK_COMMON - -if BOARD_GOOGLE_OAK_COMMON - config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_VBNV_FLASH -- To view, visit https://review.coreboot.org/c/coreboot/+/79063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Gerrit-Change-Number: 79063 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: merged

1 0

[L] Change in coreboot[main]: google/*: Clean up Kconfg board selection for Google MTK boards
by Julius Werner (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Felix Singer, Hung-Te Lin, Nico Huber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email ) Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/asurada/Kconfig: https://review.coreboot.org/c/coreboot/+/79063/comment/f0fa9d95_c43bdb7f : PS1, Line 11: config BOARD_SPECIFIC_OPTIONS > Order is a very good argument. Note that I just wanted to point out that […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Gerrit-Change-Number: 79063 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 22 Nov 2023 01:50:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards
by Julius Werner (Code Review) 22 Nov '23

22 Nov '23

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79022?usp=email ) Change subject: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards ...................................................................... google/*: Clean up Kconfig board selection for non-MTK Google Arm boards This patch unifies and simplifies the Kconfig selection model for the Gru, Herobrine, Trogdor and Veyron boards according to the model discussed in CB:78972. Also add missing license headers to two Kconfig files while I'm here. Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Signed-off-by: Julius Werner <jwerner(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79022 Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/gru/Kconfig M src/mainboard/google/herobrine/Kconfig M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/veyron/Kconfig 4 files changed, 59 insertions(+), 139 deletions(-) Approvals: Yu-Ping Wu: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/gru/Kconfig b/src/mainboard/google/gru/Kconfig index 837b06d..2d7e12c 100644 --- a/src/mainboard/google/gru/Kconfig +++ b/src/mainboard/google/gru/Kconfig @@ -1,25 +1,12 @@ ## SPDX-License-Identifier: GPL-2.0-only -config BOARD_GOOGLE_GRU_COMMON # Umbrella option to be selected by variant boards. - def_bool n - -config BOARD_GOOGLE_KEVIN - select BOARD_GOOGLE_GRU_COMMON - -config BOARD_GOOGLE_GRU - select BOARD_GOOGLE_GRU_COMMON - -config BOARD_GOOGLE_BOB - select BOARD_GOOGLE_GRU_COMMON - -config BOARD_GOOGLE_SCARLET - select BOARD_GOOGLE_GRU_COMMON - -config BOARD_GOOGLE_NEFARIO - select BOARD_GOOGLE_GRU_COMMON - -config BOARD_GOOGLE_RAINIER - select BOARD_GOOGLE_GRU_COMMON +config BOARD_GOOGLE_GRU_COMMON + def_bool BOARD_GOOGLE_BOB || \ + BOARD_GOOGLE_GRU || \ + BOARD_GOOGLE_KEVIN || \ + BOARD_GOOGLE_NEFARIO || \ + BOARD_GOOGLE_RAINIER || \ + BOARD_GOOGLE_SCARLET if BOARD_GOOGLE_GRU_COMMON @@ -27,23 +14,21 @@ # convenience. Explicitly override it when building for earlier Kevins. config GRU_HAS_TPM2 bool "Build for a board revision with a SPI TPM 2.0" - default n if BOARD_GOOGLE_KEVIN - default y + default !BOARD_GOOGLE_KEVIN config GRU_HAS_CENTERLOG_PWM - bool - default y if BOARD_GOOGLE_GRU || BOARD_GOOGLE_KEVIN || BOARD_GOOGLE_BOB - default n + def_bool BOARD_GOOGLE_GRU || \ + BOARD_GOOGLE_KEVIN || \ + BOARD_GOOGLE_BOB config GRU_HAS_WLAN_RESET - bool - default y if BOARD_GOOGLE_GRU || BOARD_GOOGLE_KEVIN || BOARD_GOOGLE_BOB - default n + def_bool BOARD_GOOGLE_GRU || \ + BOARD_GOOGLE_KEVIN || \ + BOARD_GOOGLE_BOB config GRU_BASEBOARD_SCARLET - bool - default y if BOARD_GOOGLE_SCARLET || BOARD_GOOGLE_RAINIER - default n + def_bool BOARD_GOOGLE_SCARLET || \ + BOARD_GOOGLE_RAINIER config BOARD_SPECIFIC_OPTIONS def_bool y diff --git a/src/mainboard/google/herobrine/Kconfig b/src/mainboard/google/herobrine/Kconfig index 45f296c..8758fb9 100644 --- a/src/mainboard/google/herobrine/Kconfig +++ b/src/mainboard/google/herobrine/Kconfig @@ -1,39 +1,21 @@ -config BOARD_GOOGLE_HEROBRINE_COMMON # Umbrella option to be selected by variants - def_bool n +## SPDX-License-Identifier: GPL-2.0-only -config BOARD_GOOGLE_HEROBRINE - select BOARD_GOOGLE_HEROBRINE_COMMON - -config BOARD_GOOGLE_HEROBRINE_REV0 - select BOARD_GOOGLE_HEROBRINE_COMMON - -config BOARD_GOOGLE_SENOR - select BOARD_GOOGLE_HEROBRINE_COMMON - -config BOARD_GOOGLE_PIGLIN - select BOARD_GOOGLE_HEROBRINE_COMMON - -config BOARD_GOOGLE_HOGLIN - select BOARD_GOOGLE_HEROBRINE_COMMON - -config BOARD_GOOGLE_VILLAGER - select BOARD_GOOGLE_HEROBRINE_COMMON - -config BOARD_GOOGLE_EVOKER - select BOARD_GOOGLE_HEROBRINE_COMMON - -config BOARD_GOOGLE_ZOGLIN - select BOARD_GOOGLE_HEROBRINE_COMMON - -config BOARD_GOOGLE_ZOMBIE - select BOARD_GOOGLE_HEROBRINE_COMMON +config BOARD_GOOGLE_HEROBRINE_COMMON + def_bool BOARD_GOOGLE_EVOKER || \ + BOARD_GOOGLE_HEROBRINE || \ + BOARD_GOOGLE_HEROBRINE_REV0 || \ + BOARD_GOOGLE_HOGLIN || \ + BOARD_GOOGLE_PIGLIN || \ + BOARD_GOOGLE_SENOR || \ + BOARD_GOOGLE_VILLAGER || \ + BOARD_GOOGLE_ZOGLIN || \ + BOARD_GOOGLE_ZOMBIE if BOARD_GOOGLE_HEROBRINE_COMMON config HEROBRINE_HAS_FINGERPRINT - bool - default y if BOARD_GOOGLE_HEROBRINE || BOARD_GOOGLE_HEROBRINE_REV0 - default n + def_bool BOARD_GOOGLE_HEROBRINE || \ + BOARD_GOOGLE_HEROBRINE_REV0 config BOARD_SPECIFIC_OPTIONS def_bool y diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index f7e1afe..2a933bb 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -1,45 +1,19 @@ +## SPDX-License-Identifier: GPL-2.0-only -config BOARD_GOOGLE_TROGDOR_COMMON # Umbrella option to be selected by variants - def_bool n - -config BOARD_GOOGLE_BUBS - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_COACHZ - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_GELARSHIE - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_HOMESTAR - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_KINGOFTOWN - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_LAZOR - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_MARZIPAN - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_MRBLAND - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_PAZQUEL - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_POMPOM - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_QUACKINGSTICK - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_WORMDINGLER - select BOARD_GOOGLE_TROGDOR_COMMON - -config BOARD_GOOGLE_TROGDOR - select BOARD_GOOGLE_TROGDOR_COMMON +config BOARD_GOOGLE_TROGDOR_COMMON + def_bool BOARD_GOOGLE_BUBS || \ + BOARD_GOOGLE_COACHZ || \ + BOARD_GOOGLE_GELARSHIE || \ + BOARD_GOOGLE_HOMESTAR || \ + BOARD_GOOGLE_KINGOFTOWN || \ + BOARD_GOOGLE_LAZOR || \ + BOARD_GOOGLE_MARZIPAN || \ + BOARD_GOOGLE_MRBLAND || \ + BOARD_GOOGLE_PAZQUEL || \ + BOARD_GOOGLE_POMPOM || \ + BOARD_GOOGLE_QUACKINGSTICK || \ + BOARD_GOOGLE_TROGDOR || \ + BOARD_GOOGLE_WORMDINGLER if BOARD_GOOGLE_TROGDOR_COMMON @@ -47,24 +21,20 @@ def_bool n config TROGDOR_HAS_BRIDGE_BACKLIGHT - bool - default y if BOARD_GOOGLE_HOMESTAR - default n + def_bool BOARD_GOOGLE_HOMESTAR config TROGDOR_HAS_MIPI_PANEL - bool - default y if BOARD_GOOGLE_MRBLAND || BOARD_GOOGLE_QUACKINGSTICK || BOARD_GOOGLE_WORMDINGLER + def_bool BOARD_GOOGLE_MRBLAND || \ + BOARD_GOOGLE_QUACKINGSTICK || \ + BOARD_GOOGLE_WORMDINGLER select MIPI_PANEL_AUO_B101UAN08_3 if BOARD_GOOGLE_MRBLAND || BOARD_GOOGLE_QUACKINGSTICK select MIPI_PANEL_BOE_TV101WUM_N53 if BOARD_GOOGLE_MRBLAND select MIPI_PANEL_INX_HJ110IZ_01A_B2 if BOARD_GOOGLE_WORMDINGLER select MIPI_PANEL_BOE_TV110C9M_LL0 if BOARD_GOOGLE_WORMDINGLER - default n config TROGDOR_HAS_FINGERPRINT - bool - default y if BOARD_GOOGLE_COACHZ - default y if BOARD_GOOGLE_MARZIPAN - default n + def_bool BOARD_GOOGLE_COACHZ || \ + BOARD_GOOGLE_MARZIPAN config BOARD_SPECIFIC_OPTIONS def_bool y diff --git a/src/mainboard/google/veyron/Kconfig b/src/mainboard/google/veyron/Kconfig index 0e543e1..08af442 100644 --- a/src/mainboard/google/veyron/Kconfig +++ b/src/mainboard/google/veyron/Kconfig @@ -1,27 +1,11 @@ ## SPDX-License-Identifier: GPL-2.0-only config BOARD_GOOGLE_VEYRON - def_bool n - -config BOARD_GOOGLE_VEYRON_JAQ - select BOARD_GOOGLE_VEYRON - select SYSTEM_TYPE_LAPTOP - -config BOARD_GOOGLE_VEYRON_JERRY - select BOARD_GOOGLE_VEYRON - select SYSTEM_TYPE_LAPTOP - -config BOARD_GOOGLE_VEYRON_MIGHTY - select BOARD_GOOGLE_VEYRON - select SYSTEM_TYPE_LAPTOP - -config BOARD_GOOGLE_VEYRON_MINNIE - select BOARD_GOOGLE_VEYRON - select SYSTEM_TYPE_LAPTOP - -config BOARD_GOOGLE_VEYRON_SPEEDY - select BOARD_GOOGLE_VEYRON - select SYSTEM_TYPE_LAPTOP + def_bool BOARD_GOOGLE_VEYRON_JAQ || \ + BOARD_GOOGLE_VEYRON_JERRY || \ + BOARD_GOOGLE_VEYRON_MIGHTY || \ + BOARD_GOOGLE_VEYRON_MINNIE || \ + BOARD_GOOGLE_VEYRON_SPEEDY if BOARD_GOOGLE_VEYRON @@ -29,11 +13,9 @@ # resistors. These get overpowered by the SoC's internal pull-downs, so we # cannot read those pins as tri-state. They're restricted to binary RAM codes. config VEYRON_FORCE_BINARY_RAM_CODE - bool - default y if BOARD_GOOGLE_VEYRON_JAQ - default y if BOARD_GOOGLE_VEYRON_JERRY - default y if BOARD_GOOGLE_VEYRON_MIGHTY - default n + def_bool BOARD_GOOGLE_VEYRON_JAQ || \ + BOARD_GOOGLE_VEYRON_JERRY || \ + BOARD_GOOGLE_VEYRON_MIGHTY config BOARD_SPECIFIC_OPTIONS def_bool y @@ -48,6 +30,7 @@ select SPI_FLASH_WINBOND select I2C_TPM select MAINBOARD_HAS_TPM1 + select SYSTEM_TYPE_LAPTOP config VBOOT select VBOOT_VBNV_FLASH -- To view, visit https://review.coreboot.org/c/coreboot/+/79022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Gerrit-Change-Number: 79022 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: arch/riscv/romstage: Start from assembly
by Maximilian Brune (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Arthur Heymans, Philipp Hug, ron minnich. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68840?usp=email ) Change subject: arch/riscv/romstage: Start from assembly ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68840?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I79d875aca6cd0cffe482e4ebb5f388af0adf6aed Gerrit-Change-Number: 68840 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 01:38:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC
by Maximilian Brune (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Angel Pons, Felix Singer, Lean Sheng Tan, Martin L Roth, Paul Menzel, Subrata Banik, Tim Wawrzynczak. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66545?usp=email ) Change subject: mb/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC ...................................................................... Patch Set 24: (8 comments) File src/mainboard/intel/adlrvp/devicetree_s.cb: https://review.coreboot.org/c/coreboot/+/66545/comment/73457982_863a6681 : PS22, Line 2: > move conflicting stuff to overridetrees, keep common stuff in devicetrees. The issue is that I don't know yet what is common and what is conflicting. So should I put everything into this devicetree for now and only add an empty override tree for now? File src/mainboard/intel/adlrvp/devicetree_s.cb: https://review.coreboot.org/c/coreboot/+/66545/comment/4bce2f67_a647054d : PS23, Line 4: register "usb2_ports[6]" = "USB2_PORT_MID(OC7)" # USB3/2 Type A port7 : register "usb2_ports[9]" = "USB2_PORT_MID(OC7)" # USB3/2 Type A port10 : register "usb2_ports[10]" = "USB2_PORT_MID(OC0)" # USB3/2 Type A port11 : r > +1 Done https://review.coreboot.org/c/coreboot/+/66545/comment/41563ad8_dcb9491b : PS23, Line 9: # DDI_PORT_A: Combo PHY A # ADL-S RVP UDIMM 1DPC eDP1.4 Connector : # DDI_PORT_1: Combo PHY B # ADL-S RVP UDIMM 1DPC HDMI 1.4b CRLS : # DDI_PORT_2: Combo PHY C # ADL-S RVP UDIMM 1DPC DP1.4a Connector : # DDI_PORT_3: Combo PHY D # ADL-S RVP UDIMM 1DPC HDMI 2.0b ALS : # DDI_PORT_4: Combo PHY E # ADL-S RVP UDIMM 1DPC DP1.4a Connector : # Enable eDP in PortA #TODO test : #register "ddi_portA_config" = "1" : #[DDI_PORT_A] = DDI_ENABLE_HPD : register "ddi_ports_config" = "{ : [DDI_PORT_1] = DDI_ENABLE_HPD, : [DDI_PORT_2] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, : [DDI_PORT_3] = DDI_ENABLE_HPD, : [DDI_PORT_4] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, : }" > +1 Done https://review.coreboot.org/c/coreboot/+/66545/comment/99ebc0ac_1e7d332f : PS23, Line 33: [4] = 0, : [5] = 0, > Remove, zero by default. Done https://review.coreboot.org/c/coreboot/+/66545/comment/50dc8bfd_babc8782 : PS23, Line 24: register "sata_salp_support" = "1" : register "sata_ports_enable" = "{ : [4] = 1, : [5] = 1, : [6] = 1, : [7] = 1, : }" : : register "sata_ports_dev_slp" = "{ : [4] = 0, : [5] = 0, : [6] = 1, : [7] = 1, : }" > +1 Done File src/mainboard/intel/adlrvp/variants/adlrvp_s_ddr5_udimm_1dpc/overridetree.cb: https://review.coreboot.org/c/coreboot/+/66545/comment/ec001c26_b89dba35 : PS23, Line 3: device domain 0 on > Use tabs between the device name and the on keyword. why? I have never seen that in any devicetree. https://review.coreboot.org/c/coreboot/+/66545/comment/df307813_2a3f122d : PS23, Line 23: device ref pcie5_1 off end > Remove? Done https://review.coreboot.org/c/coreboot/+/66545/comment/24edec44_c353499e : PS23, Line 60: #device ref pcie_rp9 on (doesn't work) : # # PCIE x4 Slot 2 (Document 626352 is wrong here. it states that clk_src should be 16) : # register "pch_pcie_rp[PCH_RP(9)]" = "{ : # .clk_src = 14, : # .clk_req = 14, : # .flags = PCIE_RP_CLK_REQ_DETECT, : # }" : #end > Can be removed? not sure if I should keep this here, since the configuration should be correct, but I currently have no way of verifying it. It may be that I broke the rootport somehow. -- To view, visit https://review.coreboot.org/c/coreboot/+/66545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic1f62d6dd0b00d26f8c8a71b624ba5fba4c63774 Gerrit-Change-Number: 66545 Gerrit-PatchSet: 24 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 01:28:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: src/arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker
by Jérémy Compostella (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Patrick Georgi, Srinivas Hegde. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79218?usp=email ) Change subject: src/arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878 Gerrit-Change-Number: 79218 Gerrit-PatchSet: 2 Gerrit-Owner: Srinivas Hegde <srinivashegde(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Srinivas Hegde <srinivashegde(a)google.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Wed, 22 Nov 2023 01:27:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC
by Maximilian Brune (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Felix Singer, Lean Sheng Tan, Martin L Roth, Maximilian Brune, Paul Menzel, Subrata Banik, Tim Wawrzynczak. Hello Angel Pons, Lean Sheng Tan, Subrata Banik, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/66545?usp=email to look at the new patch set (#24). The following approvals got outdated and were removed: Code-Review+1 by Lean Sheng Tan, Verified+1 by build bot (Jenkins) Change subject: mb/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC ...................................................................... mb/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC Tested: - Boot SeaBIOS (46de2eecf) -> Linux 6.0.1 - Boot 9elements/EDK2 (4f58f36b8) -> Linux 6.0.1, Windows 10 - M.2 SSD Slot 1: PCH SSD - M.2 SSD Slot 2: PCH SSD - M.2 SSD Slot 3: PCH SSD, Backside - SATA Cable Port 1-3 - SATA Direct Connect Port - DisplayPort Port 1,2 - HDMI Port 1,2 - PCIE x4 Slot 1 - PCIE x4 Slot 3 - USB Ports 1-4 (Backpanel) - M.2. CNVI: WiFi (Linux 6.0.1 works, Win 10 does not) - S3 (suspend to ram) (Linux 6.0.1 works, Win 10 does not) - S4 (hibernate) - M.2. CNVI: Bluetooth - LAN GBE missing: - Displayport over USB-C - some USB Ports still missing - PCIE x4 Slot 2 (for some reason it doesn't work) - M.2 SSD Slot 4: CPU SSD - PEG (PCIE x16 Slot) connected to CPU Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Ic1f62d6dd0b00d26f8c8a71b624ba5fba4c63774 --- M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/adlrvp/Kconfig.name M src/mainboard/intel/adlrvp/Makefile.inc A src/mainboard/intel/adlrvp/devicetree_s.cb A src/mainboard/intel/adlrvp/early_gpio_s.c A src/mainboard/intel/adlrvp/gpio_s.c M src/mainboard/intel/adlrvp/include/baseboard/variants.h M src/mainboard/intel/adlrvp/memory.c M src/mainboard/intel/adlrvp/ramstage.c M src/mainboard/intel/adlrvp/romstage_fsp_params.c A src/mainboard/intel/adlrvp/variants/adlrvp_s_ddr5_udimm_1dpc/overridetree.cb 11 files changed, 572 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/66545/24 -- To view, visit https://review.coreboot.org/c/coreboot/+/66545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic1f62d6dd0b00d26f8c8a71b624ba5fba4c63774 Gerrit-Change-Number: 66545 Gerrit-PatchSet: 24 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards
by Yu-Ping Wu (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Felix Singer, Julius Werner, Nico Huber, Shelley Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79022?usp=email ) Change subject: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Gerrit-Change-Number: 79022 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 22 Nov 2023 00:49:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards
by Julius Werner (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Felix Singer, Nico Huber, Shelley Chen, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79022?usp=email ) Change subject: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/herobrine/Kconfig: https://review.coreboot.org/c/coreboot/+/79022/comment/ddb9f1a3_7d93c779 : PS2, Line 14: config BOARD_GOOGLE_HEROBRINE > These should be removed. Sorry, rebase error. File src/mainboard/google/trogdor/Kconfig: https://review.coreboot.org/c/coreboot/+/79022/comment/18c222df_dfecdfce : PS2, Line 18: config BOARD_GOOGLE_BUBS > These should be removed. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Gerrit-Change-Number: 79022 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 00:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards
by Julius Werner (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Felix Singer, Julius Werner, Nico Huber, Shelley Chen. Hello Felix Singer, Nico Huber, Shelley Chen, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79022?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: google/*: Clean up Kconfig board selection for non-MTK Google Arm boards ...................................................................... google/*: Clean up Kconfig board selection for non-MTK Google Arm boards This patch unifies and simplifies the Kconfig selection model for the Gru, Herobrine, Trogdor and Veyron boards according to the model discussed in CB:78972. Also add missing license headers to two Kconfig files while I'm here. Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/gru/Kconfig M src/mainboard/google/herobrine/Kconfig M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/veyron/Kconfig 4 files changed, 59 insertions(+), 139 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/79022/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If679a05afd10869afba9c2a33b54862e102b5f40 Gerrit-Change-Number: 79022 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023