coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: src/arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker
by Julius Werner (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Jérémy Compostella, Patrick Georgi, Srinivas Hegde. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79218?usp=email ) Change subject: src/arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: +Patrick, any idea why this was added in CB:9283? -- To view, visit https://review.coreboot.org/c/coreboot/+/79218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878 Gerrit-Change-Number: 79218 Gerrit-PatchSet: 2 Gerrit-Owner: Srinivas Hegde <srinivashegde(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Srinivas Hegde <srinivashegde(a)google.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 00:15:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: WIP:soc/amd/mendocino: Add DBG2
by Felix Held (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Bao Zheng, Cliff Huang, Fred Reitberger, Jason Glenesk, Lance Zhao, Matt DeVillier, Tim Wawrzynczak, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79174?usp=email ) Change subject: WIP:soc/amd/mendocino: Add DBG2 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: when looking into this, i also found that we're probably using the wrong subtype; pushed CB:79219 which is however completely untested -- To view, visit https://review.coreboot.org/c/coreboot/+/79174?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c97a78d1889549421baf0bc1a2e8f959a0f47e2 Gerrit-Change-Number: 79174 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 00:14:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vendorcode/amd: Hook up opensil
by Felix Held (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Arthur Heymans, Martin L Roth, Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email ) Change subject: vendorcode/amd: Hook up opensil ...................................................................... Patch Set 13: (7 comments) Patchset: PS13: still need to look more into how the meson build system works, but already adding some comments File src/vendorcode/amd/opensil/Makefile.inc: https://review.coreboot.org/c/coreboot/+/76511/comment/abd303e5_b9337426 : PS13, Line 15: else it would make the code more readable to add a comment that this os the else branch for the if CONFIG_ARCH_RAMSTAGE_X86_32. or, which might be the better solution, don't use else here and change that to and endif for the last block and a ifeq ($(CONFIG_ARCH_RAMSTAGE_X86_64),y) as condition for the 64 bit support. might be good to make sure that exactly one of those two is set https://review.coreboot.org/c/coreboot/+/76511/comment/7f4efcf9_d541969f : PS13, Line 24: ifeq ($(CONFIG_OPENSIL_DEBUG_OUTPUT),y) add an empty line before this one, to have this if block that's unrelated to the ones before it separated for better readability https://review.coreboot.org/c/coreboot/+/76511/comment/be656096_11fac0ef : PS13, Line 30: ifeq ($(shell printf %.1s "$(obj)"),/) still need to figure out what this is doing exactly. adding a comment would certainly help https://review.coreboot.org/c/coreboot/+/76511/comment/8c40699c_b004432b : PS13, Line 46: $(CONFIG_C_ENV_BOOTBLOCK_SIZE) this should either be $(bios_size) or the bios_size definition in line 41 should be dropped https://review.coreboot.org/c/coreboot/+/76511/comment/7b5466ef_33b7f1c0 : PS13, Line 69: # Don't set a meson buildtype as opensil is broken when compiler optimizations are enabled ouch :( File src/vendorcode/amd/opensil/genoa_poc/meson_cross.template: https://review.coreboot.org/c/coreboot/+/76511/comment/7a2df6f6_8a711234 : PS13, Line 18: '-D_PORTING_H_=1', is this needed for opensil to build? -- To view, visit https://review.coreboot.org/c/coreboot/+/76511?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide2d181914116119dfd37b1511d89ea965729141 Gerrit-Change-Number: 76511 Gerrit-PatchSet: 13 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 00:05:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: payloads/libpayload: Add skip_atoi()
by Maximilian Brune (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Julius Werner. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78026?usp=email ) Change subject: payloads/libpayload: Add skip_atoi() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This should probably move into commonlib if it is supposed to be used by both sides. […] At this point I can also merge string.h to commonlib. Let me know what you think: CB:79224 -- To view, visit https://review.coreboot.org/c/coreboot/+/78026?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I73cd36ff370e15d5b6242c3b07b14d1724f8ac24 Gerrit-Change-Number: 78026 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Nov 2023 23:58:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: treewide: Move stdlib.h to commonlib
by Maximilian Brune (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Andrey Petrov, Arthur Heymans, Christian Walter, Hung-Te Lin, Jakub Czapiga, Johnny Lin, Julius Werner, Martin L Roth, Ronak Kanabar, Tim Chu, Yidi Lin, Yu-Ping Wu. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77969?usp=email ) Change subject: treewide: Move stdlib.h to commonlib ...................................................................... Patch Set 9: (7 comments) File src/commonlib/bsd/include/commonlib/bsd/stdlib.h: https://review.coreboot.org/c/coreboot/+/77969/comment/ae903f8a_804d6b3f : PS7, Line 10: #if CONFIG(COREBOOT_BUILD) > I think this is also not great (I know that that's not your patch, but I think a bunch of things wer […] No worries. I am always happy to clean up old stuff. Done https://review.coreboot.org/c/coreboot/+/77969/comment/4269eb40_0a805107 : PS7, Line 30: %s/%s/line %d > nit: This may just be my personal nitpick, but I find the `%s:%d %s():` from libpayload nicer than t […] Agree. Done. File src/drivers/intel/fsp2_0/silicon_init.c: https://review.coreboot.org/c/coreboot/+/77969/comment/2f8a108b_f6ce477b : PS6, Line 8: #include <commonlib/bsd/stdlib.h> > Yeah, that policy isn't cleanly implemented everywhere in coreboot, but it's good to fix up things w […] Oh yeah seems I forgot that one. Done. File src/lib/device_tree.c: https://review.coreboot.org/c/coreboot/+/77969/comment/e2db4526_b891ed31 : PS7, Line 5: #include <stdlib.h> > already included below Done File src/soc/intel/xeon_sp/spr/numa.c: https://review.coreboot.org/c/coreboot/+/77969/comment/721e36a2_314ff00d : PS7, Line 4: #include <stdlib.h> > Not really necessary for files that already include `<types. […] Done File src/soc/mediatek/common/pcie.c: https://review.coreboot.org/c/coreboot/+/77969/comment/d661d174_2c31f0c6 : PS7, Line 4: #include <stdlib.h> > same Done File src/soc/mediatek/mt8195/pcie.c: https://review.coreboot.org/c/coreboot/+/77969/comment/0530fd8d_63fc47d3 : PS7, Line 3: #include <stdlib.h> > same Done -- To view, visit https://review.coreboot.org/c/coreboot/+/77969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a7ab0d1ddcc7ce9af121a61b4d4eafc9e563a8a Gerrit-Change-Number: 77969 Gerrit-PatchSet: 9 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 23:57:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: treewide: Move stdlib.h to commonlib
by Maximilian Brune (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Andrey Petrov, Arthur Heymans, Christian Walter, Hung-Te Lin, Jakub Czapiga, Johnny Lin, Martin L Roth, Ronak Kanabar, Tim Chu, Yidi Lin, Yu-Ping Wu. Hello Andrey Petrov, Arthur Heymans, Christian Walter, Hung-Te Lin, Jakub Czapiga, Johnny Lin, Martin L Roth, Ronak Kanabar, Tim Chu, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/77969?usp=email to look at the new patch set (#9). Change subject: treewide: Move stdlib.h to commonlib ...................................................................... treewide: Move stdlib.h to commonlib This patch moves commonlib/stdlib.h -> commonlib/bsd/stdlib.h, since all code is BSD licensed anyway. It also moves some code from libpayloads stdlib.h to commonlib/bsd/stdlib.h so that it can be shared with coreboot. This is useful for a subsequent commit that adds devicetree.c into commonlib. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I3a7ab0d1ddcc7ce9af121a61b4d4eafc9e563a8a --- M Makefile.inc M payloads/libpayload/include/stdlib.h R src/commonlib/bsd/include/commonlib/bsd/stdlib.h M src/commonlib/storage/bouncebuf.c M src/commonlib/storage/sdhci.c M src/drivers/intel/fsp2_0/silicon_init.c M src/include/stdlib.h M src/lib/device_tree.c M src/lib/fit.c M src/soc/intel/xeon_sp/spr/numa.c M src/soc/mediatek/common/pcie.c M src/soc/mediatek/mt8195/pcie.c 12 files changed, 15 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/77969/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/77969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a7ab0d1ddcc7ce9af121a61b4d4eafc9e563a8a Gerrit-Change-Number: 77969 Gerrit-PatchSet: 9 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: treewide: Move list.h to commonlib
by Maximilian Brune (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Jakub Czapiga. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77968?usp=email ) Change subject: treewide: Move list.h to commonlib ...................................................................... Patch Set 6: (1 comment) File payloads/libpayload/libc/Makefile.inc: https://review.coreboot.org/c/coreboot/+/77968/comment/2505e5c6_6cc27491 : PS1, Line 45: libc-srcs += $(coreboottop)/src/commonlib/list.c > I updated the patch and I will keep it in mind for future patches. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/77968?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I16eb7b743fb1d36301f0eda563a62364e7a9cfec Gerrit-Change-Number: 77968 Gerrit-PatchSet: 6 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 23:54:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: treewide: Move string.h to commonlib
by Maximilian Brune (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Maximilian Brune. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79224?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: treewide: Move string.h to commonlib ...................................................................... treewide: Move string.h to commonlib This moves libpayloads string.h to commonlib/bsd/string.h and removes all function declarations that are duplicate of coreboots GPL2 licensed string.h and libpayloads string.h. It also removes the long version of the BSD-3-Clause and instead uses the SPDX short identifier. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Ifb05d70e474ad2dc9e5d4726363ce01c70699f7f --- M payloads/libpayload/include/string.h A src/commonlib/bsd/include/commonlib/bsd/string.h M src/include/string.h M src/lib/string.c 4 files changed, 38 insertions(+), 56 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/79224/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79224?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb05d70e474ad2dc9e5d4726363ce01c70699f7f Gerrit-Change-Number: 79224 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: Documentation: Improve x86_64
by Felix Held (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Benjamin Doron, Martin L Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79160?usp=email ) Change subject: Documentation: Improve x86_64 ...................................................................... Patch Set 1: (4 comments) File Documentation/arch/x86/x86_64.md: https://review.coreboot.org/c/coreboot/+/79160/comment/8a1c2a09_4601fa65 : PS1, Line 19: * The BIOS region of the SPI flash is memory mapped at reset. haven't exactly looked at the details of how this works on newer AMD SoCs, but there the bootblock is typically already executed from DRAM, so this isn't true in that case https://review.coreboot.org/c/coreboot/+/79160/comment/25bea93b_a4c7c57a : PS1, Line 107: * Fix running VGA Option ROMs option roms can't currently be run directly when in long mode, since only going to real mode is only implemented from protected mode and not from long mode, but using yabel still works from long mode. unsure how compatible yabel is with option roms in general though https://review.coreboot.org/c/coreboot/+/79160/comment/28538153_9b60c4c9 : PS1, Line 117: * Place and run code above 4GiB do we really need this? i'd say that we should just keep all code and stack/heap below 4GB https://review.coreboot.org/c/coreboot/+/79160/comment/6d9e77a2_e262ee08 : PS1, Line 155: * Entering long mode crashes on AMD host platforms. > I don't think this is true anymore. […] i haven't added the code for switching back to 32 bit mode before calling FSP; that code was already in place. on Picasso i can build coreboot in 64 bit mode and the 32 bit FSP still runs fine. on Cezanne and Mendocino there was some problem that someone else debugged, but i don't remember what the cause and solution was and if the solution has already been put into place. on Genoa, coreboot uses long mode and not protected mode -- To view, visit https://review.coreboot.org/c/coreboot/+/79160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5ba51be629a8c878aad64d3297176457cf8e855 Gerrit-Change-Number: 79160 Gerrit-PatchSet: 1 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 23:51:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: treewide: Move string.h to commonlib
by Maximilian Brune (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Maximilian Brune. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79224?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: treewide: Move string.h to commonlib ...................................................................... treewide: Move string.h to commonlib This moves libpayloads string.h to commonlib/bsd/string.h and removes all function declarations that are duplicate of coreboots GPL2 licensed string.h and libpayloads string.h. It also removes the long version of the BSD-3-Clause and instead uses the SPDX short identifier. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Ifb05d70e474ad2dc9e5d4726363ce01c70699f7f --- M payloads/libpayload/include/string.h A src/commonlib/bsd/include/commonlib/bsd/string.h M src/include/string.h 3 files changed, 34 insertions(+), 52 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/79224/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79224?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb05d70e474ad2dc9e5d4726363ce01c70699f7f Gerrit-Change-Number: 79224 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023