coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
by Robert Chen (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email ) Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/variants/quandiso/fw_config.c: https://review.coreboot.org/c/coreboot/+/79173/comment/078ee750_cfecb20e : PS4, Line 76: static const struct pad_config disable_usbc1_pins[] = { > I only found aux pin here register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E22, . […] https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/main/src/… From nissa baseboard gpio.c and quandiso gpio table, A21 and A22 are USB_C1_AUX_DC for nivviks, yavi* series and quandiso. -- To view, visit https://review.coreboot.org/c/coreboot/+/79173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Gerrit-Change-Number: 79173 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 22 Nov 2023 03:07:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Properly configure early serial
by Keith Hui (Code Review) 22 Nov '23

22 Nov '23

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79222?usp=email ) Change subject: mb/asus/p8z77-m: Properly configure early serial ...................................................................... mb/asus/p8z77-m: Properly configure early serial Board was not producing serial output until well into ramstage. To fix, select SUPERIO_NUVOTON_COMMON_COM_A Kconfig to tell nuvoton_enable_serial() to route serial port A signals to the outside, not GPIO8x. TEST=Full native raminit debug log received over serial by minicom. Change-Id: I376a79dd76ffa5f4d47e7c0cb53680e173e1ad78 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asus/p8x7x-series/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/79222/1 diff --git a/src/mainboard/asus/p8x7x-series/Kconfig b/src/mainboard/asus/p8x7x-series/Kconfig index 277fe40..e278b56 100644 --- a/src/mainboard/asus/p8x7x-series/Kconfig +++ b/src/mainboard/asus/p8x7x-series/Kconfig @@ -54,6 +54,7 @@ select BOARD_ROMSIZE_KB_8192 select MEMORY_MAPPED_TPM select SUPERIO_NUVOTON_NCT6779D + select SUPERIO_NUVOTON_COMMON_COM_A if BOARD_ASUS_P8X7X_SERIES -- To view, visit https://review.coreboot.org/c/coreboot/+/79222?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I376a79dd76ffa5f4d47e7c0cb53680e173e1ad78 Gerrit-Change-Number: 79222 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: mb/asus/p8z77-m_pro: Drop useless early init code
by Keith Hui (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Angel Pons, Nico Huber, Patrick Rudolph, Paul Menzel, Vlado Cibic. Hello Angel Pons, Patrick Rudolph, Vlado Cibic, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73693?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/asus/p8z77-m_pro: Drop useless early init code ...................................................................... mb/asus/p8z77-m_pro: Drop useless early init code Drop code that puts Super I/O into config mode, select serial device, then leave config mode right away having done nothing. I'll also take this chance to revise its #includes based on include-what-you-use results. Change-Id: I304fc1610740375b59121b6b8784122440795838 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c 1 file changed, 1 insertion(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/73693/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/73693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I304fc1610740375b59121b6b8784122440795838 Gerrit-Change-Number: 73693 Gerrit-PatchSet: 10 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Vlado Cibic Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Vlado Cibic Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
by Eric Lai (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Nick Vaccaro, Paul Menzel, Robert Chen, Shawn Ku, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email ) Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/variants/quandiso/fw_config.c: https://review.coreboot.org/c/coreboot/+/79173/comment/a1df9dc6_9c553b58 : PS4, Line 76: static const struct pad_config disable_usbc1_pins[] = { I only found aux pin here register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E22, .pad_auxn_dc = GPP_E23}" why A21 a22? -- To view, visit https://review.coreboot.org/c/coreboot/+/79173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Gerrit-Change-Number: 79173 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 02:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
by Robert Chen (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email ) Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Hi @ericllai@google.com, Can you help to review this commit? -- To view, visit https://review.coreboot.org/c/coreboot/+/79173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Gerrit-Change-Number: 79173 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 22 Nov 2023 02:40:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: joxer: chagne GPP_F17 to edge triggered
by Scott Chao (Code Review) 22 Nov '23

22 Nov '23

Scott Chao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79221?usp=email ) Change subject: joxer: chagne GPP_F17 to edge triggered ...................................................................... joxer: chagne GPP_F17 to edge triggered Change-Id: I3abaf57a90811becf3d01fbb1e4c9afac3e96e33 --- M src/mainboard/google/brya/variants/joxer/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/79221/1 diff --git a/src/mainboard/google/brya/variants/joxer/gpio.c b/src/mainboard/google/brya/variants/joxer/gpio.c index f105861..9113141 100644 --- a/src/mainboard/google/brya/variants/joxer/gpio.c +++ b/src/mainboard/google/brya/variants/joxer/gpio.c @@ -40,6 +40,8 @@ PAD_NC(GPP_F13, NONE), /* F15 : GSXSRESET# ==> NC */ PAD_NC_LOCK(GPP_F15, NONE, LOCK_CONFIG), + /* F17 : THC1_SPI2_RST# ==> EC_SOC_WAKE_ODL */ + PAD_CFG_GPI_IRQ_WAKE_LOCK(GPP_F17, NONE, EDGE_SINGLE, INVERT, LOCK_CONFIG), /* H8 : CNV_MFUART2_RXD ==> NC */ PAD_NC(GPP_H8, NONE), -- To view, visit https://review.coreboot.org/c/coreboot/+/79221?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3abaf57a90811becf3d01fbb1e4c9afac3e96e33 Gerrit-Change-Number: 79221 Gerrit-PatchSet: 1 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: [RFC] nb/intel/haswell: Allow specifying SPD addresses in devicetree
by Keith Hui (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Angel Pons, Martin L Roth. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79025?usp=email ) Change subject: [RFC] nb/intel/haswell: Allow specifying SPD addresses in devicetree ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Hmmm, do you have a link to these sandybridge changes? I'd like to see these review comments See the discussions around CB:76965. -- To view, visit https://review.coreboot.org/c/coreboot/+/79025?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I574aec9cb6a47c8aaf275ae06c7e1fb695534b34 Gerrit-Change-Number: 79025 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 02:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload: Fix the stack and data labels
by Julius Werner (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Yi Chou, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79144?usp=email ) Change subject: libpayload: Fix the stack and data labels ...................................................................... Patch Set 3: (2 comments) File payloads/libpayload/arch/arm/libpayload.ldscript: https://review.coreboot.org/c/coreboot/+/79144/comment/0e83aa12_4dab63a8 : PS3, Line 50: *(.rodata.*) Can we just add `_text`/`_etext`, `_rodata`/`_erodata` and `_bss`/`_ebss` everywhere here as well for consistency? https://review.coreboot.org/c/coreboot/+/79144/comment/d7e88f1c_5a5b4d42 : PS3, Line 77: _stack = .; Be careful, these are actually used, so you need to fix the references in the relevant assembly files as well (the three `arch/<arch>/head.S`). -- To view, visit https://review.coreboot.org/c/coreboot/+/79144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I589040f4db60b35813ea9f4ba9503244bd7def00 Gerrit-Change-Number: 79144 Gerrit-PatchSet: 3 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 01:59:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Move ttb_buffer to a standalone section
by Julius Werner (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Yi Chou, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79078?usp=email ) Change subject: libpayload: Move ttb_buffer to a standalone section ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I610276cbe30552263d791860c15e5ad9a201c744 Gerrit-Change-Number: 79078 Gerrit-PatchSet: 8 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 01:55:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: vboot: Add catchall recovery reason for unspecified phase 4 errors
by Julius Werner (Code Review) 22 Nov '23

22 Nov '23

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78866?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: vboot: Add catchall recovery reason for unspecified phase 4 errors ...................................................................... vboot: Add catchall recovery reason for unspecified phase 4 errors The code for "phase 4" of firmware verification currently only sets a recovery reason when there's an actual hash mismatch detected in vb2api_check_hash_get_digest(). This is the most likely way how this section of code can fail but not the only one. If any other unexpected issue occurs, we should still set a recovery reason rather than just reboot and risk an infinite boot loop. This patch adds a catchall recovery reason for any error code that falls out of this block of code. If a more specific recovery reason had already been set beforehand, we'll continue to use that -- if not, we'll set VB2_RECOVERY_FW_GET_FW_BODY. Change-Id: If00f00f00f00aa113e0325aad58d367f244aca49 Signed-off-by: Julius Werner <jwerner(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78866 Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/security/vboot/vboot_logic.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/src/security/vboot/vboot_logic.c b/src/security/vboot/vboot_logic.c index 11983b9..93a188c 100644 --- a/src/security/vboot/vboot_logic.c +++ b/src/security/vboot/vboot_logic.c @@ -374,7 +374,7 @@ } if (rv) - vboot_save_and_reboot(ctx, rv); + vboot_fail_and_reboot(ctx, VB2_RECOVERY_FW_GET_FW_BODY, rv); vboot_save_data(ctx); /* Only extend PCRs once on boot. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/78866?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If00f00f00f00aa113e0325aad58d367f244aca49 Gerrit-Change-Number: 78866 Gerrit-PatchSet: 5 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023