coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: mb/google/nissa/var/anraggar: Enable ILITEK touchscreen
by Paul Menzel (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Dolan Liu, Jianeng Ceng, Nick Vaccaro, Reka Norman, Shou-Chieh Hsu, Subrata Banik, Weimin Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79164?usp=email ) Change subject: mb/google/nissa/var/anraggar: Enable ILITEK touchscreen ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79164/comment/9bf8023d_f0479a0a : PS3, Line 9: Fix GPP_C6 configration for ILITEK touchscreen. Should the touchscreen have worked before, and just wasn’t tested? https://review.coreboot.org/c/coreboot/+/79164/comment/788ff35c_32d24b2b : PS3, Line 9: Fix GPP_C6 configration for ILITEK touchscreen. … according to schematics? File src/mainboard/google/brya/variants/anraggar/overridetree.cb: https://review.coreboot.org/c/coreboot/+/79164/comment/71d2b7ea_d27ef55b : PS3, Line 227: register "generic.stop_off_delay_ms" = "2" Please note in the commit message why you remove it. -- To view, visit https://review.coreboot.org/c/coreboot/+/79164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7dabf205dba616f57ef9717f950eba96282d8e3d Gerrit-Change-Number: 79164 Gerrit-PatchSet: 3 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 09:53:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
by Paul Menzel (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Nick Vaccaro, Robert Chen, Shawn Ku, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79173/comment/2f63afbf_a34a56b1 : PS6, Line 9: disabled “to” requires infinitive here: disable https://review.coreboot.org/c/coreboot/+/79173/comment/e3c27616_ce31ed85 : PS6, Line 10: wqnew new? https://review.coreboot.org/c/coreboot/+/79173/comment/20d056f0_f04eccf2 : PS6, Line 10: that C1 port is not present without a C1 port. -- To view, visit https://review.coreboot.org/c/coreboot/+/79173?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102 Gerrit-Change-Number: 79173 Gerrit-PatchSet: 6 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 09:52:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: acpi.c: Fix generating pointer to cb_tables located >4G
by Paul Menzel (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Cliff Huang, Eric Lai, Felix Held, Lance Zhao, Lean Sheng Tan, Maximilian Brune, Nico Huber, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76181?usp=email ) Change subject: acpi.c: Fix generating pointer to cb_tables located >4G ...................................................................... Patch Set 13: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76181/comment/f05c6409_bc15cabe : PS13, Line 8: It’d be great if you elaborated. -- To view, visit https://review.coreboot.org/c/coreboot/+/76181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1bc553b18d08cee502b765166227810f8e619631 Gerrit-Change-Number: 76181 Gerrit-PatchSet: 13 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 22 Nov 2023 09:51:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Add MIPI camera device
by Paul Menzel (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Dolan Liu, Eric Lai, Nick Vaccaro, Subrata Banik, Weimin Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79163?usp=email ) Change subject: mb/google/nissa/var/anraggar: Add MIPI camera device ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79163/comment/e4a9a04f_ecd9e044 : PS2, Line 9: Enable MIPI camera for anraggar project. What camera device is it? Please elaborate, what GPIOs need to be changed (according to what source) and where it is documented with how many lanes the device is connected. https://review.coreboot.org/c/coreboot/+/79163/comment/c7948254_8ac3a625 : PS2, Line 12: APP app https://review.coreboot.org/c/coreboot/+/79163/comment/740460f6_736b59a1 : PS2, Line 12: TEST=Camera APP working Which application is it? -- To view, visit https://review.coreboot.org/c/coreboot/+/79163?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a82557c94203f24449588a6005abc53cc29ca76 Gerrit-Change-Number: 79163 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Arec Kao <arec.kao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 09:50:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: src/mainboard/amd/birman: Add a new board variant for Phoenix SOC
by Paul Menzel (Code Review) 22 Nov '23

22 Nov '23

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79243?usp=email ) Change subject: src/mainboard/amd/birman: Add a new board variant for Phoenix SOC ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Why was it abandoned? -- To view, visit https://review.coreboot.org/c/coreboot/+/79243?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iabe38b1de33aad4c7ee165bec8eb1d617a4d8cba Gerrit-Change-Number: 79243 Gerrit-PatchSet: 4 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: ritul guru <ritul.bits(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 09:48:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: src/mainboard/amd/birman: Add a new board variant for Phoenix SOC
by Anand Vaikar (Code Review) 22 Nov '23

22 Nov '23

Anand Vaikar has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/79243?usp=email ) Change subject: src/mainboard/amd/birman: Add a new board variant for Phoenix SOC ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/79243?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iabe38b1de33aad4c7ee165bec8eb1d617a4d8cba Gerrit-Change-Number: 79243 Gerrit-PatchSet: 4 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ritul guru <ritul.bits(a)gmail.com> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Add MIPI camera device
by Jianeng Ceng (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Dolan Liu, Eric Lai, Nick Vaccaro, Subrata Banik, Weimin Wu. Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79163?usp=email ) Change subject: mb/google/nissa/var/anraggar: Add MIPI camera device ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/anraggar/gpio.c: https://review.coreboot.org/c/coreboot/+/79163/comment/dade65b1_0a836052 : PS2, Line 51: /* F18 : THC1_SPI2_INT# ==> EC_IN_RW_OD ==> EN_PP2800_AVDD*/ > I doubt it also control the camera power. But I don't have their schematic. […] After entering suspend, GPP_F18 will be pulled down. It will rise after resume -- To view, visit https://review.coreboot.org/c/coreboot/+/79163?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a82557c94203f24449588a6005abc53cc29ca76 Gerrit-Change-Number: 79163 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Arec Kao <arec.kao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 09:39:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Arec Kao <arec.kao(a)intel.corp-partner.google.com> Comment-In-Reply-To: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/anraggar: Add MIPI camera device
by Arec Kao (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Dolan Liu, Eric Lai, Jianeng Ceng, Nick Vaccaro, Subrata Banik, Weimin Wu. Arec Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79163?usp=email ) Change subject: mb/google/nissa/var/anraggar: Add MIPI camera device ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/anraggar/gpio.c: https://review.coreboot.org/c/coreboot/+/79163/comment/9663cdc3_b904fc39 : PS2, Line 51: /* F18 : THC1_SPI2_INT# ==> EC_IN_RW_OD ==> EN_PP2800_AVDD*/ > I doubt it also control the camera power. But I don't have their schematic. […] It seems the problem is PP2800_AVDD&PP2800_WCAM_X pins of MLB mismatch AVDD&AFVDD of sensor module. Please check pin28 & 29 in MLB and sensor module connector. -- To view, visit https://review.coreboot.org/c/coreboot/+/79163?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a82557c94203f24449588a6005abc53cc29ca76 Gerrit-Change-Number: 79163 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Arec Kao <arec.kao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 09:33:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Arec Kao <arec.kao(a)intel.corp-partner.google.com> Comment-In-Reply-To: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: acpigen.c: Add resource producer functions for mmio
by Arthur Heymans (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Arthur Heymans, Cliff Huang, Felix Held, Lance Zhao, Nico Huber, Tim Wawrzynczak. Hello Cliff Huang, Felix Held, Lance Zhao, Nico Huber, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79217?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: acpigen.c: Add resource producer functions for mmio ...................................................................... acpigen.c: Add resource producer functions for mmio Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Id9e4adcd976e1f56ef7f502d9df16dbefce95c3e --- M src/acpi/acpigen.c M src/include/acpi/acpigen.h 2 files changed, 39 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/79217/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/79217?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id9e4adcd976e1f56ef7f502d9df16dbefce95c3e Gerrit-Change-Number: 79217 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: acpigen.c: Add resource producer functions for mmio
by Arthur Heymans (Code Review) 22 Nov '23

22 Nov '23

Attention is currently required from: Arthur Heymans, Cliff Huang, Felix Held, Lance Zhao, Nico Huber, Tim Wawrzynczak. Hello Cliff Huang, Felix Held, Lance Zhao, Nico Huber, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79217?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: acpigen.c: Add resource producer functions for mmio ...................................................................... acpigen.c: Add resource producer functions for mmio Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Id9e4adcd976e1f56ef7f502d9df16dbefce95c3e --- M src/acpi/acpigen.c M src/include/acpi/acpigen.h 2 files changed, 39 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/79217/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/79217?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id9e4adcd976e1f56ef7f502d9df16dbefce95c3e Gerrit-Change-Number: 79217 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023