coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3036 discussions

[S] Change in coreboot[main]: soc/intel/braswell: Unify DPTF enablement
by Nico Huber (Code Review) 01 Nov '23

01 Nov '23

Attention is currently required from: Erik van den Bogaert, Frans Hendriks, Matt DeVillier, Michał Żygowski, Piotr Król. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78743?usp=email ) Change subject: soc/intel/braswell: Unify DPTF enablement ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/cyan/devicetree.cb: https://review.coreboot.org/c/coreboot/+/78743/comment/089d4e34_9068a413 : PS2, Line 98: off > strago is currently set to on / I didn't change it, just corrected the comment to make it consistent with other BSW boards. Right. my bad. > > cyan I had previously intentionally disabled, but missed that it was being overridden by the FSP UPD, so I was setting the intended behavior. If you'd prefer I set it on here and disable in a follow-on patch to make that more clear, I'm happy to do so If it's intentional, then it's fine. Just mention it in the commit message, please, maybe reference the commit for the reason. -- To view, visit https://review.coreboot.org/c/coreboot/+/78743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8fc1b63eda0dc2e047d9cb1e11a02d41ab8b2ad7 Gerrit-Change-Number: 78743 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 14:26:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/braswell: Unify DPTF enablement
by Matt DeVillier (Code Review) 01 Nov '23

01 Nov '23

Attention is currently required from: Erik van den Bogaert, Frans Hendriks, Michał Żygowski, Nico Huber, Piotr Król. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78743?usp=email ) Change subject: soc/intel/braswell: Unify DPTF enablement ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/cyan/devicetree.cb: https://review.coreboot.org/c/coreboot/+/78743/comment/89a8fc69_4e7e5711 : PS2, Line 98: off > I would assume that `DptfDisable` had the strongest meaning (i.e. the blob […] strago is currently set to on / I didn't change it, just corrected the comment to make it consistent with other BSW boards. cyan I had previously intentionally disabled, but missed that it was being overridden by the FSP UPD, so I was setting the intended behavior. If you'd prefer I set it on here and disable in a follow-on patch to make that more clear, I'm happy to do so -- To view, visit https://review.coreboot.org/c/coreboot/+/78743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8fc1b63eda0dc2e047d9cb1e11a02d41ab8b2ad7 Gerrit-Change-Number: 78743 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 14:13:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/*: Ensure PSP soft fuse bitmask set properly
by Matt DeVillier (Code Review) 01 Nov '23

01 Nov '23

Attention is currently required from: Eric Lai, Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian, Matt DeVillier. Hello Eric Lai, Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78823?usp=email to look at the new patch set (#4). Change subject: soc/amd/*: Ensure PSP soft fuse bitmask set properly ...................................................................... soc/amd/*: Ensure PSP soft fuse bitmask set properly Commit e728766f4596 ("soc/amd/mendocino: Do not load MP2 Firmware when in RO") added logic to ensure that the MP2 disable soft fuse bit was set for the RO section, but failed to check if the bit was already set otherwise (as it is for non-ChromeOS builds). This caused the bit to appear twice in the PSP_RO_SOFTFUSE_BITS string, and when the string was converted to a series of numeric values and added together, bit (n+1) ended up being set instead of bit n. To mitigate this, use the makefile sort() function to ensure the PSP_[RO_]SOFTFUSE_BITS string does not contain and duplicates before the bitmask is calculated. Apply this to all AMD SoC makefiles where the softfuse bits are added. TEST=build/boot google/skyrim (frostflow). Use a verbose build (V=1) to verify that the correct soft fuse value is passed to amdfwtool for RO and RW_A/B for both ChromeOS and non-ChromeOS builds. Change-Id: I2e207e20132d44016fbcb986bdfd8e935d8fead5 Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M src/soc/amd/cezanne/Makefile.inc M src/soc/amd/genoa/Makefile.inc M src/soc/amd/glinda/Makefile.inc M src/soc/amd/mendocino/Makefile.inc M src/soc/amd/phoenix/Makefile.inc M src/soc/amd/picasso/Makefile.inc 6 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/78823/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/78823?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e207e20132d44016fbcb986bdfd8e935d8fead5 Gerrit-Change-Number: 78823 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: SNB+MRC boards: Migrate MRC settings to devicetree
by Nico Huber (Code Review) 01 Nov '23

01 Nov '23

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76962?usp=email ) Change subject: SNB+MRC boards: Migrate MRC settings to devicetree ...................................................................... Patch Set 8: (1 comment) Patchset: PS5: > @Nico Does the Roda Lizard RW11 use the PEG10 slot? There's an optional MXM connector. However not on our models and hence untested. -- To view, visit https://review.coreboot.org/c/coreboot/+/76962?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie349a8f400eecca3cdbc196ea0790aebe0549e39 Gerrit-Change-Number: 76962 Gerrit-PatchSet: 8 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Fabian Groffen <grobian(a)gentoo.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2023 13:52:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: payloads/LinuxBoot: Hide the path of the kernel and initrd when building
by Nico Huber (Code Review) 01 Nov '23

01 Nov '23

Attention is currently required from: Arthur Heymans, Christian Walter, Felix Singer, Martin L Roth, Stefan Reinauer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78651?usp=email ) Change subject: payloads/LinuxBoot: Hide the path of the kernel and initrd when building ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78651?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7958e419e314a7018f84bf9c5c332c90f4a319df Gerrit-Change-Number: 78651 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 01 Nov 2023 13:46:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: arch/arm64: Add EL1/EL2/EL3 support for arm64
by Nico Huber (Code Review) 01 Nov '23

01 Nov '23

Attention is currently required from: Arthur Heymans, Christian Walter, David Milosevic, Julius Werner, Lean Sheng Tan, Maximilian Brune. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74798?usp=email ) Change subject: arch/arm64: Add EL1/EL2/EL3 support for arm64 ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74798/comment/4eac0578_89a37ba7 : PS5, Line 11: one boots into TF-A first and drops into EL2 for coreboot afterwards. > Okay, so I have resolved all comments. […] Just to make sure we're on the same page: We actually think it's wrong. We do it anyway because $vendor. Chances to rectify things after the platform is upstream are close to 0 because discussions with $vendor about it haven't even started yet. Is that correct? And to have it said: arguments that discussions will be too slow / too late usually don't help when somebody forgot to start them a year ago. If Julius agrees to the patch, I won't object. However, I would wait with merging until there was an actual decision to accept Ampere support upstream (we don't know yet what other obstacles exist and what other people think of a shimboot). -- To view, visit https://review.coreboot.org/c/coreboot/+/74798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae1c57f0846c8d0585384f7e54102a837e701e7e Gerrit-Change-Number: 74798 Gerrit-PatchSet: 6 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 13:36:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: Documentation: add Nitrokey to distributions
by Felix Singer (Code Review) 01 Nov '23

01 Nov '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78299?usp=email ) Change subject: Documentation: add Nitrokey to distributions ...................................................................... Documentation: add Nitrokey to distributions Nitrokey offers various products, which have coreboot pre-installed. Change-Id: I3ef25e0e1cb97eda5fd457bdb650f3ee3f00210a Signed-off-by: Markus Meissner <coder(a)safemailbox.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78299 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Documentation/distributions.md 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/Documentation/distributions.md b/Documentation/distributions.md index 139e5b6..219c659 100644 --- a/Documentation/distributions.md +++ b/Documentation/distributions.md @@ -8,6 +8,16 @@ ## Hardware shipping with coreboot +### Nitrokey + +[Nitrokey](https://nitrokey.com) is a german IT security hardware vendor which +offers a range of laptops, PCs, HSMs, and networking devices with coreboot and +[Dasharo](https://dasharo.com/). The devices come with neutralized Intel +Management Engine (ME) and with pre-installed [Heads](http://osresearch.net) or +EDK2 payload providing measured boot and verified boot protection. For +additional security the systems can be physically sealed and pictures of those +sealings are sent via encrypted email. + ### NovaCustom laptops [NovaCustom](https://configurelaptop.eu/) sells configurable laptops with -- To view, visit https://review.coreboot.org/c/coreboot/+/78299?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ef25e0e1cb97eda5fd457bdb650f3ee3f00210a Gerrit-Change-Number: 78299 Gerrit-PatchSet: 7 Gerrit-Owner: Markus Meissner Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: Documentation: add Nitrokey to distributions
by Felix Singer (Code Review) 01 Nov '23

01 Nov '23

Attention is currently required from: Markus Meissner, Michał Żygowski, Patrick Georgi, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78299?usp=email ) Change subject: Documentation: add Nitrokey to distributions ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78299?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ef25e0e1cb97eda5fd457bdb650f3ee3f00210a Gerrit-Change-Number: 78299 Gerrit-PatchSet: 6 Gerrit-Owner: Markus Meissner Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Markus Meissner Gerrit-Comment-Date: Wed, 01 Nov 2023 13:30:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/braswell: Unify DPTF enablement
by Nico Huber (Code Review) 01 Nov '23

01 Nov '23

Attention is currently required from: Erik van den Bogaert, Frans Hendriks, Matt DeVillier, Michał Żygowski, Piotr Król. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78743?usp=email ) Change subject: soc/intel/braswell: Unify DPTF enablement ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Patchset: PS2: Thanks for cleaning this up! File src/mainboard/google/cyan/devicetree.cb: https://review.coreboot.org/c/coreboot/+/78743/comment/f4799e13_51d05a0f : PS2, Line 98: off I would assume that `DptfDisable` had the strongest meaning (i.e. the blob actually disables the device, while `off` only made coreboot ignore it). As it wasn't set, shouldn't we turn the device `on` here? Same for Strago. -- To view, visit https://review.coreboot.org/c/coreboot/+/78743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8fc1b63eda0dc2e047d9cb1e11a02d41ab8b2ad7 Gerrit-Change-Number: 78743 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 13:16:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/braswell/Kconfig: Set HPET_MIN_TICKS
by Nico Huber (Code Review) 01 Nov '23

01 Nov '23

Attention is currently required from: Matt DeVillier, Michał Żygowski, Subrata Banik. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78744?usp=email ) Change subject: soc/intel/braswell/Kconfig: Set HPET_MIN_TICKS ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78744?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2633e7cd0c3d74c1554ae8c1f2bb6387fd6dde2b Gerrit-Change-Number: 78744 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 13:08:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023