coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: mb/google/brya: Enable ISH FW store config for Brya
by Subrata Banik (Code Review) 29 Nov '23

29 Nov '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79338?usp=email ) Change subject: mb/google/brya: Enable ISH FW store config for Brya ...................................................................... mb/google/brya: Enable ISH FW store config for Brya This patch enables the SOC_INTEL_STORE_ISH_FW_VERSION config for Brya variants to store the ISH FW version to accessible memory. BUG=b:280722061 TEST=Able to build and boot google/marasov. Change-Id: I99dab43ae4e13869b7f8797a9c4014f60e38a595 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79338/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 757cfc4..c6a4987 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -39,6 +39,7 @@ select SOC_INTEL_COMMON_BASECODE_DEBUG_FEATURE select SOC_INTEL_CRASHLOG select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V1 if SOC_INTEL_ALDERLAKE_PCH_P + select SOC_INTEL_STORE_ISH_FW_VERSION if DRIVERS_INTEL_ISH config BOARD_GOOGLE_BASEBOARD_BRYA def_bool n @@ -92,7 +93,6 @@ select SOC_INTEL_ALDERLAKE_PCH_N select SOC_INTEL_CSE_LITE_COMPRESS_ME_RW select SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE - select SOC_INTEL_STORE_ISH_FW_VERSION select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50 select SOC_INTEL_COMMON_MMC_OVERRIDE -- To view, visit https://review.coreboot.org/c/coreboot/+/79338?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I99dab43ae4e13869b7f8797a9c4014f60e38a595 Gerrit-Change-Number: 79338 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/anraggar: Enable ILITEK touchscreen
by Eric Lai (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Dolan Liu, Nick Vaccaro, Paul Menzel, Reka Norman, Shou-Chieh Hsu, Subrata Banik, Weimin Wu. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79164?usp=email ) Change subject: mb/google/nissa/var/anraggar: Enable ILITEK touchscreen ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: No report enable pin for this IC. -- To view, visit https://review.coreboot.org/c/coreboot/+/79164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7dabf205dba616f57ef9717f950eba96282d8e3d Gerrit-Change-Number: 79164 Gerrit-PatchSet: 5 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 07:43:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: CHROMIUM: mb/google/brya: Enable CSE FPT Info config for Brya
by Ivan Chen (Code Review) 29 Nov '23

29 Nov '23

Ivan Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/79337?usp=email ) Change subject: CHROMIUM: mb/google/brya: Enable CSE FPT Info config for Brya ...................................................................... Abandoned wrong branch -- To view, visit https://review.coreboot.org/c/coreboot/+/79337?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibccbee4b5326aa5d3f0586f4a0b2b0507a00968c Gerrit-Change-Number: 79337 Gerrit-PatchSet: 2 Gerrit-Owner: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: CHROMIUM: mb/google/brya: Enable CSE FPT Info config for Brya
by Subrata Banik (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Eric Lai, Ivan Chen, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79337?usp=email ) Change subject: CHROMIUM: mb/google/brya: Enable CSE FPT Info config for Brya ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: don't push anything on master branch. -- To view, visit https://review.coreboot.org/c/coreboot/+/79337?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibccbee4b5326aa5d3f0586f4a0b2b0507a00968c Gerrit-Change-Number: 79337 Gerrit-PatchSet: 2 Gerrit-Owner: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 07:28:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: CHROMIUM: mb/google/brya: Enable CSE FPT Info config for Brya
by Ivan Chen (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Eric Lai, Ivan Chen, Nick Vaccaro, Subrata Banik. Hello Eric Lai, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79337?usp=email to look at the new patch set (#2). Change subject: CHROMIUM: mb/google/brya: Enable CSE FPT Info config for Brya ...................................................................... CHROMIUM: mb/google/brya: Enable CSE FPT Info config for Brya Google Brya board selects `SOC_INTEL_STORE_ISH_FW_VERSION` to store CSE FPT information. BUG=b:310573263 TEST=Able to build and boot google/marasov. Change-Id: Ibccbee4b5326aa5d3f0586f4a0b2b0507a00968c Signed-off-by: Ivan Chen <yulunchen(a)google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/79337/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79337?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibccbee4b5326aa5d3f0586f4a0b2b0507a00968c Gerrit-Change-Number: 79337 Gerrit-PatchSet: 2 Gerrit-Owner: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: CHROMIUM: mb/google/brya: Enable CSE FPT Info config for Brya
by Ivan Chen (Code Review) 29 Nov '23

29 Nov '23

Ivan Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79337?usp=email ) Change subject: CHROMIUM: mb/google/brya: Enable CSE FPT Info config for Brya ...................................................................... CHROMIUM: mb/google/brya: Enable CSE FPT Info config for Brya Google Brya baseboard selects `SOC_INTEL_STORE_ISH_FW_VERSION` to store CSE FPT information. BUG=b:310573263 TEST=Able to build and boot google/marasov. Change-Id: Ibccbee4b5326aa5d3f0586f4a0b2b0507a00968c Signed-off-by: Ivan Chen <yulunchen(a)google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/79337/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 757cfc4..fc41961 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -49,6 +49,7 @@ select HAVE_SLP_S0_GATE select MEMORY_SOLDERDOWN if !BOARD_GOOGLE_BANSHEE select SOC_INTEL_ALDERLAKE_PCH_P + select SOC_INTEL_STORE_ISH_FW_VERSION select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_CR50 -- To view, visit https://review.coreboot.org/c/coreboot/+/79337?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibccbee4b5326aa5d3f0586f4a0b2b0507a00968c Gerrit-Change-Number: 79337 Gerrit-PatchSet: 1 Gerrit-Owner: Ivan Chen <yulunchen(a)google.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: mb/google/brox: Update storage settings for SSD and UFS
by Shelley Chen (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Ivy Jian, Karthik Ramasubramanian. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79295?usp=email ) Change subject: mb/google/brox: Update storage settings for SSD and UFS ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/mainboard/google/brox/variants/baseboard/brox/gpio.c: https://review.coreboot.org/c/coreboot/+/79295/comment/755cfe2d_adc8b02a : PS2, Line 382: /* GPP_F9 : [NF1: BOOTMPC NF6: USB_C_GPP_F9] ==> SSD_PERST_L */ : PAD_CFG_GPO(GPP_F9, 0, DEEP), : /* GPP_D11 : [] ==> EN_PP3300_SSD */ : PAD_CFG_GPO(GPP_D11, 1, DEEP), : /* GPP_S0 : SNDW0_CLL/I2S1_SCLK ==> MEM_CH_SEL */ : PAD_CFG_GPI(GPP_S0, NONE, DEEP), : /* F21 : EXT_PWR_GATE2# ==> NC */ : PAD_NC(GPP_F21, NONE), : /* H10 : UART0_RXD ==> UART_PCH_RX_DBG_TX */ : PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), : /* H11 : UART0_TXD ==> UART_PCH_TX_DBG_RX */ : PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), can you put these in order based on GPP_#? -- To view, visit https://review.coreboot.org/c/coreboot/+/79295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88922bcfa13652006aa10078c3c444624fd4575e Gerrit-Change-Number: 79295 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yen-hsing Lee <yen-hsing.lee(a)quanta.corp-partner.google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 07:21:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/corsola: Use fw_config to differentiate audio amps
by Yu-Ping Wu (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Hung-Te Lin, Xuxin Xiong, Yang Wu. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79309?usp=email ) Change subject: mb/google/corsola: Use fw_config to differentiate audio amps ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/corsola/devicetree.cb: https://review.coreboot.org/c/coreboot/+/79309/comment/a3ad9355_963cc5e7 : PS1, Line 4: AUDIO_AMP Since the option is under the AUDIO_AMP field, having the prefix `AMP` should be enough. -- To view, visit https://review.coreboot.org/c/coreboot/+/79309?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5f887f5e0d16dc14039fb12b636257d01339b2de Gerrit-Change-Number: 79309 Gerrit-PatchSet: 1 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 07:17:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8188: Support loading OP-TEE via an SMC
by Yu-Ping Wu (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Hung-Te Lin, Kiwi Liu, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78801?usp=email ) Change subject: soc/mediatek/mt8188: Support loading OP-TEE via an SMC ...................................................................... Patch Set 16: Code-Review+2 (1 comment) File src/soc/mediatek/mt8188/Makefile.inc: https://review.coreboot.org/c/coreboot/+/78801/comment/e4b86adf_48e2b354 : PS15, Line 62: BL31_MAKEARGS > Please update the codebase and rebase the patch after CB:79333 is merged. Kiwi, feel free to just rebase this onto CB:79333. -- To view, visit https://review.coreboot.org/c/coreboot/+/78801?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic38c8beb59c090ae56c5be6821dd8625435609e9 Gerrit-Change-Number: 78801 Gerrit-PatchSet: 16 Gerrit-Owner: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 07:10:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update vboot submodule to upstream main
by Uwe Poeche (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Julius Werner. Uwe Poeche has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79313?usp=email ) Change subject: Update vboot submodule to upstream main ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: This helps for problems which I reported on CB:78865 (building futility in red hat 8.8 env with glibc 2.28). Thanks for help! -- To view, visit https://review.coreboot.org/c/coreboot/+/79313?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I58b231d53f433a396b1ea8cd4e0ddc49a310e385 Gerrit-Change-Number: 79313 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 29 Nov 2023 07:08:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023