Attention is currently required from: Daniel Peng, Nick Vaccaro, Subrata Banik.
Hello Eric Lai, Nick Vaccaro, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79335?usp=email
to look at the new patch set (#3).
Change subject: mb/google/brya/var/marasov: Update MSR Package Power Limit-1 values
......................................................................
mb/google/brya/var/marasov: Update MSR Package Power Limit-1 values
As customer demand, it is necessary to set MSR Package Power Limit-1 to 17W for the DTT setting to optimize performance.
The PL1 value (17W) suggested by the thermal team which is different from the reference code(PL1=15W).
BUG=b:312321601
BRANCH=firmware-brya-14505.B
TEST=emerge-brya coreboot chromeos-bootimage
Built and booted into OS, and confirm MSR PL1=17W correctly.
Change-Id: If7874d26038118c5605cf0721c30e681b45123fe
Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/marasov/overridetree.cb
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/79335/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/79335?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7874d26038118c5605cf0721c30e681b45123fe
Gerrit-Change-Number: 79335
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Daniel Peng, Nick Vaccaro, Subrata Banik.
Hello Eric Lai, Nick Vaccaro, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79335?usp=email
to look at the new patch set (#2).
Change subject: mb/google/brya/var/marasov: Update MSR Package Power Limit-1 values
......................................................................
mb/google/brya/var/marasov: Update MSR Package Power Limit-1 values
As customer demand, it is necessary to add a 60 sec running
score "PL1=17W" table to the DTT setting to optimize performance.
The PL1 value (17W) suggested by the thermal team which is different from the reference code(PL1=15W).
BUG=b:312321601
BRANCH=firmware-brya-14505.B
TEST=emerge-brya coreboot chromeos-bootimage
Built and booted into OS, and confirm MSR PL1=17W correctly.
Change-Id: If7874d26038118c5605cf0721c30e681b45123fe
Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/marasov/overridetree.cb
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/79335/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79335?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7874d26038118c5605cf0721c30e681b45123fe
Gerrit-Change-Number: 79335
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Daniel Peng, Nick Vaccaro, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79335?usp=email )
Change subject: mb/google/brya/var/marasov: Update MSR Package Power Limit-1 values
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79335/comment/9d447f27_e72e87dd :
PS1, Line 9: it is necessary to add a 60 sec running
: score
I don't know what is this. Maybe describe what the different of performance by add the change?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79335?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7874d26038118c5605cf0721c30e681b45123fe
Gerrit-Change-Number: 79335
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:54:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79335?usp=email )
Change subject: mb/google/brya/var/marasov: Update MSR Package Power Limit-1 values
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79335?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7874d26038118c5605cf0721c30e681b45123fe
Gerrit-Change-Number: 79335
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:54:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79334?usp=email )
Change subject: mb/siemens/mc_ehl: Enable write access for SPD EEPROM on mc_ehl1
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79334?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b0fcdbeb0dbf971cfdceb70d6f4845765a3bdb6
Gerrit-Change-Number: 79334
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:53:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Paul Menzel, Subrata Banik.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79165?usp=email )
Change subject: mb/google/nissa/var/anraggar: Fix Type-C & DP functions
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79165/comment/5c771e78_7ad6c90d :
PS5, Line 10: relate
> relative? or related? not sure.
sorry, it's related. it's mean USB2P_1, USB2N_1 and USB2P_2, USB2N_2 are not exchanged, but TCP0 and TCP1 are exchanged.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79165?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9dacf06b1e672575a684856acdb10b6c88360b18
Gerrit-Change-Number: 79165
Gerrit-PatchSet: 6
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:39:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Paul Menzel, Subrata Banik, Weimin Wu.
Hello Dolan Liu, Eric Lai, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79165?usp=email
to look at the new patch set (#6).
Change subject: mb/google/nissa/var/anraggar: Fix Type-C & DP functions
......................................................................
mb/google/nissa/var/anraggar: Fix Type-C & DP functions
Due to TCPC0 & TCPC1 exchanged compare to Neried design,
but related USB2 Ports not exchanged.
BUG=b:304920262
TEST=Tpye-C & DP functions workable
Change-Id: I9dacf06b1e672575a684856acdb10b6c88360b18
Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/79165/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/79165?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9dacf06b1e672575a684856acdb10b6c88360b18
Gerrit-Change-Number: 79165
Gerrit-PatchSet: 6
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79314?usp=email )
Change subject: util/docker/archlinux: Add more packages allowing CI builds
......................................................................
Patch Set 4:
(3 comments)
File util/docker/archlinux/Dockerfile:
https://review.coreboot.org/c/coreboot/+/79314/comment/aa65c656_ae917506 :
PS3, Line 15: bash-completion \
> Add bc
Done
https://review.coreboot.org/c/coreboot/+/79314/comment/6894dd13_85b3d884 :
PS3, Line 19: cscope \
> Add dtc
Done
https://review.coreboot.org/c/coreboot/+/79314/comment/ac30df93_1dd3caaf :
PS3, Line 25: less \
> Add meson. Required for opensil.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I757e6dbac557bcb640777b819529a978bf54ed93
Gerrit-Change-Number: 79314
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:31:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment