Attention is currently required from: Martin L Roth.
Hello Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79314?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/docker/archlinux: Add more packages allowing CI builds
......................................................................
util/docker/archlinux: Add more packages allowing CI builds
Change-Id: I757e6dbac557bcb640777b819529a978bf54ed93
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/docker/archlinux/Dockerfile
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/79314/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/79314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I757e6dbac557bcb640777b819529a978bf54ed93
Gerrit-Change-Number: 79314
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nick Vaccaro, Subrata Banik, Weimin Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79166?usp=email )
Change subject: mb/google/nissa/var/anraggar: Fix the GPP_D6 for LTE power.
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79166?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2996fd35c2897269997bc0290e0ce93bbbaa1bf8
Gerrit-Change-Number: 79166
Gerrit-PatchSet: 7
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:29:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79314?usp=email )
Change subject: util/docker/archlinux: Install CMake and NSS
......................................................................
Patch Set 3:
(1 comment)
File util/docker/archlinux/Dockerfile:
https://review.coreboot.org/c/coreboot/+/79314/comment/a7301401_b2370d23 :
PS3, Line 15: bash-completion \
Add bc
--
To view, visit https://review.coreboot.org/c/coreboot/+/79314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I757e6dbac557bcb640777b819529a978bf54ed93
Gerrit-Change-Number: 79314
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:28:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Paul Menzel, Subrata Banik, Weimin Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79165?usp=email )
Change subject: mb/google/nissa/var/anraggar: Fix Type-C & DP functions
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79165/comment/8ba9ecf1_f1e0b653 :
PS5, Line 10: relate
relative? or related? not sure.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79165?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9dacf06b1e672575a684856acdb10b6c88360b18
Gerrit-Change-Number: 79165
Gerrit-PatchSet: 5
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:28:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dolan Liu, Nick Vaccaro, Paul Menzel, Reka Norman, Shou-Chieh Hsu, Subrata Banik, Weimin Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79164?usp=email )
Change subject: mb/google/nissa/var/anraggar: Enable ILITEK touchscreen
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Patchset:
PS5:
Need someone check the IC spec.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79164?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7dabf205dba616f57ef9717f950eba96282d8e3d
Gerrit-Change-Number: 79164
Gerrit-PatchSet: 5
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:25:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dolan Liu, Jianeng Ceng, Nick Vaccaro, Paul Menzel, Subrata Banik, Weimin Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79163?usp=email )
Change subject: mb/google/nissa/var/anraggar: Add OV13B10 MIPI camera device
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79163?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a82557c94203f24449588a6005abc53cc29ca76
Gerrit-Change-Number: 79163
Gerrit-PatchSet: 3
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Arec Kao <arec.kao(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:24:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79314?usp=email )
Change subject: util/docker/archlinux: Install CMake and NSS
......................................................................
Patch Set 3:
(1 comment)
File util/docker/archlinux/Dockerfile:
https://review.coreboot.org/c/coreboot/+/79314/comment/cce20d7e_0f8c14c4 :
PS3, Line 19: cscope \
Add dtc
--
To view, visit https://review.coreboot.org/c/coreboot/+/79314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I757e6dbac557bcb640777b819529a978bf54ed93
Gerrit-Change-Number: 79314
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:19:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79314?usp=email )
Change subject: util/docker/archlinux: Install CMake and NSS
......................................................................
Patch Set 3:
(1 comment)
File util/docker/archlinux/Dockerfile:
https://review.coreboot.org/c/coreboot/+/79314/comment/50cada3e_79675ffa :
PS3, Line 25: less \
Add meson. Required for opensil.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I757e6dbac557bcb640777b819529a978bf54ed93
Gerrit-Change-Number: 79314
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79314?usp=email )
Change subject: util/docker/archlinux: Install CMake and NSS
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/79314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I757e6dbac557bcb640777b819529a978bf54ed93
Gerrit-Change-Number: 79314
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:12:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Subrata Banik, Weimin Wu.
Dolan Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79165?usp=email )
Change subject: mb/google/nissa/var/anraggar: Fix Type-C & DP functions
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Patchset:
PS5:
LGTM
--
To view, visit https://review.coreboot.org/c/coreboot/+/79165?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9dacf06b1e672575a684856acdb10b6c88360b18
Gerrit-Change-Number: 79165
Gerrit-PatchSet: 5
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:07:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment