coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: include/device/device: drop HAVE_ACPI_TABLES guards
by Felix Held (Code Review) 17 Nov '23

17 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78990?usp=email ) Change subject: include/device/device: drop HAVE_ACPI_TABLES guards ...................................................................... include/device/device: drop HAVE_ACPI_TABLES guards There's no need to remove the corresponding fields from the device_operations struct when HAVE_ACPI_TABLES isn't selected. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Iac20b6cdc44a5280566ee7003a5ef6fbe913b099 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78990 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/include/device/device.h 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/include/device/device.h b/src/include/device/device.h index 07b71ec..113969c 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -53,7 +53,6 @@ unsigned long *current); void (*get_smbios_strings)(struct device *dev, struct smbios_type11 *t); -#if CONFIG(HAVE_ACPI_TABLES) unsigned long (*write_acpi_tables)(const struct device *dev, unsigned long start, struct acpi_rsdp *rsdp); void (*acpi_fill_ssdt)(const struct device *dev); @@ -61,7 +60,7 @@ const char *(*acpi_name)(const struct device *dev); /* Returns the optional _HID (Hardware ID) */ const char *(*acpi_hid)(const struct device *dev); -#endif + const struct pci_operations *ops_pci; const struct i2c_bus_operations *ops_i2c_bus; const struct spi_bus_operations *ops_spi_bus; -- To view, visit https://review.coreboot.org/c/coreboot/+/78990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iac20b6cdc44a5280566ee7003a5ef6fbe913b099 Gerrit-Change-Number: 78990 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: include/device/device: drop GENERATE_SMBIOS_TABLES guards
by Felix Held (Code Review) 17 Nov '23

17 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79092?usp=email ) Change subject: include/device/device: drop GENERATE_SMBIOS_TABLES guards ...................................................................... include/device/device: drop GENERATE_SMBIOS_TABLES guards There's no need to remove the corresponding fields from the device_operations struct when GENERATE_SMBIOS_TABLES isn't selected. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ifa24d1fd211c263b788046e63de3dd5c54cba801 Reviewed-on: https://review.coreboot.org/c/coreboot/+/79092 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/include/device/device.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/include/device/device.h b/src/include/device/device.h index 68e2622..07b71ec 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -48,11 +48,11 @@ void (*enable)(struct device *dev); void (*vga_disable)(struct device *dev); void (*reset_bus)(struct bus *bus); -#if CONFIG(GENERATE_SMBIOS_TABLES) + int (*get_smbios_data)(struct device *dev, int *handle, unsigned long *current); void (*get_smbios_strings)(struct device *dev, struct smbios_type11 *t); -#endif + #if CONFIG(HAVE_ACPI_TABLES) unsigned long (*write_acpi_tables)(const struct device *dev, unsigned long start, struct acpi_rsdp *rsdp); -- To view, visit https://review.coreboot.org/c/coreboot/+/79092?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa24d1fd211c263b788046e63de3dd5c54cba801 Gerrit-Change-Number: 79092 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/corsola: Configure I2C and I2S interface for ALC5650
by Matt DeVillier (Code Review) 17 Nov '23

17 Nov '23

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79064?usp=email ) Change subject: mb/google/corsola: Configure I2C and I2S interface for ALC5650 ...................................................................... mb/google/corsola: Configure I2C and I2S interface for ALC5650 Configure I2S1 and I2C5 for ALC5650 to support beep sound in depthcharge. BRANCH=corsola BUG=b:305828247 TEST=Verify devbeep in depthcharge console Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79064 Reviewed-by: Yidi Lin <yidilin(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/mainboard/google/corsola/mainboard.c 1 file changed, 20 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Yidi Lin: Looks good to me, approved Ruihai Zhou: Looks good to me, but someone else must approve Yu-Ping Wu: Looks good to me, approved diff --git a/src/mainboard/google/corsola/mainboard.c b/src/mainboard/google/corsola/mainboard.c index b2c65eb..69e72d7 100644 --- a/src/mainboard/google/corsola/mainboard.c +++ b/src/mainboard/google/corsola/mainboard.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <gpio.h> #include <soc/bl31.h> +#include <soc/i2c.h> #include <soc/msdc.h> #include <soc/spm.h> #include <soc/usb.h> @@ -12,7 +13,7 @@ #include "display.h" #include "gpio.h" -static void configure_audio(void) +static void configure_alc1019(void) { mtcmos_audio_power_on(); @@ -23,6 +24,20 @@ gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO); } +static void configure_alc5645(void) +{ + mtcmos_audio_power_on(); + + /* Set up I2S */ + gpio_set_mode(GPIO(I2S1_MCK), PAD_I2S1_MCK_FUNC_I2S1_MCK); + gpio_set_mode(GPIO(I2S1_BCK), PAD_I2S1_BCK_FUNC_I2S1_BCK); + gpio_set_mode(GPIO(I2S1_LRCK), PAD_I2S1_LRCK_FUNC_I2S1_LRCK); + gpio_set_mode(GPIO(I2S1_DO), PAD_I2S1_DO_FUNC_I2S1_DO); + + /* Init I2C bus timing register for audio codecs */ + mtk_i2c_bus_init(I2C5, I2C_SPEED_STANDARD); +} + static void mainboard_init(struct device *dev) { mtk_msdc_configure_emmc(true); @@ -36,7 +51,10 @@ setup_usb_host(); - configure_audio(); + if (CONFIG(BOARD_GOOGLE_CHINCHOU)) + configure_alc5645(); + else + configure_alc1019(); if (spm_init()) printk(BIOS_ERR, "spm init failed, system suspend may not work\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/79064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854 Gerrit-Change-Number: 79064 Gerrit-PatchSet: 11 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jiaxin Yu <jiaxin.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: MAINTAINERS: Add Dinesh Gehlot as MTL SOC and GOOGLE REX MB maintainer
by Matt DeVillier (Code Review) 17 Nov '23

17 Nov '23

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79090?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: MAINTAINERS: Add Dinesh Gehlot as MTL SOC and GOOGLE REX MB maintainer ...................................................................... MAINTAINERS: Add Dinesh Gehlot as MTL SOC and GOOGLE REX MB maintainer Change-Id: I92d5497644338927b81fbabea2bce45f1e59f0b4 Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79090 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M MAINTAINERS 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified diff --git a/MAINTAINERS b/MAINTAINERS index 4c63cbf..1da196d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -351,6 +351,7 @@ M: Kapil Porwal <kapilporwal(a)google.com> M: Jakub Czapiga <jacz(a)semihalf.com> M: Eran Mitrani <mitrani(a)google.com> +M: Dinesh Gehlot <digehlot(a)google.com> S: Maintained F: src/mainboard/google/rex/ @@ -887,6 +888,7 @@ M: Kapil Porwal <kapilporwal(a)google.com> M: Jakub Czapiga <jacz(a)semihalf.com> M: Eran Mitrani <mitrani(a)google.com> +M: Dinesh Gehlot <digehlot(a)google.com> S: Maintained F: src/soc/intel/meteorlake/ -- To view, visit https://review.coreboot.org/c/coreboot/+/79090?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92d5497644338927b81fbabea2bce45f1e59f0b4 Gerrit-Change-Number: 79090 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[L] Change in coreboot[main]: Docs/releases: Update 4.22 release notes
by Paul Menzel (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79077?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: Docs/releases: Update 4.22 release notes ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Patchset: PS1: Thank you for writing this up. File Documentation/releases/coreboot-4.22-relnotes.md: https://review.coreboot.org/c/coreboot/+/79077/comment/fdcb53c9_355ebaca : PS1, Line 154: Moved *Move* for consistency? https://review.coreboot.org/c/coreboot/+/79077/comment/1531a893_d9300c6d : PS1, Line 158: chromebooks Chromebooks -- To view, visit https://review.coreboot.org/c/coreboot/+/79077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id723f8e1fc92ef1a36e877f48e594eef59b0ba8e Gerrit-Change-Number: 79077 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 14:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: Docs/releases: Update 4.22 release notes
by Patrick Georgi (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79077?usp=email ) Change subject: Docs/releases: Update 4.22 release notes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id723f8e1fc92ef1a36e877f48e594eef59b0ba8e Gerrit-Change-Number: 79077 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 14:07:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: DNS: Example of clang format
by Martin L Roth (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Angel Pons, Boris Mittelberg, Caveh Jalali, Cliff Huang, Felix Held, Hung-Te Lin, Jérémy Compostella, Lance Zhao, Philipp Hug, Sean Rhodes, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu, ron minnich. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78833?usp=email ) Change subject: DNS: Example of clang format ...................................................................... Patch Set 4: (4 comments) File src/drivers/intel/gma/i915_reg.h: PS4: > the removed 2 space indentations make this more difficult to read Right, unfortunately that's just a coreboot convention. We might be able to add a change to indent macros that are the format (X << Y) or BIT(Y), but things like `#define GEN6_MBC_SNPCR_SHIFT 21` are going to be more problematic. File src/drivers/pc80/vga/vga_font_8x16.c: PS4: > this makes this file much worse than before. […] This is probably related to the trailing comma issue as well. If we removed the final comma of each section, I think it would be better, but I suspect that's some sort of bug in clang-format. File src/include/device/pci_ids.h: PS4: > i'd say that this looked better before the change We can fix that by enabling alignment over blank lines, but that might break things in other places. File src/northbridge/intel/gm45/raminit.c: https://review.coreboot.org/c/coreboot/+/78833/comment/5d4729dc_e53a582e : PS4, Line 942: /* VCO 3200 */ > would moving the comments after the array elements make things to work better? Yes, i tested that and it did. -- To view, visit https://review.coreboot.org/c/coreboot/+/78833?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I596ec6d69184594870d9db1488618225a1ac421f Gerrit-Change-Number: 78833 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 13:52:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vendorcode/amd/opensil/genoa: Implement console callback
by Martin L Roth (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76512?usp=email ) Change subject: vendorcode/amd/opensil/genoa: Implement console callback ...................................................................... Patch Set 8: (1 comment) Patchset: PS4: > I went ahead and renamed them, but I'm going to pause here for any feedback. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76512?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I208eea37ffde64a2311cb9f51e2bcd1ac3dbad4d Gerrit-Change-Number: 76512 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 17 Nov 2023 13:44:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/zork/morphius: Drop touchscreen detection
by Felix Held (Code Review) 17 Nov '23

17 Nov '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78404?usp=email ) Change subject: mb/google/zork/morphius: Drop touchscreen detection ...................................................................... mb/google/zork/morphius: Drop touchscreen detection Morphius boards using pre-v3.6 schematics don't have a dedicated GPIO for touchscreen power/enable, and so fail with runtime detection enabled. Since it only has one touchscreen option, and no SKUs lack a touchscreen, we can safely assume it is present in all cases. TEST=build/boot morphius w/4k screen, verify touchscreen enabled in cbmem and functional in Linux and Windows. Change-Id: I13e07e14b5a18fa1dd3b18950cf46e9d7821eedc Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78404 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb index 9c07a40..2e4595e 100644 --- a/src/mainboard/google/zork/variants/morphius/overridetree.cb +++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb @@ -120,7 +120,6 @@ register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen"" register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_12)" - register "generic.detect" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_90)" register "generic.enable_delay_ms" = "10" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" -- To view, visit https://review.coreboot.org/c/coreboot/+/78404?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I13e07e14b5a18fa1dd3b18950cf46e9d7821eedc Gerrit-Change-Number: 78404 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[XL] Change in coreboot[main]: DNS: Example of clang format
by Felix Held (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Angel Pons, Boris Mittelberg, Caveh Jalali, Cliff Huang, Hung-Te Lin, Jérémy Compostella, Lance Zhao, Martin L Roth, Philipp Hug, Sean Rhodes, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu, ron minnich. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78833?usp=email ) Change subject: DNS: Example of clang format ...................................................................... Patch Set 4: (5 comments) Patchset: PS4: this is definitely an improvement compared to how the result of the last attempt of auto-formatting the source code looked. not perfect, but this makes me a bit more confident that eventually deploying this might be a good idea File src/drivers/intel/gma/i915_reg.h: PS4: the removed 2 space indentations make this more difficult to read File src/drivers/pc80/vga/vga_font_8x16.c: PS4: this makes this file much worse than before. not sure why things work in the other files while making quite a mess here File src/include/device/pci_ids.h: PS4: i'd say that this looked better before the change File src/northbridge/intel/gm45/raminit.c: https://review.coreboot.org/c/coreboot/+/78833/comment/55fe548b_a0b188b4 : PS4, Line 942: /* VCO 3200 */ would moving the comments after the array elements make things to work better? -- To view, visit https://review.coreboot.org/c/coreboot/+/78833?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I596ec6d69184594870d9db1488618225a1ac421f Gerrit-Change-Number: 78833 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 12:24:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023