coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[M] Change in coreboot[main]: mb/google/trogdor: Move selects from Kconfig.name to Kconfig
by Martin L Roth (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79027?usp=email ) Change subject: mb/google/trogdor: Move selects from Kconfig.name to Kconfig ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/79027?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I30a15277527a1e423691ff55ff11cc2136cefc90 Gerrit-Change-Number: 79027 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Fri, 17 Nov 2023 22:17:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/qualcomm/{sc7180,sc7280}: Allow building without QC blobs repo
by Martin L Roth (Code Review) 17 Nov '23

17 Nov '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79026?usp=email ) Change subject: soc/qualcomm/{sc7180,sc7280}: Allow building without QC blobs repo ...................................................................... soc/qualcomm/{sc7180,sc7280}: Allow building without QC blobs repo Building coreboot for the Qualcomm SoCs SC7180 and SC7280 requires to include the Qualcomm blobs, which requires to accept their license. However, for various reasons it makes sense to build without blobs, e.g. static analysis or just build-testing. So in order to do that, run the steps integrating the Qualcomm blobs into the coreboot binary only if USE_QC_BLOBS is enabled and also remove guards which prevent building related mainboards when USE_QC_BLOBS is not enabled. Change-Id: I249ac477b8f10e7fa0848e967c23a3b3b9bbd27d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79026 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/herobrine/Kconfig.name M src/mainboard/google/trogdor/Kconfig.name M src/soc/qualcomm/sc7180/Kconfig M src/soc/qualcomm/sc7180/Makefile.inc M src/soc/qualcomm/sc7280/Makefile.inc 5 files changed, 9 insertions(+), 17 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/mainboard/google/herobrine/Kconfig.name b/src/mainboard/google/herobrine/Kconfig.name index 06530a0..e779c91 100644 --- a/src/mainboard/google/herobrine/Kconfig.name +++ b/src/mainboard/google/herobrine/Kconfig.name @@ -1,7 +1,5 @@ comment "Herobrine" -if USE_QC_BLOBS - config BOARD_GOOGLE_HEROBRINE bool "-> Herobrine" select BOARD_GOOGLE_HEROBRINE_COMMON @@ -37,8 +35,3 @@ config BOARD_GOOGLE_ZOMBIE bool "-> Zombie" select BOARD_GOOGLE_HEROBRINE_COMMON - -endif - -comment "(Herobrine requires 'Allow QC blobs repository')" - depends on !USE_QC_BLOBS diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name index db4cff0..cc1ffbd 100644 --- a/src/mainboard/google/trogdor/Kconfig.name +++ b/src/mainboard/google/trogdor/Kconfig.name @@ -1,7 +1,5 @@ comment "Trogdor" -if USE_QC_BLOBS - config BOARD_GOOGLE_BUBS bool "-> Bubs" select BOARD_GOOGLE_TROGDOR_COMMON @@ -53,8 +51,3 @@ config BOARD_GOOGLE_TROGDOR bool "-> Trogdor" select BOARD_GOOGLE_TROGDOR_COMMON - -endif - -comment "(Trogdor requires 'Allow QC blobs repository')" - depends on !USE_QC_BLOBS diff --git a/src/soc/qualcomm/sc7180/Kconfig b/src/soc/qualcomm/sc7180/Kconfig index 066ff5d..f813372 100644 --- a/src/soc/qualcomm/sc7180/Kconfig +++ b/src/soc/qualcomm/sc7180/Kconfig @@ -2,7 +2,6 @@ config SOC_QUALCOMM_SC7180 bool default n - depends on USE_QC_BLOBS select ARCH_BOOTBLOCK_ARMV8_64 select ARCH_RAMSTAGE_ARMV8_64 select ARCH_ROMSTAGE_ARMV8_64 diff --git a/src/soc/qualcomm/sc7180/Makefile.inc b/src/soc/qualcomm/sc7180/Makefile.inc index 734691e..ead5720 100644 --- a/src/soc/qualcomm/sc7180/Makefile.inc +++ b/src/soc/qualcomm/sc7180/Makefile.inc @@ -56,6 +56,8 @@ BL31_MAKEARGS += PLAT=sc7180 +ifeq ($(CONFIG_USE_QC_BLOBS),y) + SC7180_BLOB := $(top)/3rdparty/qc_blobs/sc7180 ifeq ($(CONFIG_QC_SDI_ENABLE),y) @@ -150,3 +152,5 @@ $(objcbfs)/bootblock.bin endif + +endif diff --git a/src/soc/qualcomm/sc7280/Makefile.inc b/src/soc/qualcomm/sc7280/Makefile.inc index 4401484..ae23f45 100644 --- a/src/soc/qualcomm/sc7280/Makefile.inc +++ b/src/soc/qualcomm/sc7280/Makefile.inc @@ -62,10 +62,11 @@ CPPFLAGS_common += -Isrc/soc/qualcomm/sc7280/include CPPFLAGS_common += -Isrc/soc/qualcomm/common/include -SC7280_BLOB := $(top)/3rdparty/qc_blobs/sc7280 +BL31_MAKEARGS += PLAT=sc7280 ################################################################################ -BL31_MAKEARGS += PLAT=sc7280 +ifeq ($(CONFIG_USE_QC_BLOBS),y) +SC7280_BLOB := $(top)/3rdparty/qc_blobs/sc7280 ifeq ($(CONFIG_QC_SDI_ENABLE),y) BL31_MAKEARGS += QTI_SDI_BUILD=1 @@ -175,3 +176,5 @@ cbfs-files-y += $(GSI_FW_CBFS) endif + +endif -- To view, visit https://review.coreboot.org/c/coreboot/+/79026?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I249ac477b8f10e7fa0848e967c23a3b3b9bbd27d Gerrit-Change-Number: 79026 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: soc/qualcomm/{sc7180,sc7280}: Allow building without QC blobs repo
by Martin L Roth (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79026?usp=email ) Change subject: soc/qualcomm/{sc7180,sc7280}: Allow building without QC blobs repo ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79026?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I249ac477b8f10e7fa0848e967c23a3b3b9bbd27d Gerrit-Change-Number: 79026 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Fri, 17 Nov 2023 22:17:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/qualcomm/{sc7180,sc7280}: Allow building without QC blobs repo
by Felix Singer (Code Review) 17 Nov '23

17 Nov '23

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79026?usp=email ) Change subject: soc/qualcomm/{sc7180,sc7280}: Allow building without QC blobs repo ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/79026?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I249ac477b8f10e7fa0848e967c23a3b3b9bbd27d Gerrit-Change-Number: 79026 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Nov 2023 22:15:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Fix configuration for TPM in Kconfig
by Shelley Chen (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Nick Vaccaro. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79102?usp=email ) Change subject: Fix configuration for TPM in Kconfig ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brox/Kconfig: https://review.coreboot.org/c/coreboot/+/79102/comment/bf6de84d_eab18b33 : PS1, Line 90: 33 > How was this number determined? Hi Nick, I got this from the definition of GPE0_DW1_01 in src/soc/intel/common/pch/include/intelpch/gpe.h: #define GPE0_DW1_01 33 -- To view, visit https://review.coreboot.org/c/coreboot/+/79102?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0ecaa6fcfc05c3c2e55f857d7a4e59fe46096bb5 Gerrit-Change-Number: 79102 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 22:02:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: Docs/releases: Update 4.22 release notes
by Jason Glenesk (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Angel Pons, Felix Singer, Martin L Roth, Matt DeVillier, Patrick Georgi, Paul Menzel. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79077?usp=email ) Change subject: Docs/releases: Update 4.22 release notes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id723f8e1fc92ef1a36e877f48e594eef59b0ba8e Gerrit-Change-Number: 79077 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 21:58:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: Docs/security/vboot: Update list of boards with vboot
by Jason Glenesk (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Martin L Roth. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79071?usp=email ) Change subject: Docs/security/vboot: Update list of boards with vboot ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77c5ca2c2c36d8b1ddadad4f15d2d4148ff0b325 Gerrit-Change-Number: 79071 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 21:56:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: google/*: Clean up Kconfg board selection for Google MTK boards
by Julius Werner (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Felix Singer, Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email ) Change subject: google/*: Clean up Kconfg board selection for Google MTK boards ...................................................................... Patch Set 1: (3 comments) File src/mainboard/google/corsola/Kconfig: https://review.coreboot.org/c/coreboot/+/79063/comment/da3df88a_ced26a31 : PS1, Line 22: select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_CHINCHOU Hmm... I think I find my version a bit clearer to be honest, but it's your board so happy to switch this to your proposal if you prefer. I think the way I wrote it makes it pretty straight-forward to read: > * All the Kinglers have ANX, except for Steelix which also has Parade in addition. > * All the Krabbies have Parade, except Chinchou which has ANX instead. > * All the Staryus have MIPI. I think it would be well set-up to be extended from there too, except if we get more boards like Chinchou which are Krabby but need the Parade, then it might be worth adding a `KRABBY_HAS_PS8640` intermediary option to make that easier to write. I do like the `CORSOLA_HAS_xxx` options in general to organize things, but if you already have your boards split into subvariants anyway then I don't think you need to make extra options for things that already apply only to exactly one of those. So as long as all the Staryus have MIPI panels and all the other ones don't, you probably don't need a `CORSOLA_HAS_MIPI_PANEL`, you can just use `BOARD_GOOGLE_STARYU_COMMON` there (unless you anticipate that you're gonna add more non-Staryus with MIPI in the future). Also, I think we don't usually use default-overrides for `bool` options because that's just equivalent to selecting that option from `BOARD_SPECIFIC_OPTIONS` (at least if the default normally is `n`). So if you want to organize it the way you proposed, I think rather than overriding the defaults you could just add ``` select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_KINGLER_COMMON || BOARD_GOOGLE_CHINCHOU select DRIVER_PARADE_PS8640 if !(DRIVER_ANALOGIX_ANX7625 || BOARD_GOOGLE_STARYU_COMMON) || BOARD_GOOGLE_STEELIX ``` File src/mainboard/google/kukui/Kconfig: https://review.coreboot.org/c/coreboot/+/79063/comment/ab7aab54_7a2b245d : PS1, Line 27: BOARD_GOOGLE_WILLOW > This needs to select `BOARD_GOOGLE_KUKUI_COMMON`. Here kukui is considered as the parent of jacuzzi. I did that by adding JACUZZI_COMMON to the def_bool list for KUKUI_COMMON above. I went back and forth a bit about whether it's better that way or with a select here... I settled on that because I think it's a bit more consistent, that way the KUKUI_COMMON option alone tells you about everything it applies to and there are no surprise boards added later from other configs. But happy to switch to the select version if you prefer. https://review.coreboot.org/c/coreboot/+/79063/comment/f90e2fff_2c0e02a4 : PS1, Line 36: select VBOOT_VBNV_FLASH > Not related to the patch, but I've always been wondering how repeated definitions of a Kconfig optio […] In effect, yeah, but the mechanism is a little different. This basically just "extends" the original definition, and the encompassing `if` block here is equivalent to just writing `if ...` behind every line. So basically, this is equivalent to adding a `select VBOOT_VBNV_FLASH if BOARD_GOOGLE_KUKUI_COMMON` to the `config VBOOT` definition in `src/security/vboot/Kconfig`. -- To view, visit https://review.coreboot.org/c/coreboot/+/79063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a Gerrit-Change-Number: 79063 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 21:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: Docs/releases: Update 4.22 release notes
by Martin L Roth (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Matt DeVillier, Patrick Georgi, Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79077?usp=email ) Change subject: Docs/releases: Update 4.22 release notes ...................................................................... Patch Set 2: (5 comments) File Documentation/releases/coreboot-4.22-relnotes.md: https://review.coreboot.org/c/coreboot/+/79077/comment/95a8630e_31331742 : PS1, Line 25: when > at which time Done https://review.coreboot.org/c/coreboot/+/79077/comment/0937fbfd_6793a872 : PS1, Line 25: through > up until Done https://review.coreboot.org/c/coreboot/+/79077/comment/95750c35_8281ea6c : PS1, Line 167: > * Work on chipset devicetrees for all platforms. Done https://review.coreboot.org/c/coreboot/+/79077/comment/2e177ec2_ebe263f1 : PS1, Line 189: > Add opensil submodule Done https://review.coreboot.org/c/coreboot/+/79077/comment/3b90bb6b_df874d76 : PS1, Line 318: * Add Chipset device trees for all SOCs > Complete Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id723f8e1fc92ef1a36e877f48e594eef59b0ba8e Gerrit-Change-Number: 79077 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 17 Nov 2023 21:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: Docs/releases: Update 4.22 release notes
by Martin L Roth (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth, Patrick Georgi, Paul Menzel. Hello Angel Pons, Felix Singer, Jason Glenesk, Patrick Georgi, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79077?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Paul Menzel, Code-Review+2 by Patrick Georgi, Verified+1 by build bot (Jenkins) Change subject: Docs/releases: Update 4.22 release notes ...................................................................... Docs/releases: Update 4.22 release notes These should be the final release notes prior to tagging coreboot Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Id723f8e1fc92ef1a36e877f48e594eef59b0ba8e --- M Documentation/releases/coreboot-4.22-relnotes.md 1 file changed, 272 insertions(+), 62 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/79077/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id723f8e1fc92ef1a36e877f48e594eef59b0ba8e Gerrit-Change-Number: 79077 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023