coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[S] Change in coreboot[main]: mb/goog/brya/var/brya0/skolas: Disable HPS GPIOs if HPS_ABSENT
by Eric Lai (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Nick Vaccaro, Nick Vaccaro, Shelley Chen, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79123?usp=email ) Change subject: mb/goog/brya/var/brya0/skolas: Disable HPS GPIOs if HPS_ABSENT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79123?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8cbe4f40c41f1d06e8f511c3e88c05984566d441 Gerrit-Change-Number: 79123 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 18 Nov 2023 04:46:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/goog/brya/var/brya0/skolas: Disable LTE GPIOs if LTE_ABSENT
by Eric Lai (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Nick Vaccaro, Nick Vaccaro, Shelley Chen, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79122?usp=email ) Change subject: mb/goog/brya/var/brya0/skolas: Disable LTE GPIOs if LTE_ABSENT ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3f3bc2b536babf71cc484cce02f96f47707f729c Gerrit-Change-Number: 79122 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 18 Nov 2023 04:46:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Move ttb_buffer to a standalone section
by Yi Chou (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Julius Werner, Yu-Ping Wu. Hello Julius Werner, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79078?usp=email to look at the new patch set (#8). Change subject: libpayload: Move ttb_buffer to a standalone section ...................................................................... libpayload: Move ttb_buffer to a standalone section When cleaning the sensitive data in the memory, we will want to prevent zero out the content of tbb_buffer. Move the ttb_buffer to a standalone section will simplify the problem. BUG=b:248610274 TEST=emerge-cherry libpayload BRANCH=none Change-Id: I610276cbe30552263d791860c15e5ad9a201c744 Signed-off-by: Yi Chou <yich(a)google.com> --- M payloads/libpayload/arch/arm64/libpayload.ldscript M payloads/libpayload/arch/arm64/mmu.c 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/79078/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/79078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I610276cbe30552263d791860c15e5ad9a201c744 Gerrit-Change-Number: 79078 Gerrit-PatchSet: 8 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/goog/brya/var/skolas: sync slolas overridetree with brya0
by Eric Lai (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Nick Vaccaro, Nick Vaccaro, Shelley Chen, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79121?usp=email ) Change subject: mb/goog/brya/var/skolas: sync slolas overridetree with brya0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79121?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I14a2ed803a8ffb8614018af587c66034fb724b38 Gerrit-Change-Number: 79121 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 18 Nov 2023 04:44:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/joxer: Add speaker ldo config
by Eric Lai (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Derek Huang, Felix Held, Nick Vaccaro, Subrata Banik, Terry Chen. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79111?usp=email ) Change subject: mb/google/nissa/var/joxer: Add speaker ldo config ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79111?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie68f2b35f024b4dd066d831ae8fd5a662d407753 Gerrit-Change-Number: 79111 Gerrit-PatchSet: 3 Gerrit-Owner: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 18 Nov 2023 04:41:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Move ttb_buffer to a standalone section
by Yi Chou (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Julius Werner, Yu-Ping Wu. Hello Julius Werner, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79078?usp=email to look at the new patch set (#7). Change subject: libpayload: Move ttb_buffer to a standalone section ...................................................................... libpayload: Move ttb_buffer to a standalone section When cleaning the sensitive data in the memory, we will want to prevent zero out the content of tbb_buffer. Move the ttb_buffer to a standalone section will simplify the problem. BUG=b:248610274 TEST=emerge-cherry libpayload BRANCH=none Change-Id: I610276cbe30552263d791860c15e5ad9a201c744 Signed-off-by: Yi Chou <yich(a)google.com> --- M payloads/libpayload/arch/arm64/libpayload.ldscript M payloads/libpayload/arch/arm64/mmu.c 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/79078/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/79078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I610276cbe30552263d791860c15e5ad9a201c744 Gerrit-Change-Number: 79078 Gerrit-PatchSet: 7 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: libpayload: Move ttb_buffer to a standalone section
by Yi Chou (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Julius Werner, Yu-Ping Wu. Yi Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79078?usp=email ) Change subject: libpayload: Move ttb_buffer to a standalone section ...................................................................... Patch Set 6: (2 comments) Patchset: PS5: > Maybe this would be a good opportunity to fix the _stack/_estack inconsistency as well? Added another CL for that: https://review.coreboot.org/c/coreboot/+/79144 File payloads/libpayload/arch/arm64/mmu.c: https://review.coreboot.org/c/coreboot/+/79078/comment/3754c180_23fad487 : PS5, Line 44: ".ttb_buffer" > Added it into the `payloads/libpayload/arch/arm64/libpayload.ldscript`. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I610276cbe30552263d791860c15e5ad9a201c744 Gerrit-Change-Number: 79078 Gerrit-PatchSet: 6 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 18 Nov 2023 04:18:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yi Chou <yich(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload: Fix the stack and data labels
by Yi Chou (Code Review) 18 Nov '23

18 Nov '23

Yi Chou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79144?usp=email ) Change subject: libpayload: Fix the stack and data labels ...................................................................... libpayload: Fix the stack and data labels We should make sure the consistency between _stack/_estack and the other labels. And _data & _edata is also useful to clean up the sensitive data on the data section. BUG=b:248610274 TEST=emerge-cherry libpayload BRANCH=none Change-Id: I589040f4db60b35813ea9f4ba9503244bd7def00 Signed-off-by: Yi Chou <yich(a)google.com> --- M payloads/libpayload/arch/arm/libpayload.ldscript M payloads/libpayload/arch/arm64/libpayload.ldscript M payloads/libpayload/arch/x86/libpayload.ldscript 3 files changed, 18 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/79144/1 diff --git a/payloads/libpayload/arch/arm/libpayload.ldscript b/payloads/libpayload/arch/arm/libpayload.ldscript index 5510218..73c8f0b 100644 --- a/payloads/libpayload/arch/arm/libpayload.ldscript +++ b/payloads/libpayload/arch/arm/libpayload.ldscript @@ -51,12 +51,14 @@ } .data : { + . = ALIGN(16); + _data = .; *(.data) *(.data.*) + . = ALIGN(16); + _edata = .; } - _edata = .; - .bss : { *(.sbss) *(.sbss.*) @@ -72,10 +74,10 @@ . = ALIGN(16); _eheap = .; - _estack = .; + _stack = .; . += CONFIG_LP_STACK_SIZE; . = ALIGN(16); - _stack = .; + _estack = .; } _end = .; diff --git a/payloads/libpayload/arch/arm64/libpayload.ldscript b/payloads/libpayload/arch/arm64/libpayload.ldscript index e225aa8..be95a42 100644 --- a/payloads/libpayload/arch/arm64/libpayload.ldscript +++ b/payloads/libpayload/arch/arm64/libpayload.ldscript @@ -51,12 +51,14 @@ } .data : { + . = ALIGN(16); + _data = .; *(.data) *(.data.*) + . = ALIGN(16); + _edata = .; } - _edata = .; - .bss : { *(.ttb_buffer) @@ -74,10 +76,10 @@ . = ALIGN(16); _eheap = .; - _estack = .; + _stack = .; . += CONFIG_LP_STACK_SIZE; . = ALIGN(16); - _stack = .; + _estack = .; } _end = .; diff --git a/payloads/libpayload/arch/x86/libpayload.ldscript b/payloads/libpayload/arch/x86/libpayload.ldscript index 2d7e912..ee0fdfd 100644 --- a/payloads/libpayload/arch/x86/libpayload.ldscript +++ b/payloads/libpayload/arch/x86/libpayload.ldscript @@ -50,12 +50,14 @@ } .data : { + . = ALIGN(16); + _data = .; *(.data) *(.data.*) + . = ALIGN(16); + _edata = .; } - _edata = .; - .bss : { *(.sbss) *(.sbss.*) @@ -71,10 +73,10 @@ . = ALIGN(16); _eheap = .; - _estack = .; + _stack = .; . += CONFIG_LP_STACK_SIZE; . = ALIGN(16); - _stack = .; + _estack = .; } _end = .; -- To view, visit https://review.coreboot.org/c/coreboot/+/79144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I589040f4db60b35813ea9f4ba9503244bd7def00 Gerrit-Change-Number: 79144 Gerrit-PatchSet: 1 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: libpayload: Move ttb_buffer to a standalone section
by Yi Chou (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Julius Werner, Yu-Ping Wu. Yi Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79078?usp=email ) Change subject: libpayload: Move ttb_buffer to a standalone section ...................................................................... Patch Set 6: (1 comment) File payloads/libpayload/arch/arm64/mmu.c: https://review.coreboot.org/c/coreboot/+/79078/comment/1a6bb6ea_521021cd : PS5, Line 44: ".ttb_buffer" > You need to actually add this section to all the `payloads/libpayload/arch/*/libpayload. […] Added it into the `payloads/libpayload/arch/arm64/libpayload.ldscript`. I think the tbb_buffer is only valid on the arm64, so we don't need to change the other architecture. -- To view, visit https://review.coreboot.org/c/coreboot/+/79078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I610276cbe30552263d791860c15e5ad9a201c744 Gerrit-Change-Number: 79078 Gerrit-PatchSet: 6 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 18 Nov 2023 04:09:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Move ttb_buffer to a standalone section
by Yi Chou (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Yi Chou, Yu-Ping Wu. Hello Julius Werner, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79078?usp=email to look at the new patch set (#6). Change subject: libpayload: Move ttb_buffer to a standalone section ...................................................................... libpayload: Move ttb_buffer to a standalone section When cleaning the sensitive data in the memory, we will want to prevent zero out the content of tbb_buffer. Move the ttb_buffer to a standalone section will simplify the problem. BUG=b:248610274 TEST=emerge-cherry libpayload BRANCH=none Change-Id: I610276cbe30552263d791860c15e5ad9a201c744 Signed-off-by: Yi Chou <yich(a)google.com> --- M payloads/libpayload/arch/arm64/libpayload.ldscript M payloads/libpayload/arch/arm64/mmu.c 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/79078/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/79078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I610276cbe30552263d791860c15e5ad9a201c744 Gerrit-Change-Number: 79078 Gerrit-PatchSet: 6 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023