coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: cross-repo-cherrypick: Update downstream branch
by Jon Murphy (Code Review) 18 Nov '23

18 Nov '23

Jon Murphy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79143?usp=email ) Change subject: cross-repo-cherrypick: Update downstream branch ...................................................................... cross-repo-cherrypick: Update downstream branch ChromeOS has switched to using the main branch, update accordingly. BUG=b:294218930 TEST=None Change-Id: I31f67ef4fb175a4e4896b5bed81d5ae1cdddb827 Signed-off-by: Jon Murphy <jpmurphy(a)google.com> --- M util/scripts/cross-repo-cherrypick 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/79143/1 diff --git a/util/scripts/cross-repo-cherrypick b/util/scripts/cross-repo-cherrypick index b27ff43..21f2fb1 100755 --- a/util/scripts/cross-repo-cherrypick +++ b/util/scripts/cross-repo-cherrypick @@ -28,7 +28,7 @@ MESSAGE_PREFIX="UPSTREAM: " ;; chromium-review.googlesource.com) - BRANCH="cros/chromeos-2016.05" + BRANCH="cros/main" MESSAGE_PREFIX="" ;; esac -- To view, visit https://review.coreboot.org/c/coreboot/+/79143?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I31f67ef4fb175a4e4896b5bed81d5ae1cdddb827 Gerrit-Change-Number: 79143 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: util/lint: Add linter to keep selects out of Kconfig.name
by Martin L Roth (Code Review) 18 Nov '23

18 Nov '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78972?usp=email ) Change subject: util/lint: Add linter to keep selects out of Kconfig.name ...................................................................... util/lint: Add linter to keep selects out of Kconfig.name While having select statements in Kconfig.name files is valid in the syntax of the Kconfig language, having the selections split between the normal Kconfig file and Kconfig.name files makes it harder to see what's going on. Kconfig.name files will now be limited to their original purpose of selecting a particular board or board variant, not actually configuring that board. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I2aab78e296f2958e77a938b1afa40a25a6aa82b0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78972 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- A util/lint/lint-stable-029-kconfig-name-selects 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Maximilian Brune: Looks good to me, approved diff --git a/util/lint/lint-stable-029-kconfig-name-selects b/util/lint/lint-stable-029-kconfig-name-selects new file mode 100755 index 0000000..78d6070 --- /dev/null +++ b/util/lint/lint-stable-029-kconfig-name-selects @@ -0,0 +1,16 @@ +#!/usr/bin/env sh +# SPDX-License-Identifier: GPL-2.0-or-later +# +# DESCR: Check that boards don't use select Kconfig.name + +export LC_ALL=C +FAIL=0 + +for board in src/mainboard/*/*; do + if [ -f ${board}/Kconfig.name ] && grep -q "select " "${board}/Kconfig.name"; then + echo "Mainboard ${board} uses 'select' in Kconfig.name" + FAIL=1 + fi +done + +exit ${FAIL} -- To view, visit https://review.coreboot.org/c/coreboot/+/78972?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2aab78e296f2958e77a938b1afa40a25a6aa82b0 Gerrit-Change-Number: 78972 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/google/brox: Use Ti50 config
by Shelley Chen (Code Review) 18 Nov '23

18 Nov '23

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79100?usp=email ) Change subject: mb/google/brox: Use Ti50 config ...................................................................... mb/google/brox: Use Ti50 config Brox is using Ti50, so make sure that we set the right config for that. BUG=b:300690448 BRANCH=None TEST=emerge-brox coreboot Change-Id: If4a16448eebc028b2989c1de150b9e0f9067ee92 Signed-off-by: Shelley Chen <shchen(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79100 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/brox/Kconfig M src/mainboard/google/brox/chromeos.fmd 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Nick Vaccaro: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/brox/Kconfig b/src/mainboard/google/brox/Kconfig index 2b4038c..08a0656 100644 --- a/src/mainboard/google/brox/Kconfig +++ b/src/mainboard/google/brox/Kconfig @@ -48,7 +48,7 @@ select SOC_INTEL_RAPTORLAKE select SOC_INTEL_ALDERLAKE_PCH_P select SYSTEM_TYPE_LAPTOP - select TPM_GOOGLE_CR50 + select TPM_GOOGLE_TI50 config BOARD_GOOGLE_BROX select BOARD_GOOGLE_BASEBOARD_BROX diff --git a/src/mainboard/google/brox/chromeos.fmd b/src/mainboard/google/brox/chromeos.fmd index 65ceba7..fffb77e 100644 --- a/src/mainboard/google/brox/chromeos.fmd +++ b/src/mainboard/google/brox/chromeos.fmd @@ -47,6 +47,7 @@ # memory protected range specification. WP_RO 8M { RO_VPD(PRESERVE) 16K + RO_GSCVD 8K RO_SECTION { FMAP 2K RO_FRID 64 -- To view, visit https://review.coreboot.org/c/coreboot/+/79100?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If4a16448eebc028b2989c1de150b9e0f9067ee92 Gerrit-Change-Number: 79100 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/brox: Fix GPIO assignments in gpio.h
by Shelley Chen (Code Review) 18 Nov '23

18 Nov '23

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78952?usp=email ) Change subject: mb/google/brox: Fix GPIO assignments in gpio.h ...................................................................... mb/google/brox: Fix GPIO assignments in gpio.h Assigning the macros in gpio.h to the correct GPIOs. Also, fixing GPE configurations so that they are mapped to the proper wake sources (GPP_B, D, E groups). BUG=b:300690448 BRANCH=None TEST=emerge-brox coreboot Change-Id: I6320cd98e560e514e63c52e173cb7923cfd1cdee Signed-off-by: Shelley Chen <shchen(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78952 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb M src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Nick Vaccaro: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb index 186aadb..2b73ad2 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb +++ b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb @@ -1,9 +1,9 @@ chip soc/intel/alderlake # GPE configuration - register "pmc_gpe0_dw0" = "GPP_A" - register "pmc_gpe0_dw1" = "GPP_E" - register "pmc_gpe0_dw2" = "GPP_F" + register "pmc_gpe0_dw0" = "GPP_B" + register "pmc_gpe0_dw1" = "GPP_D" + register "pmc_gpe0_dw2" = "GPP_E" # EC host command ranges are in 0x800-0x8ff & 0x200-0x20f register "gen1_dec" = "0x00fc0801" diff --git a/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h b/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h index 794394f..54321e5 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h +++ b/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h @@ -8,13 +8,13 @@ /* eSPI virtual wire reporting */ #define EC_SCI_GPI GPE0_ESPI -/* EC wake is EC_PCH_INT which is routed to GPP_F17 pin */ -#define GPE_EC_WAKE GPE0_DW2_17 +/* EC wake is EC_PCH_INT which is routed to GPP_D1 pin */ +#define GPE_EC_WAKE GPE0_DW1_01 /* WP signal to PCH */ -#define GPIO_PCH_WP GPP_E15 +#define GPIO_PCH_WP GPP_E8 /* Used to gate SoC's SLP_S0# signal */ -#define GPIO_SLP_S0_GATE GPP_F9 +#define GPIO_SLP_S0_GATE GPP_D17 /* GPIO IRQ for tight timestamps / wake support */ -#define EC_SYNC_IRQ GPP_F17_IRQ +#define EC_SYNC_IRQ GPP_D1_IRQ #endif /* __BASEBOARD_GPIO_H__ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/78952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6320cd98e560e514e63c52e173cb7923cfd1cdee Gerrit-Change-Number: 78952 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: sbom/Makefile.inc: Change GOPATH
by Maximilian Brune (Code Review) 18 Nov '23

18 Nov '23

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77780?usp=email ) Change subject: sbom/Makefile.inc: Change GOPATH ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/77780/comment/84586ef3_b13f4135 : PS3, Line 7: sbom/Makefile.inc > Should me make this change wider than just the SBOM? Maybe put it into toolchain. […] sounds good. Give some time and I will do a patch But for now I would leave it the way it is in this patch (I am not sure if I find time in the near future) https://review.coreboot.org/c/coreboot/+/77780/comment/6c65b940_401c67e9 : PS3, Line 11: since offline build are still not : possible, because go will fetch the packages at build time > Can we do something like we do with the util/crossgcc/tarballs folder where files can be placed to be installed by the coreboot builds even when the system isn't connected to the internet? I would use the `go mod vendor` command. It is a command to download all dependencies for a go program and place them in folder called "vendor" (probably customizable). We can use that at the same time we download the toolchain. I think the command was even meant for offline builds. I will mark it as resolved so that the patch gets merged until we have a better solution in place. -- To view, visit https://review.coreboot.org/c/coreboot/+/77780?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2a35369628454057ea4758cd1225e57f07cb71c8 Gerrit-Change-Number: 77780 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sat, 18 Nov 2023 01:51:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Move ttb_buffer to a standalone section
by Julius Werner (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Yi Chou, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79078?usp=email ) Change subject: libpayload: Move ttb_buffer to a standalone section ...................................................................... Patch Set 5: (2 comments) Patchset: PS5: Maybe this would be a good opportunity to fix the _stack/_estack inconsistency as well? File payloads/libpayload/arch/arm64/mmu.c: https://review.coreboot.org/c/coreboot/+/79078/comment/90d87306_87bc6966 : PS5, Line 44: ".ttb_buffer" You need to actually add this section to all the `payloads/libpayload/arch/*/libpayload.ldscript` scripts though. Depthcharge chooses to maintain its own linker script, but most other payloads use the default one from this repo. -- To view, visit https://review.coreboot.org/c/coreboot/+/79078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I610276cbe30552263d791860c15e5ad9a201c744 Gerrit-Change-Number: 79078 Gerrit-PatchSet: 5 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 18 Nov 2023 01:13:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/lint: Add linter to keep selects out of Kconfig.name
by Maximilian Brune (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Martin L Roth, Nico Huber. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78972?usp=email ) Change subject: util/lint: Add linter to keep selects out of Kconfig.name ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78972?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2aab78e296f2958e77a938b1afa40a25a6aa82b0 Gerrit-Change-Number: 78972 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 18 Nov 2023 01:12:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/herobrine: Move selects from Kconfig.name to Kconfig
by Martin L Roth (Code Review) 17 Nov '23

17 Nov '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79028?usp=email ) Change subject: mb/google/herobrine: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/herobrine: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I25b7adccf60abe515d129f8d00383165eccf6431 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79028 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/herobrine/Kconfig M src/mainboard/google/herobrine/Kconfig.name 2 files changed, 27 insertions(+), 9 deletions(-) Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/herobrine/Kconfig b/src/mainboard/google/herobrine/Kconfig index a95ac06..45f296c 100644 --- a/src/mainboard/google/herobrine/Kconfig +++ b/src/mainboard/google/herobrine/Kconfig @@ -1,6 +1,33 @@ config BOARD_GOOGLE_HEROBRINE_COMMON # Umbrella option to be selected by variants def_bool n +config BOARD_GOOGLE_HEROBRINE + select BOARD_GOOGLE_HEROBRINE_COMMON + +config BOARD_GOOGLE_HEROBRINE_REV0 + select BOARD_GOOGLE_HEROBRINE_COMMON + +config BOARD_GOOGLE_SENOR + select BOARD_GOOGLE_HEROBRINE_COMMON + +config BOARD_GOOGLE_PIGLIN + select BOARD_GOOGLE_HEROBRINE_COMMON + +config BOARD_GOOGLE_HOGLIN + select BOARD_GOOGLE_HEROBRINE_COMMON + +config BOARD_GOOGLE_VILLAGER + select BOARD_GOOGLE_HEROBRINE_COMMON + +config BOARD_GOOGLE_EVOKER + select BOARD_GOOGLE_HEROBRINE_COMMON + +config BOARD_GOOGLE_ZOGLIN + select BOARD_GOOGLE_HEROBRINE_COMMON + +config BOARD_GOOGLE_ZOMBIE + select BOARD_GOOGLE_HEROBRINE_COMMON + if BOARD_GOOGLE_HEROBRINE_COMMON config HEROBRINE_HAS_FINGERPRINT diff --git a/src/mainboard/google/herobrine/Kconfig.name b/src/mainboard/google/herobrine/Kconfig.name index e779c91..4c49373 100644 --- a/src/mainboard/google/herobrine/Kconfig.name +++ b/src/mainboard/google/herobrine/Kconfig.name @@ -2,36 +2,27 @@ config BOARD_GOOGLE_HEROBRINE bool "-> Herobrine" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_HEROBRINE_REV0 bool "-> Herobrine_Rev0" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_SENOR bool "-> Senor" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_PIGLIN bool "-> Piglin" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_HOGLIN bool "-> Hoglin" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_VILLAGER bool "-> Villager" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_EVOKER bool "-> Evoker" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_ZOGLIN bool "-> Zoglin" - select BOARD_GOOGLE_HEROBRINE_COMMON config BOARD_GOOGLE_ZOMBIE bool "-> Zombie" - select BOARD_GOOGLE_HEROBRINE_COMMON -- To view, visit https://review.coreboot.org/c/coreboot/+/79028?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25b7adccf60abe515d129f8d00383165eccf6431 Gerrit-Change-Number: 79028 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/herobrine: Move selects from Kconfig.name to Kconfig
by Martin L Roth (Code Review) 17 Nov '23

17 Nov '23

Attention is currently required from: Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79028?usp=email ) Change subject: mb/google/herobrine: Move selects from Kconfig.name to Kconfig ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/79028?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25b7adccf60abe515d129f8d00383165eccf6431 Gerrit-Change-Number: 79028 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Fri, 17 Nov 2023 22:18:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/trogdor: Move selects from Kconfig.name to Kconfig
by Martin L Roth (Code Review) 17 Nov '23

17 Nov '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79027?usp=email ) Change subject: mb/google/trogdor: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/trogdor: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I30a15277527a1e423691ff55ff11cc2136cefc90 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79027 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/Kconfig.name 2 files changed, 39 insertions(+), 13 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index 028dc2b..f7e1afe 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -2,6 +2,45 @@ config BOARD_GOOGLE_TROGDOR_COMMON # Umbrella option to be selected by variants def_bool n +config BOARD_GOOGLE_BUBS + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_COACHZ + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_GELARSHIE + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_HOMESTAR + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_KINGOFTOWN + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_LAZOR + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_MARZIPAN + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_MRBLAND + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_PAZQUEL + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_POMPOM + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_QUACKINGSTICK + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_WORMDINGLER + select BOARD_GOOGLE_TROGDOR_COMMON + +config BOARD_GOOGLE_TROGDOR + select BOARD_GOOGLE_TROGDOR_COMMON + if BOARD_GOOGLE_TROGDOR_COMMON config TROGDOR_REV0 diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name index cc1ffbd..e22159f 100644 --- a/src/mainboard/google/trogdor/Kconfig.name +++ b/src/mainboard/google/trogdor/Kconfig.name @@ -2,52 +2,39 @@ config BOARD_GOOGLE_BUBS bool "-> Bubs" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_COACHZ bool "-> Coachz" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_GELARSHIE bool "-> Gelarshie" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_HOMESTAR bool "-> Homestar" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_KINGOFTOWN bool "-> Kingoftown" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_LAZOR bool "-> Lazor" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_MARZIPAN bool "-> Marzipan" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_MRBLAND bool "-> Mrbland" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_PAZQUEL bool "-> Pazquel" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_POMPOM bool "-> Pompom" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_QUACKINGSTICK bool "-> Quackingstick" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_WORMDINGLER bool "-> Wormdingler" - select BOARD_GOOGLE_TROGDOR_COMMON config BOARD_GOOGLE_TROGDOR bool "-> Trogdor" - select BOARD_GOOGLE_TROGDOR_COMMON -- To view, visit https://review.coreboot.org/c/coreboot/+/79027?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I30a15277527a1e423691ff55ff11cc2136cefc90 Gerrit-Change-Number: 79027 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023