coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[main]: Update vboot submodule to upstream main
by Martin L Roth (Code Review) 19 Nov '23

19 Nov '23

Attention is currently required from: Eric Lai, Felix Singer, Julius Werner. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78865?usp=email ) Change subject: Update vboot submodule to upstream main ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > We'd like to hold of on merging this change until after the 4.22 release is tagged on 2023_11_17. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78865?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7ecdabcdd26df349b8abf1c5a77c806facfe1d8 Gerrit-Change-Number: 78865 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sun, 19 Nov 2023 03:04:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/crossgcc: Update LLVM from 16.0.6 to 17.0.4
by Martin L Roth (Code Review) 19 Nov '23

19 Nov '23

Attention is currently required from: Arthur Heymans, Felix Singer, Maximilian Brune, Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78884?usp=email ) Change subject: util/crossgcc: Update LLVM from 16.0.6 to 17.0.4 ...................................................................... Patch Set 1: (2 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/78884/comment/3789157c_500929a1 : PS1, Line 8: > Any statistics how the sizes change and how build time is affected? Not currently, but you could help by doing that testing and adding the statistics. Patchset: PS1: > Waiting until coreboot 4.22 release is done. Just testing for now. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78884?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifed410f4b7fdc358535f01850328c642d19ff1f6 Gerrit-Change-Number: 78884 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 19 Nov 2023 03:04:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/crossgcc: Update CMake from 3.26.4 to 3.27.7
by Martin L Roth (Code Review) 19 Nov '23

19 Nov '23

Attention is currently required from: Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78883?usp=email ) Change subject: util/crossgcc: Update CMake from 3.26.4 to 3.27.7 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) This change is ready for review. Patchset: PS1: > Waiting until coreboot 4.22 release is done. Just testing for now. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78883?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4dbe9b7a05171bb244ec1ebe6ce7d390a6373d61 Gerrit-Change-Number: 78883 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Sun, 19 Nov 2023 03:02:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream master
by Martin L Roth (Code Review) 19 Nov '23

19 Nov '23

Attention is currently required from: Lean Sheng Tan. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79004?usp=email ) Change subject: Update fsp submodule to upstream master ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > We want to hold this change until after 2023_11_17, when the 4.22 release should be tagged. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79004?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9fe65d830061c93ceac549dc7f41e7a98646a0a3 Gerrit-Change-Number: 79004 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Sun, 19 Nov 2023 03:01:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/abuild: Better identify config string in log
by Martin L Roth (Code Review) 19 Nov '23

19 Nov '23

Attention is currently required from: Felix Singer, Keith Hui, Martin L Roth. Hello Felix Singer, Keith Hui, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76936?usp=email to look at the new patch set (#4). Change subject: util/abuild: Better identify config string in log ...................................................................... util/abuild: Better identify config string in log When using the --skip_set and --skip_unset arguments, the config line looked like a statement that the build was being skipped instead of abuild just printing the configuration. This updates those config statements to better show that it's the config and not stating that this particular build is being skipped. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I6cc59f9b33dcda51aeb3640d449037a0aa054e36 --- M util/abuild/abuild 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/76936/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/76936?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6cc59f9b33dcda51aeb3640d449037a0aa054e36 Gerrit-Change-Number: 76936 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: Docs/releases: Finalize 4.22 release notes
by Martin L Roth (Code Review) 19 Nov '23

19 Nov '23

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79147?usp=email ) Change subject: Docs/releases: Finalize 4.22 release notes ...................................................................... Docs/releases: Finalize 4.22 release notes Now that the 4.22 release tag has been added to git, update the release notes with the final statistics and wording. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iae9653a275fcc1d11efbb88e12676f332be0a5dc --- M Documentation/releases/coreboot-4.22-relnotes.md 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/79147/1 diff --git a/Documentation/releases/coreboot-4.22-relnotes.md b/Documentation/releases/coreboot-4.22-relnotes.md index e32607a..52042af 100644 --- a/Documentation/releases/coreboot-4.22-relnotes.md +++ b/Documentation/releases/coreboot-4.22-relnotes.md @@ -1,4 +1,4 @@ -Upcoming release - coreboot 4.22 +coreboot 4.22 ======================================================================== The next release is planned for mid-February, 2024 @@ -235,15 +235,15 @@ Statistics from the 4.21 to the 4.22 release -------------------------------------------- -* Total Commits: 885 -* Average Commits per day: 10.72 -* Total lines added: 58276 -* Average lines added per commit: 65.85 -* Number of patches adding more than 100 lines: 54 -* Average lines added per small commit: 37.77 -* Total lines removed: 27790 -* Average lines removed per commit: 31.40 -* Total difference between added and removed: 30486 +* Total Commits: 977 +* Average Commits per day: 10.98 +* Total lines added: 62993 +* Average lines added per commit: 64.48 +* Number of patches adding more than 100 lines: 60 +* Average lines added per small commit: 37.55 +* Total lines removed: 30042 +* Average lines removed per commit: 30.75 +* Total difference between added and removed: 32951 * Total authors: 135 * New authors: 14 -- To view, visit https://review.coreboot.org/c/coreboot/+/79147?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae9653a275fcc1d11efbb88e12676f332be0a5dc Gerrit-Change-Number: 79147 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: drivers/ipmi to lib: Fix misspellings & capitalization issues
by Martin L Roth (Code Review) 19 Nov '23

19 Nov '23

Attention is currently required from: Alexander Couzens, Christian Walter, Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77637?usp=email ) Change subject: drivers/ipmi to lib: Fix misspellings & capitalization issues ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/77637/comment/44d8eeab_354f822b : PS1, Line 8: > It’d be great, if you added the tool you used. I use an editor, that's all. There's no special tool. I open the file and words that aren't in the dictionary are highlighted. I look at those and fix them, ignore them, or add them to the dictionary. -- To view, visit https://review.coreboot.org/c/coreboot/+/77637?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I926ec4c1c00339209ef656995031026935e52558 Gerrit-Change-Number: 77637 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 19 Nov 2023 02:54:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: acpi: Move EINJ code to vendorcode/ocp
by Martin L Roth (Code Review) 19 Nov '23

19 Nov '23

Attention is currently required from: Arthur Heymans, Jonathan Zhang, Lance Zhao, Rocky Phagura, Tim Wawrzynczak. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77416?usp=email ) Change subject: acpi: Move EINJ code to vendorcode/ocp ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/77416/comment/1b9e784f_e6ddbd8f : PS3, Line 7: acpi: Move EINJ code to vendorcode/ocp > So some technical insight. The code in acpi. […] They *could* stay, but there's no reason to keep them if we're moving everything else out. We wouldn't implement header files for random tables that weren't actually implemented in coreboot, so I'd argue these shouldn't be left in the main ACPI header file. Unrelated to this patch, I'd actually like to split up the main acpi.h file into the separate tables. It's gotten too large IMO. File src/include/acpi/acpi.h: https://review.coreboot.org/c/coreboot/+/77416/comment/acd74d24_821f38b7 : PS3, Line 78: EINJ > should we keep this here ? Yes, that must remain. It's just a value in an enum though, so it doesn't do anything if it's not used. -- To view, visit https://review.coreboot.org/c/coreboot/+/77416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e91b0730cf3fcef0c54c513181c973bfe18bacf Gerrit-Change-Number: 77416 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Rocky Phagura <rphagura(a)fb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 19 Nov 2023 02:52:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: arch/arm64: Extend cache helper functions
by David Milosevic (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Angel Pons, Benjamin Doron, Julius Werner. David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79106?usp=email ) Change subject: arch/arm64: Extend cache helper functions ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79106/comment/aaa6642e_671ff7cd : PS4, Line 12: Furthermore, static functions were grouped and moved to the top and : non-static functions to the bottom, in order to provide a better : structure to the file. > Please don't. […] Done File src/arch/arm64/armv8/cache.c: https://review.coreboot.org/c/coreboot/+/79106/comment/edeb9257_93de9ce5 : PS4, Line 14: enum dcache_op { : OP_DCCSW, : OP_DCCISW, : OP_DCISW, : OP_DCCIVAC, : OP_DCCVAC, : OP_DCIVAC, : }; > What benefit does moving this enum away from the `dcache_op_va()` function provide? Done https://review.coreboot.org/c/coreboot/+/79106/comment/f8610024_613a9205 : PS4, Line 113: enum cache_type cpu_get_cache_type(enum cache_level level) : { : uint32_t ctype_bitshift = (level - 1) * 3; : : if (level < CACHE_L1 || level > CACHE_L7) : return NO_CACHE; : : /* 3-bits per cache-level */ : return (raw_read_clidr_el1() >> ctype_bitshift) & 0x7; : } > Unless you have to, please avoid moving functions around. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79106?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de Gerrit-Change-Number: 79106 Gerrit-PatchSet: 5 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 18 Nov 2023 20:23:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: arch/arm64: Extend cache helper functions
by David Milosevic (Code Review) 18 Nov '23

18 Nov '23

Attention is currently required from: Benjamin Doron, David Milosevic, Julius Werner. Hello Benjamin Doron, Julius Werner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79106?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: arch/arm64: Extend cache helper functions ...................................................................... arch/arm64: Extend cache helper functions This patch extends the cpu_get_cache_info function, so that additional information like size of cache lines can be retrieved. Patch was tested against the qemu-sbsa mainboard. Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com> --- M src/arch/arm64/armv8/cache.c M src/arch/arm64/include/armv8/arch/cache.h 2 files changed, 52 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/79106/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/79106?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de Gerrit-Change-Number: 79106 Gerrit-PatchSet: 5 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023