October 2023 - coreboot-gerrit

[XS] Change in coreboot[main]: Update fsp submodule to upstream master branch
by Felix Singer (Code Review) Oct. 2, 2023

Oct. 2, 2023

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78189?usp=email ) Change subject: Update fsp submodule to upstream master branch ...................................................................... Update fsp submodule to upstream master branch Updating from commit id a72794810884 (2023-09-07): IoT ADL-N MR1 (4172_00) to commit id 481ea7cf0bae (2023-09-19): Move to RaptorLakeFspBinPkg.dec This brings in 9 new commits: 481ea7cf0b Move to RaptorLakeFspBinPkg.dec 55e25b819e Raptor Lake FSP C.1.BD.40 2b0aac4f64 Raptor Lake FSP C.0.BD.40 3fa75657aa Add Client Raptor Lake FSP 8d24189361 Add Alder Lake and Raptor Lake to README.md 98f4a1fe2f Rename to AlderlakeSiliconPkg c78a6784cb Add FvLateSilicon for Alder Lake 849ce8261b Tiger Lake FSP A.0.7E.70 4b0b1eb4e3 Update SplitFspBin.py to latest from edk2 Change-Id: I8a724bf0a03cba5a9689894e1aec0a81a5bf2c94 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78189 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Sean Rhodes: Looks good to me, approved Felix Singer: Looks good to me, approved Michał Żygowski: Looks good to me, approved diff --git a/3rdparty/fsp b/3rdparty/fsp index a727948..481ea7c 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit a72794810884966001c927a5f202a46eb5161488 +Subproject commit 481ea7cf0bae0107c3e14aa746e52657647142f3 -- To view, visit https://review.coreboot.org/c/coreboot/+/78189?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a724bf0a03cba5a9689894e1aec0a81a5bf2c94 Gerrit-Change-Number: 78189 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream master branch
by Felix Singer (Code Review) Oct. 2, 2023

Oct. 2, 2023

Attention is currently required from: Matt DeVillier, Nick Vaccaro, Subrata Banik. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78189?usp=email ) Change subject: Update fsp submodule to upstream master branch ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78189?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a724bf0a03cba5a9689894e1aec0a81a5bf2c94 Gerrit-Change-Number: 78189 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 02 Oct 2023 11:02:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Hook up FSP repo for RPL-P/S
by Sean Rhodes (Code Review) Oct. 2, 2023

Oct. 2, 2023

Attention is currently required from: Matt DeVillier, Nick Vaccaro, Subrata Banik. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78190?usp=email ) Change subject: soc/intel/alderlake: Hook up FSP repo for RPL-P/S ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida92d269fcaf6f323599ec174f4dcedbbe65f03c Gerrit-Change-Number: 78190 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 02 Oct 2023 10:46:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream master branch
by Sean Rhodes (Code Review) Oct. 2, 2023

Oct. 2, 2023

Attention is currently required from: Matt DeVillier, Nick Vaccaro, Subrata Banik. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78189?usp=email ) Change subject: Update fsp submodule to upstream master branch ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78189?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a724bf0a03cba5a9689894e1aec0a81a5bf2c94 Gerrit-Change-Number: 78189 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 02 Oct 2023 10:45:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream master branch
by Michał Żygowski (Code Review) Oct. 2, 2023

Oct. 2, 2023

Attention is currently required from: Matt DeVillier, Nick Vaccaro, Sean Rhodes, Subrata Banik. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78189?usp=email ) Change subject: Update fsp submodule to upstream master branch ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78189?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a724bf0a03cba5a9689894e1aec0a81a5bf2c94 Gerrit-Change-Number: 78189 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 02 Oct 2023 09:51:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Hook up FSP repo for RPL-P/S
by Michał Żygowski (Code Review) Oct. 2, 2023

Oct. 2, 2023

Attention is currently required from: Matt DeVillier, Nick Vaccaro, Sean Rhodes, Subrata Banik. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78190?usp=email ) Change subject: soc/intel/alderlake: Hook up FSP repo for RPL-P/S ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/alderlake/Kconfig: https://review.coreboot.org/c/coreboot/+/78190/comment/34155d37_52f480dd : PS1, Line 427: default "3rdparty/fsp/AlderLakeFspBinPkg/Client/AlderLakeS/Fsp.fd" if SOC_INTEL_ALDERLAKE_PCH_S Actually, this should not be needed anymore if RPL-S FSP is here. We could basically drop ADL-S FSP. -- To view, visit https://review.coreboot.org/c/coreboot/+/78190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida92d269fcaf6f323599ec174f4dcedbbe65f03c Gerrit-Change-Number: 78190 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 02 Oct 2023 09:48:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/geralt: Remove SAMSUNG_ATANA33XC20 panel support
by Yidi Lin (Code Review) Oct. 2, 2023

Oct. 2, 2023

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78210?usp=email ) Change subject: mb/google/geralt: Remove SAMSUNG_ATANA33XC20 panel support ...................................................................... mb/google/geralt: Remove SAMSUNG_ATANA33XC20 panel support This panel is never actually enabled on Geralt. The derived project won't use this panel neither. Therefore, remove this panel support. BUG=none BRANCH=none TEST=emerge-geralt coreboot Change-Id: I97ed5b341724ed42098b2c17d0eb75eab881dbb1 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/mainboard/google/geralt/panel_geralt.c 1 file changed, 0 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/78210/1 diff --git a/src/mainboard/google/geralt/panel_geralt.c b/src/mainboard/google/geralt/panel_geralt.c index 443703d..455f759 100644 --- a/src/mainboard/google/geralt/panel_geralt.c +++ b/src/mainboard/google/geralt/panel_geralt.c @@ -24,11 +24,6 @@ gpio_output(GPIO_MIPI_BL_PWM_1V8, 0); } -static void configure_edp_backlight(void) -{ - gpio_output(GPIO_AP_DISP_BKLTEN, 0); -} - static void power_on_mipi_boe_tv110c9m_ll0(void) { const struct tps65132s_reg_setting reg_settings[] = { @@ -61,13 +56,6 @@ mdelay(6); } -static void power_on_edp_samsung_atana33xc20(void) -{ - gpio_output(GPIO_EN_PP3300_EDP_DISP_X, 1); - gpio_set_pull(GPIO_EDP_HPD_1V8, GPIO_PULL_ENABLE, GPIO_PULL_UP); - gpio_set_mode(GPIO_EDP_HPD_1V8, 4); -} - static struct panel_description panels[] = { [1] = { .name = "BOE_TV110C9M_LL0", @@ -76,13 +64,6 @@ .disp_path = DISP_PATH_MIPI, .pwm_ctrl_gpio = true, }, - [11] = { - .name = "SAMSUNG_ATANA33XC20", - .power_on = power_on_edp_samsung_atana33xc20, - .configure_panel_backlight = configure_edp_backlight, - .disp_path = DISP_PATH_EDP, - .pwm_ctrl_gpio = false, - }, }; struct panel_description *get_panel_description(uint32_t panel_id) -- To view, visit https://review.coreboot.org/c/coreboot/+/78210?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I97ed5b341724ed42098b2c17d0eb75eab881dbb1 Gerrit-Change-Number: 78210 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: mb/google/geralt: Update voltage mapping tables for RAM ID and LCMD ID
by Yidi Lin (Code Review) Oct. 2, 2023

Oct. 2, 2023

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78209?usp=email ) Change subject: mb/google/geralt: Update voltage mapping tables for RAM ID and LCMD ID ...................................................................... mb/google/geralt: Update voltage mapping tables for RAM ID and LCMD ID The tolerance of ADC voltage table is too small. Update the table values accordring to the suggestion from the hardware team. The patch is prepared for the derived projects. There is no actual issue now. BRANCH=none BUG=b:301908091 TEST=check firmware screen Change-Id: I3bde30b6bbe79c81e276f23f4110715c3278d42c Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/mainboard/google/geralt/boardid.c 1 file changed, 15 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/78209/1 diff --git a/src/mainboard/google/geralt/boardid.c b/src/mainboard/google/geralt/boardid.c index 3a08c6d..460c26c 100644 --- a/src/mainboard/google/geralt/boardid.c +++ b/src/mainboard/google/geralt/boardid.c @@ -22,34 +22,26 @@ static const unsigned int ram_voltages[ADC_LEVELS] = { /* ID : Voltage (unit: uV) */ - [0] = 74300, - [1] = 211700, - [2] = 318800, - [3] = 428600, - [4] = 541700, - [5] = 665800, - [6] = 781400, - [7] = 900000, - [8] = 1023100, - [9] = 1137000, - [10] = 1240000, - [11] = 1342600, + [0] = 74296, + [1] = 211673, + [2] = 365055, + [3] = 524272, + [4] = 706302, + [5] = 899119, + [6] = 1108941, + [7] = 1342616, }; static const unsigned int panel_voltages[ADC_LEVELS] = { /* ID : Voltage (unit: uV) */ [0] = 0, - [1] = 283000, - [2] = 394000, - [3] = 503000, - [4] = 608000, - [5] = 712000, - [6] = 823000, - [7] = 937000, - [8] = 1046000, - [9] = 1155000, - [10] = 1277000, - [11] = 1434000, + [1] = 282774, + [2] = 472379, + [3] = 652542, + [4] = 830258, + [5] = 1011767, + [6] = 1209862, + [7] = 1427880, }; static const unsigned int *adc_voltages[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/78209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3bde30b6bbe79c81e276f23f4110715c3278d42c Gerrit-Change-Number: 78209 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Correct touchscreen GPIO settings
by Tyler Wang (Code Review) Oct. 2, 2023

Oct. 2, 2023

Tyler Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78208?usp=email ) Change subject: mb/google/rex/var/karis: Correct touchscreen GPIO settings ...................................................................... mb/google/rex/var/karis: Correct touchscreen GPIO settings Set GPP_C00, GPP_C01 to output high in ramstage. BUG=none TEST=(1) emerge-rex coreboot (2) Test on karis, touchscreen function works Change-Id: I1190016fbfb2aeb21bdbba334c8c25986435769f --- M src/mainboard/google/rex/variants/karis/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/78208/1 diff --git a/src/mainboard/google/rex/variants/karis/gpio.c b/src/mainboard/google/rex/variants/karis/gpio.c index 4e5eb68..5e64eee 100644 --- a/src/mainboard/google/rex/variants/karis/gpio.c +++ b/src/mainboard/google/rex/variants/karis/gpio.c @@ -96,9 +96,9 @@ PAD_NC(GPP_B23, NONE), /* GPP_C00 : [] ==> EN_TCHSCR_PWR */ - PAD_CFG_GPO(GPP_C00, 0, DEEP), + PAD_CFG_GPO(GPP_C00, 1, DEEP), /* GPP_C01 : [] ==> SOC_TCHSCR_RST_R_L */ - PAD_CFG_GPO(GPP_C01, 0, DEEP), + PAD_CFG_GPO(GPP_C01, 1, DEEP), /* GPP_C02 : SOC_TCHSCR_SPI_INT_STRAP ==> Component NC */ PAD_NC(GPP_C02, NONE), /* GPP_C03 : [] ==> Test pad. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/78208?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1190016fbfb2aeb21bdbba334c8c25986435769f Gerrit-Change-Number: 78208 Gerrit-PatchSet: 1 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/starmie: Add 3 ms delay to AW37503 Power IC panel timing
by Yidi Lin (Code Review) Oct. 2, 2023

Oct. 2, 2023

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu, cong yang. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78185?usp=email ) Change subject: mb/google/starmie: Add 3 ms delay to AW37503 Power IC panel timing ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78185?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I488c746d1fcfc165125b0ecccb0bccbb99231b00 Gerrit-Change-Number: 78185 Gerrit-PatchSet: 6 Gerrit-Owner: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 02 Oct 2023 08:31:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0