Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jakub Czapiga, Julius Werner, Nick Vaccaro, Nick Vaccaro, Yu-Ping Wu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78076?usp=email )
Change subject: {lib, ec/google}: Add weak implementation for get_lid_switch()
......................................................................
Patch Set 2:
(2 comments)
File src/ec/google/chromeec/switches.c:
https://review.coreboot.org/c/coreboot/+/78076/comment/40b67142_e0664fc8 :
PS1, Line 8: {
> Since this is now usually called twice in ramstage (once for lb_gpios and once by the GMA driver) it […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/78076/comment/cbad61e2_6371788b :
PS1, Line 9: if (!CONFIG(VBOOT_LID_SWITCH))
> > Oh, right because Chromeboxes still have ECs. Okay that makes sense. I wonder if we should flip it around though (or just make it `default y`). It seems cumbersome that every laptop mainboard needs to select this explicitly when 90% of our boards are laptops.
>
> that is valid point, ideally VBOOT_LID_SWITCH should be default y if VBOOT is enabled and then chromeboxes and bases can overrides that to N.
my initial understanding that only chromeos devices are using vboot and we should be enable VBOOT_LID_SWITCH enable by default. But looks like there are many board outside chromeos selects VBOOT but eventually doesn't wanted to keep VBOOT_LID_SWITCH default enable aka implement get_lid_status() API.
I have attempted CB:78207 which apparently much widespread than i originally thought.
--
To view, visit https://review.coreboot.org/c/coreboot/+/78076?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8847bc6f08f5d9cecf9d9ddaf33c44bd40491e98
Gerrit-Change-Number: 78076
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Sun, 01 Oct 2023 19:51:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jakub Czapiga, Julius Werner, Nick Vaccaro, Nick Vaccaro, Yu-Ping Wu.
Hello Boris Mittelberg, Caveh Jalali, Jakub Czapiga, Julius Werner, Nick Vaccaro, Nick Vaccaro, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78076?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Jakub Czapiga, Verified+1 by build bot (Jenkins)
Change subject: {lib, ec/google}: Add weak implementation for get_lid_switch()
......................................................................
{lib, ec/google}: Add weak implementation for get_lid_switch()
This patch implements a weak get_lid_switch() function that returns 1
(aka LID open) unless overridden by a real implementation.
This is necessary for platforms that do not have the
EC_GOOGLE_CHROMEEC_LPC config.
Additionally, this function is now getting called twice in ramstage
(once for lb_gpios and once by the GMA driver), so cached the response
from `get_lid_switch()` in a static local variable to avoid unnecessary
overhead.
BUG=b:299137940
TEST=Able to build and boot google/rex.
Change-Id: I8847bc6f08f5d9cecf9d9ddaf33c44bd40491e98
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/ec/google/chromeec/switches.c
M src/lib/bootmode.c
2 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/78076/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/78076?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8847bc6f08f5d9cecf9d9ddaf33c44bd40491e98
Gerrit-Change-Number: 78076
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eran Mitrani, Hung-Te Lin, Jakub Czapiga, Jason Nien, Julius Werner, Kapil Porwal, Martin Roth, Nick Vaccaro, Tarun, Yidi Lin, Yu-Ping Wu.
Hello Eran Mitrani, Hung-Te Lin, Jakub Czapiga, Jason Nien, Julius Werner, Kapil Porwal, Martin Roth, Nick Vaccaro, Tarun, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78207?usp=email
to look at the new patch set (#2).
Change subject: mb: Enable VBOOT_LID_SWITCH by default
......................................................................
mb: Enable VBOOT_LID_SWITCH by default
Remove mainboard-specific overrides to VBOOT_LID_SWITCH config.
VBOOT_LID_SWITCH is now enabled by default.
Platforms that wish to disable VBOOT_LID_SWITCH should override
the config from mainboard Kconfig.
TEST=Ensure VBOOT_LID_SWITCH is enabled for google/rex, but not
applicable for Ovis (aka Chromeosbox).
Change-Id: I922c04e0fa0675090cea7c7b3f4e2275eb70f523
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/mainboard/amd/birman/Kconfig
M src/mainboard/amd/chausie/Kconfig
M src/mainboard/amd/majolica/Kconfig
M src/mainboard/amd/mayan/Kconfig
M src/mainboard/clevo/kbl-u/Kconfig
M src/mainboard/emulation/qemu-i440fx/Kconfig
M src/mainboard/emulation/qemu-q35/Kconfig
M src/mainboard/facebook/fbg1701/Kconfig
M src/mainboard/facebook/monolith/Kconfig
M src/mainboard/google/asurada/Kconfig
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/beltino/Kconfig
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/cherry/Kconfig
M src/mainboard/google/corsola/Kconfig
M src/mainboard/google/cyan/Kconfig
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/drallion/Kconfig
M src/mainboard/google/eve/Kconfig
M src/mainboard/google/fizz/Kconfig
M src/mainboard/google/foster/Kconfig
M src/mainboard/google/gale/Kconfig
M src/mainboard/google/geralt/Kconfig
M src/mainboard/google/glados/Kconfig
M src/mainboard/google/gru/Kconfig
M src/mainboard/google/guybrush/Kconfig
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/herobrine/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/google/kahlee/Kconfig
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/link/Kconfig
M src/mainboard/google/mistral/Kconfig
M src/mainboard/google/myst/Kconfig
M src/mainboard/google/nyan/Kconfig
M src/mainboard/google/nyan_big/Kconfig
M src/mainboard/google/nyan_blaze/Kconfig
M src/mainboard/google/oak/Kconfig
M src/mainboard/google/octopus/Kconfig
M src/mainboard/google/parrot/Kconfig
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/puff/Kconfig
M src/mainboard/google/reef/Kconfig
M src/mainboard/google/rex/Kconfig
M src/mainboard/google/sarien/Kconfig
M src/mainboard/google/skyrim/Kconfig
M src/mainboard/google/slippy/Kconfig
M src/mainboard/google/smaug/Kconfig
M src/mainboard/google/storm/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/google/trogdor/Kconfig
M src/mainboard/google/veyron/Kconfig
M src/mainboard/google/veyron_mickey/Kconfig
M src/mainboard/google/veyron_rialto/Kconfig
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/zork/Kconfig
M src/mainboard/hp/z220_series/Kconfig
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/baskingridge/Kconfig
M src/mainboard/intel/coffeelake_rvp/Kconfig
M src/mainboard/intel/glkrvp/Kconfig
M src/mainboard/intel/jasperlake_rvp/Kconfig
M src/mainboard/intel/kblrvp/Kconfig
M src/mainboard/intel/kunimitsu/Kconfig
M src/mainboard/intel/mtlrvp/Kconfig
M src/mainboard/intel/shadowmountain/Kconfig
M src/mainboard/intel/strago/Kconfig
M src/mainboard/intel/tglrvp/Kconfig
M src/mainboard/intel/wtm2/Kconfig
M src/mainboard/lenovo/haswell/Kconfig
M src/mainboard/lenovo/t400/Kconfig
M src/mainboard/lenovo/t410/Kconfig
M src/mainboard/lenovo/t420s/Kconfig
M src/mainboard/lenovo/t430/Kconfig
M src/mainboard/lenovo/t430s/Kconfig
M src/mainboard/lenovo/t520/Kconfig
M src/mainboard/lenovo/t530/Kconfig
M src/mainboard/lenovo/x131e/Kconfig
M src/mainboard/lenovo/x1_carbon_gen1/Kconfig
M src/mainboard/lenovo/x200/Kconfig
M src/mainboard/lenovo/x201/Kconfig
M src/mainboard/lenovo/x220/Kconfig
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/lenovo/x60/Kconfig
M src/mainboard/msi/ms7d25/Kconfig
M src/mainboard/msi/ms7e06/Kconfig
M src/mainboard/opencellular/elgon/Kconfig
M src/mainboard/protectli/vault_cml/Kconfig
M src/mainboard/protectli/vault_ehl/Kconfig
M src/mainboard/samsung/lumpy/Kconfig
M src/mainboard/samsung/stumpy/Kconfig
M src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig
M src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig
M src/mainboard/siemens/mc_apl1/variants/mc_apl5/Kconfig
M src/mainboard/siemens/mc_apl1/variants/mc_apl6/Kconfig
M src/mainboard/starlabs/lite/Kconfig
M src/mainboard/starlabs/starbook/Kconfig
M src/mainboard/supermicro/x11-lga1151-series/Kconfig
M src/mainboard/up/squared/Kconfig
M src/security/vboot/Kconfig
101 files changed, 210 insertions(+), 38 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/78207/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78207?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I922c04e0fa0675090cea7c7b3f4e2275eb70f523
Gerrit-Change-Number: 78207
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78194?usp=email )
Change subject: cpu/intel/model_206ax: Only use supported C-states
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78194/comment/6bf28020_4d08048a :
PS1, Line 9: Make sure that the C-state is supported by the CPU.
: Downgrade if it's not and make sure to not advertise
: duplicate states.
> Would be less lines, if you used 72 characters per line.
Done
File src/cpu/intel/model_206ax/acpi.c:
https://review.coreboot.org/c/coreboot/+/78194/comment/13a86f47_92766dbd :
PS1, Line 110: BIOS_DEBUG
> Should this be info?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/78194?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaaee050e0ce3c29c12e97f5819a29f485a7946c2
Gerrit-Change-Number: 78194
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 01 Oct 2023 07:01:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78133?usp=email )
Change subject: cpu/intel/model_206ax: Print supported C-states
......................................................................
Patch Set 5:
(1 comment)
File src/arch/x86/cpu_common.c:
https://review.coreboot.org/c/coreboot/+/78133/comment/ac2a17ac_6ee9fd10 :
PS4, Line 198: cpuid_eax(0)
> cpuid_get_max_func() can be used instead of cpuid_eax(0)
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/78133?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I713712a1a104714cbf3091782e564e7e784cf21d
Gerrit-Change-Number: 78133
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 01 Oct 2023 07:00:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78192?usp=email )
Change subject: x86/include/arch/cpuid.h: Fix inline assembly
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78192/comment/9e90d023_4782e688 :
PS1, Line 12: prevent
> prevents
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/78192?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5dc0bb620184a355716b9c8d4206d55554b41ab9
Gerrit-Change-Number: 78192
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 01 Oct 2023 07:00:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Paul Menzel.
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78194?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Paul Menzel, Verified+1 by build bot (Jenkins)
Change subject: cpu/intel/model_206ax: Only use supported C-states
......................................................................
cpu/intel/model_206ax: Only use supported C-states
When advertising C-state using the ACPI _CST object, make sure
to only advertise those that are supported by the CPU.
Downgrade if it's not and make sure to not advertise duplicate
states.
Add debug prints for the finally selected mapping of ACPI
C-state vs Intel CPU C-state.
Test: Tested on Lenovo X220.
All C-states are still advertised as all are supported.
Change-Id: Iaaee050e0ce3c29c12e97f5819a29f485a7946c2
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/cpu/intel/model_206ax/acpi.c
1 file changed, 57 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/78194/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78194?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaaee050e0ce3c29c12e97f5819a29f485a7946c2
Gerrit-Change-Number: 78194
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Rudolph, Paul Menzel.
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78193?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Paul Menzel, Verified+1 by build bot (Jenkins)
Change subject: cpu/intel/model_206ax: Use haswell cstate_map
......................................................................
cpu/intel/model_206ax: Use haswell cstate_map
Make the code look like on newer platforms. This doesn't change
functionality.
Test: Lenovo X220 still boots and advertises all C-states as
before.
Change-Id: Ie7076d11720d55a4ac11318cbbdab9f75d08e15e
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/cpu/intel/model_206ax/acpi.c
M src/cpu/intel/model_206ax/model_206ax.h
2 files changed, 37 insertions(+), 50 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/78193/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78193?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7076d11720d55a4ac11318cbbdab9f75d08e15e
Gerrit-Change-Number: 78193
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Rudolph.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78133?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: cpu/intel/model_206ax: Print supported C-states
......................................................................
cpu/intel/model_206ax: Print supported C-states
According to the BWG C-states are processor specific
and BIOS must check if a C-state is supported at all.
Print the supported C-states in generate_C_state_entries().
Test: Tested on Lenovo X220 using Intel i5-2540M.
All C-states are reported as supported.
Change-Id: I713712a1a104714cbf3091782e564e7e784cf21d
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/arch/x86/cpu_common.c
M src/arch/x86/include/arch/cpu.h
M src/cpu/intel/model_206ax/acpi.c
3 files changed, 47 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/78133/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/78133?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I713712a1a104714cbf3091782e564e7e784cf21d
Gerrit-Change-Number: 78133
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newpatchset