October 2023 - coreboot-gerrit

[XS] Change in coreboot[main]: mb/starlabs: Set POWER_STATE_OFF_AFTER_FAILURE
by Sean Rhodes (Code Review) Oct. 2, 2023

Oct. 2, 2023

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78223?usp=email ) Change subject: mb/starlabs: Set POWER_STATE_OFF_AFTER_FAILURE ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78223?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d06047fe23322520e9c84ded8f1941f6d716a51 Gerrit-Change-Number: 78223 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 02 Oct 2023 20:18:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl: Enable PchHdaSdiEnable
by Sean Rhodes (Code Review) Oct. 2, 2023

Oct. 2, 2023

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78201?usp=email ) Change subject: mb/starlabs/starbook/adl: Enable PchHdaSdiEnable ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78201?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5fd3617c4cb1e69b7e0ecf6cddf4c143da99b927 Gerrit-Change-Number: 78201 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 02 Oct 2023 20:17:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook: Include ACPI for GNA scoring accelerator
by Sean Rhodes (Code Review) Oct. 2, 2023

Oct. 2, 2023

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78202?usp=email ) Change subject: mb/starlabs/starbook: Include ACPI for GNA scoring accelerator ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78202?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id42d07aabfd08c6c7a38515f9cf4b749750deecd Gerrit-Change-Number: 78202 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 02 Oct 2023 20:17:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/{adl,rpl}: Disable GpioOverride
by Sean Rhodes (Code Review) Oct. 2, 2023

Oct. 2, 2023

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78199?usp=email ) Change subject: mb/starlabs/starbook/{adl,rpl}: Disable GpioOverride ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78199?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf8d2112a1c44064af73bb54fd3e1a1a429e0649 Gerrit-Change-Number: 78199 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 02 Oct 2023 20:14:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/{adl,rpl}: Remove unnecessary entries
by Sean Rhodes (Code Review) Oct. 2, 2023

Oct. 2, 2023

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78198?usp=email ) Change subject: mb/starlabs/starbook/{adl,rpl}: Remove unnecessary entries ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78198?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I929af0bed6c2e1024b4787424a8fe466edce5a36 Gerrit-Change-Number: 78198 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 02 Oct 2023 20:14:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/{adl,rpl}: Enable the CNVi device
by Sean Rhodes (Code Review) Oct. 2, 2023

Oct. 2, 2023

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78197?usp=email ) Change subject: mb/starlabs/starbook/{adl,rpl}: Enable the CNVi device ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1b0052b569b575fec7893322dec0280c9f1ed79f Gerrit-Change-Number: 78197 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 02 Oct 2023 20:14:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[NoOp] Change in coreboot[main]: mb/starlabs/starbook/rpl: Update the VBT to 251
by Sean Rhodes (Code Review) Oct. 2, 2023

Oct. 2, 2023

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78196?usp=email ) Change subject: mb/starlabs/starbook/rpl: Update the VBT to 251 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78196?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36bb2cc92e744e761ec6af9c026c429373c1750a Gerrit-Change-Number: 78196 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 02 Oct 2023 20:14:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin: Update the Q Events
by Sean Rhodes (Code Review) Oct. 2, 2023

Oct. 2, 2023

Attention is currently required from: Sean Rhodes. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77405?usp=email ) Change subject: ec/starlabs/merlin: Update the Q Events ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/77405?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3300be5254549fe5cd3b3490d9191240c6d36b6e Gerrit-Change-Number: 77405 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 02 Oct 2023 20:14:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: {commonlib, libpayload}: Add "is external display" in coreboot table
by Subrata Banik (Code Review) Oct. 2, 2023

Oct. 2, 2023

Attention is currently required from: Andrey Petrov, Arthur Heymans, Julius Werner, Nick Vaccaro, Subrata Banik, Yu-Ping Wu. Hello Andrey Petrov, Arthur Heymans, Julius Werner, Nick Vaccaro, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/77796?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: {commonlib, libpayload}: Add "is_external display" in coreboot table ...................................................................... {commonlib, libpayload}: Add "is_external display" in coreboot table This patch introduces a new coreboot table entry named "is_external_display" to understand if external display is attached. This information is useful to prevent graceful shutdown by payload when the LID is closed but an external display is present. This piece of the information will be gathered by coreboot and passed into the payload using this new entry aka external_display because payload (i.e., deptcharge) doesn't have any other way to determine if external display is available. BUG=b:299137940 TEST=Able to build and boot google/rex. w/o this patch: LID closed and external display attached (HDMI) in developer mode (GBB 0x39): > System is powered off by depthcharge w/ this patch: LID closed and external display attached (HDMI) in developer mode (GBB 0x39): > Booted to OS and device is alive/usable Change-Id: I0fa7eee4c5a50371a7a66c6ca1ac2c7d046d010b Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M payloads/libpayload/include/coreboot_tables.h M src/commonlib/include/commonlib/coreboot_tables.h M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/graphics.c M src/drivers/intel/fsp2_0/include/fsp/graphics.h 5 files changed, 48 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/77796/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/77796?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0fa7eee4c5a50371a7a66c6ca1ac2c7d046d010b Gerrit-Change-Number: 77796 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: soc/intel/cmn/gfx: Add API to report presence of external display
by Subrata Banik (Code Review) Oct. 2, 2023

Oct. 2, 2023

Attention is currently required from: Arthur Heymans, Julius Werner, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Werner Zeh. Hello Arthur Heymans, Julius Werner, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Werner Zeh, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78080?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/cmn/gfx: Add API to report presence of external display ...................................................................... soc/intel/cmn/gfx: Add API to report presence of external display This patch implements an API to report the presence of an external display on Intel silicon. The API uses information from the transcoder and framebuffer to determine if an external display is connected. For example, if the transcoder is attached to any DDI ports other than DDI-A (eDP), and the framebuffer is initialized, then it is likely that an external display is present. This information can be used by payloads to determine whether or not to power on the display, even if eDP is not initialized. BUG=b:299137940 TEST=Build and boot google/rex Scenarios: Booting with eDP alone: is_external_display value is 0 Booting with eDP + HDMI: is_external_display value is 0 Booting with HDMI alone: is_external_display value is 1 Booting with USB-C display alone: is_external_display value is 1 Change-Id: I77436940978c7fa9368d79394b46a5e794c32e42 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/common/block/graphics/graphics.c 1 file changed, 51 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/78080/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78080?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77436940978c7fa9368d79394b46a5e794c32e42 Gerrit-Change-Number: 78080 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newpatchset

1 0