coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[M] Change in coreboot[master]: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown
by Eric Lai (Code Review) 03 Jan '23

03 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Derek Huang, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 ) Change subject: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown ...................................................................... Patch Set 11: (1 comment) File src/mainboard/google/brya/mainboard.c: https://review.coreboot.org/c/coreboot/+/70773/comment/1d38e83a_3ac0a2e3 PS11, Line 219: if (CONFIG(CR50_RESET_CLEAR_EC_AP_IDLE_FLAG)) { > suggestion: […] I think you can add in here https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thi… , this can benefit for the future project. -- To view, visit https://review.coreboot.org/c/coreboot/+/70773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Gerrit-Change-Number: 70773 Gerrit-PatchSet: 11 Gerrit-Owner: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 03 Jan 2023 05:02:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/kano: Set the ov2740 to 0 and the hi556 to 1 for SSFC
by David Wu (Code Review) 03 Jan '23

03 Jan '23

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71628 ) Change subject: mb/google/brya/var/kano: Set the ov2740 to 0 and the hi556 to 1 for SSFC ...................................................................... mb/google/brya/var/kano: Set the ov2740 to 0 and the hi556 to 1 for SSFC When EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG is enabled and SSFC is not set, it will treat missing SSFC as zero, so Kano needs to set the ov2740 to 0 to avoid probing wrong mipi camera. Before patch >fw_config match found: UFC=UFC_MIPI_OVTI2740 >fw_config match found: AUDIO=MAX98373_NAU88L25B_I2S >fw_config match found: AUDIO=MAX98373_NAU88L25B_I2S >fw_config match found: AUDIO=MAX98373_NAU88L25B_I2S >fw_config match found: UFC=UFC_MIPI_OVTI2740 >fw_config match found: ZYDRON_UFC=UFC_MIPI_HI556 >fw_config match found: UFC=UFC_MIPI_OVTI2740 >fw_config match found: STYLUS=STYLUS_PRESENT After patch >fw_config match found: UFC=UFC_MIPI_OVTI2740 >fw_config match found: AUDIO=MAX98373_NAU88L25B_I2S >fw_config match found: AUDIO=MAX98373_NAU88L25B_I2S >fw_config match found: AUDIO=MAX98373_NAU88L25B_I2S >fw_config match found: UFC=UFC_MIPI_OVTI2740 >I2C: 00:20 disabled by fw_config >fw_config match found: UFC=UFC_MIPI_OVTI2740 >fw_config match found: STYLUS=STYLUS_PRESENT BUG=b:262939431 TEST=Boot on kano and check functional with ov2740 camera. Change-Id: I46fac6c820d6006956680a07198db82225630905 Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/kano/overridetree.cb 1 file changed, 39 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/71628/1 diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb index b45fbf7..f1fe5e7 100644 --- a/src/mainboard/google/brya/variants/kano/overridetree.cb +++ b/src/mainboard/google/brya/variants/kano/overridetree.cb @@ -17,8 +17,8 @@ option STYLUS_PRESENT 1 end field ZYDRON_UFC 36 37 - option UFC_MIPI_HI556 0 - option UFC_MIPI_OVTI2740 1 + option UFC_MIPI_OVTI2740 0 + option UFC_MIPI_HI556 1 end end chip soc/intel/alderlake -- To view, visit https://review.coreboot.org/c/coreboot/+/71628 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46fac6c820d6006956680a07198db82225630905 Gerrit-Change-Number: 71628 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown
by Subrata Banik (Code Review) 03 Jan '23

03 Jan '23

Attention is currently required from: Tarun Tuli, Derek Huang, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Eric Lai, Boris Mittelberg. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 ) Change subject: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown ...................................................................... Patch Set 11: (4 comments) File src/mainboard/google/brya/mainboard.c: https://review.coreboot.org/c/coreboot/+/70773/comment/2058e2f1_b1706eb8 PS11, Line 16: #include <ec/google/chromeec/ec.h> nit: consider alphabetic order please https://review.coreboot.org/c/coreboot/+/70773/comment/99a85533_75a29c00 PS11, Line 217: __weak i don't think you need the `weak` implementation anymore now. https://review.coreboot.org/c/coreboot/+/70773/comment/0507cddf_5abd53b8 PS11, Line 219: if (CONFIG(CR50_RESET_CLEAR_EC_AP_IDLE_FLAG)) { suggestion: ``` if (!CONFIG(CR50_RESET_CLEAR_EC_AP_IDLE_FLAG)) return; /* Send EC command to clear AP_IDLE flag */ if (!google_chromeec_reboot(0, EC_REBOOT_NO_OP, EC_REBOOT_FLAG_CLEAR_AP_IDLE | EC_REBOOT_FLAG_ON_AP_SHUTDOWN)) printk(BIOS_INFO, "Successfully clear AP_IDLE flag"); else printk(BIOS_ERR, "Failed to clear EC AP_IDLE flag"); ``` File src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h: https://review.coreboot.org/c/coreboot/+/70773/comment/17008e46_dd5a0aa5 PS11, Line 28: variant_prepare_cr50_reset mainboard_prepare_cr50_reset -- To view, visit https://review.coreboot.org/c/coreboot/+/70773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Gerrit-Change-Number: 70773 Gerrit-PatchSet: 11 Gerrit-Owner: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 03 Jan 2023 04:22:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown
by Derek Huang (Code Review) 03 Jan '23

03 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Eric Lai, Boris Mittelberg. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 ) Change subject: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown ...................................................................... Patch Set 11: (1 comment) Patchset: PS9: > if this is common request, it can add in cr50 code with Kconfig. Yes, it makes more sense. I have updated the CL, please review -- To view, visit https://review.coreboot.org/c/coreboot/+/70773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Gerrit-Change-Number: 70773 Gerrit-PatchSet: 11 Gerrit-Owner: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 03 Jan 2023 04:16:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: Move ME spec structure to its header file
by Dinesh Gehlot (Code Review) 03 Jan '23

03 Jan '23

Dinesh Gehlot has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71627 ) Change subject: soc/intel/meteorlake: Move ME spec structure to its header file ...................................................................... soc/intel/meteorlake: Move ME spec structure to its header file This patch moves ME host firmware status register structure to ME header file. It also marks unused structure fields to reserved. BUG=b:260309647 Test=Able to build and boot Google/rex Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Ib3dafd6c030c0c848aa82b03bb336cc8fad14de3 --- M src/soc/intel/meteorlake/include/soc/me.h M src/soc/intel/meteorlake/me.c 2 files changed, 80 insertions(+), 98 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/71627/1 diff --git a/src/soc/intel/meteorlake/include/soc/me.h b/src/soc/intel/meteorlake/include/soc/me.h index 17cf5cd..58f9052 100644 --- a/src/soc/intel/meteorlake/include/soc/me.h +++ b/src/soc/intel/meteorlake/include/soc/me.h @@ -3,43 +3,79 @@ #ifndef _METEORLAKE_ME_H_ #define _METEORLAKE_ME_H_ -#include <stdint.h> - /* ME Host Firmware Status register 1 */ union me_hfsts1 { - u32 data; + uint32_t data; struct { - u32 working_state: 4; - u32 mfg_mode: 1; - u32 fpt_bad: 1; - u32 operation_state: 3; - u32 fw_init_complete: 1; - u32 ft_bup_ld_flr: 1; - u32 update_in_progress: 1; - u32 error_code: 4; - u32 operation_mode: 4; - u32 reset_count: 4; - u32 boot_options_present: 1; - u32 invoke_enhance_dbg_mode: 1; - u32 bist_test_state: 1; - u32 bist_reset_request: 1; - u32 current_power_source: 2; - u32 reserved: 1; - u32 d0i3_support_valid: 1; + uint32_t working_state : 4; + uint32_t mfg_mode : 1; + uint32_t fpt_bad : 1; + uint32_t operation_state : 3; + uint32_t fw_init_complete : 1; + uint32_t ft_bup_ld_flr : 1; + uint32_t update_in_progress : 1; + uint32_t error_code : 4; + uint32_t operation_mode : 4; + uint32_t reserved_0 : 4; + uint32_t boot_options_present : 1; + uint32_t invoke_enhance_dbg_mode: 1; + uint32_t reserved_1 : 5; + uint32_t d0i3_support_valid : 1; + } __packed fields; +}; + +/* Host Firmware Status Register 2 */ +union me_hfsts2 { + uint32_t data; + struct { + uint32_t reserved_0 : 4; + uint32_t cpu_replaced : 1; + uint32_t reserved_1 : 3; + uint32_t cpu_replaced_valid : 1; + uint32_t low_power_state : 1; + uint32_t reserved_2 : 22; } __packed fields; }; /* ME Host Firmware Status Register 3 */ union me_hfsts3 { - u32 data; + uint32_t data; struct { - u32 reserved_0: 4; - u32 fw_sku: 3; - u32 reserved_7: 2; - u32 reserved_9: 2; - u32 resered_11: 3; - u32 resered_14: 16; - u32 reserved_30: 2; + uint32_t reserved_0 : 4; + uint32_t fw_sku : 3; + uint32_t reserved_1 : 25; + } __packed fields; +}; + +/* Host Firmware Status Register 4 */ +union me_hfsts4 { + uint32_t data; + struct { + uint32_t rsvd0; + } __packed fields; +}; + +/* Host Firmware Status Register 5 */ +union me_hfsts5 { + uint32_t data; + struct { + uint32_t reserved_0 : 17; + uint32_t txt_support : 1; + uint32_t reserved_1 : 3; + uint32_t cpu_debug_disabled : 1; + uint32_t reserved_2 : 10; + } __packed fields; +}; + +/* Host Firmware Status Register 6 */ +union me_hfsts6 { + uint32_t data; + struct { + uint32_t reserved_0 : 21; + uint32_t manuf_lock : 1; + uint32_t reserved_1 : 8; + uint32_t fpf_soc_lock : 1; + uint32_t reserved_2 : 1; } __packed fields; }; #endif diff --git a/src/soc/intel/meteorlake/me.c b/src/soc/intel/meteorlake/me.c index 265fd36..815cb0d 100644 --- a/src/soc/intel/meteorlake/me.c +++ b/src/soc/intel/meteorlake/me.c @@ -6,76 +6,6 @@ #include <soc/me.h> #include <stdint.h> -/* Host Firmware Status Register 2 */ -union me_hfsts2 { - uint32_t data; - struct { - uint32_t nftp_load_failure : 1; - uint32_t icc_prog_status : 2; - uint32_t invoke_mebx : 1; - uint32_t cpu_replaced : 1; - uint32_t rsvd0 : 1; - uint32_t mfs_failure : 1; - uint32_t warm_reset_rqst : 1; - uint32_t cpu_replaced_valid : 1; - uint32_t low_power_state : 1; - uint32_t me_power_gate : 1; - uint32_t ipu_needed : 1; - uint32_t forced_safe_boot : 1; - uint32_t rsvd1 : 2; - uint32_t listener_change : 1; - uint32_t status_data : 8; - uint32_t current_pmevent : 4; - uint32_t phase : 4; - } __packed fields; -}; - -/* Host Firmware Status Register 4 */ -union me_hfsts4 { - uint32_t data; - struct { - uint32_t rsvd0 : 1; - uint32_t flash_log_exist : 1; - uint32_t rsvd1 : 30; - } __packed fields; -}; - -/* Host Firmware Status Register 5 */ -union me_hfsts5 { - uint32_t data; - struct { - uint32_t acm_active : 1; - uint32_t valid : 1; - uint32_t result_code_source : 1; - uint32_t error_status_code : 5; - uint32_t acm_done_sts : 1; - uint32_t timeout_count : 7; - uint32_t scrtm_indicator : 1; - uint32_t txt_support : 1; - uint32_t btg_profile : 3; - uint32_t cpu_debug_disabled : 1; - uint32_t bsp_init_disabled : 1; - /* BSP Boot Policy Manifest Execution Status */ - uint32_t bsp_bpm_exe_sts : 1; - uint32_t btg_token_applied : 1; - uint32_t btg_status : 4; - uint32_t rsvd0 : 2; - uint32_t start_enforcement : 1; - } __packed fields; -}; - -/* Host Firmware Status Register 6 */ -union me_hfsts6 { - uint32_t data; - struct { - uint32_t rsvd0 : 21; - uint32_t manuf_lock : 1; - uint32_t rsvd2 : 8; - uint32_t fpf_soc_lock : 1; - uint32_t sx_resume_type : 1; - } __packed fields; -}; - static bool is_manufacturing_mode(union me_hfsts1 hfsts1, union me_hfsts6 hfsts6) { /* -- To view, visit https://review.coreboot.org/c/coreboot/+/71627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3dafd6c030c0c848aa82b03bb336cc8fad14de3 Gerrit-Change-Number: 71627 Gerrit-PatchSet: 1 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/intel/alderlake: Move ME spec structure to its header file
by Dinesh Gehlot (Code Review) 03 Jan '23

03 Jan '23

Attention is currently required from: Tarun Tuli, Dinesh Gehlot. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71625 to look at the new patch set (#2). Change subject: soc/intel/alderlake: Move ME spec structure to its header file ...................................................................... soc/intel/alderlake: Move ME spec structure to its header file This patch moves ME host firmware status register structure to ME header file. It also marks unused structure fields to reserved. BUG=b:260309647 Test=Able to build and boot Google/brya. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Ic14305b0479a8c57531d9930946eded7ac518b09 --- M src/soc/intel/alderlake/include/soc/me.h M src/soc/intel/alderlake/me.c 2 files changed, 80 insertions(+), 107 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/71625/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71625 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic14305b0479a8c57531d9930946eded7ac518b09 Gerrit-Change-Number: 71625 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown
by Derek Huang (Code Review) 03 Jan '23

03 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Derek Huang, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg. Hello Tarun Tuli, Subrata Banik, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70773 to look at the new patch set (#11). Change subject: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown ...................................................................... src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown When AP boots up after Cr50 firmware update and reboot, AP finds that Cr50 reset is required for Cr50 to pick the new firmware so it trigger Cr50 reset and power off the system, AP expects system will power on automatically after Cr50 reset. However this is not the case for Chromebox, Chromebox EC set AP_IDLE flag when system is shutting down, when AP_IDLE flag is set in EC, the system stays at S5/G3 and wait for power button presssend. It cause an issue in factory that the operator needs to press power button to power on the DUT after Cr50 firmware update. This patch sends EC command to direct EC to clear AP_IDLE flag after AP shutdown so AP can boot up when Cr50 reset. BUG=b:261119366 BRANCH=firmware-brya-14505.B TEST=DUT boots up after Cr50 firmware update in factory test flow Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Signed-off-by: Derek Huang <derekhuang(a)google.com> --- M src/ec/google/chromeec/ec_commands.h M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h 4 files changed, 60 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/70773/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/70773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Gerrit-Change-Number: 70773 Gerrit-PatchSet: 11 Gerrit-Owner: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown
by build bot (Jenkins) (Code Review) 03 Jan '23

03 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Derek Huang, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 ) Change subject: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown ...................................................................... Patch Set 10: (1 comment) File src/mainboard/google/brya/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167514): https://review.coreboot.org/c/coreboot/+/70773/comment/9b6bebac_f886c892 PS10, Line 219: if(CONFIG(CR50_RESET_CLEAR_EC_AP_IDLE_FLAG)) { space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/70773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Gerrit-Change-Number: 70773 Gerrit-PatchSet: 10 Gerrit-Owner: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 03 Jan 2023 04:07:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown
by Derek Huang (Code Review) 03 Jan '23

03 Jan '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Derek Huang, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg. Hello Tarun Tuli, Subrata Banik, Caveh Jalali, Nick Vaccaro, Daisuke Nojiri, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70773 to look at the new patch set (#10). Change subject: src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown ...................................................................... src/mainboard/brya/: Clear EC AP_IDLE flag after shutdown When AP boots up after Cr50 firmware update and reboot, AP finds that Cr50 reset is required for Cr50 to pick the new firmware so it trigger Cr50 reset and power off the system, AP expects system will power on automatically after Cr50 reset. However this is not the case for Chromebox, Chromebox EC set AP_IDLE flag when system is shutting down, when AP_IDLE flag is set in EC, the system stays at S5/G3 and wait for power button presssend. It cause an issue in factory that the operator needs to press power button to power on the DUT after Cr50 firmware update. This patch sends EC command to direct EC to clear AP_IDLE flag after AP shutdown so AP can boot up when Cr50 reset. BUG=b:261119366 BRANCH=firmware-brya-14505.B TEST=DUT boots up after Cr50 firmware update in factory test flow Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Signed-off-by: Derek Huang <derekhuang(a)google.com> --- M src/ec/google/chromeec/ec_commands.h M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h 4 files changed, 60 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/70773/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/70773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b Gerrit-Change-Number: 70773 Gerrit-PatchSet: 10 Gerrit-Owner: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: [WIP] soc/amd: Change CPU ASL for p-states
by Kyösti Mälkki (Code Review) 03 Jan '23

03 Jan '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71614 ) Change subject: [WIP] soc/amd: Change CPU ASL for p-states ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71614/comment/4e70a8aa_5e899e01 PS1, Line 13: (SB900_)ACPI_IO_BASE named ACPI_CPU_CONTROL. https://review.coreboot.org/c/coreboot/+/53/1/src/southbridge/amd/cimx/sb90… File src/soc/amd/common/block/include/amdblocks/acpi.h: https://review.coreboot.org/c/coreboot/+/71614/comment/4da1af39_4495853a PS1, Line 20: #define MMIO_ACPI_GPE0_BLK 0x14 We have offsets 0x0c/0x14 here, 0x10/0x20 in IO space. Is this intentional? -- To view, visit https://review.coreboot.org/c/coreboot/+/71614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I886a40ea9d58da102fe21f5f0018ac22b562e1f5 Gerrit-Change-Number: 71614 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 03 Jan 2023 04:05:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023