Attention is currently required from: Wilson Chou, Marc Jones, Nico Huber, Ryback Hung, Johnny Lin, Tim Wawrzynczak, Shuming Chu (Shuming).
Hello build bot (Jenkins), Marc Jones, Jonathan Zhang, Ryback Hung, Johnny Lin, Shuming Chu (Shuming),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67264
to look at the new patch set (#3).
Change subject: device: Clear lane error status
......................................................................
device: Clear lane error status
Refer to PCI Express Base rev6.0 v1.0, 4.2.7 Link Training and Status
State Rules, Lane Error Status is normal to record the error when link
training. To make sure Lane Error Status is correct in OS runtime,
add a Kconfig PCIEXP_LANE_ERR_STAT_CLEAR that clears the PCIe lane error
status register at the end of PCIe link training.
Test=On Crater Lake, lspci -vvv shows
bb:01.0 PCI bridge: Intel Corporation Device 352a (rev 03)
(prog-if 00 [Normal decode])
Capabilities: [a30 v1] Secondary PCI Express
LnkCtl3: LnkEquIntrruptEn- PerformEqu-
LaneErrStat: LaneErr at lane: 0
Signed-off-by: Wilson Chou <Wilson.Chou(a)quantatw.com>
Change-Id: I6344223636409d8fc25e365a6375fc81e69f41a5
---
M src/device/Kconfig
M src/device/pciexp_device.c
M src/include/device/pci_def.h
3 files changed, 60 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/67264/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/67264
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6344223636409d8fc25e365a6375fc81e69f41a5
Gerrit-Change-Number: 67264
Gerrit-PatchSet: 3
Gerrit-Owner: Wilson Chou <wilson.chou%quantatw.com(a)gtempaccount.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Wilson Chou <wilson.chou%quantatw.com(a)gtempaccount.com>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Erik van den Bogaert, Jakub Czapiga, Frans Hendriks, Christian Walter, Julius Werner, Kangheui Won.
Hello Erik van den Bogaert, build bot (Jenkins), Frans Hendriks, Jakub Czapiga, Kangheui Won, Christian Walter, Yu-Ping Wu, Kangheui Won,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66561
to look at the new patch set (#6).
Change subject: cbfs/vboot: Adapt to new vb2_digest API
......................................................................
cbfs/vboot: Adapt to new vb2_digest API
CL:3825558 changes all vb2_digest and vb2_hash functions to take a new
hwcrypto_allowed argument, to potentially let them try to call the
vb2ex_hwcrypto API for hash calculation. This change will open hardware
crypto acceleration up to all hash calculations in coreboot (most
notably CBFS verification). As part of this change, the
vb2_digest_buffer() function has been removed, so replace existing
instances in coreboot with the newer vb2_hash_calculate() API.
Due to the circular dependency of these changes with vboot, this patch
also needs to update the vboot submodule:
Updating from commit id 18cb85b5:
2load_kernel.c: Expose load kernel as vb2_api
to commit id b827ddb9:
tests: Ensure auxfw sync runs after EC sync
This brings in 15 new commits.
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: I287d8dac3c49ad7ea3e18a015874ce8d610ec67e
---
M 3rdparty/vboot
M payloads/libpayload/include/cbfs_glue.h
M payloads/libpayload/libcbfs/cbfs.c
M src/commonlib/bsd/cbfs_private.c
M src/commonlib/bsd/include/commonlib/bsd/cbfs_private.h
M src/include/cbfs_glue.h
M src/lib/cbfs.c
M src/lib/metadata_hash.c
M src/security/tpm/tspi/tspi.c
M src/security/vboot/misc.h
M src/security/vboot/mrc_cache_hash_tpm.c
M src/security/vboot/tpm_common.c
M src/soc/intel/alderlake/hsphy.c
M src/soc/intel/common/block/cse/cse_lite.c
M src/vendorcode/eltan/security/mboot/mboot.c
M src/vendorcode/eltan/security/verified_boot/vboot_check.c
M tests/lib/cbfs-verification-test.c
M util/cbfstool/cbfs_glue.h
M util/cbfstool/cbfs_image.c
M util/cbfstool/cbfstool.c
M util/cbfstool/platform_fixups.c
21 files changed, 121 insertions(+), 83 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/66561/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/66561
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I287d8dac3c49ad7ea3e18a015874ce8d610ec67e
Gerrit-Change-Number: 66561
Gerrit-PatchSet: 6
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Kangheui Won <khwon(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Robert Zieba, Caveh Jalali, Selma Bensaid.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67265 )
Change subject: util/spd_tools: Update LP5X support for ADL/RPL/MTL
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67265
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iadb4688f1cb4265dab1dc7c242f0c301d5498b83
Gerrit-Change-Number: 67265
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Robert Zieba <robertzieba(a)google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 23:45:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Caveh Jalali.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67266 )
Change subject: util/spd_tools: Rebuild utils when source changes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67266
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4775fe0e00e0f5d4f8b4b47331d836aba53c0e69
Gerrit-Change-Number: 67266
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Sep 2022 23:36:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Thomas Heijligen.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67272 )
Change subject: util/docker/coreboot-jenkins-node: Install cmocka
......................................................................
Patch Set 3:
(1 comment)
File util/docker/coreboot-jenkins-node/Dockerfile:
https://review.coreboot.org/c/coreboot/+/67272/comment/a5238911_57b5a497
PS2, Line 27: libcmocka-dev \
> Nit: The list is in a alphabetic order.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/67272
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b
Gerrit-Change-Number: 67272
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Thu, 01 Sep 2022 23:31:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth.
Hello build bot (Jenkins), Patrick Georgi, Martin L Roth, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67272
to look at the new patch set (#3).
Change subject: util/docker/coreboot-jenkins-node: Install cmocka
......................................................................
util/docker/coreboot-jenkins-node: Install cmocka
coreboot and flashrom use cmocka for unit testing. Install it so that
the CI can use it.
Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/docker/coreboot-jenkins-node/Dockerfile
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/67272/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/67272
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b
Gerrit-Change-Number: 67272
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66916 )
Change subject: Documentation: Move devicetree documentation
......................................................................
Documentation: Move devicetree documentation
Move devicetree.md from acpi/ to getting_started/. The devicetree has
nothing to do with ACPI and getting_started has the most similar
information about coreboot.
Change-Id: I873b293f036a9e3bcdc98135386f9158c645513c
Signed-off-by: Marc Jones <marc(a)marcjonesconsulting.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66916
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
M Documentation/acpi/index.md
R Documentation/getting_started/devicetree.md
M Documentation/getting_started/index.md
3 files changed, 18 insertions(+), 4 deletions(-)
Approvals:
build bot (Jenkins): Verified
Stefan Reinauer: Looks good to me, approved
diff --git a/Documentation/acpi/index.md b/Documentation/acpi/index.md
index 2f65e29..20e8319 100644
--- a/Documentation/acpi/index.md
+++ b/Documentation/acpi/index.md
@@ -10,7 +10,3 @@
## GPIO
- [GPIO toggling in ACPI AML](gpio.md)
-
-## devicetree
-
-- [Adding devices to a device tree](devicetree.md)
diff --git a/Documentation/acpi/devicetree.md b/Documentation/getting_started/devicetree.md
similarity index 100%
rename from Documentation/acpi/devicetree.md
rename to Documentation/getting_started/devicetree.md
diff --git a/Documentation/getting_started/index.md b/Documentation/getting_started/index.md
index cbdf606..becb6af 100644
--- a/Documentation/getting_started/index.md
+++ b/Documentation/getting_started/index.md
@@ -6,3 +6,4 @@
* [Kconfig](kconfig.md)
* [Writing Documentation](writing_documentation.md)
* [Setting up GPIOs](gpio.md)
+* [Adding devices to a device tree](devicetree.md)
--
To view, visit https://review.coreboot.org/c/coreboot/+/66916
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I873b293f036a9e3bcdc98135386f9158c645513c
Gerrit-Change-Number: 66916
Gerrit-PatchSet: 4
Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Fred Reitberger.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67300 )
Change subject: lib/xxhash.c: Add new hash functions
......................................................................
Patch Set 1:
(3 comments)
File src/lib/xxhash.c:
https://review.coreboot.org/c/coreboot/+/67300/comment/064c348a_a09e39a5
PS1, Line 7: * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php)
Don't need the full text here, that's what the SPDX tag is for.
https://review.coreboot.org/c/coreboot/+/67300/comment/2110c54e_5a8f247d
PS1, Line 57: #endif
unused?
https://review.coreboot.org/c/coreboot/+/67300/comment/3eda7c62_ec47d2a7
PS1, Line 90: if (IS_ALIGNED(up, 4)) {
I don't think you want to do this, it's gonna kill your performance. The kernel code is designed (I think) to collapse to nothing on platforms that support unaligned accesses, but what you're doing here does not. Also, you are not actually honoring the le32 part in the aligned case here (remember we do have ppc64).
coreboot platforms always allow unaligned accesses, so I think you can just use le32toh()/le64toh() for these.
--
To view, visit https://review.coreboot.org/c/coreboot/+/67300
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8108af5ab14d8e6c6f5859bd36155c7d254e892c
Gerrit-Change-Number: 67300
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 23:13:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment