coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[M] Change in coreboot[master]: soc/amd/*: Put code about PSP FW into common Makefile.inc
by Bao Zheng (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Zheng Bao. Hello Zheng Bao, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/67325 to review the following change. Change subject: soc/amd/*: Put code about PSP FW into common Makefile.inc ...................................................................... soc/amd/*: Put code about PSP FW into common Makefile.inc Change the variable XXXX_FWM_POSITION to a generic name AMD_SOC_FWM_POSITION. Put it with definitions of A/B FW position to common Makefile.inc. Change-Id: I13aa83f57daf24e16ea1900b9920843a3f9b0337 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M src/soc/amd/cezanne/Makefile.inc M src/soc/amd/common/Makefile.inc M src/soc/amd/mendocino/Makefile.inc M src/soc/amd/picasso/Makefile.inc 4 files changed, 46 insertions(+), 94 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/67325/1 diff --git a/src/soc/amd/cezanne/Makefile.inc b/src/soc/amd/cezanne/Makefile.inc index 205b349..aa495dd 100644 --- a/src/soc/amd/cezanne/Makefile.inc +++ b/src/soc/amd/cezanne/Makefile.inc @@ -64,18 +64,6 @@ # | | PSPDIR ADDR | BIOSDIR ADDR | # +-----------+---------------+----------------+ -$(if $(CONFIG_AMD_FWM_POSITION_INDEX), ,\ - $(error Invalid AMD firmware position index. Check if the board sets a valid ROM size)) - -CEZANNE_FWM_POSITION=$(call int-add, \ - $(call int-subtract, 0xffffffff \ - $(call int-shift-left, \ - 0x80000 $(CONFIG_AMD_FWM_POSITION_INDEX))) 0x20000 1) - -# 0x40 accounts for the cbfs_file struct + filename + metadata structs, aligned to 64 bytes -# Building the cbfs image will fail if the offset isn't large enough -AMD_FW_AB_POSITION := 0x40 - CEZANNE_FW_A_POSITION=$(call int-add, \ $(shell awk '$$2 == "FMAP_SECTION_FW_MAIN_A_START" {print $$3}' $(obj)/fmap_config.h) \ $(AMD_FW_AB_POSITION)) @@ -240,7 +228,7 @@ $(OPT_APOB_NV_BASE) \ $(OPT_VERSTAGE_FILE) \ $(OPT_VERSTAGE_SIG_FILE) \ - --location $(shell printf "%#x" $(CEZANNE_FWM_POSITION)) \ + --location $(shell printf "%#x" $(AMD_SOC_FWM_POSITION)) \ --multilevel \ --output $@ @@ -274,24 +262,4 @@ --multilevel \ --output $@ - -cbfs-files-y += apu/amdfw -apu/amdfw-file := $(obj)/amdfw.rom -apu/amdfw-position := $(CEZANNE_FWM_POSITION) -apu/amdfw-type := raw - -ifeq ($(CONFIG_VBOOT_SLOTS_RW_AB)$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),yy) -cbfs-files-y += apu/amdfw_a -apu/amdfw_a-file := $(obj)/amdfw_a.rom -# Ensure this ends up at the beginning of the FW_MAIN_A fmap region -apu/amdfw_a-position := $(AMD_FW_AB_POSITION) -apu/amdfw_a-type := raw - -cbfs-files-y += apu/amdfw_b -apu/amdfw_b-file := $(obj)/amdfw_b.rom -# Ensure this ends up at the beginning of the FW_MAIN_B fmap region -apu/amdfw_b-position := $(AMD_FW_AB_POSITION) -apu/amdfw_b-type := raw -endif - endif # ($(CONFIG_SOC_AMD_CEZANNE),y) diff --git a/src/soc/amd/common/Makefile.inc b/src/soc/amd/common/Makefile.inc index a935565..03e57c0 100644 --- a/src/soc/amd/common/Makefile.inc +++ b/src/soc/amd/common/Makefile.inc @@ -5,6 +5,18 @@ subdirs-y += vboot endif +$(if $(CONFIG_AMD_FWM_POSITION_INDEX), ,\ + $(error Invalid AMD firmware position index. Check if the board sets a valid ROM size)) + +AMD_SOC_FWM_POSITION=$(call int-add, \ + $(call int-subtract, 0xffffffff \ + $(call int-shift-left, \ + 0x80000 $(CONFIG_AMD_FWM_POSITION_INDEX))) 0x20000 1) + +# 0x40 accounts for the cbfs_file struct + filename + metadata structs, aligned to 64 bytes +# Building the cbfs image will fail if the offset isn't large enough +AMD_FW_AB_POSITION := 0x40 + ifneq ($(CONFIG_AMDFW_CONFIG_FILE), ) FIRMWARE_LOCATION=$(shell grep -e FIRMWARE_LOCATION $(CONFIG_AMDFW_CONFIG_FILE) | awk '{print $$2}') @@ -14,4 +26,21 @@ amd_microcode_bins += $(wildcard ${FIRMWARE_LOCATION}/*UcodePatch_*.bin) +cbfs-files-y += apu/amdfw +apu/amdfw-file := $(obj)/amdfw.rom +apu/amdfw-position := $(AMD_SOC_FWM_POSITION) +apu/amdfw-type := raw + +ifeq ($(CONFIG_VBOOT_SLOTS_RW_AB)$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),yy) +cbfs-files-y += apu/amdfw_a +apu/amdfw_a-file := $(obj)/amdfw_a.rom +apu/amdfw_a-position := $(AMD_FW_AB_POSITION) +apu/amdfw_a-type := raw + +cbfs-files-y += apu/amdfw_b +apu/amdfw_b-file := $(obj)/amdfw_b.rom +apu/amdfw_b-position := $(AMD_FW_AB_POSITION) +apu/amdfw_b-type := raw +endif + endif diff --git a/src/soc/amd/mendocino/Makefile.inc b/src/soc/amd/mendocino/Makefile.inc index 225b4a9..5bcbdc2 100644 --- a/src/soc/amd/mendocino/Makefile.inc +++ b/src/soc/amd/mendocino/Makefile.inc @@ -66,18 +66,6 @@ # | | PSPDIR ADDR | BIOSDIR ADDR | # +-----------+---------------+----------------+ -$(if $(CONFIG_AMD_FWM_POSITION_INDEX), ,\ - $(error Invalid AMD firmware position index. Check if the board sets a valid ROM size)) - -MENDOCINO_FWM_POSITION=$(call int-add, \ - $(call int-subtract, 0xffffffff \ - $(call int-shift-left, \ - 0x80000 $(CONFIG_AMD_FWM_POSITION_INDEX))) 0x20000 1) - -# 0x40 accounts for the cbfs_file struct + filename + metadata structs, aligned to 64 bytes -# Building the cbfs image will fail if the offset isn't large enough -AMD_FW_AB_POSITION := 0x40 - MENDOCINO_FW_A_POSITION=$(call int-add, \ $(shell awk '$$2 == "FMAP_SECTION_FW_MAIN_A_START" {print $$3}' $(obj)/fmap_config.h) \ $(AMD_FW_AB_POSITION)) @@ -237,7 +225,7 @@ $(OPT_APOB_NV_BASE) \ $(OPT_VERSTAGE_FILE) \ $(OPT_VERSTAGE_SIG_FILE) \ - --location $(shell printf "%#x" $(MENDOCINO_FWM_POSITION)) \ + --location $(shell printf "%#x" $(AMD_SOC_FWM_POSITION)) \ --output $@ $(PSP_BIOSBIN_FILE): $(PSP_ELF_FILE) $(AMDCOMPRESS) @@ -268,22 +256,4 @@ --anywhere \ --output $@ - -cbfs-files-y += apu/amdfw -apu/amdfw-file := $(obj)/amdfw.rom -apu/amdfw-position := $(MENDOCINO_FWM_POSITION) -apu/amdfw-type := raw - -ifeq ($(CONFIG_VBOOT_SLOTS_RW_AB)$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),yy) -cbfs-files-y += apu/amdfw_a -apu/amdfw_a-file := $(obj)/amdfw_a.rom -apu/amdfw_a-position := $(AMD_FW_AB_POSITION) -apu/amdfw_a-type := raw - -cbfs-files-y += apu/amdfw_b -apu/amdfw_b-file := $(obj)/amdfw_b.rom -apu/amdfw_b-position := $(AMD_FW_AB_POSITION) -apu/amdfw_b-type := raw -endif - endif # ($(CONFIG_SOC_AMD_MENDOCINO),y) diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index 4bf1844..018a131 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -69,18 +69,6 @@ # | | PSPDIR ADDR | BIOSDIR ADDR | # +-----------+---------------+----------------+ -$(if $(CONFIG_AMD_FWM_POSITION_INDEX), ,\ - $(error Invalid AMD firmware position index. Check if the board sets a valid ROM size)) - -PICASSO_FWM_POSITION=$(call int-add, \ - $(call int-subtract, 0xffffffff \ - $(call int-shift-left, \ - 0x80000 $(CONFIG_AMD_FWM_POSITION_INDEX))) 0x20000 1) - -# 0x40 accounts for the cbfs_file struct + filename + metadata structs, aligned to 64 bytes -# Building the cbfs image will fail if the offset isn't large enough -AMD_FW_AB_POSITION := 0x40 - PICASSO_FW_A_POSITION=$(call int-add, \ $(shell awk '$$2 == "FMAP_SECTION_FW_MAIN_A_START" {print $$3}' $(obj)/fmap_config.h) \ $(AMD_FW_AB_POSITION)) @@ -246,7 +234,7 @@ $(OPT_APOB0_NV_BASE) \ $(OPT_VERSTAGE_FILE) \ $(OPT_VERSTAGE_SIG_FILE) \ - --location $(shell printf "%#x" $(PICASSO_FWM_POSITION)) \ + --location $(shell printf "%#x" $(AMD_SOC_FWM_POSITION)) \ --output $@ $(PSP_BIOSBIN_FILE): $(PSP_ELF_FILE) $(AMDCOMPRESS) @@ -277,21 +265,4 @@ --anywhere \ --output $@ -cbfs-files-y += apu/amdfw -apu/amdfw-file := $(obj)/amdfw.rom -apu/amdfw-position := $(PICASSO_FWM_POSITION) -apu/amdfw-type := raw - -ifeq ($(CONFIG_VBOOT_SLOTS_RW_AB)$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),yy) -cbfs-files-y += apu/amdfw_a -apu/amdfw_a-file := $(obj)/amdfw_a.rom -apu/amdfw_a-position := $(AMD_FW_AB_POSITION) -apu/amdfw_a-type := raw - -cbfs-files-y += apu/amdfw_b -apu/amdfw_b-file := $(obj)/amdfw_b.rom -apu/amdfw_b-position := $(AMD_FW_AB_POSITION) -apu/amdfw_b-type := raw -endif - endif # ($(CONFIG_SOC_AMD_PICASSO),y) -- To view, visit https://review.coreboot.org/c/coreboot/+/67325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13aa83f57daf24e16ea1900b9920843a3f9b0337 Gerrit-Change-Number: 67325 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/liveiso/common: Install arch-install-scripts
by Felix Singer (Code Review) 04 Sep '22

04 Sep '22

Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/67324 ) Change subject: util/liveiso/common: Install arch-install-scripts ...................................................................... util/liveiso/common: Install arch-install-scripts The package arch-install-scripts contains useful tools to work on an Arch Linux installation. Change-Id: Icc75b964908302e96e5744f25a592235ea69de4c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/common.nix 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/67324/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc75b964908302e96e5744f25a592235ea69de4c Gerrit-Change-Number: 67324 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/liveiso/common: Install arch-install-scripts
by Felix Singer (Code Review) 04 Sep '22

04 Sep '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67324 ) Change subject: util/liveiso/common: Install arch-install-scripts ...................................................................... util/liveiso/common: Install arch-install-scripts The package arch-install-scripts contains useful tools to work on a Arch Linux installation. Change-Id: Icc75b964908302e96e5744f25a592235ea69de4c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/common.nix 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/67324/1 diff --git a/util/liveiso/common.nix b/util/liveiso/common.nix index b08b48f..426484b 100644 --- a/util/liveiso/common.nix +++ b/util/liveiso/common.nix @@ -103,6 +103,7 @@ environment.systemPackages = with pkgs; [ acpica-tools + arch-install-scripts btrfs-progs bzip2 ccrypt -- To view, visit https://review.coreboot.org/c/coreboot/+/67324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc75b964908302e96e5744f25a592235ea69de4c Gerrit-Change-Number: 67324 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[M] Change in blobs[master]: mb/google/skyrim: Add initial APCB release for skyrim board
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/blobs/+/67323 ) Change subject: mb/google/skyrim: Add initial APCB release for skyrim board ...................................................................... mb/google/skyrim: Add initial APCB release for skyrim board This is a data file that gives configuration data to AMD's ABL, the PSP AGESA Bootloader. As there is no code, there is no ABI, license, or version number. Specified contents describing memory initialization: Memory is 2 channel, LPDDR5/LPDDR5x The GPIOs to use for the SPD identifiers: Bit 0: GPIO 144 Bit 1: GPIO 85 Bit 2: GPIO 79 Bit 3: GPIO 91 Contains 16 slots for possible SPD entries. UMA size is set to 64MB. eSPI I/O range address and size configuration. MEMRESTORECTL is enabled to leverage MRC Cache. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ia72eb4bd3ea74d813cad34e06fb0452814460144 --- A mainboard/google/skyrim/APCB_MDN_D5.bin A mainboard/google/skyrim/Release.txt 2 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/23/67323/1 diff --git a/mainboard/google/skyrim/APCB_MDN_D5.bin b/mainboard/google/skyrim/APCB_MDN_D5.bin new file mode 100644 index 0000000..2e58266 --- /dev/null +++ b/mainboard/google/skyrim/APCB_MDN_D5.bin Binary files differ diff --git a/mainboard/google/skyrim/Release.txt b/mainboard/google/skyrim/Release.txt new file mode 100644 index 0000000..fb5149d --- /dev/null +++ b/mainboard/google/skyrim/Release.txt @@ -0,0 +1,25 @@ +Files: + APCB_MDN_D5.bin - Data only - No license, ABI or Version # + +2022-09-02: Initial public release: +- Add APCB_MDN_D5.bin + This is a data file that gives configuration data to AMD's ABL, + the PSP AGESA Bootloader. As there is no code, there is no ABI, + license, or version number. + + Specified contents describing memory initialization: + Memory is 2 channel, LPDDR5/LPDDR5x + + The GPIOs to use for the SPD identifiers: + Bit 0: GPIO 144 + Bit 1: GPIO 85 + Bit 2: GPIO 79 + Bit 3: GPIO 91 + + Contains 16 slots for possible SPD entries. + UMA size is set to 64MB. + eSPI I/O range address and size configuration. + MEMRESTORECTL is enabled to leverage MRC Cache. + +sha1sum: +a91237472d662b8035450e19f118adaece4748f4 APCB_MDN_D5.bin -- To view, visit https://review.coreboot.org/c/blobs/+/67323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: Ia72eb4bd3ea74d813cad34e06fb0452814460144 Gerrit-Change-Number: 67323 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/lint/lint: Reformat usage
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67192 ) Change subject: util/lint/lint: Reformat usage ...................................................................... util/lint/lint: Reformat usage Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I684d374bd02a42e178383c26936e137e173f8f7e Reviewed-on: https://review.coreboot.org/c/coreboot/+/67192 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/lint/lint 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/util/lint/lint b/util/lint/lint index 3c1e599..c9561a4 100755 --- a/util/lint/lint +++ b/util/lint/lint @@ -8,7 +8,16 @@ JUNIT=0 usage () { - printf "Usage: %s <lint|lint-stable|lint-extended> [--junit]\n" "$0" + printf "Usage: %s <sub-command> [Options]\n" "$0" + printf " Sub-commands:\n" + printf " lint-stable : Run standard lint tests - should pass\n" + printf " lint-extended : Run extended lint tests - should pass\n" + printf " lint : Run full lint tests - Not expected to pass\n\n" + + printf " Options:\n" + printf " -h | --help : Show this help message\n" + printf " -J | --junit : Send test output to a JUnit file\n" + printf "\n" } #write to the junit xml file if --junit was specified -- To view, visit https://review.coreboot.org/c/coreboot/+/67192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I684d374bd02a42e178383c26936e137e173f8f7e Gerrit-Change-Number: 67192 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: util/lint/lint: Add command line parsing
by Martin L Roth (Code Review) 04 Sep '22

04 Sep '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67191 ) Change subject: util/lint/lint: Add command line parsing ...................................................................... util/lint/lint: Add command line parsing The lint script just did very basic argument parsing and required the sub-command and --junit argument to be in specific locations. I'm adding additional commands, so the first step is to add true command line parsing. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I7118c29e6c5d785b35a7ae12cf5984c43ebc3ab9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/67191 Reviewed-by: Raul Rangel <rrangel(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/lint/lint 1 file changed, 49 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved diff --git a/util/lint/lint b/util/lint/lint index 6bf982d..3c1e599 100755 --- a/util/lint/lint +++ b/util/lint/lint @@ -5,6 +5,8 @@ #set -x # uncomment for debug +JUNIT=0 + usage () { printf "Usage: %s <lint|lint-stable|lint-extended> [--junit]\n" "$0" } @@ -16,9 +18,36 @@ fi } +if ! cmd_args="$(getopt -l help,junit -o hJ -- "$@")"; then + usage + exit 0 +fi +eval set -- "${cmd_args}" + +while true; do + case "$1" in + -h | --help) + usage + exit 0 + ;; + -J | --junit) + echo "selected junit" + JUNIT=1 + ;; + --) shift; break ;; + *) break ;; + esac + shift +done + #verify the first command line parameter -if [ -z "$1" ] || [ "$1" != "lint" ] && [ "$1" != "lint-stable" ] && \ +if [ -z "$1" ]; then + echo "Error: A sub-command is needed." + usage + exit 1 +elif [ "$1" != "lint" ] && [ "$1" != "lint-stable" ] && [ "$1" != "lint-extended" ]; then + echo "Error: $1 is not a valid sub-command." usage exit 1 fi @@ -30,13 +59,9 @@ fi FAILED=0; -#check optional second command line parameter. -if [ "$2" = "--junit" ]; then - JUNIT=1 +if [ "${JUNIT}" -eq 1 ]; then echo '<?xml version="1.0" encoding="utf-8"?>' > "$XMLFILE" junit_write '<testsuite>' -else - JUNIT=0 fi #run all scripts of the requested type -- To view, visit https://review.coreboot.org/c/coreboot/+/67191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7118c29e6c5d785b35a7ae12cf5984c43ebc3ab9 Gerrit-Change-Number: 67191 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: amdfwtool: Put soc name setting to fw.cfg from command line
by Martin Roth (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Bao Zheng, Jason Nien, Matt DeVillier. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58552 ) Change subject: amdfwtool: Put soc name setting to fw.cfg from command line ...................................................................... Patch Set 28: (1 comment) Patchset: PS28: Sorry, but could we split this into 3 patches so that we don't have to modify the util in the same change as the src? 1) Add the new option to the util 2) Update the src to use the new option 3) Remove the old option I know it's a pain, but it helps keep the changes concise. -- To view, visit https://review.coreboot.org/c/coreboot/+/58552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0eead1f2156542ea03d58145f5ad67683bf9b52 Gerrit-Change-Number: 58552 Gerrit-PatchSet: 28 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Sat, 03 Sep 2022 21:35:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: allocator_v4: Use memranges only for toplevel
by Nico Huber (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Arthur Heymans, Bill XIE, Tim Wawrzynczak, Eric Lai, Werner Zeh, Kyösti Mälkki. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65420 ) Change subject: allocator_v4: Use memranges only for toplevel ...................................................................... Patch Set 8: (1 comment) File src/device/resource_allocator_v4.c: https://review.coreboot.org/c/coreboot/+/65420/comment/3a7f1ce5_9d1f5b2c PS7, Line 437: void assign_resource_cb(void *param, struct device *dev, struct resource *res) : { : /* We have to filter the same resources as update_bridge_resource(). */ : if (!res->size || !res->limit) : return; : : assign_resource(res, *(const resource_t *)param + res->base, dev); : } > It's like a "lambda" function from FP, I get what you're trying to do 😊 Just doesn't seem a very co […] More or less common practice in Ada ;) with very similar semantics, now that I think about it (no closure, the nested function is only valid while the outer one executes). Do you think the meaning of the code could be misunderstood? Then I'll change it. -- To view, visit https://review.coreboot.org/c/coreboot/+/65420 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70c700318a85f6760f27597730bc9c9a86dbe6b3 Gerrit-Change-Number: 65420 Gerrit-PatchSet: 8 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Sep 2022 19:44:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: intelp2m: Add Go Managing Dependencies System support
by Maxim Polyakov (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Martin L Roth, Patrick Georgi, David Hendricks, Paul Menzel, Angel Pons, ron minnich. Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64724 ) Change subject: intelp2m: Add Go Managing Dependencies System support ...................................................................... Patch Set 5: (1 comment) File util/intelp2m/go.mod: https://review.coreboot.org/c/coreboot/+/64724/comment/1dc09753_d436247f PS1, Line 1: github.com > This has been tested with an internal git repository. + some tests: 1) import the coreboot project into some go project: $cd path/to/any-go-project $go get review.coreboot.org/coreboot.git go: downloading review.coreboot.org/coreboot.git v0.0.0-20220903004133-39914a50ae16 go: added review.coreboot.org/coreboot.git v0.0.0-20220903004133-39914a50ae16 Thus, 'go get' correctly downloaded the contents of the coreboot repository. 2) import intelp2m: $cd path/to/any-go-project $go get review.coreboot.org/coreboot.git/util/intelp2m review.coreboot.org/coreboot.git/util/intelp2m imports ./config: "./config" is relative, but relative import paths are not supported in module mode review.coreboot.org/coreboot.git/util/intelp2m imports ./parser: "./parser" is relative, but relative import paths are not supported in module mode so the problem is in the package names, but after this patch, the import should be without errors; 3) import a repository with an incorrect url: $cd path/to/any-go-project $go get review.coreboot.org/coreboot/test go: unrecognized import path "review.coreboot.org/coreboot/test": reading https://review.coreboot.org/coreboot/test?go-get=1: 404 Not Found This has not happened in previous cases. -- To view, visit https://review.coreboot.org/c/coreboot/+/64724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12efae31227129b8c884af10fb233f398c4094e7 Gerrit-Change-Number: 64724 Gerrit-PatchSet: 5 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Sep 2022 19:07:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: intelp2m: Add Go Managing Dependencies System support
by Maxim Polyakov (Code Review) 03 Sep '22

03 Sep '22

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022