coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[L] Change in coreboot[master]: intelp2m/patform/sunrise: Add unit tests
by build bot (Jenkins) (Code Review) 03 Sep '22

03 Sep '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67132 ) Change subject: intelp2m/patform/sunrise: Add unit tests ...................................................................... Patch Set 3: (2 comments) File util/intelp2m/platforms/test/suite.go: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-157985): https://review.coreboot.org/c/coreboot/+/67132/comment/d6737397_fb3c8333 PS3, Line 56: func (suite Suite) Run(t *testing.T, lable string, platform PlatformSpecificIf) { 'lable' may be misspelled - perhaps 'label'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-157985): https://review.coreboot.org/c/coreboot/+/67132/comment/bb7ddc23_d157a772 PS3, Line 57: t.Run(lable, func(t *testing.T) { 'lable' may be misspelled - perhaps 'label'? -- To view, visit https://review.coreboot.org/c/coreboot/+/67132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15c7483f120a330849d4bad036427be205b0911c Gerrit-Change-Number: 67132 Gerrit-PatchSet: 3 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Sep 2022 19:03:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: intelp2m/patform/apollolake: Add unit tests
by Maxim Polyakov (Code Review) 03 Sep '22

03 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67134 to look at the new patch set (#3). Change subject: intelp2m/patform/apollolake: Add unit tests ...................................................................... intelp2m/patform/apollolake: Add unit tests - The generated map of long and short macros should correspond to the reference ones for all pads (INTEL-SUNRISE-PCH/PAD-MAP); - generated field macros should correspond to the RO_FIELDS mask (INTEL-SUNRISE-PCH/MASK); - macros generated from the zero values bits of the DW registers should correspond to the reference ones (INTEL-SUNRISE-PCH/EMRTY). Change-Id: I1c47edb31d24930068486c74147c5fbc9b18b4b6 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- A util/intelp2m/platforms/apl/apl_test.go 1 file changed, 184 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/67134/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/67134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c47edb31d24930068486c74147c5fbc9b18b4b6 Gerrit-Change-Number: 67134 Gerrit-PatchSet: 3 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: intelp2m/patform/lewisburg: Add unit tests
by Maxim Polyakov (Code Review) 03 Sep '22

03 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67133 to look at the new patch set (#3). Change subject: intelp2m/patform/lewisburg: Add unit tests ...................................................................... intelp2m/patform/lewisburg: Add unit tests - The generated map of long and short macros should correspond to the reference ones for all pads (INTEL-SUNRISE-PCH/PAD-MAP); - generated field macros should correspond to the RO_FIELDS mask (INTEL-SUNRISE-PCH/MASK); - macros generated from the zero values bits of the DW registers should correspond to the reference ones (INTEL-SUNRISE-PCH/EMRTY). Change-Id: Iec18462be8428c3f37d546332211a730ee589a2d Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- A util/intelp2m/platforms/lbg/lbg_test.go 1 file changed, 192 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/67133/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/67133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec18462be8428c3f37d546332211a730ee589a2d Gerrit-Change-Number: 67133 Gerrit-PatchSet: 3 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: intelp2m/patform/sunrise: Add unit tests
by Maxim Polyakov (Code Review) 03 Sep '22

03 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67132 to look at the new patch set (#3). Change subject: intelp2m/patform/sunrise: Add unit tests ...................................................................... intelp2m/patform/sunrise: Add unit tests - The generated map of long and short macros should correspond to the reference ones for all pads (INTEL-SUNRISE-PCH/PAD-MAP); - generated field macros should correspond to the RO_FIELDS mask (INTEL-SUNRISE-PCH/MASK); - macros generated from the zero values bits of the DW registers should correspond to the reference ones (INTEL-SUNRISE-PCH/EMRTY). Use the following command in the console to run all the tests in the project: make test Change-Id: I15c7483f120a330849d4bad036427be205b0911c Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/Makefile A util/intelp2m/platforms/snr/snr_test.go A util/intelp2m/platforms/test/suite.go 3 files changed, 298 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/67132/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/67132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15c7483f120a330849d4bad036427be205b0911c Gerrit-Change-Number: 67132 Gerrit-PatchSet: 3 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex: Correct GPSI0 muxing for pads requiring NF8
by Jamie Ryu (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal, Ivy Jian. Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67317 ) Change subject: mb/google/rex: Correct GPSI0 muxing for pads requiring NF8 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab4e0bc6890cd8e976c513fe87dda0da9b5f2ee0 Gerrit-Change-Number: 67317 Gerrit-PatchSet: 2 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 03 Sep 2022 18:37:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: intelp2m: Add Go Managing Dependencies System support
by Maxim Polyakov (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Martin L Roth, Patrick Georgi, Paul Menzel, Angel Pons, ron minnich. Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64724 ) Change subject: intelp2m: Add Go Managing Dependencies System support ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: Thanks for the review File util/intelp2m/go.mod: https://review.coreboot.org/c/coreboot/+/64724/comment/063b72e3_67e79366 PS1, Line 1: github.com > I suggest creating a new branch for testing in the coreboot project and merging this patch there. […] This has been tested with an internal git repository. -- To view, visit https://review.coreboot.org/c/coreboot/+/64724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12efae31227129b8c884af10fb233f398c4094e7 Gerrit-Change-Number: 64724 Gerrit-PatchSet: 4 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Sep 2022 17:07:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: intelp2m/patform/sunrise: Add unit tests
by build bot (Jenkins) (Code Review) 03 Sep '22

03 Sep '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67132 ) Change subject: intelp2m/patform/sunrise: Add unit tests ...................................................................... Patch Set 2: Verified+1 (2 comments) File util/intelp2m/platforms/test/suite.go: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-157980): https://review.coreboot.org/c/coreboot/+/67132/comment/536d05d6_3ac44440 PS2, Line 56: func (suite Suite) Run(t *testing.T, lable string, platform PlatformSpecificIf) { 'lable' may be misspelled - perhaps 'label'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-157980): https://review.coreboot.org/c/coreboot/+/67132/comment/e6bc6bf9_4f39ee3d PS2, Line 57: t.Run(lable, func(t *testing.T) { 'lable' may be misspelled - perhaps 'label'? -- To view, visit https://review.coreboot.org/c/coreboot/+/67132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15c7483f120a330849d4bad036427be205b0911c Gerrit-Change-Number: 67132 Gerrit-PatchSet: 2 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Sep 2022 17:05:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/intelp2m: Print the current project verion
by Maxim Polyakov (Code Review) 03 Sep '22

03 Sep '22

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67321 ) Change subject: util/intelp2m: Print the current project verion ...................................................................... util/intelp2m: Print the current project verion Print the current project version in the console and in the generated file with the pad configuration: version = major-minor; major = 1.0; minor = last commit in the intelp2m directory. Change-Id: Id2fd0757c003004af976309a44dbbfff0eb517a7 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/Makefile M util/intelp2m/main.go 2 files changed, 52 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/67321/1 diff --git a/util/intelp2m/Makefile b/util/intelp2m/Makefile index 74aa09d..f7e7640 100644 --- a/util/intelp2m/Makefile +++ b/util/intelp2m/Makefile @@ -1,14 +1,21 @@ -# simple makefile for the project +PROJECT_NAME := intelp2m -OUTPUT_DIR = generate -PROJECT_NAME = intelp2m +THIS_FILE := $(lastword $(MAKEFILE_LIST)) +THIS_DIR := $(abspath $(dir $(THIS_FILE))) -default: +P2M_OUTPUT_DIR := $(THIS_DIR)/generate +P2M_VERSION ?= 1.0-$(shell git log --oneline -n 1 --pretty=format:%h $(THIS_DIR)) +P2M_LDFLAGS = "-X main.Version=$(P2M_VERSION)" + +default: version go version - go build -v -o $(PROJECT_NAME) + go build -ldflags=$(P2M_LDFLAGS) -v -o $(PROJECT_NAME) test: go test ./... -v -count=1 clean: - rm -Rf $(PROJECT_NAME) $(OUTPUT_DIR) + rm -Rf $(PROJECT_NAME) $(P2M_OUTPUT_DIR) + +version: + @echo $(P2M_VERSION) diff --git a/util/intelp2m/main.go b/util/intelp2m/main.go index b79b728..bb9ddca 100644 --- a/util/intelp2m/main.go +++ b/util/intelp2m/main.go @@ -9,20 +9,29 @@ "review.coreboot.org/coreboot/coreboot/util/intelp2m/parser" ) +var ( + // Version is injected into main during project build + Version string = "Unknown" +) + +// printVersion - print the utility version in the console +func printVersion() { + fmt.Printf("[ intelp2m ] Version: %s\n", Version) +} + // generateOutputFile - generates include file // parser : parser data structure func generateOutputFile(parser *parser.ParserData) (err error) { - - config.OutputGenFile.WriteString(`/* SPDX-License-Identifier: GPL-2.0-only */ + header := fmt.Sprintf(`/* SPDX-License-Identifier: GPL-2.0-only */ #ifndef CFG_GPIO_H #define CFG_GPIO_H #include <gpio.h> -/* Pad configuration was generated automatically using intelp2m utility */ -static const struct pad_config gpio_table[] = { -`) +/* Pad configuration was generated automatically using intelp2m %s */ +static const struct pad_config gpio_table[] = {`, Version) + config.OutputGenFile.WriteString(header + "\n") // Add the pads map parser.PadMapFprint() config.OutputGenFile.WriteString(`}; @@ -49,14 +58,14 @@ nonCheckFlag := flag.Bool("n", false, - "Generate macros without checking.\n" + - "\tIn this case, some fields of the configuration registers\n" + - "\tDW0 will be ignored.\n") + "Generate macros without checking.\n"+ + "\tIn this case, some fields of the configuration registers\n"+ + "\tDW0 will be ignored.\n") - infoLevels := []*bool { - flag.Bool("i", false, "Show pads function in the comments"), - flag.Bool("ii", false, "Show DW0/DW1 value in the comments"), - flag.Bool("iii", false, "Show ignored bit fields in the comments"), + infoLevels := []*bool{ + flag.Bool("i", false, "Show pads function in the comments"), + flag.Bool("ii", false, "Show DW0/DW1 value in the comments"), + flag.Bool("iii", false, "Show ignored bit fields in the comments"), flag.Bool("iiii", false, "Show target PAD_CFG() macro in the comments"), } @@ -65,18 +74,19 @@ "\t1 - gpio.h\n"+ "\t2 - your template\n\t") - platform := flag.String("p", "snr", "set platform:\n"+ + platform := flag.String("p", "snr", "set platform:\n"+ "\tsnr - Sunrise PCH or Skylake/Kaby Lake SoC\n"+ "\tlbg - Lewisburg PCH with Xeon SP\n"+ "\tapl - Apollo Lake SoC\n"+ "\tcnl - CannonLake-LP or Whiskeylake/Coffeelake/Cometlake-U SoC\n"+ "\tadl - AlderLake PCH\n") - fieldstyle := flag.String("fld", "none", "set fields macros style:\n"+ + fieldstyle := flag.String("fld", "none", "set fields macros style:\n"+ "\tcb - use coreboot style for bit fields macros\n"+ "\tfsp - use fsp style\n"+ "\traw - do not convert, print as is\n") + printVersion() flag.Parse() config.IgnoredFieldsFlagSet(*ignFlag) @@ -85,7 +95,7 @@ for level, flag := range infoLevels { if *flag { config.InfoLevelSet(level + 1) - fmt.Printf("Info level: Use level %d!\n", level + 1) + fmt.Printf("Info level: Use level %d!\n", level+1) break } } -- To view, visit https://review.coreboot.org/c/coreboot/+/67321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id2fd0757c003004af976309a44dbbfff0eb517a7 Gerrit-Change-Number: 67321 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: lib/xxhash.c: Add new hash functions
by Fred Reitberger (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Julius Werner. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67300 ) Change subject: lib/xxhash.c: Add new hash functions ...................................................................... Patch Set 3: (1 comment) File src/include/xxhash.h: https://review.coreboot.org/c/coreboot/+/67300/comment/1d5b5565_cb568843 PS2, Line 3: /* > Same here. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8108af5ab14d8e6c6f5859bd36155c7d254e892c Gerrit-Change-Number: 67300 Gerrit-PatchSet: 3 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 03 Sep 2022 14:45:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: libpayload/Makefile.inc: Initialize vboot depending on UPDATED_SUBMOD...
by Nico Huber (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Bora Guvendik, Wonkyu Kim, Selma Bensaid, Jérémy Compostella, Nicholas Chin. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67118 ) Change subject: libpayload/Makefile.inc: Initialize vboot depending on UPDATED_SUBMODULES ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > UPDATED_SUBMODULES is not meant to be used as a user interface. I assume […] Btw. what payload did you test this with? -- To view, visit https://review.coreboot.org/c/coreboot/+/67118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d58b863cf709930900c7e691e52cac71f88a349 Gerrit-Change-Number: 67118 Gerrit-PatchSet: 3 Gerrit-Owner: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Sep 2022 11:57:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022