Attention is currently required from: Werner Zeh.
Hello build bot (Jenkins), Mario Scheithauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67101
to look at the new patch set (#4).
Change subject: mb/siemens/mc_ehl2: Change to new RTC RV3028-C7
......................................................................
mb/siemens/mc_ehl2: Change to new RTC RV3028-C7
Since the latest redesign a new RTC was introduced on mc_ehl2. Instead
of the old RX6110SA the new Micro Crystal RTC RV3028 is used now. Since
the address of this new RTC conflicts with an EEPROM on I2C bus 2, the
new RTC was moved to I2C bus 1.
As the mainboard is not finished yet, there are no incompatibility
issues with this change. Every new mainboard will have the new RTC and
the older mainboards are not delivered yet.
Change-Id: I3dd00855b8c9b22bdea21d3c8563cdb392868751
Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com>
---
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
2 files changed, 25 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/67101/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/67101
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3dd00855b8c9b22bdea21d3c8563cdb392868751
Gerrit-Change-Number: 67101
Gerrit-PatchSet: 4
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Arthur Heymans.
Hello build bot (Jenkins), Mario Scheithauer, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67099
to look at the new patch set (#4).
Change subject: drivers/i2c: Add a new RTC RV-3028-C7 from Micro Crystal
......................................................................
drivers/i2c: Add a new RTC RV-3028-C7 from Micro Crystal
This patch adds a driver for a new RTC from Micro Crystal. Supported
features are:
* configure backup voltage switchover via devicetree
* configure backup capacitor charging mode via devicetree
* set date if a voltage drop on backup voltage was detected
to either a user definable (devicetree) or coreboot build date
Change-Id: I37176ea726e50e4e74d409488981d7618ecff8bb
Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com>
---
A src/drivers/i2c/rv3028c7/Kconfig
A src/drivers/i2c/rv3028c7/Makefile.inc
A src/drivers/i2c/rv3028c7/chip.h
A src/drivers/i2c/rv3028c7/rv3028c7.c
A src/drivers/i2c/rv3028c7/rv3028c7.h
5 files changed, 306 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/67099/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/67099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37176ea726e50e4e74d409488981d7618ecff8bb
Gerrit-Change-Number: 67099
Gerrit-PatchSet: 4
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67099 )
Change subject: drivers/i2c: Add a new RTC RV-3028-C7 from Micro Crystal
......................................................................
Patch Set 3:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67099/comment/9b3c11fc_b43597d3
PS3, Line 12: devietree
> devicetree
Ack
Patchset:
PS3:
Thanks for the review Martin.
File src/drivers/i2c/rv3028c7/chip.h:
https://review.coreboot.org/c/coreboot/+/67099/comment/0fcd2b98_0d57d1d7
PS3, Line 2:
> Add guards around header file?
Looks like a lot of chip.h files in the tree do no use the guards. But a lot do, so I will add them here.
https://review.coreboot.org/c/coreboot/+/67099/comment/e1d02a00_11efce39
PS3, Line 28: CARGE_VIA_3K
> CHARGE_? Same below.
Ack
https://review.coreboot.org/c/coreboot/+/67099/comment/2b698aea_d9844e4b
PS3, Line 38: /* User year to set */
> /* User year to set (2-digit) */
Ack
https://review.coreboot.org/c/coreboot/+/67099/comment/506c66d8_12b7866a
PS3, Line 41: cap_cahrge
> cap_charge?
Ack
File src/drivers/i2c/rv3028c7/rv3028c7.c:
https://review.coreboot.org/c/coreboot/+/67099/comment/5bea0230_fed2f445
PS3, Line 22: } while ((status & EE_BUSY_BIT) && !stopwatch_expired(&sw));
> Add a 1ms delay here so this time can be used elsewhere if needed? […]
Sounds good, will add.
--
To view, visit https://review.coreboot.org/c/coreboot/+/67099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37176ea726e50e4e74d409488981d7618ecff8bb
Gerrit-Change-Number: 67099
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 05 Sep 2022 05:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67330 )
Change subject: Documentation: Add some more acronyms to the list.
......................................................................
Patch Set 1:
(4 comments)
File Documentation/acronyms.md:
https://review.coreboot.org/c/coreboot/+/67330/comment/cfee899a_2947e212
PS1, Line 61: in processor chip
Seems like this is missing a word, perhaps "in a processor chip" or "in the processor chip"
https://review.coreboot.org/c/coreboot/+/67330/comment/58cfb203_b62bf489
PS1, Line 305: EDP
eDP
https://review.coreboot.org/c/coreboot/+/67330/comment/e80d39c7_dc1d9bd2
PS1, Line 647: [Original Design Manufacturer]
Nit: Add double asterisks (bold) for consistency with other external links in this list
https://review.coreboot.org/c/coreboot/+/67330/comment/0ed5ceee_272ffb0d
PS1, Line 948: TME - Intel: Total Memory Encryption
Should be moved a line down as it breaks the TLB hyperlink
--
To view, visit https://review.coreboot.org/c/coreboot/+/67330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d
Gerrit-Change-Number: 67330
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 05:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67330 )
Change subject: Documentation: Add some more acronyms to the list.
......................................................................
Patch Set 1:
(2 comments)
File Documentation/acronyms.md:
https://review.coreboot.org/c/coreboot/+/67330/comment/110f03dd_df6be398
PS1, Line 50: ]
Should be a * to match opening double asterisks
https://review.coreboot.org/c/coreboot/+/67330/comment/4cd53917_7ce45a6b
PS1, Line 603: This has been
: generally been
: https://en.wikipedia.org/wiki/MultiProcessor_Specification by the ACPI
: tables.
Noticed this when skimming the rendered markdown. Not sure what word was intended to go here
--
To view, visit https://review.coreboot.org/c/coreboot/+/67330
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d
Gerrit-Change-Number: 67330
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 04:41:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Zheng Bao, Fred Reitberger, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67050 )
Change subject: soc/amd: Recalculate the field power in PSS table entry
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/cezanne/acpi.c:
https://review.coreboot.org/c/coreboot/+/67050/comment/7df5de24_3f689dee
PS2, Line 198: power_in_mw
> I'd argue it was confusing before, since the variable was set before the current divisor was applied […]
Please vote should we change code or keep it as it is in AGESA.
Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/67050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib43103cc62c18debea3fd2c23d9c30fb0ecd781b
Gerrit-Change-Number: 67050
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 05 Sep 2022 03:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com>
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-MessageType: comment