coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[M] Change in coreboot[master]: intelp2m/patform/apollolake: Add unit tests
by Maxim Polyakov (Code Review) 05 Sep '22

05 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67134 to look at the new patch set (#4). Change subject: intelp2m/patform/apollolake: Add unit tests ...................................................................... intelp2m/patform/apollolake: Add unit tests - The generated map of long and short macros should correspond to the reference ones for all pads (INTEL-SUNRISE-PCH/PAD-MAP); - generated field macros should correspond to the RO_FIELDS mask (INTEL-SUNRISE-PCH/MASK); - macros generated from the zero values bits of the DW registers should correspond to the reference ones (INTEL-SUNRISE-PCH/EMRTY). Change-Id: I1c47edb31d24930068486c74147c5fbc9b18b4b6 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- A util/intelp2m/platforms/apl/apl_test.go 1 file changed, 184 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/67134/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/67134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c47edb31d24930068486c74147c5fbc9b18b4b6 Gerrit-Change-Number: 67134 Gerrit-PatchSet: 4 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: intelp2m/patform/lewisburg: Add unit tests
by Maxim Polyakov (Code Review) 05 Sep '22

05 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67133 to look at the new patch set (#4). Change subject: intelp2m/patform/lewisburg: Add unit tests ...................................................................... intelp2m/patform/lewisburg: Add unit tests - The generated map of long and short macros should correspond to the reference ones for all pads (INTEL-SUNRISE-PCH/PAD-MAP); - generated field macros should correspond to the RO_FIELDS mask (INTEL-SUNRISE-PCH/MASK); - macros generated from the zero values bits of the DW registers should correspond to the reference ones (INTEL-SUNRISE-PCH/EMRTY). Change-Id: Iec18462be8428c3f37d546332211a730ee589a2d Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- A util/intelp2m/platforms/lbg/lbg_test.go 1 file changed, 192 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/67133/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/67133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec18462be8428c3f37d546332211a730ee589a2d Gerrit-Change-Number: 67133 Gerrit-PatchSet: 4 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: intelp2m/patform/sunrise: Add unit tests
by Maxim Polyakov (Code Review) 05 Sep '22

05 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67132 to look at the new patch set (#4). Change subject: intelp2m/patform/sunrise: Add unit tests ...................................................................... intelp2m/patform/sunrise: Add unit tests - The generated map of long and short macros should correspond to the reference ones for all pads (INTEL-SUNRISE-PCH/PAD-MAP); - generated field macros should correspond to the RO_FIELDS mask (INTEL-SUNRISE-PCH/MASK); - macros generated from the zero values bits of the DW registers should correspond to the reference ones (INTEL-SUNRISE-PCH/EMRTY). Use the following command in the console to run all the tests in the project: make test Change-Id: I15c7483f120a330849d4bad036427be205b0911c Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/Makefile A util/intelp2m/platforms/snr/snr_test.go A util/intelp2m/platforms/test/suite.go 3 files changed, 298 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/67132/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/67132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15c7483f120a330849d4bad036427be205b0911c Gerrit-Change-Number: 67132 Gerrit-PatchSet: 4 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: intelp2m: Add Go Managing Dependencies System support
by Maxim Polyakov (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth, Patrick Georgi, David Hendricks, Paul Menzel, Angel Pons, ron minnich. Hello build bot (Jenkins), Martin L Roth, Patrick Georgi, David Hendricks, Paul Menzel, Angel Pons, ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64724 to look at the new patch set (#6). Change subject: intelp2m: Add Go Managing Dependencies System support ...................................................................... intelp2m: Add Go Managing Dependencies System support Add go.mod containing the full name of the project according to the docs [1]: review.coreboot.org/coreboot.git/util/intelp2m, and aslo, based on this, rename the internal packages to point to the absolute path. This will allow Go Managing Dependencies System to integrate packages from intelp2m to third-party Go written on the Go language [1]. This also requires fixing the Golang compiler version in go.mod: use go1.18 [2], the latest up-to-date version. [1] https://go.dev/doc/modules/managing-dependencies [2] https://tip.golang.org/doc/go1.18 [ TEST ] 1) Import the coreboot project into some go project: $cd path/to/go-project $go get review.coreboot.org/coreboot.git go: downloading review.coreboot.org/coreboot.git v0.0.0-20220903004133 -39914a50ae16 go: added review.coreboot.org/coreboot.git v0.0.0-20220903004133 -39914a50ae16 Thus, 'go get' correctly downloaded the contents of the repository. 2) Import intelp2m: $cd path/to/go-project $go get review.coreboot.org/coreboot.git/util/intelp2m review.coreboot.org/coreboot.git/util/intelp2m imports ./config: "./config" is relative, but relative import paths are not supported in module mode review.coreboot.org/coreboot.git/util/intelp2m imports ./parser: "./parser" is relative, but relative import paths are not supported in module mode Thus, the problem is in the package names, but after this patch, the import should be without errors. 3) Import a repository with an incorrect url: $cd path/to/go-project $go get review.coreboot.org/coreboot/test go: unrecognized import path "review.coreboot.org/coreboot/test": reading https://review.coreboot.org/coreboot/test?go-get=1: 404 Not Found This has not happened in previous cases. Change-Id: I12efae31227129b8c884af10fb233f398c4094e7 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/intelp2m/Makefile M util/intelp2m/fields/cb/cb.go M util/intelp2m/fields/fields.go M util/intelp2m/fields/fsp/fsp.go M util/intelp2m/fields/raw/raw.go A util/intelp2m/go.mod M util/intelp2m/main.go M util/intelp2m/parser/parser.go M util/intelp2m/platforms/adl/macro.go M util/intelp2m/platforms/adl/template.go M util/intelp2m/platforms/apl/macro.go M util/intelp2m/platforms/apl/template.go M util/intelp2m/platforms/cnl/macro.go M util/intelp2m/platforms/cnl/template.go M util/intelp2m/platforms/common/macro.go M util/intelp2m/platforms/lbg/macro.go M util/intelp2m/platforms/snr/macro.go M util/intelp2m/platforms/snr/template.go 18 files changed, 111 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/64724/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/64724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12efae31227129b8c884af10fb233f398c4094e7 Gerrit-Change-Number: 64724 Gerrit-PatchSet: 6 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/grunt: Add more spaces to coreboot region
by Bao Zheng (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Jason Nien, Zheng Bao, Martin Roth. Hello build bot (Jenkins), Jason Nien, Zheng Bao, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67241 to look at the new patch set (#3). Change subject: mb/grunt: Add more spaces to coreboot region ...................................................................... mb/grunt: Add more spaces to coreboot region The amdfw.rom and AGESA.bin are not in CBFS now in default setting. We need to add them back but the space in "COREBOOT" region is limited. So we need to expand it. Change-Id: I35861bf866054c23820037eaa7fd370b56f5da70 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd 1 file changed, 18 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/67241/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/67241 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35861bf866054c23820037eaa7fd370b56f5da70 Gerrit-Change-Number: 67241 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/alderlake: Remove dependency of FSP-S CpuMpPei Module
by Angel Pons (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth, Subrata Banik, Tim Wawrzynczak, Ronak Kanabar, Eric Lai, Werner Zeh. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66706 ) Change subject: soc/intel/alderlake: Remove dependency of FSP-S CpuMpPei Module ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/66706/comment/b0df8524_cdcddb26 PS5, Line 26: https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/CpuMpPei/CpuMpPei.… > > I think the link is no longer accurate, at least I can't make sense out of the line (it's just a c […] Much better, thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/66706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ebe0bcfda513e79e791df7ab54b357aa23d295c Gerrit-Change-Number: 66706 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 07:09:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add WWAN ACPI support
by Ivy Jian (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67336 ) Change subject: mb/google/rex: Add WWAN ACPI support ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67336/comment/fde25745_e95f790a PS1, Line 8: > 'addtional' may be misspelled - perhaps 'additional'? Please fix. https://review.coreboot.org/c/coreboot/+/67336/comment/8d0cab11_47144ef8 PS1, Line 13: TEST=check cbmem -c > Possible unwrapped commit description (prefer a maximum 72 chars per line) Please fix. https://review.coreboot.org/c/coreboot/+/67336/comment/252f76aa_03c9c74f PS1, Line 14: [INFO ] \_SB.PCI0.RP06: Enable RTD3 for PCI: 00:1c.5 (Intel PCIe Runtime D3) > Possible unwrapped commit description (prefer a maximum 72 chars per line) Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/67336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6114c589769d2eca882cf1a5255cf4c5937121a6 Gerrit-Change-Number: 67336 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 06:49:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add WWAN ACPI support
by Eric Lai (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67336 ) Change subject: mb/google/rex: Add WWAN ACPI support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6114c589769d2eca882cf1a5255cf4c5937121a6 Gerrit-Change-Number: 67336 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 06:43:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add WWAN ACPI support
by build bot (Jenkins) (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67336 ) Change subject: mb/google/rex: Add WWAN ACPI support ...................................................................... Patch Set 1: (3 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158038): https://review.coreboot.org/c/coreboot/+/67336/comment/9f9c72c4_550c7c6c PS1, Line 8: 'addtional' may be misspelled - perhaps 'additional'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158038): https://review.coreboot.org/c/coreboot/+/67336/comment/db799ef9_9fd25342 PS1, Line 13: TEST=check cbmem -c Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158038): https://review.coreboot.org/c/coreboot/+/67336/comment/ddf3fd52_dcfca233 PS1, Line 14: [INFO ] \_SB.PCI0.RP06: Enable RTD3 for PCI: 00:1c.5 (Intel PCIe Runtime D3) Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/67336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6114c589769d2eca882cf1a5255cf4c5937121a6 Gerrit-Change-Number: 67336 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 06:33:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add WWAN ACPI support
by Ivy Jian (Code Review) 05 Sep '22

05 Sep '22

Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67336 ) Change subject: mb/google/rex: Add WWAN ACPI support ...................................................................... mb/google/rex: Add WWAN ACPI support Add FM350GL 5G WWAN support using drivers/wwan/fm and addtional PM features from RTD3. BUG=b:244077118 TEST=check cbmem -c [INFO ] \_SB.PCI0.RP06: Enable RTD3 for PCI: 00:1c.5 (Intel PCIe Runtime D3) [INFO ] \_SB.PCI0.RP06: Enable WWAN for PCI: 00:1c.5 (Fibocom FM-350-GL) check PXSX Device is generated in ssdt. Signed-off-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Change-Id: I6114c589769d2eca882cf1a5255cf4c5937121a6 --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/rex0/overridetree.cb 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/67336/1 diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 367cf09..55d3008 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -18,6 +18,7 @@ def_bool n select BOARD_GOOGLE_REX_COMMON select DRIVERS_INTEL_PMC + select DRIVERS_WWAN_FM350GL select MAINBOARD_HAS_CHROMEOS select MEMORY_SOLDERDOWN select SOC_INTEL_METEORLAKE diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index 417d47b..0b2ebdc 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -226,6 +226,24 @@ .clk_req = 3, .flags = PCIE_RP_HOTPLUG | PCIE_RP_LTR | PCIE_RP_AER, }" + chip soc/intel/common/block/pcie/rtd3 + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C05)" + register "reset_off_delay_ms" = "20" + # register "reset_delay_ms" = "1000" + register "srcclk_pin" = "3" + register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" + register "skip_on_off_support" = "true" + device generic 0 alias rp6_rtd3 on end + end + chip drivers/wwan/fm + register "fcpo_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E07)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A15)" + register "perst_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C05)" + register "wake_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F10)" + register "add_acpi_dma_property" = "true" + use rp6_rtd3 as rtd3dev + device generic 0 on end + end end #PCIE6 WWAN card device ref gspi1 on end device ref soc_espi on -- To view, visit https://review.coreboot.org/c/coreboot/+/67336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6114c589769d2eca882cf1a5255cf4c5937121a6 Gerrit-Change-Number: 67336 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022