coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[M] Change in coreboot[master]: soc/intel/broadwell: Consolidate SPD handling
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Angel Pons. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55811 ) Change subject: soc/intel/broadwell: Consolidate SPD handling ...................................................................... Patch Set 14: (1 comment) File src/mainboard/intel/wtm2/pei_data.c: https://review.coreboot.org/c/coreboot/+/55811/comment/d2329654_67bf7f49 PS14, Line 8: spdi->addresses[0] = 0x51; : spdi->addresses[2] = 0x51; looks like there is a typo. Is it possible the have same address for both dimms ? -- To view, visit https://review.coreboot.org/c/coreboot/+/55811 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92a05003a319c354675368cae8e34980bd2f9e10 Gerrit-Change-Number: 55811 Gerrit-PatchSet: 14 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 10:03:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Add audio parts ALC5682I-VD and MAX9835
by Ivy Jian (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik, Kapil Porwal. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66919 ) Change subject: mb/google/rex: Add audio parts ALC5682I-VD and MAX9835 ...................................................................... Patch Set 19: (1 comment) File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/66919/comment/71164f66_e6064396 PS19, Line 210: 10EC5682 Hi Eran, I cherry-pick your CL to try , it shows `rt5682 i2c-10EC5682:00: Device with ID register 6749 is not rt5682` and I have confirmed with EE , Rex use ALC5682I-VS. need use `RTL5682` for ALC5682I-VS. -- To view, visit https://review.coreboot.org/c/coreboot/+/66919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8dfc79e7e4d27828726145156c870733d716899 Gerrit-Change-Number: 66919 Gerrit-PatchSet: 19 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 09:54:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/amd/agesa/*/fixme.c: Drop some white space issues
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Paul Menzel. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65887 ) Change subject: cpu/amd/agesa/*/fixme.c: Drop some white space issues ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/65887/comment/31b84c77_1e60d566 PS1, Line 7: white spaces issues > white space issues Ack https://review.coreboot.org/c/coreboot/+/65887/comment/1dbd0883_213b9651 PS1, Line 7: some > One could argue that the whitespace usage in local variable declarations is non-conformant, and thes […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/65887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I335b5ac415b76067c70c8e2e6f1703eb10f69c50 Gerrit-Change-Number: 65887 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 05 Sep 2022 09:54:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: lint/checkpatch: Add XA_STATE and XA_STATE_ORDER to the macro declara...
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67338 ) Change subject: lint/checkpatch: Add XA_STATE and XA_STATE_ORDER to the macro declaration ...................................................................... lint/checkpatch: Add XA_STATE and XA_STATE_ORDER to the macro declaration This reduce the difference with linux v6.0-rc3. Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Ica20264d744ea8f77b56c63d29e1fafc2e68a869 --- M util/lint/checkpatch.pl 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/67338/1 diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index ef2faee..2d2cbb1 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -945,7 +945,8 @@ our $declaration_macros = qr{(?x: (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(| (?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(| - (?:SKCIPHER_REQUEST|SHASH_DESC|AHASH_REQUEST)_ON_STACK\s*\( + (?:SKCIPHER_REQUEST|SHASH_DESC|AHASH_REQUEST)_ON_STACK\s*\(| + (?:$Storage\s+)?(?:XA_STATE|XA_STATE_ORDER)\s*\( )}; our %allow_repeated_words = ( -- To view, visit https://review.coreboot.org/c/coreboot/+/67338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica20264d744ea8f77b56c63d29e1fafc2e68a869 Gerrit-Change-Number: 67338 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: lint/checkpatch: Fix incorrect camelcase detection on numeric constant
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67337 ) Change subject: lint/checkpatch: Fix incorrect camelcase detection on numeric constant ...................................................................... lint/checkpatch: Fix incorrect camelcase detection on numeric constant This reduce the difference with linux v6.0-rc3. Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I15e1a935665c38b8a2109d412b1d16f935cbb402 --- M util/lint/checkpatch.pl 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/67337/1 diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 650ddff..ef2faee 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -5326,7 +5326,7 @@ $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ && #Ignore some three character SI units explicitly, like MiB and KHz $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) { - while ($var =~ m{($Ident)}g) { + while ($var =~ m{\b($Ident)}g) { my $word = $1; next if ($word !~ /[A-Z][a-z]|[a-z][A-Z]/); if ($check) { -- To view, visit https://review.coreboot.org/c/coreboot/+/67337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15e1a935665c38b8a2109d412b1d16f935cbb402 Gerrit-Change-Number: 67337 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: lint/checkpatch: Update 'check for illegal assignment in if conditional'
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65829 ) Change subject: lint/checkpatch: Update 'check for illegal assignment in if conditional' ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Thank you File util/lint/checkpatch.pl: https://review.coreboot.org/c/coreboot/+/65829/comment/5e578a48_8fe8a51d PS2, Line 5164: if (ERROR("TRAILING_STATEMENTS", > Did you want this in a separate patch? I don't think so. The title is about 'check for illegal assignment in if conditional'. Should I push another patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/65829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63b3561471d3bd0ebfe7e5733c6dd6fb673904e0 Gerrit-Change-Number: 65829 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 09:19:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/amd/agesa/*/fixme.c: Drop some white space issues
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Paul Menzel, Elyes Haouas. Hello build bot (Jenkins), Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65887 to look at the new patch set (#3). Change subject: cpu/amd/agesa/*/fixme.c: Drop some white space issues ...................................................................... cpu/amd/agesa/*/fixme.c: Drop some white space issues Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I335b5ac415b76067c70c8e2e6f1703eb10f69c50 --- M src/cpu/amd/agesa/family14/fixme.c M src/cpu/amd/agesa/family16kb/fixme.c 2 files changed, 18 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/65887/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/65887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I335b5ac415b76067c70c8e2e6f1703eb10f69c50 Gerrit-Change-Number: 65887 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: cpu/amd/agesa/*/fixme.c: Fix some white space issues
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Paul Menzel, Elyes Haouas. Hello build bot (Jenkins), Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65887 to look at the new patch set (#2). Change subject: cpu/amd/agesa/*/fixme.c: Fix some white space issues ...................................................................... cpu/amd/agesa/*/fixme.c: Fix some white space issues Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I335b5ac415b76067c70c8e2e6f1703eb10f69c50 --- M src/cpu/amd/agesa/family14/fixme.c M src/cpu/amd/agesa/family16kb/fixme.c 2 files changed, 18 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/65887/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/65887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I335b5ac415b76067c70c8e2e6f1703eb10f69c50 Gerrit-Change-Number: 65887 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4}
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Nico Huber, Martin L Roth, Jakub Czapiga, Arthur Heymans, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Martin L Roth, Jakub Czapiga, Paul Menzel, Angel Pons, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62181 to look at the new patch set (#8). Change subject: device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4} ...................................................................... device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4} Change-Id: Iaffa84704d2a627394b2aae4d35d47d1358a2621 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/device/dram/ddr2.c M src/device/dram/ddr3.c M src/device/dram/ddr4.c M src/device/dram/spd.c M src/include/device/dram/ddr2.h M src/include/device/dram/ddr3.h M src/include/device/dram/ddr4.h M src/include/spd.h M src/mainboard/scaleway/tagada/ramstage.c M src/northbridge/intel/haswell/haswell_mrc/raminit.c M src/northbridge/intel/sandybridge/raminit_mrc.c M tests/lib/dimm_info_util-test.c 12 files changed, 103 insertions(+), 180 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/62181/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/62181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaffa84704d2a627394b2aae4d35d47d1358a2621 Gerrit-Change-Number: 62181 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4}
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Nico Huber, Martin L Roth, Jakub Czapiga, Arthur Heymans, Patrick Rudolph. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62181 ) Change subject: device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4} ...................................................................... Patch Set 7: (2 comments) Patchset: PS7: Thank you. File src/include/device/dram/ddr4.h: https://review.coreboot.org/c/coreboot/+/62181/comment/0188e758_153058a9 PS7, Line 29: SPD_DDR4_DIMM_TYPE_EXTENDED = 0x0, > Is this something to worry about? defined here: src/include/spd.h -- To view, visit https://review.coreboot.org/c/coreboot/+/62181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaffa84704d2a627394b2aae4d35d47d1358a2621 Gerrit-Change-Number: 62181 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 05 Sep 2022 09:05:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022