coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[S] Change in coreboot[master]: allocator_v4: Disable top-down mode by default
by Christian Walter (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Nico Huber, Martin L Roth, Tim Wawrzynczak, Arthur Heymans. Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67328 ) Change subject: allocator_v4: Disable top-down mode by default ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I982e6d7355b9e689de10357d6c16ed718705270e Gerrit-Change-Number: 67328 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Sep 2022 13:53:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: allocator_v4: Disable top-down mode by default
by Lean Sheng Tan (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Nico Huber, Martin L Roth, Tim Wawrzynczak, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67328 ) Change subject: allocator_v4: Disable top-down mode by default ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I982e6d7355b9e689de10357d6c16ed718705270e Gerrit-Change-Number: 67328 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Sep 2022 13:30:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "allocator_v4: Treat above 4G resources more natively"
by Lean Sheng Tan (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Nico Huber, Martin L Roth, Tim Wawrzynczak, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67329 ) Change subject: Revert "allocator_v4: Treat above 4G resources more natively" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5721cb84b29fc42240dff94f49a94461d88e7fbc Gerrit-Change-Number: 67329 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Sep 2022 13:30:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: configs/config.prodrive_hermes: Fix typo
by Lean Sheng Tan (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Justin van Son, Christian Walter, Angel Pons, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67343 ) Change subject: configs/config.prodrive_hermes: Fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf24e00fb895a670ea798f64a79035d858ec0d4f Gerrit-Change-Number: 67343 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Sep 2022 13:07:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/smbus: SC16IS750 I2C to UART converter chip initialization
by build bot (Jenkins) (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Ahamed Husni. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67342 ) Change subject: drivers/smbus: SC16IS750 I2C to UART converter chip initialization ...................................................................... Patch Set 3: Verified-1 (3 comments) File src/drivers/smbus/sc16is750_init.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158068): https://review.coreboot.org/c/coreboot/+/67342/comment/fd915c80_3f987ef6 PS3, Line 7: do_smbus_write_byte(CONFIG_FIXED_SMBUS_IO_BASE, \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158068): https://review.coreboot.org/c/coreboot/+/67342/comment/1bee5a85_9c63ca14 PS3, Line 21: sc16is750_write_byte(REG_LCR << 3, 0b10000011); Avoid gcc v4.3+ binary constant extension: <0b10000011> Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158068): https://review.coreboot.org/c/coreboot/+/67342/comment/fc0c57b9_f8ec0273 PS3, Line 27: sc16is750_write_byte(REG_LCR << 3, 0b00000011); Avoid gcc v4.3+ binary constant extension: <0b00000011> -- To view, visit https://review.coreboot.org/c/coreboot/+/67342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31188b8c0f9b0ce9454da984e630eca9101d145 Gerrit-Change-Number: 67342 Gerrit-PatchSet: 3 Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 13:02:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/console: attach smbus console driver
by Ahamed Husni (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Ahamed Husni. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67341 to look at the new patch set (#3). Change subject: src/console: attach smbus console driver ...................................................................... src/console: attach smbus console driver Change-Id: I3a9bf64e59d529253bfdcdfa565bb2bb92975728 Signed-off-by: Husni Faiz <ahamedhusni73(a)gmail.com> --- M src/console/console.c A src/drivers/smbus/Makefile.inc 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/67341/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/67341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a9bf64e59d529253bfdcdfa565bb2bb92975728 Gerrit-Change-Number: 67341 Gerrit-PatchSet: 3 Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: drivers/smbus: SC16IS750 I2C to UART converter chip initialization
by build bot (Jenkins) (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Ahamed Husni. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67342 ) Change subject: drivers/smbus: SC16IS750 I2C to UART converter chip initialization ...................................................................... Patch Set 2: Verified-1 (3 comments) File src/drivers/smbus/sc16is750_init.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158066): https://review.coreboot.org/c/coreboot/+/67342/comment/5df79a5e_51ab2085 PS2, Line 7: do_smbus_write_byte(CONFIG_FIXED_SMBUS_IO_BASE, \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158066): https://review.coreboot.org/c/coreboot/+/67342/comment/a2d61ab9_b4b4fdaf PS2, Line 21: sc16is750_write_byte(REG_LCR << 3, 0b10000011); Avoid gcc v4.3+ binary constant extension: <0b10000011> Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158066): https://review.coreboot.org/c/coreboot/+/67342/comment/b0206964_196e6c5b PS2, Line 27: sc16is750_write_byte(REG_LCR << 3, 0b00000011); Avoid gcc v4.3+ binary constant extension: <0b00000011> -- To view, visit https://review.coreboot.org/c/coreboot/+/67342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31188b8c0f9b0ce9454da984e630eca9101d145 Gerrit-Change-Number: 67342 Gerrit-PatchSet: 2 Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 12:59:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: bd82x6x/early_pch: enable smbus in bootblock stage
by Ahamed Husni (Code Review) 05 Sep '22

05 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67340 to look at the new patch set (#2). Change subject: bd82x6x/early_pch: enable smbus in bootblock stage ...................................................................... bd82x6x/early_pch: enable smbus in bootblock stage Change-Id: I97d0afb013ede428383acaa0aa97ab04fe80e2a4 Signed-off-by: Husni Faiz <ahamedhusni73(a)gmail.com> --- M src/southbridge/intel/bd82x6x/early_pch.c M src/southbridge/intel/common/Makefile.inc 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/67340/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67340 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97d0afb013ede428383acaa0aa97ab04fe80e2a4 Gerrit-Change-Number: 67340 Gerrit-PatchSet: 2 Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: configs/config.prodrive_hermes: Fix typo
by Angel Pons (Code Review) 05 Sep '22

05 Sep '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67343 ) Change subject: configs/config.prodrive_hermes: Fix typo ...................................................................... configs/config.prodrive_hermes: Fix typo Remove extra 'o' in "Tech*o*nologies". Change-Id: Icf24e00fb895a670ea798f64a79035d858ec0d4f Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M configs/config.prodrive_hermes 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/67343/1 diff --git a/configs/config.prodrive_hermes b/configs/config.prodrive_hermes index 35c617c..ce8d687 100644 --- a/configs/config.prodrive_hermes +++ b/configs/config.prodrive_hermes @@ -1,7 +1,7 @@ # Settings used by Prodrive to build coreboot for the Hermes CONFIG_VENDOR_PRODRIVE=y CONFIG_BOARD_PRODRIVE_HERMES=y -CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="Prodrive Techonologies B.V." +CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="Prodrive Technologies B.V." CONFIG_POST_IO=y CONFIG_USE_LEGACY_8254_TIMER=y CONFIG_HERMES_USES_SPS_FIRMWARE=y -- To view, visit https://review.coreboot.org/c/coreboot/+/67343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf24e00fb895a670ea798f64a79035d858ec0d4f Gerrit-Change-Number: 67343 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: drivers/smbus: SC16IS750 I2C to UART converter chip initialization
by build bot (Jenkins) (Code Review) 05 Sep '22

05 Sep '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67342 ) Change subject: drivers/smbus: SC16IS750 I2C to UART converter chip initialization ...................................................................... Patch Set 1: (3 comments) File src/drivers/smbus/sc16is750_init.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158062): https://review.coreboot.org/c/coreboot/+/67342/comment/63ade1b7_9289f31a PS1, Line 7: do_smbus_write_byte(CONFIG_FIXED_SMBUS_IO_BASE, \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158062): https://review.coreboot.org/c/coreboot/+/67342/comment/2b3cf374_9f0b81b9 PS1, Line 21: sc16is750_write_byte(REG_LCR << 3, 0b10000011); Avoid gcc v4.3+ binary constant extension: <0b10000011> Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158062): https://review.coreboot.org/c/coreboot/+/67342/comment/fd64fd40_4ac5e1d2 PS1, Line 27: sc16is750_write_byte(REG_LCR << 3, 0b00000011); Avoid gcc v4.3+ binary constant extension: <0b00000011> -- To view, visit https://review.coreboot.org/c/coreboot/+/67342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib31188b8c0f9b0ce9454da984e630eca9101d145 Gerrit-Change-Number: 67342 Gerrit-PatchSet: 1 Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Sep 2022 11:59:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022