coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[S] Change in coreboot[master]: util/lint: ignore util/goswid, a new submodule
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67327 ) Change subject: util/lint: ignore util/goswid, a new submodule ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62b58f0c536312fe4677855bca8f44bc7d3ebc85 Gerrit-Change-Number: 67327 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:18:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: configs/config.prodrive_hermes: Fix typo
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Justin van Son, Christian Walter, Angel Pons, Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67343 ) Change subject: configs/config.prodrive_hermes: Fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf24e00fb895a670ea798f64a79035d858ec0d4f Gerrit-Change-Number: 67343 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:15:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/lint/checkpatch: check for phases in commit message.
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67347 ) Change subject: util/lint/checkpatch: check for phases in commit message. ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0fe7c75cc10926a3f4713c350c39af11b62bbae Gerrit-Change-Number: 67347 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:08:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/lint: Add rules.h & compiler.h to 019-header-files linter
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67350 ) Change subject: util/lint: Add rules.h & compiler.h to 019-header-files linter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4964ff26f5e83abbbdd26c2b1cd9a2eab5a0a0d Gerrit-Change-Number: 67350 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:07:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/soc/intel: remove force-included header compiler.h from file
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67349 ) Change subject: src/soc/intel: remove force-included header compiler.h from file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d3eb3f5e5f940910b2d45e0a2ae508e5ce91609 Gerrit-Change-Number: 67349 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:06:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src: remove force-included header rules.h from individual files
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth, Philipp Hug, Julius Werner, ron minnich. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67348 ) Change subject: src: remove force-included header rules.h from individual files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a1876b4b671d8565cf9b391d3babf800c074db Gerrit-Change-Number: 67348 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:06:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/hp/z220_series: Add configs for integrated XHCI
by Bill XIE (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Paul Menzel. Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67089 ) Change subject: mb/hp/z220_series: Add configs for integrated XHCI ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67089/comment/b8d133bf_71d393b9 PS8, Line 13: for a variant. > Needs an update. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifddecfd1d32ed6ab84d7eed8dc2d85d83cbebbcc Gerrit-Change-Number: 67089 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:04:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/hp/z220_series: Add configs for integrated XHCI
by Bill XIE (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Bill XIE, Paul Menzel. Hello build bot (Jenkins), Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67089 to look at the new patch set (#9). Change subject: mb/hp/z220_series: Add configs for integrated XHCI ...................................................................... mb/hp/z220_series: Add configs for integrated XHCI Without these, all SuperSpeed ports are wired to EHCI #2. "superspeed_capable_ports" and "xhci_switchable_ports" should fit both CMT and SFF variants, while "xhci_overcurrent_mapping" should be consistent with the first 4 elements of mainboard_usb_ports[]. With this commit, SuperSpeed devices plugged in SuperSpeed ports are wired to the XHCI on my own Z220 SFF. Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org> Change-Id: Ifddecfd1d32ed6ab84d7eed8dc2d85d83cbebbcc --- M src/mainboard/hp/z220_series/devicetree.cb 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/67089/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/67089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifddecfd1d32ed6ab84d7eed8dc2d85d83cbebbcc Gerrit-Change-Number: 67089 Gerrit-PatchSet: 9 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: Documentation: Add some more acronyms to the list.
by Martin L Roth (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Nicholas Chin. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67330 ) Change subject: Documentation: Add some more acronyms to the list. ...................................................................... Patch Set 1: (7 comments) Patchset: PS1: Thank File Documentation/acronyms.md: https://review.coreboot.org/c/coreboot/+/67330/comment/dbdd7cee_aabeac68 PS1, Line 50: ] > Should be a * to match opening double asterisks Thanks! definitely appreciate the thorough review. Done. https://review.coreboot.org/c/coreboot/+/67330/comment/fcf88643_b2fc3a54 PS1, Line 61: in processor chip > Seems like this is missing a word, perhaps "in a processor chip" or "in the processor chip" Done https://review.coreboot.org/c/coreboot/+/67330/comment/88c537a0_5e53e977 PS1, Line 305: EDP > eDP Done https://review.coreboot.org/c/coreboot/+/67330/comment/62e1cbb7_6168b459 PS1, Line 603: This has been : generally been : https://en.wikipedia.org/wiki/MultiProcessor_Specification by the ACPI : tables. > Noticed this when skimming the rendered markdown. […] I'm going with `superseded`. https://review.coreboot.org/c/coreboot/+/67330/comment/ef4d50c3_70d65bc9 PS1, Line 647: [Original Design Manufacturer] > Nit: Add double asterisks (bold) for consistency with other external links in this list Done https://review.coreboot.org/c/coreboot/+/67330/comment/5632638f_2356b9b2 PS1, Line 948: TME - Intel: Total Memory Encryption > Should be moved a line down as it breaks the TLB hyperlink Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d Gerrit-Change-Number: 67330 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 16:58:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation: Add some more acronyms to the list.
by build bot (Jenkins) (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67330 ) Change subject: Documentation: Add some more acronyms to the list. ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158077): https://review.coreboot.org/c/coreboot/+/67330/comment/18cb19ec_b9d75c78 PS2, Line 6: Subject line should not end with a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/67330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d Gerrit-Change-Number: 67330 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 16:58:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022