coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[L] Change in coreboot[master]: qualcomm/sc7280: remove unnecessary malloc and early return on failure
by Yu-Ping Wu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Shelley Chen, Venkat Thogaru, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66975 ) Change subject: qualcomm/sc7280: remove unnecessary malloc and early return on failure ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/66975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51f7a86d143128d2c426fb8940ff34a66152b426 Gerrit-Change-Number: 66975 Gerrit-PatchSet: 4 Gerrit-Owner: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 05 Sep 2022 23:27:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: Add Intel Whitetip Mountain 2 mainboard
by Nico Huber (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Stefan Reinauer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/2725 ) Change subject: Add Intel Whitetip Mountain 2 mainboard ...................................................................... Patch Set 4: (1 comment) File src/mainboard/intel/wtm2/romstage.c: https://review.coreboot.org/c/coreboot/+/2725/comment/58e544c6_45c1ac74 PS4, Line 121: spd_addresses: { 0xa2, 0x00, 0xa2, 0x00 }, > These SPD addresses look wrong Slippy has memory down, and may or may not be derived from this. Maybe this really is 1 EEPROM for 2 channels with the same config? Also, the line changed on purpose from WTM1 to WTM2. Can't be sure without the hardware at hand ofc. -- To view, visit https://review.coreboot.org/c/coreboot/+/2725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I999452d86f00a2c245fa39b1b76080f6a3b1e352 Gerrit-Change-Number: 2725 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Duncan Laurie Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Sep 2022 21:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/hermes: Add libgfxinit support
by Angel Pons (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Christian Walter. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62648 ) Change subject: mb/prodrive/hermes: Add libgfxinit support ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62648/comment/59717b30_8d912996 PS4, Line 9: Tested DP port works. HDMI seems broken, but that is also the case in Linux. > LSPCon is actually the only difference between the default and avalanche […] I had a look at the actual hardware today. The Poseidon (default VBT) piggyback board has two DisplayPort connectors and an HDMI connector with the MegaChips LSPCON. There's also a more sophisticated piggyback board, which includes SFP connectors. IIRC it has DVI-I with some chip, HDMI (I didn't see a LSPCON) and DisplayPort. Patchset: PS4: Will try to test this tomorrow. -- To view, visit https://review.coreboot.org/c/coreboot/+/62648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib71d06e1d83cd26b0fef37acc64f699c452c13dc Gerrit-Change-Number: 62648 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 21:44:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/broadwell: Consolidate SPD handling
by Angel Pons (Code Review) 05 Sep '22

05 Sep '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55811 ) Change subject: soc/intel/broadwell: Consolidate SPD handling ...................................................................... Patch Set 14: (1 comment) File src/mainboard/intel/wtm2/pei_data.c: https://review.coreboot.org/c/coreboot/+/55811/comment/1cb6c7e9_0ebe60cc PS14, Line 8: spdi->addresses[0] = 0x51; : spdi->addresses[2] = 0x51; > This has been wrong since coreboot 4.4 so it's either an ancient mistake or it's just a weird board. CB:2725 already had this issue -- To view, visit https://review.coreboot.org/c/coreboot/+/55811 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92a05003a319c354675368cae8e34980bd2f9e10 Gerrit-Change-Number: 55811 Gerrit-PatchSet: 14 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 05 Sep 2022 21:37:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: Add Intel Whitetip Mountain 2 mainboard
by Angel Pons (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/2725 ) Change subject: Add Intel Whitetip Mountain 2 mainboard ...................................................................... Patch Set 4: (1 comment) File src/mainboard/intel/wtm2/romstage.c: https://review.coreboot.org/c/coreboot/+/2725/comment/e0c03a4b_14d520e3 PS4, Line 121: spd_addresses: { 0xa2, 0x00, 0xa2, 0x00 }, These SPD addresses look wrong -- To view, visit https://review.coreboot.org/c/coreboot/+/2725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I999452d86f00a2c245fa39b1b76080f6a3b1e352 Gerrit-Change-Number: 2725 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Duncan Laurie Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Sep 2022 21:36:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/broadwell: Consolidate SPD handling
by Angel Pons (Code Review) 05 Sep '22

05 Sep '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55811 ) Change subject: soc/intel/broadwell: Consolidate SPD handling ...................................................................... Patch Set 14: (1 comment) File src/mainboard/intel/wtm2/pei_data.c: https://review.coreboot.org/c/coreboot/+/55811/comment/3f0f28b7_f51b8b42 PS14, Line 8: spdi->addresses[0] = 0x51; : spdi->addresses[2] = 0x51; > > looks like there is a typo. […] This has been wrong since coreboot 4.4 so it's either an ancient mistake or it's just a weird board. -- To view, visit https://review.coreboot.org/c/coreboot/+/55811 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92a05003a319c354675368cae8e34980bd2f9e10 Gerrit-Change-Number: 55811 Gerrit-PatchSet: 14 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 05 Sep 2022 21:34:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/lint: ignore util/goswid, a new submodule
by Martin L Roth (Code Review) 05 Sep '22

05 Sep '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67327 ) Change subject: util/lint: ignore util/goswid, a new submodule ...................................................................... util/lint: ignore util/goswid, a new submodule git submodules should be ignored when parsing the coreboot tree for lint errors. Those should be handled in their own commit checks. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I62b58f0c536312fe4677855bca8f44bc7d3ebc85 Reviewed-on: https://review.coreboot.org/c/coreboot/+/67327 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/lint/lint-stable-003-whitespace 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/util/lint/lint-stable-003-whitespace b/util/lint/lint-stable-003-whitespace index 9a6db00..5174120 100755 --- a/util/lint/lint-stable-003-whitespace +++ b/util/lint/lint-stable-003-whitespace @@ -5,7 +5,7 @@ # DESCR: Check for superfluous whitespace in the tree LC_ALL=C export LC_ALL -EXCLUDELIST='^src/vendorcode/|^util/kconfig/|^util/nvidia/cbootimage$|COPYING|LICENSE|README|_shipped$|\.patch$|\.bin$|\.hex$|\.jpg$|\.gif$|\.ttf$|\.woff$|\.png$|\.eot$|\.vbt$|\.ico$|\.md$' +EXCLUDELIST='^src/vendorcode/|^util/kconfig/|^util/nvidia/cbootimage$|^util/goswid$|COPYING|LICENSE|README|_shipped$|\.patch$|\.bin$|\.hex$|\.jpg$|\.gif$|\.ttf$|\.woff$|\.png$|\.eot$|\.vbt$|\.ico$|\.md$' INCLUDELIST="src util payloads Makefile* toolchain.inc tests" # shellcheck disable=SC2086,SC2046 -- To view, visit https://review.coreboot.org/c/coreboot/+/67327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62b58f0c536312fe4677855bca8f44bc7d3ebc85 Gerrit-Change-Number: 67327 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in coreboot[master]: util/lint: Update tools that use git to use a library
by Martin L Roth (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64973 ) Change subject: util/lint: Update tools that use git to use a library ...................................................................... Patch Set 5: (1 comment) File util/lint/helper_functions.sh: https://review.coreboot.org/c/coreboot/+/64973/comment/21e3de35_2f1ef5ae PS4, Line 5: > I'll add a description to the file, but the DESCR line is for the 'lint' tool to show what the tests […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64973 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61ba1cc4f7205e0d4baf993588bbc774120405cb Gerrit-Change-Number: 64973 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Sep 2022 19:34:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/lint: Update tools that use git to use a library
by Martin L Roth (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Hello Felix Singer, build bot (Jenkins), Paul Menzel, Angel Pons, Elyes Haouas, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64973 to look at the new patch set (#5). Change subject: util/lint: Update tools that use git to use a library ...................................................................... util/lint: Update tools that use git to use a library Each of the tools that used git had similar functionality. This combines all of that into a single script that gets sourced by each. This makes maintenance much easier. By doing this and updating each of the scripts to do the correct thing if the script isn't being run in a git repository, it makes them work much better for the releases, which are just released as a tarball, without any attached git repository. Change-Id: I61ba1cc4f7205e0d4baf993588bbc774120405cb Signed-off-by: Martin Roth <martin(a)coreboot.org> --- A util/lint/helper_functions.sh M util/lint/lint-000-license-headers M util/lint/lint-007-checkpatch M util/lint/lint-008-kconfig M util/lint/lint-014-qualified-types M util/lint/lint-extended-015-final-newlines M util/lint/lint-extended-020-signed-off-by M util/lint/lint-stable-003-whitespace M util/lint/lint-stable-004-style-labels M util/lint/lint-stable-005-board-status M util/lint/lint-stable-008-kconfig M util/lint/lint-stable-009-old-licenses M util/lint/lint-stable-010-asm-syntax M util/lint/lint-stable-012-executable-bit M util/lint/lint-stable-013-site-local M util/lint/lint-stable-016-non-ascii M util/lint/lint-stable-017-configs M util/lint/lint-stable-018-symlinks M util/lint/lint-stable-019-header-files M util/lint/lint-stable-021-coreboot-lowercase M util/lint/lint-stable-022-clang-format M util/lint/lint-stable-023-filenames M util/lint/lint-stable-026-line-endings 23 files changed, 293 insertions(+), 152 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/64973/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/64973 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61ba1cc4f7205e0d4baf993588bbc774120405cb Gerrit-Change-Number: 64973 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/kconfig/regex.c: Remove leftover
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67353 ) Change subject: util/kconfig/regex.c: Remove leftover ...................................................................... util/kconfig/regex.c: Remove leftover coreboot doesn't support the MIPS architecture anymore. Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I404d034949a7786d7971117081537baf27ff2e22 --- M util/kconfig/regex.c 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/67353/1 diff --git a/util/kconfig/regex.c b/util/kconfig/regex.c index d0e1d7b..bde5f82 100644 --- a/util/kconfig/regex.c +++ b/util/kconfig/regex.c @@ -3098,7 +3098,6 @@ /* Free everything we malloc. */ -#ifdef REGEX_MALLOC #define FREE_VAR(var) if (var) free (var); var = NULL #define FREE_VARIABLES() \ do { \ @@ -3113,10 +3112,6 @@ FREE_VAR (reg_dummy); \ FREE_VAR (reg_info_dummy); \ } while (0) -#else /* not REGEX_MALLOC */ -/* Some MIPS systems (at least) want this to free alloca'd storage. */ -#define FREE_VARIABLES() alloca (0) -#endif /* not REGEX_MALLOC */ /* These values must meet several constraints. They must not be valid -- To view, visit https://review.coreboot.org/c/coreboot/+/67353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I404d034949a7786d7971117081537baf27ff2e22 Gerrit-Change-Number: 67353 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022