coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[S] Change in coreboot[master]: mb/google/rex: Add FW_CONFIG* to Kconfig
by Subrata Banik (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Eran Mitrani, Paul Menzel, Kapil Porwal. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66817 ) Change subject: mb/google/rex: Add FW_CONFIG* to Kconfig ...................................................................... Patch Set 22: -Code-Review (1 comment) Patchset: PS22: Will get back later after enabling/flashing the CBI binary -- To view, visit https://review.coreboot.org/c/coreboot/+/66817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib729c98a4d67aa46992fdccf592010b0313605a6 Gerrit-Change-Number: 66817 Gerrit-PatchSet: 22 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 18:24:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/lint: Update tools that use git to use a library
by Martin L Roth (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64973 ) Change subject: util/lint: Update tools that use git to use a library ...................................................................... Patch Set 4: (1 comment) File util/lint/helper_functions.sh: https://review.coreboot.org/c/coreboot/+/64973/comment/24f6d552_e8aa226b PS4, Line 5: > Add a DESCR line? I'll add a description to the file, but the DESCR line is for the 'lint' tool to show what the tests are supposed to do. Since this isn't a tool, but a library included by the tools, that isn't applicable here. https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/ut… -- To view, visit https://review.coreboot.org/c/coreboot/+/64973 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61ba1cc4f7205e0d4baf993588bbc774120405cb Gerrit-Change-Number: 64973 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Sep 2022 18:23:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/lint: Add rules.h & compiler.h to 019-header-files linter
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67350 ) Change subject: util/lint: Add rules.h & compiler.h to 019-header-files linter ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4964ff26f5e83abbbdd26c2b1cd9a2eab5a0a0d Gerrit-Change-Number: 67350 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 18:14:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in blobs[master]: soc/mediatek: Update capitalization of coreboot
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth, Martin Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/67352 ) Change subject: soc/mediatek: Update capitalization of coreboot ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/67352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: Icb1d6ee12057d552938496d198a17b6c8bfd93e8 Gerrit-Change-Number: 67352 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 18:13:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation: Add some more acronyms to the list.
by Nicholas Chin (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67330 ) Change subject: Documentation: Add some more acronyms to the list. ...................................................................... Patch Set 2: (2 comments) File Documentation/acronyms.md: https://review.coreboot.org/c/coreboot/+/67330/comment/14ccd5f1_a54f4d02 PS1, Line 50: ] > Thanks! definitely appreciate the thorough review. […] Probably should have worded this more clearly, what I meant was replace the extra "]" with the second "*". All that needs to be done now is remove the extra closing square bracket. File Documentation/acronyms.md: https://review.coreboot.org/c/coreboot/+/67330/comment/7c1b33ff_f4e5b1e2 PS2, Line 603: been Remove the first "been", should be "This has generally been superseded by" instead of "This has been generally been superseded by" -- To view, visit https://review.coreboot.org/c/coreboot/+/67330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d Gerrit-Change-Number: 67330 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 18:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/lint/lint-stable-019-header-files: add test
by Elyes Haouas (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67351 ) Change subject: util/lint/lint-stable-019-header-files: add test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I971951d4248dd10abe4c622025fdaf86e014c6cc Gerrit-Change-Number: 67351 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Sep 2022 18:09:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in blobs[master]: soc/mediatek: Update capitalization of coreboot
by Martin L Roth (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin Roth. Hello Martin Roth, I'd like you to do a code review. Please visit https://review.coreboot.org/c/blobs/+/67352 to review the following change. Change subject: soc/mediatek: Update capitalization of coreboot ...................................................................... soc/mediatek: Update capitalization of coreboot coreboot was spelled with a capital C in these files. We don't run the linters on these files, but since they're part of a coreboot-owned repo, let's fix them. Signed-off-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Change-Id: Icb1d6ee12057d552938496d198a17b6c8bfd93e8 --- M soc/mediatek/mt8183/README.md M soc/mediatek/mt8186/README.md M soc/mediatek/mt8195/README.md 3 files changed, 25 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/52/67352/1 diff --git a/soc/mediatek/mt8183/README.md b/soc/mediatek/mt8183/README.md index f217387..7233a07 100644 --- a/soc/mediatek/mt8183/README.md +++ b/soc/mediatek/mt8183/README.md @@ -11,13 +11,13 @@ ## Who uses it -Coreboot loads `dram.elf` at the first time bootup if no DRAM parameters have +coreboot loads `dram.elf` at the first time bootup if no DRAM parameters have been cached. ## How to load `dram.elf` -Coreboot locates `dram.elf` file, and locates the entry point `_start`, +coreboot locates `dram.elf` file, and locates the entry point `_start`, then it passes DRAM struct `param`, and calls `_start(&param)` to execute `dram.elf` flow. diff --git a/soc/mediatek/mt8186/README.md b/soc/mediatek/mt8186/README.md index eb7a848..e5e497a 100644 --- a/soc/mediatek/mt8186/README.md +++ b/soc/mediatek/mt8186/README.md @@ -29,7 +29,7 @@ SSPM firmware is loaded into SSPM SRAM at system initialization. ## Who uses it -Coreboot will load sspm.bin to SSPM SRAM at ramstage. +coreboot will load sspm.bin to SSPM SRAM at ramstage. ## How to load `sspm.bin` Use CBFS to load `sspm.bin`. @@ -49,11 +49,11 @@ bootups. ## Who uses it -Coreboot loads `dram.elf` during the first bootup if no valid DRAM parameters +coreboot loads `dram.elf` during the first bootup if no valid DRAM parameters are found on NOR/NAND or eMMC. ## How to load `dram.elf` -Coreboot locates `dram.elf` file, locates the entry point `_start`, +coreboot locates `dram.elf` file, locates the entry point `_start`, passes a `dramc_param` struct argument `dparam` to it, and calls `_start(&dparam)` to execute `dram.elf`. @@ -130,7 +130,7 @@ ## The output of `dram.elf` `dram.elf` configures suitable dramc settings and returns the DRAM parameters. -Then, Coreboot saves the parameters on the specified firmware flash section: +Then, coreboot saves the parameters on the specified firmware flash section: `"RW_MRC_CACHE"`. ## Return values diff --git a/soc/mediatek/mt8195/README.md b/soc/mediatek/mt8195/README.md index 872764b..f7fba10 100644 --- a/soc/mediatek/mt8195/README.md +++ b/soc/mediatek/mt8195/README.md @@ -12,7 +12,7 @@ MCUPM firmware (`mcupm.bin`) is loaded into MCUPM SRAM at system initialization. ## Who uses it -Coreboot will load MCUPM at ramstage. It will copy mcupm.bin to MCUPM SRAM. +coreboot will load MCUPM at ramstage. It will copy mcupm.bin to MCUPM SRAM. ## How to load `mcupm.bin` Use CBFS to load `mcupm.bin`, then set normal boot flag and release software reset pin of MCUPM. @@ -32,7 +32,7 @@ SSPM firmware is loaded into SSPM SRAM at system initialization. ## Who uses it -Coreboot will load sspm.bin to SSPM SRAM at ramstage. +coreboot will load sspm.bin to SSPM SRAM at ramstage. ## How to load `sspm.bin` Use CBFS to load `sspm.bin`. @@ -69,11 +69,11 @@ bootups. ## Who uses it -Coreboot loads `dram.elf` during the first bootup if no valid DRAM parameters +coreboot loads `dram.elf` during the first bootup if no valid DRAM parameters are found on NOR/NAND or eMMC. ## How to load `dram.elf` -Coreboot locates `dram.elf` file, locates the entry point `_start`, +coreboot locates `dram.elf` file, locates the entry point `_start`, passes a `dramc_param` struct argument `dparam` to it, and calls `_start(&dparam)` to execute `dram.elf`. @@ -138,7 +138,7 @@ ## The output of `dram.elf` `dram.elf` configures suitable dramc settings and returns the DRAM parameters. -Then, Coreboot saves the parameters on the specified firmware flash section: +Then, coreboot saves the parameters on the specified firmware flash section: `"RW_MRC_CACHE"`. ## Return values -- To view, visit https://review.coreboot.org/c/blobs/+/67352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: Icb1d6ee12057d552938496d198a17b6c8bfd93e8 Gerrit-Change-Number: 67352 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/lint/lint-stable-019-header-files: add test
by Martin L Roth (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67351 ) Change subject: util/lint/lint-stable-019-header-files: add test ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'd initially started a test script with util/lint/check_lint_tests, but I think including the tests as a part of the script itself is a better solution. -- To view, visit https://review.coreboot.org/c/coreboot/+/67351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I971951d4248dd10abe4c622025fdaf86e014c6cc Gerrit-Change-Number: 67351 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 05 Sep 2022 17:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/lint/lint-stable-019-header-files: add test
by Martin L Roth (Code Review) 05 Sep '22

05 Sep '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67351 ) Change subject: util/lint/lint-stable-019-header-files: add test ...................................................................... util/lint/lint-stable-019-header-files: add test Add a test to make sure that the linter fails correctly. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I971951d4248dd10abe4c622025fdaf86e014c6cc --- M util/lint/lint-stable-019-header-files 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/67351/1 diff --git a/util/lint/lint-stable-019-header-files b/util/lint/lint-stable-019-header-files index 6495d15..f73e0e7 100755 --- a/util/lint/lint-stable-019-header-files +++ b/util/lint/lint-stable-019-header-files @@ -11,6 +11,28 @@ HEADER_FILES="k\?config rules compiler" +TESTFILE1="src/lib/version.c" +TESTFILE2="src/lib/string.c" +TESTFILE3="src/lib/malloc.c" +TESTFILE4="src/lib/hardwaremain.c" +EXPECTED_FAILURES=4 + +# Configure to make sure tests fail +if [ "$1" = "--test" ]; then + sed -i.bak "s|^.*SPDX-License-Identifier.*|&\n\n#include <config.h>\n|" "${TESTFILE1}" + sed -i.bak "s|^.*SPDX-License-Identifier.*|&\n\n#include \"kconfig.h\"\n|" "${TESTFILE2}" + sed -i.bak "s|^.*SPDX-License-Identifier.*|&\n\n#include \"compiler.h\"\n|" "${TESTFILE3}" + sed -i.bak "s|^.*SPDX-License-Identifier.*|&\n\n#include <rules.h>\n|" "${TESTFILE4}" + echo "Expect ${EXPECTED_FAILURES} failures." + exit 0 +elif [ "$1" = "--reset" ]; then + mv "${TESTFILE1}.bak" "${TESTFILE1}" + mv "${TESTFILE2}.bak" "${TESTFILE2}" + mv "${TESTFILE3}.bak" "${TESTFILE3}" + mv "${TESTFILE4}.bak" "${TESTFILE4}" + exit 0 +fi + # Use git grep if the code is in a git repo, otherwise use grep. if [ -n "$(command -v git)" ] && \ [ "$(git rev-parse --is-inside-work-tree 2>/dev/null)" = "true" ] -- To view, visit https://review.coreboot.org/c/coreboot/+/67351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I971951d4248dd10abe4c622025fdaf86e014c6cc Gerrit-Change-Number: 67351 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/lint: Add rules.h & compiler.h to 019-header-files linter
by Martin L Roth (Code Review) 05 Sep '22

05 Sep '22

Attention is currently required from: Martin L Roth. Hello build bot (Jenkins), Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67350 to look at the new patch set (#3). Change subject: util/lint: Add rules.h & compiler.h to 019-header-files linter ...................................................................... util/lint: Add rules.h & compiler.h to 019-header-files linter The rules.h & compiler.h includes were removed in previous commits, so add the checks to keep them out to the linter. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: If4964ff26f5e83abbbdd26c2b1cd9a2eab5a0a0d --- M util/lint/lint-stable-019-header-files 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/67350/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/67350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4964ff26f5e83abbbdd26c2b1cd9a2eab5a0a0d Gerrit-Change-Number: 67350 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022