coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[S] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by build bot (Jenkins) (Code Review) 06 Sep '22

06 Sep '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67365 ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Patch Set 1: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158092): https://review.coreboot.org/c/coreboot/+/67365/comment/94ed246f_a61f4bde PS1, Line 9: Updating from commit id e0a6a512b: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158092): https://review.coreboot.org/c/coreboot/+/67365/comment/b769d4ad_fde958dc PS1, Line 12: to commit id 7805999e6: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/67365 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19e4cb1d423086796040834ebce9262d39935e90 Gerrit-Change-Number: 67365 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Sep 2022 06:29:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by Yu-Ping Wu (Code Review) 06 Sep '22

06 Sep '22

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67365 ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Update arm-trusted-firmware submodule to upstream master Updating from commit id e0a6a512b: 2022-02-03 22:59:34 +0100 - (Merge changes from topic "msm8916" into integration) to commit id 7805999e6: 2022-09-05 16:42:34 +0200 - (Merge changes from topic "st-nand-updates" into integration) This brings in 1030 new commits. Change-Id: I19e4cb1d423086796040834ebce9262d39935e90 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M 3rdparty/arm-trusted-firmware 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/67365/1 diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index e0a6a51..7805999 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit e0a6a512b51558b64eb500e6b731e4c743050af2 +Subproject commit 7805999e645da500ccd971c2ab9a60c763b299e8 -- To view, visit https://review.coreboot.org/c/coreboot/+/67365 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19e4cb1d423086796040834ebce9262d39935e90 Gerrit-Change-Number: 67365 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/geralt: Pass reset gpio parameter to BL31
by Yu-Ping Wu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Rex-BC Chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67357 ) Change subject: mb/google/geralt: Pass reset gpio parameter to BL31 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67357/comment/2e24719b_46361cfe PS1, Line 9: To support gpio reset SoC, we need to pass the reset gpio parameter to : BL31. Pass the reset gpio parameter to BL31 to support SoC reset. -- To view, visit https://review.coreboot.org/c/coreboot/+/67357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdfbd6bd82f64b084f6349cb617443053c89a3f1 Gerrit-Change-Number: 67357 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 06:22:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: Enable ARM Trusted Firmware integration
by Yu-Ping Wu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67356 ) Change subject: soc/mediatek/mt8188: Enable ARM Trusted Firmware integration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id16405c84f6e0a2e21f95cc45babf85bd980b43e Gerrit-Change-Number: 67356 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 06:21:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8188: enable mfgpll properly and fix SPMI muxes
by Yu-Ping Wu (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67355 ) Change subject: soc/mediatek/mt8188: enable mfgpll properly and fix SPMI muxes ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67355/comment/c422c9d5_c2a6de7b PS1, Line 9: We failed to bringup GPU in kernel due to the wrong pll setting. Some of the pll settings are incorrect, which cause problems in GPU after booting into kernel. File src/soc/mediatek/mt8188/pll.c: https://review.coreboot.org/c/coreboot/+/67355/comment/6a9242f5_5cb80c55 PS1, Line 526: setbits32 Use `clrsetbits32`. -- To view, visit https://review.coreboot.org/c/coreboot/+/67355 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I971109a5f72e3307899daaf5a5f26022124b559b Gerrit-Change-Number: 67355 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 06:20:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/kinox: Update the DPTF parameters and fan table
by Sumeet R Pawnikar (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Dtrain Hsu, Tim Wawrzynczak, Ricky Chang. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67314 ) Change subject: mb/google/brya/var/kinox: Update the DPTF parameters and fan table ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I751bc5442f64428c383034755cd5d74fbd0ea91e Gerrit-Change-Number: 67314 Gerrit-PatchSet: 3 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 05:23:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: intelp2m: Add Go Managing Dependencies System support
by David Hendricks (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Martin L Roth, Patrick Georgi, Maxim Polyakov, Paul Menzel, Angel Pons, ron minnich. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64724 ) Change subject: intelp2m: Add Go Managing Dependencies System support ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Patchset: PS7: I was able to apply this patch to a personal repo, modify the URLs, and import from another project and it seemed to work fine. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/64724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12efae31227129b8c884af10fb233f398c4094e7 Gerrit-Change-Number: 64724 Gerrit-PatchSet: 7 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 05:23:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek: a common implementation to register BL31 reset
by Hung-Te Lin (Code Review) 06 Sep '22

06 Sep '22

Hung-Te Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67359 ) Change subject: soc/mediatek: a common implementation to register BL31 reset ...................................................................... soc/mediatek: a common implementation to register BL31 reset WIP - we should provide a weak/stub if ATF config is not selected. BUG=None TEST=None Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Signed-off-by: Hung-Te Lin <hungte(a)chromium.org> --- M src/mainboard/google/cherry/mainboard.c A src/soc/mediatek/common/bl31.c A src/soc/mediatek/common/include/soc/bl31.h M src/soc/mediatek/mt8183/Makefile.inc M src/soc/mediatek/mt8186/Makefile.inc M src/soc/mediatek/mt8188/Makefile.inc M src/soc/mediatek/mt8192/Makefile.inc M src/soc/mediatek/mt8195/Makefile.inc 8 files changed, 62 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/67359/1 diff --git a/src/mainboard/google/cherry/mainboard.c b/src/mainboard/google/cherry/mainboard.c index b69403e..a4f76bb 100644 --- a/src/mainboard/google/cherry/mainboard.c +++ b/src/mainboard/google/cherry/mainboard.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <bl31.h> #include <boardid.h> #include <bootmode.h> #include <console/console.h> @@ -10,6 +9,7 @@ #include <edid.h> #include <framebuffer_info.h> #include <gpio.h> +#include <soc/bl31.h> #include <soc/ddp.h> #include <soc/dpm.h> #include <soc/dptx.h> @@ -23,8 +23,6 @@ #include "gpio.h" -#include <arm-trusted-firmware/include/export/plat/mediatek/common/plat_params_exp.h> - /* GPIO to schematics names */ #define GPIO_AP_EDP_BKLTEN GPIO(DGI_D5) #define GPIO_BL_PWM_1V8 GPIO(DISP_PWM0) @@ -57,17 +55,6 @@ } } -static void register_reset_to_bl31(void) -{ - static struct bl_aux_param_gpio param_reset = { - .h = { .type = BL_AUX_PARAM_MTK_RESET_GPIO }, - .gpio = { .polarity = ARM_TF_GPIO_LEVEL_HIGH }, - }; - - param_reset.gpio.index = GPIO_RESET.id; - register_bl31_aux_param(&param_reset.h); -} - /* Set up backlight control pins as output pin and power-off by default */ static void configure_panel_backlight(void) { @@ -160,7 +147,8 @@ if (spm_init()) printk(BIOS_ERR, "spm init failed, system suspend may not work\n"); - register_reset_to_bl31(); + if (CONFIG(ARM64_USE_ARM_TRUSTED_FIRMWARE)) + register_reset_to_bl31(GPIO_RESET.id, ACTIVE_HIGH); } static void mainboard_enable(struct device *dev) diff --git a/src/soc/mediatek/common/bl31.c b/src/soc/mediatek/common/bl31.c new file mode 100644 index 0000000..d89ce1a --- /dev/null +++ b/src/soc/mediatek/common/bl31.c @@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <assert.h> + +#include <bl31.h> +#include <soc/bl31.h> +#include <boot/coreboot_tables.h> +#include <gpio.h> +#include <arm-trusted-firmware/include/export/plat/mediatek/common/plat_params_exp.h> + +void register_reset_to_bl31(int gpio_index, int gpio_polarity) +{ + static struct bl_aux_param_gpio param_reset = { + .h = { .type = BL_AUX_PARAM_MTK_RESET_GPIO }, + }; + + switch (gpio_polarity) { + case ACTIVE_HIGH: + param_reset.gpio.polarity = ARM_TF_GPIO_LEVEL_HIGH; + break; + + case ACTIVE_LOW: + param_reset.gpio.polarity = ARM_TF_GPIO_LEVEL_LOW; + break; + + default: + assert(0); + } + + param_reset.gpio.index = gpio_index; + register_bl31_aux_param(&param_reset.h); +} diff --git a/src/soc/mediatek/common/include/soc/bl31.h b/src/soc/mediatek/common/include/soc/bl31.h new file mode 100644 index 0000000..0c61ed3 --- /dev/null +++ b/src/soc/mediatek/common/include/soc/bl31.h @@ -0,0 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ +#ifndef _SOC_BL31_H_ +#define _SOC_BL31_H_ + +void register_reset_to_bl31(int gpio_index, int gpio_polarity); + +#endif /* _SOC_BL31_H_ */ diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc index 2cf8133..1624421 100644 --- a/src/soc/mediatek/mt8183/Makefile.inc +++ b/src/soc/mediatek/mt8183/Makefile.inc @@ -25,6 +25,7 @@ verstage-y += ../common/wdt.c romstage-y += ../common/auxadc.c +ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += ../common/bl31.c romstage-y += ../common/cbmem.c emi.c romstage-y += dramc_init_setting.c romstage-y += dramc_param.c diff --git a/src/soc/mediatek/mt8186/Makefile.inc b/src/soc/mediatek/mt8186/Makefile.inc index 892c809..bd1e560 100644 --- a/src/soc/mediatek/mt8186/Makefile.inc +++ b/src/soc/mediatek/mt8186/Makefile.inc @@ -27,6 +27,7 @@ romstage-y += ../common/rtc.c ../common/rtc_osc_init.c rtc.c ramstage-y += ../common/auxadc.c +ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += ../common/bl31.c ramstage-y += ../common/ddp.c ddp.c ramstage-y += ../common/devapc.c devapc.c ramstage-y += ../common/dfd.c diff --git a/src/soc/mediatek/mt8188/Makefile.inc b/src/soc/mediatek/mt8188/Makefile.inc index 70ec42a..3f83cbc 100644 --- a/src/soc/mediatek/mt8188/Makefile.inc +++ b/src/soc/mediatek/mt8188/Makefile.inc @@ -29,6 +29,7 @@ romstage-y += ../common/rtc.c ../common/rtc_osc_init.c ../common/rtc_mt6359p.c ramstage-y += ../common/auxadc.c +ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += ../common/bl31.c ramstage-y += ../common/devapc.c devapc.c ramstage-y += ../common/dfd.c ramstage-y += ../common/dpm.c diff --git a/src/soc/mediatek/mt8192/Makefile.inc b/src/soc/mediatek/mt8192/Makefile.inc index 3e3f59ae..cd3f473 100644 --- a/src/soc/mediatek/mt8192/Makefile.inc +++ b/src/soc/mediatek/mt8192/Makefile.inc @@ -32,6 +32,7 @@ ramstage-y += apusys.c ramstage-y += ../common/auxadc.c +ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += ../common/bl31.c ramstage-y += ../common/ddp.c ddp.c ramstage-y += devapc.c ramstage-y += ../common/dfd.c diff --git a/src/soc/mediatek/mt8195/Makefile.inc b/src/soc/mediatek/mt8195/Makefile.inc index a09cb9c..2d50506 100644 --- a/src/soc/mediatek/mt8195/Makefile.inc +++ b/src/soc/mediatek/mt8195/Makefile.inc @@ -39,6 +39,7 @@ ramstage-y += apusys.c ramstage-y += apusys_devapc.c ramstage-y += ../common/auxadc.c +ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += ../common/bl31.c ramstage-y += ../common/early_init.c ramstage-y += ../common/ddp.c ddp.c ramstage-y += ../common/devapc.c devapc.c -- To view, visit https://review.coreboot.org/c/coreboot/+/67359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf Gerrit-Change-Number: 67359 Gerrit-PatchSet: 1 Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by Rex-BC Chen (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67358 ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67358 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I981956fbdcbcfa4ce185652478b9bb30d40f5686 Gerrit-Change-Number: 67358 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 05:02:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by build bot (Jenkins) (Code Review) 06 Sep '22

06 Sep '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67358 ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Patch Set 1: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158090): https://review.coreboot.org/c/coreboot/+/67358/comment/40809883_74f9cca9 PS1, Line 9: Updating from commit id e0a6a512b: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158090): https://review.coreboot.org/c/coreboot/+/67358/comment/a5fcee1a_471e47bc PS1, Line 12: to commit id 7805999e6: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/67358 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I981956fbdcbcfa4ce185652478b9bb30d40f5686 Gerrit-Change-Number: 67358 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Sep 2022 04:20:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022