Attention is currently required from: Michał Żygowski, Igor Bagnucki, Angel Pons.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63463 )
Change subject: mainboard/msi/ms7d25: Add early support for MSI PRO Z690-A DDR4 WIFI
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/msi/ms7d25/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/63463/comment/63f5fe4c_bd86e629
PS10, Line 11: /* OEM revision */
> It's not the OEM revision, this is just copy-pasta. Please drop the comment.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63463
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5df69822dbb3ff79e087408a0693de37df2142e8
Gerrit-Change-Number: 63463
Gerrit-PatchSet: 11
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:04:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Igor Bagnucki, Michał Kopeć.
Michał Kopeć has uploaded a new patch set (#11) to the change originally created by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/63463 )
Change subject: mainboard/msi/ms7d25: Add early support for MSI PRO Z690-A DDR4 WIFI
......................................................................
mainboard/msi/ms7d25: Add early support for MSI PRO Z690-A DDR4 WIFI
Initial mainboard code MSI PRO Z690-A DDR4 WIFI. The platform boots up
up to romstage where it returns from FSP memory init with an error.
What works:
- open-source CAR setup
- NCT6687D serial port with TX pin exposed on JBD1 header
- SMBus reading SPD from all 4 DIMMs
This board will serve as a reference board for enabling Alder Lake-S
support in coreboot. More code and functionalities will be added in
subsequent patches as src/soc/alderlake code will be improved for
PCH-S.
TEST=Extract the microcode from vendor firmware and include it in the
build. The platform should print the console on the serial port even
without FSP blob.
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Change-Id: I5df69822dbb3ff79e087408a0693de37df2142e8
Signed-off-by: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
---
A configs/config.msi_ms7d25
A src/mainboard/msi/ms7d25/Kconfig
A src/mainboard/msi/ms7d25/Kconfig.name
A src/mainboard/msi/ms7d25/Makefile.inc
A src/mainboard/msi/ms7d25/board_info.txt
A src/mainboard/msi/ms7d25/bootblock.c
A src/mainboard/msi/ms7d25/devicetree.cb
A src/mainboard/msi/ms7d25/dsdt.asl
A src/mainboard/msi/ms7d25/hda_verb.c
A src/mainboard/msi/ms7d25/mainboard.c
A src/mainboard/msi/ms7d25/romstage_fsp_params.c
11 files changed, 282 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/63463/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/63463
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5df69822dbb3ff79e087408a0693de37df2142e8
Gerrit-Change-Number: 63463
Gerrit-PatchSet: 11
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: zanxi chen.
zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64790 )
Change subject: mb/google/corsola: Enable ps8640 for steelix
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/64790
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c6310794c89fc8aa0e69e114c1f7ebd5479c549
Gerrit-Change-Number: 64790
Gerrit-PatchSet: 2
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 14:35:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64870 )
Change subject: cpu/amd/smm: Move MP & SMM init in a common place
......................................................................
Patch Set 3:
(1 comment)
File src/cpu/amd/smm/smm_helper.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150350):
https://review.coreboot.org/c/coreboot/+/64870/comment/a6297350_94c6765c
PS3, Line 88: static void get_smm_info(uintptr_t *perm_smbase, size_t *perm_smsize, size_t *smm_save_state_size)
line length of 98 exceeds 96 columns
--
To view, visit https://review.coreboot.org/c/coreboot/+/64870
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c457ab69581f8c29f2d79c054ca3bc7e58a896e
Gerrit-Change-Number: 64870
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 01 Jun 2022 13:33:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held.
Hello Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64872
to look at the new patch set (#5).
Change subject: soc/amd: Do SMM relocation via MSR
......................................................................
soc/amd: Do SMM relocation via MSR
AMD CPUs have a convenient MSR that allows to set the SMBASE in the save
state without ever entering SMM (e.g. at the default 0x30000 address).
This has been a feature in all AMD CPUs since at least AMD K8. This
allows to do relocation in parallel in ramstage and without setting up a
relocation handler, which likely results in a speedup. The more cores
the higher the speedup as relocation was happening sequentially. On a 4
core AMD picasso system this results in 33ms boot speedup.
TESTED on google/vilboz (Picasso) with CONFIG_SMI_DEBUG: verify that SMM
is correctly relocated with the BSP correctly entering the smihandler.
Change-Id: I9729fb94ed5c18cfd57b8098c838c08a04490e4b
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/amd/smm/smm_helper.c
M src/cpu/x86/Kconfig
M src/cpu/x86/mp_init.c
M src/soc/amd/common/Kconfig.common
4 files changed, 27 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/64872/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/64872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9729fb94ed5c18cfd57b8098c838c08a04490e4b
Gerrit-Change-Number: 64872
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held.
Hello Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64871
to look at the new patch set (#3).
Change subject: cpu/amd: Move locking SMM as part of SMM init
......................................................................
cpu/amd: Move locking SMM as part of SMM init
Change-Id: Ibcdfc0f9ae211644cf0911790b0b0c5d1b0b7dc9
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/amd/smm/smm_helper.c
M src/include/cpu/amd/smm.h
M src/soc/amd/common/block/cpu/smm/finalize.c
3 files changed, 4 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/64871/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/64871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcdfc0f9ae211644cf0911790b0b0c5d1b0b7dc9
Gerrit-Change-Number: 64871
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset