build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64873 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
......................................................................
Patch Set 1:
(72 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/79e4f0c8_afebb0fc
PS1, Line 20: Please share your feedback/suggestions and tell about other useful patches,
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/1b819f71_d364d0d0
PS1, Line 23: 1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options,
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/93c83abb_20876c47
PS1, Line 24: example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs,
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/5f754f72_2582b4d0
PS1, Line 25: and also good IRQ routing for AMD Lenovo G505S, ASUS A88XM-E and AM1I-A boards.
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/971f2fb5_2b6453e7
PS1, Line 31: Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Possible unwrapped commit description (prefer a maximum 72 chars per line)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/d4332b11_c6487b5d
PS1, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y.
line length of 98 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/37064054_711eb750
PS1, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful.
line length of 98 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/31894ae3_eb2c5e37
PS1, Line 215: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it.
line length of 99 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/a17ffefc_6e6d9591
PS1, Line 230: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560.
line length of 99 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/8c4e8e24_f40dcf75
PS1, Line 243: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches.
line length of 99 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/b2846923_a279af49
PS1, Line 251: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n"
line length of 99 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/ccc4ab8d_fa1518d0
PS1, Line 253: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n"
line length of 113 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/fa332aa7_a4f1b86c
PS1, Line 258: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n"
line length of 133 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/e78b3ca4_5193ce37
PS1, Line 270: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum"
line length of 121 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/fb6ffe30_b928a6b2
PS1, Line 271: printf "\n is changing constantly and not provided by $1 project, so not checked.\n"
line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/543df168_8c3ba31b
PS1, Line 279: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image.
line length of 99 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/9001aa0a_fc10767b
PS1, Line 296: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n"
line length of 120 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/9c91264d_6b3afcd6
PS1, Line 300: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}freedos.img${bend} could take a couple of minutes...\n\n"
line length of 123 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/c37b47f7_c79e194a
PS1, Line 304: floppy_verifier "freedos" "3f7834ea4575ba05d106e4b8f59f886da7bfb1979ee386be2a2deba8df518925"
line length of 103 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/e69f2c13_0e3b2661
PS1, Line 308: floppy_verifier "michalos" "9e063275a4b098a4af15fffbf6d0a8ae83d11470cb170809a38512eedc035843"
line length of 103 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/dd22d791_cab6dbaa
PS1, Line 316: floppy_verifier "fiwix" "c4f919adbb95bd145238e7543fe78f2703d87ee7d79e9b57f05b09a64aaa814f"
line length of 103 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/e591c2eb_8128ce5f
PS1, Line 320: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87"
line length of 103 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/7439b89b_2e824c9b
PS1, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1"
line length of 103 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/7cad3a3e_1628ab41
PS1, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27"
line length of 103 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/3dd4ca03_216bee2f
PS1, Line 335: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455"
line length of 103 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/398114c9_f77eed0f
PS1, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info.
line length of 99 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/951750de_c66b4c45
PS1, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n"
line length of 130 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/fcc8a991_977b6b99
PS1, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then
line length of 146 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/7e7ff3ef_7ded5400
PS1, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n"
line length of 117 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/f803cbae_a0211e65
PS1, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info.
line length of 97 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/f3a1b0be_79fba6d3
PS1, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n"
line length of 109 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/36a52f32_e33b577b
PS1, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !"
line length of 143 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/1822623d_685d5293
PS1, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n"
line length of 115 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/0ac241a3_c88a5ebc
PS1, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then
line length of 125 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/43c5c7f5_0ebedc42
PS1, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma
line length of 98 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/0967a410_ad66a2c5
PS1, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n"
line length of 127 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/dd7cd086_3813b7ca
PS1, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -"
line length of 118 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/bf18d644_9faacb1c
PS1, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n"
line length of 105 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/5fee82c9_c8f0dfd3
PS1, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool.
line length of 98 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/51e8eb1e_99a3955d
PS1, Line 430: csb_patcher "atombios" "58748" "2" "d3c12c8" "f6a0d71ef0ceef69e74419e0f8c90b4ac9c121d8d283f5605ad6c652cd1ab3d2" "$1" "AMD "
line length of 135 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/59c5bfa3_ed07cb7b
PS1, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G"
line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/b56051db_3ddac334
PS1, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M"
line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/830935b7_07a3e14b
PS1, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230"
line length of 99 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/7f6a11d4_89595ed9
PS1, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series"
line length of 111 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/ce1e4901_74a5c495
PS1, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D"
line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/952a6200_c664f484
PS1, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'.
line length of 97 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/0382dcca_bf57c62e
PS1, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n"
line length of 98 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/a90f6106_739db380
PS1, Line 541: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n"
line length of 125 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/313d025a_bd430625
PS1, Line 677: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory,"
line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/4ae5307c_a2a9b010
PS1, Line 678: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n"
line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/12db77b2_50190b45
PS1, Line 681: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory,"
line length of 104 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/46c36620_1403126b
PS1, Line 733: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n"
line length of 114 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/046fedcd_19de5f29
PS1, Line 735: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n"
line length of 118 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/fd0c5072_3df38668
PS1, Line 750: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n"
line length of 98 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/42a964db_bc71f098
PS1, Line 752: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n"
line length of 97 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/dcd75a4c_bb3cfd4f
PS1, Line 758: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n"
line length of 112 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/c49163da_a2a2d97a
PS1, Line 765: # Prints the currently-known errata: what you might need to do to ensure a stable coreboot build.
line length of 97 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/45696f8f_c08ba14d
PS1, Line 768: printf "\n ${bold}downgrade the GCC${bend} of a coreboot toolchain with three commands:\n"
line length of 102 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/aba75bc5_fbadd5fc
PS1, Line 772: if yesno "This should be manually done before patching. ${bold}Continue patching?${bend}" "" ; then
line length of 103 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/020c5caf_ef879e59
PS1, Line 788: csb_patcher "dgpu" "58745" "3" "0cf99e4" "d6b3328b2c58debed96ba9f8c71f6b9fa7673ce5c01c6c96492dab2ba6377af7" "$1" "G505S "
line length of 137 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/49d3527a_2366f763
PS1, Line 793: csb_patcher "atombios" "58748" "2" "d3c12c8" "f6a0d71ef0ceef69e74419e0f8c90b4ac9c121d8d283f5605ad6c652cd1ab3d2" "$1" "AMD "
line length of 135 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/ddb00a17_add2ba2d
PS1, Line 798: csb_patcher "irq" "48427" "13" "337b193" "47511fe883ed603879b5ca90606b44dc76c0564f44562742eaa43226974dc9f1" "$1" "AMD good "
line length of 140 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/b6d411ac_53b90d33
PS1, Line 803: csb_patcher "seabios" "32351" "16" "726e469" "be7f432355f30f7a6220059a558d4fc0ce1b6f1f84a238020983190764f52935" "$1" ""
line length of 131 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/f40d4567_33efb127
PS1, Line 808: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs "
line length of 143 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/8aba35cd_d6368bc6
PS1, Line 813: csb_patcher "config.lenovo_g505s" "64829" "1" "941b5c7" "d1ebfb0df3f6fa237b0f61a4236f30652bcd3606ae659ff3e958944081cdafe8" "$1" ""
line length of 131 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/86d3f308_7c6bd942
PS1, Line 818: csb_patcher "config.asus_am1i-a" "64831" "1" "6c178df" "86fee19e7e87d2b6ab36547259bf955a05680b60ccdcdc9999978397a2f2c794" "$1" ""
line length of 131 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/13335325_17e788fd
PS1, Line 823: csb_patcher "config.asus_a88xm-e" "64832" "1" "0afd75d" "c9945bc94963dc40129b043c5d8b164cf7e74a115976d7a4af2991e15cb64e66" "$1" ""
line length of 131 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/e1362e06_66f21026
PS1, Line 830: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n"
line length of 99 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/a82fb8a1_4f678c41
PS1, Line 833: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n"
line length of 106 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/55c005f7_066343c1
PS1, Line 888: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it."
line length of 113 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/8822cd27_99fa3a64
PS1, Line 889: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}"
line length of 127 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150397):
https://review.coreboot.org/c/coreboot/+/64873/comment/d74a4c6c_c8bb444d
PS1, Line 911: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom"
line length of 97 exceeds 96 columns
--
To view, visit https://review.coreboot.org/c/coreboot/+/64873
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia392bad869a82707380d3a1e3c51b3e15f4f02f2
Gerrit-Change-Number: 64873
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-CC: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64640 )
Change subject: mainboard/msi/ms7d25: Enable CBFS serial number and UUID as default
......................................................................
Patch Set 5: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/64640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8af889f12617d4ab6a27c6f336276c04f26244c
Gerrit-Change-Number: 64640
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:19:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64295 )
Change subject: mainboard/msi/ms7d25: Add USB macros and port designation comments
......................................................................
Patch Set 8: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/64295
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2e842ef240ab25e2a9f7fa2e0766206fde7943d
Gerrit-Change-Number: 64295
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:18:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64222 )
Change subject: mainboard/msi/ms7d25: Add default vboot configuration
......................................................................
Patch Set 9: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/64222
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9590a33e828906de083cb23c8b647ed2da0750ee
Gerrit-Change-Number: 64222
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:18:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64221 )
Change subject: drivers/mrc_cache: Do not verify TPM MRC hash if secdata is mocked
......................................................................
Patch Set 9: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/64221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0cf04b129fe1c5e94cd8a803bb21aa350c3f8da
Gerrit-Change-Number: 64221
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:17:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64050 )
Change subject: mainboard/msi/ms7d25: Fill board-specific SMBIOS data
......................................................................
Patch Set 10: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/64050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie64be21ff302274769b77550c29e58d4ea1376d1
Gerrit-Change-Number: 64050
Gerrit-PatchSet: 10
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:16:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Kopeć, Christian Walter.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64049 )
Change subject: drivers/crb: Add SMBIOS hook to generate type 43 TPM Device
......................................................................
Patch Set 8: Verified-1
(1 comment)
File src/drivers/crb/tis.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150388):
https://review.coreboot.org/c/coreboot/+/64049/comment/0fdea406_1ed25e41
PS8, Line 211: #endif
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/64049
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05289f98969bd431017aff1aa77be5806d6f1838
Gerrit-Change-Number: 64049
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64048 )
Change subject: smbios: Add API to generate SMBIOS type 43 TPM Device
......................................................................
Patch Set 8: Verified-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/64048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2db29f8bc4cfbc6648bb2cabad074d9ea583ca9
Gerrit-Change-Number: 64048
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:16:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63957 )
Change subject: drivers/crb: Initialize Intel PTT control area
......................................................................
Patch Set 9: Verified-1
(2 comments)
File src/drivers/crb/tpm.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150386):
https://review.coreboot.org/c/coreboot/+/63957/comment/2698f65f_b764165a
PS9, Line 205: * some precious miliseconds which would be wasted in crb_activate_locality polling
'miliseconds' may be misspelled - perhaps 'milliseconds'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150386):
https://review.coreboot.org/c/coreboot/+/63957/comment/d95a2551_6bdabffb
PS9, Line 264: * Initialize CRB adresses and sizes for PTT. It seems to be possible
'adresses' may be misspelled - perhaps 'addresses'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63957
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8e473ecc1a520851d6d48ccad9da35c6f91005d
Gerrit-Change-Number: 63957
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:15:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63956 )
Change subject: drivers/intel/ptt: Use the correct detection method
......................................................................
Patch Set 9: Verified-1
(1 comment)
File src/security/intel/txt/txt_register.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150385):
https://review.coreboot.org/c/coreboot/+/63956/comment/ad6633ac_fb7ace87
PS9, Line 98: #define TXT_STS_FTIF (TXT_BASE + 0x800)
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/63956
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a55c9f38f5bb94fb1186592446a28e675c1207c
Gerrit-Change-Number: 63956
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 15:15:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment