coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: ec/google: Add support for ARTG method
by Varshit B Pandya (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Paul Menzel, Rizwan Qureshi, Sumeet R Pawnikar, Eric Lai. Hello build bot (Jenkins), Rizwan Qureshi, Tim Wawrzynczak, Sumeet R Pawnikar, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63949 to look at the new patch set (#6). Change subject: ec/google: Add support for ARTG method ...................................................................... ec/google: Add support for ARTG method As per Intel Dynamic Tunning revision 1.3.13 add support for ARTG under \_SB.DPTF.TPWR device. Chromeec is passing ARTG value in multiples of 50mW to save space, driver expects this in mW hence multiplying it by 50 in ACPI mehod. Corresponding EC changes: https://crrev.com/c/3545780 BUG=b:205928013 TEST=Build, boot brya4es and dump SSDT to check methods. Method (ARTG, 0, Serialized) { Local0 = \_SB.PCI0.LPCB.EC0.ARTG /* External reference */ Local0 *= 0x32 Return (Local0) } Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com> Change-Id: I501ce59fd9e7f39d8b68f7e757b953ec7fb7f072 --- M src/ec/google/chromeec/acpi/ec.asl M src/ec/google/chromeec/acpi/emem.asl M src/ec/google/chromeec/ec_dptf_helpers.c 3 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/63949/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/63949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I501ce59fd9e7f39d8b68f7e757b953ec7fb7f072 Gerrit-Change-Number: 63949 Gerrit-PatchSet: 6 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/google: Add PSRC and PBOK method
by Varshit B Pandya (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Subrata Banik, Rizwan Qureshi. Hello build bot (Jenkins), Subrata Banik, Rizwan Qureshi, Tim Wawrzynczak, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62945 to look at the new patch set (#14). Change subject: ec/google: Add PSRC and PBOK method ...................................................................... ec/google: Add PSRC and PBOK method As per Intel Dynamic Tuning revision 1.3.13 add support for PSRC and PBOK under \_SB.DPTF.TPWR device ec_fill_dptf_helpers() is used to generate all the helper function that DPTF requires. BUG=b:205928013 TEST=Buil, boot brya0 and dump SSDT to check methods Scope (\_SB.DPTF.TPWR) { Method (PSRC, 0, Serialized) { Local0 = \_SB.PCI0.LPCB.EC0.PWRT /* External reference */ Local0 &= 0x03 Return (Local0) } Method (PBOK, 1, Serialized) { Local0 = (Arg0 & 0x0F) \_SB.PCI0.LPCB.EC0.PBOK = Local0 } } Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com> Change-Id: Ia536a9e1528f6e415247eca9ed2b0b685eb73196 --- M src/ec/google/chromeec/ec_dptf_helpers.c 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/62945/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/62945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia536a9e1528f6e415247eca9ed2b0b685eb73196 Gerrit-Change-Number: 62945 Gerrit-PatchSet: 14 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/google: Notify DPTF driver power participant on PD event
by Varshit B Pandya (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Varshit B Pandya, Subrata Banik, Rizwan Qureshi. Hello build bot (Jenkins), Subrata Banik, Rizwan Qureshi, Tim Wawrzynczak, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62946 to look at the new patch set (#14). Change subject: ec/google: Notify DPTF driver power participant on PD event ...................................................................... ec/google: Notify DPTF driver power participant on PD event The DPTF power participant device needs to be notified when power source changes so it can re-evaluate power source and power source change count, this can be later used by DPTF along with methods provided by EC. Corresponding changes in EC are https://crrev.com/c/3545778 and https://crrev.com/c/3547317 BUG=b:205928013 TEST=Build, boot brya0 and dump DSDT to check change Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com> Change-Id: I07f58b928a0dba92bec3817177142c586e5014b9 --- M src/ec/google/chromeec/acpi/ec.asl M src/ec/google/chromeec/acpi/emem.asl 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/62946/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/62946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07f58b928a0dba92bec3817177142c586e5014b9 Gerrit-Change-Number: 62946 Gerrit-PatchSet: 14 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[4.16_branch]: util/crossgcc: Update tools to point to the coreboot archive
by Martin L Roth (Code Review) 02 Jun '22

02 Jun '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64874 ) Change subject: util/crossgcc: Update tools to point to the coreboot archive ...................................................................... util/crossgcc: Update tools to point to the coreboot archive For releases, we save the tarballs of everything used to create the release toolchain. This allows us to be sure that they'll be available even if the original sites go offline. This change update the 4.16 version of buildgcc to point at the coreboot archive instead of the original locations. The hashes are still in the release archive and will not be updated, so you can be sure you're getting the correct versions. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I920370a43f820203b5a2d21aa70d62bd53186926 --- M util/crossgcc/buildgcc 1 file changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/64874/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 6b7558f..1ee22a8 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -47,19 +47,19 @@ # These are sanitized by the jenkins toolchain test builder, so if # a completely new URL is added here, it probably needs to be added # to the jenkins build as well, or the builder won't download it. -GMP_ARCHIVE="https://ftpmirror.gnu.org/gmp/gmp-${GMP_VERSION}.tar.xz" -MPFR_ARCHIVE="https://ftpmirror.gnu.org/mpfr/mpfr-${MPFR_VERSION}.tar.xz" -MPC_ARCHIVE="https://ftpmirror.gnu.org/mpc/mpc-${MPC_VERSION}.tar.gz" -GCC_ARCHIVE="https://ftpmirror.gnu.org/gcc/gcc-${GCC_VERSION}/gcc-${GCC_VERSION}.tar.xz" -BINUTILS_ARCHIVE="https://ftpmirror.gnu.org/binutils/binutils-${BINUTILS_VERSION}.tar.xz" -IASL_ARCHIVE="https://acpica.org/sites/acpica/files/acpica-unix2-${IASL_VERSION}.tar.gz" +GMP_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/gmp-${GMP_VERSION}.tar.xz" +MPFR_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/mpfr-${MPFR_VERSION}.tar.xz" +MPC_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/mpc-${MPC_VERSION}.tar.gz" +GCC_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/gcc-${GCC_VERSION}.tar.xz" +BINUTILS_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/binutils-${BINUTILS_VERSION}…" +IASL_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/acpica-unix2-${IASL_VERSION}…" # CLANG toolchain archive locations -LLVM_ARCHIVE="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" -CLANG_ARCHIVE="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" -CRT_ARCHIVE="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" -CTE_ARCHIVE="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" -CMAKE_ARCHIVE="https://cmake.org/files/v${CMAKE_VERSION%.*}/cmake-${CMAKE_VERSION}.tar.gz" -NASM_ARCHIVE="https://www.nasm.us/pub/nasm/releasebuilds/${NASM_VERSION}/nasm-${NASM_VERS…" +LLVM_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/llvm-${CLANG_VERSION}.src.ta…" +CLANG_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/clang-${CLANG_VERSION}.src.t…" +CRT_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/compiler-rt-${CLANG_VERSION}…" +CTE_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/clang-tools-extra-${CLANG_VE…" +CMAKE_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/cmake-${CMAKE_VERSION}.tar.gz" +NASM_ARCHIVE="https://coreboot.org/releases/crossgcc-sources/nasm-${NASM_VERSION}.tar.bz2" ALL_ARCHIVES="$GMP_ARCHIVE $MPFR_ARCHIVE $MPC_ARCHIVE \ $GCC_ARCHIVE $BINUTILS_ARCHIVE $IASL_ARCHIVE \ -- To view, visit https://review.coreboot.org/c/coreboot/+/64874 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.16_branch Gerrit-Change-Id: I920370a43f820203b5a2d21aa70d62bd53186926 Gerrit-Change-Number: 64874 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/fast_spi: Use `need_restore_mtrr()` to clear temp MTRR
by Subrata Banik (Code Review) 02 Jun '22

02 Jun '22

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/63492 ) Change subject: soc/intel/fast_spi: Use `need_restore_mtrr()` to clear temp MTRR ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/63492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67fd36080b318ace53f3e34da53d747f9a3aa400 Gerrit-Change-Number: 63492 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel/fast_spi: Use `need_restore_mtrr()` to clear temp MTRR
by Lean Sheng Tan (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Subrata Banik, Werner Zeh. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63492 ) Change subject: soc/intel/fast_spi: Use `need_restore_mtrr()` to clear temp MTRR ...................................................................... Patch Set 2: -Code-Review (1 comment) Patchset: PS2: I think this CL is not needed as Arthur's CL has been merged. Thanks everyone -- To view, visit https://review.coreboot.org/c/coreboot/+/63492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67fd36080b318ace53f3e34da53d747f9a3aa400 Gerrit-Change-Number: 63492 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 16:18:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/acpi: Rework to reduce code duplication
by Lean Sheng Tan (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Nico Huber, Wonkyu Kim, Subrata Banik, Maulik V Vaghela, Abel Briggs, Paul Menzel, Tim Wawrzynczak, Reka Norman, Julius Werner, Arthur Heymans, Karthikeyan Ramasubramanian. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64012 ) Change subject: ec/acpi: Rework to reduce code duplication ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: Abel, can you add a topic on your EC patch train? Will be easier to track. -- To view, visit https://review.coreboot.org/c/coreboot/+/64012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifda5c030ff81f1046be58aa1fcafdcf71a27cd41 Gerrit-Change-Number: 64012 Gerrit-PatchSet: 10 Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Abel Briggs <abelbriggs1(a)hotmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 16:16:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/acpi: Rework to reduce code duplication
by Lean Sheng Tan (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Nico Huber, Wonkyu Kim, Subrata Banik, Maulik V Vaghela, Abel Briggs, Paul Menzel, Tim Wawrzynczak, Reka Norman, Julius Werner, Arthur Heymans, Karthikeyan Ramasubramanian. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64012 ) Change subject: ec/acpi: Rework to reduce code duplication ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: nice work Abel, thanks for carrying this through! -- To view, visit https://review.coreboot.org/c/coreboot/+/64012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifda5c030ff81f1046be58aa1fcafdcf71a27cd41 Gerrit-Change-Number: 64012 Gerrit-PatchSet: 10 Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Abel Briggs <abelbriggs1(a)hotmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 16:14:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/acpi: Rework to reduce code duplication
by Lean Sheng Tan (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Nico Huber, Wonkyu Kim, Subrata Banik, Maulik V Vaghela, Abel Briggs, Paul Menzel, Tim Wawrzynczak, Reka Norman, Julius Werner, Arthur Heymans, Karthikeyan Ramasubramanian. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64012 ) Change subject: ec/acpi: Rework to reduce code duplication ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifda5c030ff81f1046be58aa1fcafdcf71a27cd41 Gerrit-Change-Number: 64012 Gerrit-PatchSet: 10 Gerrit-Owner: Abel Briggs <abelbriggs1(a)hotmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Abel Briggs <abelbriggs1(a)hotmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 16:13:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/i440bx: Use PARALLEL_MP
by Lean Sheng Tan (Code Review) 02 Jun '22

02 Jun '22

Attention is currently required from: Keith Hui, Branden Waldner, Angel Pons, Arthur Heymans, Patrick Rudolph. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59693 ) Change subject: nb/intel/i440bx: Use PARALLEL_MP ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8d2582b353069eecea8561cfe01b2dd8221779b Gerrit-Change-Number: 59693 Gerrit-PatchSet: 10 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 16:11:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022