Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Rizwan Qureshi, Sumeet R Pawnikar, Eric Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63698 )
Change subject: mb/google/brya: Configure PROP value for brya
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/63698/comment/581f2746_79c65114
PS6, Line 198: 20000
> What kind of effect on performance might this arbitrary value have?
I'll get more info on this, for now I have moved this patch on top so we can close on the other patches.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63698
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id39c1e7bf35b537fca0b97bfe77b2ae3c3cf4ecc
Gerrit-Change-Number: 63698
Gerrit-PatchSet: 10
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 16:54:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Rizwan Qureshi, Eric Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64120 )
Change subject: ec/google: Add PBSS and PMAX method
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64120/comment/94762883_a0b12840
PS3, Line 13:
> link to the corresponding EC CL?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/64120
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I739d7fa3a7f60868087ba96c684345be7827eb51
Gerrit-Change-Number: 64120
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 16:52:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Poornima Tom, Tim Wawrzynczak, Paul Menzel, Rizwan Qureshi, Sumeet R Pawnikar, Eric Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63949 )
Change subject: ec/google: Add support for ARTG method
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63949/comment/d3ff34e7_412d52d8
PS5, Line 15: https://chromium-review.googlesource.com/c/
: chromiumos/platform/ec/+/3545780
> `https://crrev.com/c/3545780` […]
Done
File src/ec/google/chromeec/acpi/emem.asl:
https://review.coreboot.org/c/coreboot/+/63949/comment/935b00ac_a2ed46b4
PS2, Line 52: ARTG, 16, // Adapter Rating
> At present, we are testing DTT features on brya using legacy EC cahnges, as brya doesn't still suppo […]
Done
File src/ec/google/chromeec/ec_dptf_helpers.c:
https://review.coreboot.org/c/coreboot/+/63949/comment/2e522400_54666aae
PS5, Line 155: /* Local0 *= 0x32 */
> why does it need to be multiplied by 50?
Done
https://review.coreboot.org/c/coreboot/+/63949/comment/582430d7_7e07fece
PS5, Line 165: acpigen_pop_len
> `acpigen_write_method_end()`
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I501ce59fd9e7f39d8b68f7e757b953ec7fb7f072
Gerrit-Change-Number: 63949
Gerrit-PatchSet: 6
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 16:52:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Poornima Tom <poornima.tom(a)intel.com>
Comment-In-Reply-To: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Rizwan Qureshi, Sumeet R Pawnikar, Eric Lai.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63698 )
Change subject: mb/google/brya: Configure PROP value for brya
......................................................................
Patch Set 10: Verified+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63698
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id39c1e7bf35b537fca0b97bfe77b2ae3c3cf4ecc
Gerrit-Change-Number: 63698
Gerrit-PatchSet: 10
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 16:52:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Rizwan Qureshi.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62946 )
Change subject: ec/google: Notify DPTF driver power participant on PD event
......................................................................
Patch Set 14:
(1 comment)
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/62946/comment/2cd63951_9265beef
PS13, Line 358: 0x81
> How about a symbolic constant for this Notify value?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/62946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07f58b928a0dba92bec3817177142c586e5014b9
Gerrit-Change-Number: 62946
Gerrit-PatchSet: 14
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 16:51:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Rizwan Qureshi, Eric Lai.
Hello build bot (Jenkins), Subrata Banik, Rizwan Qureshi, Tim Wawrzynczak, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64641
to look at the new patch set (#3).
Change subject: ec/google: Add RBHF, VBNL and CMPP method
......................................................................
ec/google: Add RBHF, VBNL and CMPP method
As per Intel Dynamic Tuning revision 1.3.13 add support for RBHF, VBNL
and CTYP under \_SB.DPTF.TBAT device.
ec_fill_dptf_helpers() is used to generate all the helper function that
DPTF requires.
BUG=b:205928013
TEST=Build, boot brya0 and dump SSDT to check methods.
Method (RBHF, 0, Serialized)
{
Local0 = \_SB.PCI0.LPCB.EC0.RBHF /* External reference */
Return (Local0)
}
Method (VBNL, 0, Serialized)
{
Local0 = \_SB.PCI0.LPCB.EC0.VBNL /* External reference */
Return (Local0)
}
Method (CMPP, 0, Serialized)
{
Local0 = \_SB.PCI0.LPCB.EC0.CMPP /* External reference */
Return (Local0)
}
Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Change-Id: Ib85977889360dde2ccf00cd6895fffcc38ad4807
---
M src/ec/google/chromeec/acpi/ec.asl
M src/ec/google/chromeec/acpi/emem.asl
M src/ec/google/chromeec/ec_dptf_helpers.c
3 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/64641/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/64641
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib85977889360dde2ccf00cd6895fffcc38ad4807
Gerrit-Change-Number: 64641
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Subrata Banik, Rizwan Qureshi, Eric Lai.
Hello build bot (Jenkins), Subrata Banik, Rizwan Qureshi, Tim Wawrzynczak, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64120
to look at the new patch set (#4).
Change subject: ec/google: Add PBSS and PMAX method
......................................................................
ec/google: Add PBSS and PMAX method
As per Intel Dynamic Tuning revision 1.3.13 add support for PBSS and
PMAX under \_SB.DPTF.TBAT device
ec_fill_dptf_helpers() is used to generate all the helper function that
DPTF requires.
Corresponding EC patches: https://crrev.com/c/3659128 and
https://crrev.com/c/3659129
BUG=b:205928013
TEST=Build, boot brya0 and dump SSDT to check methods.
Scope (\_SB.DPTF.TBAT)
{
Method (PMAX, 0, Serialized)
{
Local0 = \_SB.PCI0.LPCB.EC0.PMAX /* External reference */
Return (Local0)
}
Method (PBSS, 0, Serialized)
{
Local0 = \_SB.PCI0.LPCB.EC0.PBSS /* External reference */
Return (Local0)
}
}
Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Change-Id: I739d7fa3a7f60868087ba96c684345be7827eb51
---
M src/ec/google/chromeec/ec_dptf_helpers.c
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/64120/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/64120
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I739d7fa3a7f60868087ba96c684345be7827eb51
Gerrit-Change-Number: 64120
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset