Attention is currently required from: Reka Norman, Tim Wawrzynczak, Felix Held.
Terry Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64662 )
Change subject: spd/lp5: Add new LP5 part H58G56AK6BX069
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
gen spd_gen again in patch8
--
To view, visit https://review.coreboot.org/c/coreboot/+/64662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6136e17706c6248598886f8f9bd8fdd7efff4dab
Gerrit-Change-Number: 64662
Gerrit-PatchSet: 8
Gerrit-Owner: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 01 Jun 2022 01:38:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Nicholas Chin.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64846 )
Change subject: Documentation: Update coreboot 4.17 release notes
......................................................................
Patch Set 2:
(6 comments)
File Documentation/releases/coreboot-4.17-relnotes.md:
https://review.coreboot.org/c/coreboot/+/64846/comment/e48e6a65_66f60261
PS2, Line 45: particularly
: commits interesting
> particularly interesting commits
Done
https://review.coreboot.org/c/coreboot/+/64846/comment/e8c29a1d_91ec2b9c
PS2, Line 54: cbmeme
> cbmem?
Done
https://review.coreboot.org/c/coreboot/+/64846/comment/4eebe17a_1152a03c
PS2, Line 54: would
: initializing
> would be initializing
Done
https://review.coreboot.org/c/coreboot/+/64846/comment/d530b237_de512bc1
PS2, Line 57: This reason
> The reason
Done
https://review.coreboot.org/c/coreboot/+/64846/comment/8adea724_e3b59084
PS2, Line 65: * Add new coreDOOM payload, a port of Doom to libpayload
> This line seems a bit redundant now that the full commit message is included below. […]
I moved this to the last line and changed it to say "* Add new coreDOOM payload. See commit message below."
https://review.coreboot.org/c/coreboot/+/64846/comment/a7e5848c_6f39aa07
PS2, Line 67: the
> Remove "the". I probably missed this when I originally wrote that line in a previous patch.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/64846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9491ad9aa6ab3eb5504bee85591f3b1d9bf6cc2
Gerrit-Change-Number: 64846
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 01:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Tim Wawrzynczak, Felix Held.
Terry Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64662 )
Change subject: spd/lp5: Add new LP5 part H58G56AK6BX069
......................................................................
Patch Set 7:
(1 comment)
File spd/lp5/memory_parts.json:
https://review.coreboot.org/c/coreboot/+/64662/comment/feaeed5c_c83e8ea2
PS6, Line 72: },
> Missing an opening brace on the next line.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/64662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6136e17706c6248598886f8f9bd8fdd7efff4dab
Gerrit-Change-Number: 64662
Gerrit-PatchSet: 7
Gerrit-Owner: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 01 Jun 2022 01:26:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Julius Werner.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64843 )
Change subject: Documentation: Update index.md and add 4.18 release notes
......................................................................
Patch Set 1:
(1 comment)
File Documentation/releases/coreboot-4.18-relnotes.md:
https://review.coreboot.org/c/coreboot/+/64843/comment/2c6d0dd1_9c033aa9
PS1, Line 17:
> When you want to deprecate something, this should be announced 6 months before.
Sorry, I meant: If you want to remove something, then it should be announced 6 months before. The announcement itself makes that thing deprecated.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64843
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52814ebbae804ea0ff24a7cec0618054029b8b47
Gerrit-Change-Number: 64843
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 01 Jun 2022 01:19:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Eran Mitrani, Tim Wawrzynczak, Nick Vaccaro.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64529 )
Change subject: vendorcode/intel/fsp: Add Raptor Lake FSP headers for FSP v3127_05_8
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Do you know where the code is that determines which headers to use?
src/soc/intel/alderlake/Kconfig
I wanted to avoid adding a SOC_RAPTORLAKE flag but I will need to add it. We can remove it later.
config FSP_HEADER_PATH
string "Location of FSP headers"
default "src/vendorcode/intel/fsp/fsp2_0/alderlake_n/" if SOC_INTEL_ALDERLAKE_PCH_N
default "src/vendorcode/intel/fsp/fsp2_0/alderlake/"
--
To view, visit https://review.coreboot.org/c/coreboot/+/64529
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dd14468ec09bfe1a0904686e66d37a7389efdd4
Gerrit-Change-Number: 64529
Gerrit-PatchSet: 5
Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.corp-partner.google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 01:17:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Julius Werner.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64843 )
Change subject: Documentation: Update index.md and add 4.18 release notes
......................................................................
Patch Set 1:
(1 comment)
File Documentation/releases/coreboot-4.18-relnotes.md:
https://review.coreboot.org/c/coreboot/+/64843/comment/6b9536bd_6b7d9196
PS1, Line 17:
> Sorry, I'm not really sure what is supposed to go into which notes here. […]
When you want to deprecate something, this should be announced 6 months before. So the earliest point for removing would be _after_ the 4.19 release and thus it should go to the 4.17 release notes.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64843
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52814ebbae804ea0ff24a7cec0618054029b8b47
Gerrit-Change-Number: 64843
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 01 Jun 2022 01:15:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64843 )
Change subject: Documentation: Update index.md and add 4.18 release notes
......................................................................
Patch Set 1:
(1 comment)
File Documentation/releases/coreboot-4.18-relnotes.md:
https://review.coreboot.org/c/coreboot/+/64843/comment/c4e6f999_65ee369c
PS1, Line 17:
> Do you mean the 4. […]
Sorry, I'm not really sure what is supposed to go into which notes here. The idea is that after the 4.18 tag is created, I want to remove the code from ToT (so it will still be in 4.18 but not in anything after that). I don't know if that means it should go in the 4.17 or 4.18 notes.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64843
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52814ebbae804ea0ff24a7cec0618054029b8b47
Gerrit-Change-Number: 64843
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 01:09:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Zhuohao Lee, Felix Held.
Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64665 )
Change subject: mb/google/brask/variants/moli: enable USB retimer
......................................................................
Patch Set 6:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64665
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7ea0b0d85776857d07e129935059397720fa0e8
Gerrit-Change-Number: 64665
Gerrit-PatchSet: 6
Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 01 Jun 2022 01:05:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment