coreboot-gerrit June 2022

coreboot-gerrit@coreboot.org

1 participants
1234 discussions

Change in coreboot[master]: cbfs: Add CBFS_TYPE_INTEL_FIT and exclude it from CBFS verification
by Julius Werner (Code Review) 31 May '22

31 May '22

Attention is currently required from: Tim Wawrzynczak. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64736 ) Change subject: cbfs: Add CBFS_TYPE_INTEL_FIT and exclude it from CBFS verification ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > This would also be needed for "bpm.bin" when using CBnT. Yeah... I don't really understand how that stuff works, I hope one of you can eventually fix it up if you ever want to combine it with CBFS verification. -- To view, visit https://review.coreboot.org/c/coreboot/+/64736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c1bb6dab0c9ccc6e78529758a42ad3194cd130c Gerrit-Change-Number: 64736 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 00:32:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: commonlib: Clean up compiler.h
by build bot (Jenkins) (Code Review) 31 May '22

31 May '22

Attention is currently required from: Patrick Georgi, Jakub Czapiga. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64737 ) Change subject: commonlib: Clean up compiler.h ...................................................................... Patch Set 2: (1 comment) File src/commonlib/bsd/include/commonlib/bsd/compiler.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150164): https://review.coreboot.org/c/coreboot/+/64737/comment/5ca3c01c_78b74f0a PS2, Line 35: #define __always_inline inline __attribute__((__always_inline__)) Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/64737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9644da594bb69133843c6b7f12ce50b2e45fd24b Gerrit-Change-Number: 64737 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 00:31:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfs: Add CBFS_TYPE_INTEL_FIT and exclude it from CBFS verification
by build bot (Jenkins) (Code Review) 31 May '22

31 May '22

Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64736 ) Change subject: cbfs: Add CBFS_TYPE_INTEL_FIT and exclude it from CBFS verification ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c1bb6dab0c9ccc6e78529758a42ad3194cd130c Gerrit-Change-Number: 64736 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 00:31:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfs: Rename TYPE_FIT to TYPE_FIT_PAYLOAD
by Julius Werner (Code Review) 31 May '22

31 May '22

Attention is currently required from: Philipp Hug, Patrick Rudolph, Christian Walter, ron minnich. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64735 ) Change subject: cbfs: Rename TYPE_FIT to TYPE_FIT_PAYLOAD ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/64735/comment/e487c917_4e25f565 PS1, Line 13: fit_payload`). > Are you aware of any script that needs to be changed? No, that's why I added Patrick to the CC... he added that functionality and I'm not aware of anyone else using it. There are no instances of this in the coreboot tree but there may be in other organizations' external build scripts. File util/nvramtool/cbfs.h: https://review.coreboot.org/c/coreboot/+/64735/comment/fc51b278_98dcc62e PS1, Line 29: #define CBFS_TYPE_FIT_PAYLOAD 0x21 > Can we align these with tabs? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I826cefce54ade06c6612c8a7bb53e02092e7b11a Gerrit-Change-Number: 64735 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 00:30:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfs: Rename TYPE_FIT to TYPE_FIT_PAYLOAD
by Julius Werner (Code Review) 31 May '22

31 May '22

Attention is currently required from: Philipp Hug, Patrick Rudolph, Christian Walter, Julius Werner, ron minnich. Hello build bot (Jenkins), Philipp Hug, Patrick Rudolph, Christian Walter, Arthur Heymans, Yu-Ping Wu, ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64735 to look at the new patch set (#2). Change subject: cbfs: Rename TYPE_FIT to TYPE_FIT_PAYLOAD ...................................................................... cbfs: Rename TYPE_FIT to TYPE_FIT_PAYLOAD There are too many "FIT" in firmware land. In order to reduce possible confusion of CBFS_TYPE_FIT with the Intel Firmware Interface Table, this patch renames it to CBFS_TYPE_FIT_PAYLOAD (including the cbfstool argument, so calling scripts will now need to replace `-t fit` with `-t fit_payload`). Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: I826cefce54ade06c6612c8a7bb53e02092e7b11a --- M src/arch/arm/boot.c M src/arch/riscv/boot.c M src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h M src/lib/prog_loaders.c M src/security/tpm/tspi/crtm.c M util/cbfstool/cbfs.h M util/cbfstool/cbfstool.c M util/nvramtool/cbfs.h 8 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/64735/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I826cefce54ade06c6612c8a7bb53e02092e7b11a Gerrit-Change-Number: 64735 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/cpu: Use SoC overrides to set CPU privilege level
by Eric Lai (Code Review) 31 May '22

31 May '22

Attention is currently required from: Jeff Daly, Mariusz Szafrański, Jonathan Zhang, Angel Pons, Andrey Petrov, Anjaneya "Reddy" Chagam, Subrata Banik, Johnny Lin, Tim Wawrzynczak, Christian Walter, Suresh Bellampalli, Vanessa Eusebio, Werner Zeh, Tim Chu. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64806 ) Change subject: soc/intel/common/cpu: Use SoC overrides to set CPU privilege level ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4584516102560e6bb2a4ae8c0d036be40ed96990 Gerrit-Change-Number: 64806 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 00:29:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Update coreboot 4.17 release notes
by Martin L Roth (Code Review) 31 May '22

31 May '22

Attention is currently required from: Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64846 ) Change subject: Documentation: Update coreboot 4.17 release notes ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: Please review these. If there are any significant changes or anything that I missed and you'd like added, please reply here. I added the "Significant bugs fixed" section - If there are any other bugs that should be listed there, let me know. Also, if you added any bugs to this release, please let me know so I can include that as well. File Documentation/releases/coreboot-4.17-relnotes.md: https://review.coreboot.org/c/coreboot/+/64846/comment/b7bebbae_c488b7b0 PS1, Line 250: ### payloads/external: Add support for coreDOOM payload > I would move this below the Payloads section Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9491ad9aa6ab3eb5504bee85591f3b1d9bf6cc2 Gerrit-Change-Number: 64846 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 01 Jun 2022 00:27:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/nissa/var/nivviks: Enable ISH when UFS is present
by Eric Lai (Code Review) 31 May '22

31 May '22

Attention is currently required from: Daniil Lunev, Kangheui Won, Reka Norman, Tim Wawrzynczak, Gwendal Grignou. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64845 ) Change subject: mb/google/nissa/var/nivviks: Enable ISH when UFS is present ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib60d44322cfbd8f82c33ecac7598881dfb1d0c3c Gerrit-Change-Number: 64845 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Daniil Lunev <dlunev(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniil Lunev <dlunev(a)chromium.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 00:26:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Update coreboot 4.17 release notes
by Martin L Roth (Code Review) 31 May '22

31 May '22

Attention is currently required from: Martin L Roth. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64846 to look at the new patch set (#2). Change subject: Documentation: Update coreboot 4.17 release notes ...................................................................... Documentation: Update coreboot 4.17 release notes These are the final release notes before the release. They will be updated immediately following the release with final numbers and the commit ids that the release spans. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Id9491ad9aa6ab3eb5504bee85591f3b1d9bf6cc2 --- M Documentation/releases/coreboot-4.17-relnotes.md 1 file changed, 305 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/64846/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9491ad9aa6ab3eb5504bee85591f3b1d9bf6cc2 Gerrit-Change-Number: 64846 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation: Update index.md and add 4.18 release notes
by Julius Werner (Code Review) 31 May '22

31 May '22

Attention is currently required from: Martin L Roth. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64843 ) Change subject: Documentation: Update index.md and add 4.18 release notes ...................................................................... Patch Set 1: (1 comment) File Documentation/releases/coreboot-4.18-relnotes.md: https://review.coreboot.org/c/coreboot/+/64843/comment/04accfbe_eca97b41 PS1, Line 17: Would you mind adding the planned deprecation for the old libpayload API while you're here (https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/VLMK… -- To view, visit https://review.coreboot.org/c/coreboot/+/64843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52814ebbae804ea0ff24a7cec0618054029b8b47 Gerrit-Change-Number: 64843 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 00:23:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2022