coreboot-gerrit May 2022

coreboot-gerrit@coreboot.org

1 participants
6166 discussions

Change in coreboot[master]: mb/google/skyrim: Fix SD card power sequence
by Ian Feng (Code Review) 03 May '22

03 May '22

Ian Feng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64023 ) Change subject: mb/google/skyrim: Fix SD card power sequence ...................................................................... mb/google/skyrim: Fix SD card power sequence Fix power sequence according to datasheet:GL9750S-OIY04 rev1.24. BUG=b:229181624 TEST=Build and boot to OS in Skyrim. Ensure that the SD Controller and SD Card are enumerated fine. Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Change-Id: Iea729d43d10a3f8353b4fe540146d00975f4d422 --- M src/mainboard/google/skyrim/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/64023/1 diff --git a/src/mainboard/google/skyrim/variants/baseboard/gpio.c b/src/mainboard/google/skyrim/variants/baseboard/gpio.c index 53c40de..41d6bbe 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/gpio.c +++ b/src/mainboard/google/skyrim/variants/baseboard/gpio.c @@ -195,6 +195,8 @@ PAD_GPO(GPIO_7, HIGH), /* PCIE_RST0_L */ PAD_NFO(GPIO_26, PCIE_RST0_L, HIGH), + /* SD_AUX_RESET_L */ + PAD_NFO(GPIO_27, PCIE_RST1_L, HIGH), }; __weak void variant_pcie_gpio_table(const struct soc_amd_gpio **gpio, size_t *size) -- To view, visit https://review.coreboot.org/c/coreboot/+/64023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea729d43d10a3f8353b4fe540146d00975f4d422 Gerrit-Change-Number: 64023 Gerrit-PatchSet: 1 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/cmn/blk/pmc: API to inform PMC about PCI enumeration done
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63953 ) Change subject: soc/intel/cmn/blk/pmc: API to inform PMC about PCI enumeration done ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63953/comment/5acd9095_fa67b902 PS3, Line 7: soc/intel/cmn/blk/pmc: API to inform PMC about PCI enumeration done Please make it a statement by adding a verb in imperative mood: > Add API … https://review.coreboot.org/c/coreboot/+/63953/comment/75ceab01_df8952aa PS3, Line 10: Who is going to use this API? File src/soc/intel/common/block/pmc/pmclib.c: https://review.coreboot.org/c/coreboot/+/63953/comment/651630d1_3d965a6f PS3, Line 799: printk(BIOS_ERR, "PMC: Failed sending PCI Enumeration Done Command\n"); What are the consequences, and what should be done in this case? -- To view, visit https://review.coreboot.org/c/coreboot/+/63953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77d428f9501feaccab8bb431090d10ce8d3af9b2 Gerrit-Change-Number: 63953 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 03 May 2022 07:14:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: enable BT offload on Moli
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Tim Wawrzynczak, Casper Chang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64020 ) Change subject: mb/google/brask/variants/moli: enable BT offload on Moli ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/64020/comment/f39ffc53_371467ec PS1, Line 7: on Moli Already in prefix. https://review.coreboot.org/c/coreboot/+/64020/comment/1d516267_fc871678 PS1, Line 9: Enable BT offload on moli Mention fw_config, NAU88L25B, and what needs to be done to hook them up. https://review.coreboot.org/c/coreboot/+/64020/comment/46243b86_051a68c6 PS1, Line 12: TEST=emerge-brask coreboot. Check BT offload enabled and audio works. How can this be checked in the OS? -- To view, visit https://review.coreboot.org/c/coreboot/+/64020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72d91d2dafffa7d9604b7dd3d697cb3b2b04b152 Gerrit-Change-Number: 64020 Gerrit-PatchSet: 1 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 03 May 2022 07:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [only for test] test gcc-13 snapshot
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Elyes Haouas. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61533 ) Change subject: [only for test] test gcc-13 snapshot ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > Building GCC v13-20220501 for target ... failed. Check 'build-i386-elf-GCC/build.log'. -- To view, visit https://review.coreboot.org/c/coreboot/+/61533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2545f4119a20eec6482fbdf8993eb842af96a0a7 Gerrit-Change-Number: 61533 Gerrit-PatchSet: 10 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 03 May 2022 06:47:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Make __weak usage consistent
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63178 ) Change subject: mb/google/brya: Make __weak usage consistent ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63178/comment/01546c88_fe0cbaea PS2, Line 7: mb/google/brya: Make __weak usage consistent At least I had to look at the diff to understand, what is meant by this. No idea, if below is better: > Consistently put void before __weak attribute -- To view, visit https://review.coreboot.org/c/coreboot/+/63178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic59cccdf0fb88fc71a440170ee40b73dd8736a33 Gerrit-Change-Number: 63178 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 06:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo: correct typo in macros
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Stefan Ott, Peter Lemenkov, Alexander Couzens. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63991 ) Change subject: lenovo: correct typo in macros ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63991/comment/83480928_1303b6ca PS1, Line 7: lenovo: correct typo in macros Maybe: > lenovo: Correct typo in macro H8_HAS_BAT_THRESHOLDS_IMPL -- To view, visit https://review.coreboot.org/c/coreboot/+/63991 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0550a115d75183cd72e478ae739731001febe22 Gerrit-Change-Number: 63991 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 May 2022 06:43:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Fix wrong typec_port for voxel
by Derek Huang (Code Review) 03 May '22

03 May '22

Derek Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64022 ) Change subject: mb/google/volteer: Fix wrong typec_port for voxel ...................................................................... mb/google/volteer: Fix wrong typec_port for voxel This change fixes wrong type-C port number for voxel. Voxel uses tcss_usb3_port1 not tcss_usb3_port3. BUG=b:189476816 TEST=Check the transactions are happening on correct port. Also checked retimer firmware update on both the ports. Signed-off-by: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Change-Id: Iba7b3b15296bed99d3626a6d53dfd59e8d20fe5f --- M src/mainboard/google/volteer/variants/voxel/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/64022/1 diff --git a/src/mainboard/google/volteer/variants/voxel/overridetree.cb b/src/mainboard/google/volteer/variants/voxel/overridetree.cb index 4bca103..a2bb85d 100644 --- a/src/mainboard/google/volteer/variants/voxel/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voxel/overridetree.cb @@ -83,7 +83,7 @@ chip drivers/intel/usb4/retimer register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H10)" register "dfp[1].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H10)" - use tcss_usb3_port3 as dfp[0].typec_port + use tcss_usb3_port1 as dfp[0].typec_port use tcss_usb3_port2 as dfp[1].typec_port device generic 0 on end end -- To view, visit https://review.coreboot.org/c/coreboot/+/64022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba7b3b15296bed99d3626a6d53dfd59e8d20fe5f Gerrit-Change-Number: 64022 Gerrit-PatchSet: 1 Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: lenovo: correct typo in macros
by Felix Singer (Code Review) 03 May '22

03 May '22

Attention is currently required from: Stefan Ott, Peter Lemenkov, Alexander Couzens. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63991 ) Change subject: lenovo: correct typo in macros ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63991 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0550a115d75183cd72e478ae739731001febe22 Gerrit-Change-Number: 63991 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 May 2022 06:11:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Make __weak usage consistent
by Elyes Haouas (Code Review) 03 May '22

03 May '22

Attention is currently required from: Tim Wawrzynczak. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63178 ) Change subject: mb/google/brya: Make __weak usage consistent ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: ( git grep '__weak void' ) -- To view, visit https://review.coreboot.org/c/coreboot/+/63178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic59cccdf0fb88fc71a440170ee40b73dd8736a33 Gerrit-Change-Number: 63178 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 06:06:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo: correct typo in macros
by Elyes Haouas (Code Review) 03 May '22

03 May '22

Attention is currently required from: Stefan Ott, Peter Lemenkov, Alexander Couzens. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63991 ) Change subject: lenovo: correct typo in macros ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63991 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0550a115d75183cd72e478ae739731001febe22 Gerrit-Change-Number: 63991 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 May 2022 06:02:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2022