Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63862 )
Change subject: mb/siemens/mc_ehl2: Adjust PSE TSN settings in devicetree
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63862/comment/b8069cfc_dcde3e60
PS2, Line 9: Controller
> controllers
Done
https://review.coreboot.org/c/coreboot/+/63862/comment/1f8f38cc_520033d4
PS2, Line 10: including
> Do you want to mention that they are controlled by the PSE? Or what is this 'including' referring to […]
I have expanded the sentence a little...
--
To view, visit https://review.coreboot.org/c/coreboot/+/63862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74e660548b2c44d5dbdb6023d5a36cfdd7e96f43
Gerrit-Change-Number: 63862
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Tue, 03 May 2022 07:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Arthur Heymans, Werner Zeh.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63982 )
Change subject: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63982/comment/153d084b_1b960d6c
PS1, Line 7: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI
Mention APL somewhere in here?
https://review.coreboot.org/c/coreboot/+/63982/comment/2fffcb90_07676679
PS1, Line 16: controller inaccessible from the OS.
Mention that flashrom is one of the affected use cases?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63982
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa89cdf41f42d4df5b46f095e22924157d9f3c3f
Gerrit-Change-Number: 63982
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Tue, 03 May 2022 07:20:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63861 )
Change subject: soc/intel/elkhartlake: Implement TSN GbE driver
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/63861/comment/176bfa35_8c3a96db
PS2, Line 240: TSN_GBE_DRIVER
> Since this would be an elkhart lake spcific driver should we name it EHL_TSN_DRIVER?
Renamed to EHL_TSN_DRIVER - you are right, this is EHL specific
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/63861/comment/d0173a96_d82e923a
PS2, Line 15: if (!io_mem_base) {
: printk(BIOS_ERR, "TSN GbE: Error can't find I/O MEM resource\n");
: return;
: }
> This check is not needed here as it is already done in find_resource() for you. […]
With the removal of the check I must also remove the first two lines for the time being. I will reimplement this at the first use.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63861
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7522914c56b74486bb088280d2686acf7027d1d3
Gerrit-Change-Number: 63861
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Tue, 03 May 2022 07:18:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64024 )
Change subject: drivers/phy/m88e1512: Add new driver for Marvell PHY 88E1512
......................................................................
drivers/phy/m88e1512: Add new driver for Marvell PHY 88E1512
This driver enables the usage of an external Marvell PHY 88E1512 which
should be connected to a SOC internal MAC controller. In a first step it
is only the framework of the driver. Functionality will follow with a
second patch. To be able to use the driver, it is necessary to activate
the scan bus operation in the corresponding SOC TSN GbE driver.
One can change parameters in device tree so that the used setup can be
adapted in device tree to match the configuration of the device on the
mainboard.
Link to the Marvell PHY 88E1512 datasheet:
https://www.marvell.com/content/dam/marvell/en/public-collateral/
transceivers/marvell-phys-transceivers-alaska-88e151x-datasheet.pdf
Change-Id: Iabe1aef2217dfaee4b5a4bd83782ab588d4be642
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
A src/drivers/phy/m88e1512/Kconfig
A src/drivers/phy/m88e1512/Makefile.inc
A src/drivers/phy/m88e1512/chip.h
A src/drivers/phy/m88e1512/m88e1512.c
M src/soc/intel/elkhartlake/tsn_gbe.c
5 files changed, 42 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/64024/1
diff --git a/src/drivers/phy/m88e1512/Kconfig b/src/drivers/phy/m88e1512/Kconfig
new file mode 100644
index 0000000..8e9a2d9
--- /dev/null
+++ b/src/drivers/phy/m88e1512/Kconfig
@@ -0,0 +1,5 @@
+config DRIVERS_PHY_M88E1512
+ bool
+ default n
+ help
+ Enable support for external Marvell PHY chip 88E1512.
diff --git a/src/drivers/phy/m88e1512/Makefile.inc b/src/drivers/phy/m88e1512/Makefile.inc
new file mode 100644
index 0000000..0d38051
--- /dev/null
+++ b/src/drivers/phy/m88e1512/Makefile.inc
@@ -0,0 +1 @@
+ramstage-$(CONFIG_DRIVERS_PHY_M88E1512) += m88e1512.c
diff --git a/src/drivers/phy/m88e1512/chip.h b/src/drivers/phy/m88e1512/chip.h
new file mode 100644
index 0000000..d3ca3b5
--- /dev/null
+++ b/src/drivers/phy/m88e1512/chip.h
@@ -0,0 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+struct drivers_phy_m88e1512_config {
+ uint8_t device_index;
+};
diff --git a/src/drivers/phy/m88e1512/m88e1512.c b/src/drivers/phy/m88e1512/m88e1512.c
new file mode 100644
index 0000000..c3ceb2c
--- /dev/null
+++ b/src/drivers/phy/m88e1512/m88e1512.c
@@ -0,0 +1,29 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <console/console.h>
+#include <device/device.h>
+#include "chip.h"
+
+static void m88e1512_final(struct device *dev)
+{
+ struct drivers_phy_m88e1512_config *config = dev->chip_info;
+
+ printk(BIOS_INFO, "%s: device index %x / pnp port %x\n", dev->chip_ops->name,
+ config->device_index, dev->path.pnp.port);
+}
+
+static struct device_operations m88e1512_ops = {
+ .read_resources = noop_read_resources,
+ .set_resources = noop_set_resources,
+ .final = m88e1512_final,
+};
+
+static void m88e1512_enable(struct device *dev)
+{
+ dev->ops = &m88e1512_ops;
+}
+
+struct chip_operations drivers_phy_m88e1512_ops = {
+ CHIP_NAME("88E1512")
+ .enable_dev = m88e1512_enable
+};
diff --git a/src/soc/intel/elkhartlake/tsn_gbe.c b/src/soc/intel/elkhartlake/tsn_gbe.c
index bab5c1c..208ad83 100644
--- a/src/soc/intel/elkhartlake/tsn_gbe.c
+++ b/src/soc/intel/elkhartlake/tsn_gbe.c
@@ -120,6 +120,8 @@
.read_resources = pci_dev_read_resources,
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
+ .scan_bus = scan_generic_bus,
+ .ops_pci = &pci_dev_ops_pci,
.final = gbe_tsn_final,
};
--
To view, visit https://review.coreboot.org/c/coreboot/+/64024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabe1aef2217dfaee4b5a4bd83782ab588d4be642
Gerrit-Change-Number: 64024
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-MessageType: newchange
Attention is currently required from: Werner Zeh.
Hello build bot (Jenkins), Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63889
to look at the new patch set (#2).
Change subject: mb/siemens/mc_ehl2: Invert PHY IRQ from falling edge to rising edge
......................................................................
mb/siemens/mc_ehl2: Invert PHY IRQ from falling edge to rising edge
There are three external Marvel PHY 88E1512 on this mainboard. The PHY
IRQ comes with a falling edge but the EHL MAC side needs a rising edge
signal. For that reason, we need an inversion of the IRQ polarity.
Change-Id: Id3caf582b4434b046779f5733e6ad9b57528ce35
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/63889/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63889
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3caf582b4434b046779f5733e6ad9b57528ce35
Gerrit-Change-Number: 63889
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Mario Scheithauer.
Hello build bot (Jenkins), Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63888
to look at the new patch set (#2).
Change subject: soc/intel/ehl: Provide function to change PHY-to-MAC IRQ polarity
......................................................................
soc/intel/ehl: Provide function to change PHY-to-MAC IRQ polarity
EHL MAC side expects a rising edge signal for an IRQ. Based on the
mainboard wiring it could be necessary to change the interrupt polarity.
This patch provides the functionality to invert a falling edge signal
that comes from an external PHY.
Change-Id: Ia314014c7cacbeb72629c773c8c0bb5f002a3f54
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/soc/intel/elkhartlake/Kconfig
M src/soc/intel/elkhartlake/include/soc/tsn_gbe.h
M src/soc/intel/elkhartlake/tsn_gbe.c
3 files changed, 112 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/63888/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63888
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia314014c7cacbeb72629c773c8c0bb5f002a3f54
Gerrit-Change-Number: 63888
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Werner Zeh.
Hello build bot (Jenkins), Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63864
to look at the new patch set (#3).
Change subject: mb/siemens/mc_ehl2: Enable TSN GbE driver
......................................................................
mb/siemens/mc_ehl2: Enable TSN GbE driver
This variant uses all three EHL Ethernet GbE-TSN Controller so enable
the TSN GbE driver in order to set the needed MAC addresses. The
required function to retrieve a valid MAC address was already implement
in the common mainboard.c for mc_ehl.
TEST:
- Boot mc_ehl2 into Linux and check MAC addr via ifconfig
Change-Id: Ia052c44feb606f9e1d31d047f2acc67e3226a895
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/63864/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/63864
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia052c44feb606f9e1d31d047f2acc67e3226a895
Gerrit-Change-Number: 63864
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Mario Scheithauer.
Hello build bot (Jenkins), Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63863
to look at the new patch set (#3).
Change subject: soc/intel/elkhartlake: Provide ability to update TSN GbE MAC addresses
......................................................................
soc/intel/elkhartlake: Provide ability to update TSN GbE MAC addresses
This patch provides the functionality to change the TSN GbE MAC
addresses. Prerequisite for this is a mainboard specific function that
returns a matching MAC address.
A test was performed with the following patch, which enables the TSN GbE
driver for mc_ehl2 mainboard.
Change-Id: I2303a64cfd09fa02734ca9452d26591af2a76221
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/soc/intel/elkhartlake/include/soc/tsn_gbe.h
M src/soc/intel/elkhartlake/tsn_gbe.c
2 files changed, 36 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/63863/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/63863
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2303a64cfd09fa02734ca9452d26591af2a76221
Gerrit-Change-Number: 63863
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63862
to look at the new patch set (#3).
Change subject: mb/siemens/mc_ehl2: Adjust PSE TSN settings in devicetree
......................................................................
mb/siemens/mc_ehl2: Adjust PSE TSN settings in devicetree
This mainboard uses all three internal Ethernet GbE-TSN controllers. Two
of them reside in PCH including Intel Programmable Services Engine (PSE)
and are controlled by these.
This patch enables the Serial Gigabit Media Independent Interface
(SGMII) mode for GbE PSE0 and GbE PSE1. By setting PCH PSE DMA pins to
host owned, the IO is under control of the IA processor cores through
system software. And furthermore, the PCH TSN Link speed is set to 1
Gbps.
TEST:
- Boot mc_ehl2 into Linux and check inet addr via ifconfig
Change-Id: I74e660548b2c44d5dbdb6023d5a36cfdd7e96f43
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/63862/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/63862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74e660548b2c44d5dbdb6023d5a36cfdd7e96f43
Gerrit-Change-Number: 63862
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Mario Scheithauer.
Hello build bot (Jenkins), Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63861
to look at the new patch set (#3).
Change subject: soc/intel/elkhartlake: Implement TSN GbE driver
......................................................................
soc/intel/elkhartlake: Implement TSN GbE driver
To be able to make EHL Ethernet GbE-TSN Controller configurable, a
driver is required. Functionality comes in following patches.
Change-Id: I7522914c56b74486bb088280d2686acf7027d1d3
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/soc/intel/elkhartlake/Kconfig
M src/soc/intel/elkhartlake/Makefile.inc
A src/soc/intel/elkhartlake/include/soc/tsn_gbe.h
A src/soc/intel/elkhartlake/tsn_gbe.c
4 files changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/63861/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/63861
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7522914c56b74486bb088280d2686acf7027d1d3
Gerrit-Change-Number: 63861
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-MessageType: newpatchset