coreboot-gerrit May 2022

coreboot-gerrit@coreboot.org

1 participants
6166 discussions

Change in coreboot[master]: soc/amd/common/block/psp/psp_gen2: move CORE_2_PSP_MSG_38 defines
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Jason Glenesk, Marshall Dawson, Fred Reitberger, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64011 ) Change subject: soc/amd/common/block/psp/psp_gen2: move CORE_2_PSP_MSG_38 defines ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67cc2ff63d1c0322b514521975f3ce0f9b1cf5b1 Gerrit-Change-Number: 64011 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 03 May 2022 07:39:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Henry Sun, Super Ni, Teddy Shih, Aseda Aboagye, Simon Yang, Ivan Chen, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63652 ) Change subject: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/dedede/variants/beadrix/overridetree.cb: https://review.coreboot.org/c/coreboot/+/63652/comment/e06552ea_ccb4f89a PS4, Line 188: register "reg_gnrl_ctrl0" = "0x0a" Where are these values from? -- To view, visit https://review.coreboot.org/c/coreboot/+/63652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If172d13aa62503547227adf91f049ea50b948888 Gerrit-Change-Number: 63652 Gerrit-PatchSet: 4 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshihau(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com> Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Attention: Teddy Shih <teddyshihau(a)gmail.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 03 May 2022 07:34:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Henry Sun, Super Ni, Teddy Shih, Aseda Aboagye, Simon Yang, Ivan Chen, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63652 ) Change subject: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63652/comment/acb60b11_bfaed257 PS4, Line 9: To meet LTE's RF Specific Absorption Rate (SAR) certification, : we add a Semtech Smart Proximity Sensor (P-Sensor) SX9324 for SAR. : P-Sensor connects EC of I2C 5 bus and GPIO D22, D23, as well as, : SoC of GPIO E11, according to mainboard schematic. Please reflow for 72 characters per line. -- To view, visit https://review.coreboot.org/c/coreboot/+/63652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If172d13aa62503547227adf91f049ea50b948888 Gerrit-Change-Number: 63652 Gerrit-PatchSet: 4 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshihau(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com> Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Attention: Teddy Shih <teddyshihau(a)gmail.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 03 May 2022 07:33:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/acpi: Add support for NBCI _DSM subfunction
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64008 ) Change subject: mb/google/brya/acpi: Add support for NBCI _DSM subfunction ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/64008/comment/cfadc1aa_2e40a9de PS1, Line 11: Nvidia Please specify which one. I guess the proprietary? https://review.coreboot.org/c/coreboot/+/64008/comment/1c26fd3d_172b5b9c PS1, Line 14: TEST=build Which proprietary Nvidia kernel driver and what Linux version are you testing with? -- To view, visit https://review.coreboot.org/c/coreboot/+/64008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19eb9417923d297a084d6f5329682e91cd506a9e Gerrit-Change-Number: 64008 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 07:28:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/crota: Enable Bluetooth offload support
by Paul Menzel (Code Review) 03 May '22

03 May '22

1 0

Change in coreboot[master]: mb/google/brya/variants/crota: Enable Bluetooth offload support
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Terry Chen, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64019 ) Change subject: mb/google/brya/variants/crota: Enable Bluetooth offload support ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/brya/variants/crota/gpio.c: https://review.coreboot.org/c/coreboot/+/64019/comment/83a3789a_15198a48 PS3, Line 102: PAD_CFG_NF(GPP_VGPIO_30, NONE, DEEP, NF3), /* BT_I2S_BCLK */ : PAD_CFG_NF(GPP_VGPIO_31, NONE, DEEP, NF3), /* BT_I2S_SYNC */ : PAD_CFG_NF(GPP_VGPIO_32, NONE, DEEP, NF3), /* BT_I2S_SDO */ : PAD_CFG_NF(GPP_VGPIO_33, NONE, DEEP, NF3), /* BT_I2S_SDI */ : PAD_CFG_NF(GPP_VGPIO_34, NONE, DEEP, NF1), /* SSP2_SCLK */ : PAD_CFG_NF(GPP_VGPIO_35, NONE, DEEP, NF1), /* SSP2_SFRM */ : PAD_CFG_NF(GPP_VGPIO_36, NONE, DEEP, NF1), /* SSP_TXD */ : PAD_CFG_NF(GPP_VGPIO_37, NONE, DEEP, NF1), /* SSP_RXD */ Mention the source in the commit message. File src/mainboard/google/brya/variants/crota/variant.c: https://review.coreboot.org/c/coreboot/+/64019/comment/7f864963_95b3ae4b PS3, Line 9: config->cnvi_bt_audio_offload = 1; Please fix the indentation. -- To view, visit https://review.coreboot.org/c/coreboot/+/64019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ac54156cc4a8d824ed1c549d66fc369698a352c Gerrit-Change-Number: 64019 Gerrit-PatchSet: 3 Gerrit-Owner: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 07:27:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/ehl: Provide function to change PHY-to-MAC IRQ polarity
by Mario Scheithauer (Code Review) 03 May '22

03 May '22

Attention is currently required from: Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63888 ) Change subject: soc/intel/ehl: Provide function to change PHY-to-MAC IRQ polarity ...................................................................... Patch Set 2: (20 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63888/comment/9e026077_3ef04532 PS1, Line 7: PHY to MAC > 'PHY-to-MAC' could make things more clear here as it is the IRQ routed from the external PHY to the […] Done https://review.coreboot.org/c/coreboot/+/63888/comment/1a423c0d_3df8fb99 PS1, Line 9: It may be that a connected PHY requires an inverting of the interrupt : signal. > Maybe: […] Done File src/soc/intel/elkhartlake/Kconfig: https://review.coreboot.org/c/coreboot/+/63888/comment/47991c3f_158aa94a PS1, Line 246: TSN_GBE_PHY2MAC_INTR_POL > Should we move to a model where the polarity is given directly instead of just 'inverting' the curre […] Done https://review.coreboot.org/c/coreboot/+/63888/comment/2b0d011b_cfb94be0 PS1, Line 251: This invert > Maybe: […] Done File src/soc/intel/elkhartlake/include/soc/tsn_gbe.h: https://review.coreboot.org/c/coreboot/+/63888/comment/46745fc4_6a5c5b76 PS1, Line 12: TSN_GMII_DELAY > Add _US to the define to indicated that the timout is in microsecond units? Done https://review.coreboot.org/c/coreboot/+/63888/comment/46650aa1_93ce834c PS1, Line 14: ADDR > Maybe 'ADR'? Done https://review.coreboot.org/c/coreboot/+/63888/comment/43f53229_4a23f261 PS1, Line 24: ADD > 'ADR' as you mead address here? ADD just look weird here. Done https://review.coreboot.org/c/coreboot/+/63888/comment/4564753d_bb95c95d PS1, Line 26: 0x40 > Once you have started to use the shift syntax, why not continue here? […] Done File src/soc/intel/elkhartlake/tsn_gbe.c: https://review.coreboot.org/c/coreboot/+/63888/comment/fb535f1a_652b34a5 PS1, Line 34: : uint32_t i; : : for (i = 0; i < TSN_MAX_LOOP_TIME; ++i) { : if (read32((void *)(io_mem_base + TSN_MAC_MDIO_ADDR)) & TSN_MAC_GMII_BUSY) : udelay(TSN_GMII_DELAY); : else : return CB_SUCCESS; : } : printk(BIOS_ERR, "%s Timeout in %d micro seconds\n", __func__, : TSN_MAX_LOOP_TIME * TSN_GMII_DELAY); : return CB_ERR; > Would it make sense to use a stopwatch here instead? You could get rid of the for-loop by just defin […] Done https://review.coreboot.org/c/coreboot/+/63888/comment/ce391451_af205b28 PS1, Line 48: uint8_t phy_add, uint8_t reg_add > I would rather call them pyh_adr and reg_adr here. Done https://review.coreboot.org/c/coreboot/+/63888/comment/b22b687a_e5e7cbf4 PS1, Line 52: Status > status Done https://review.coreboot.org/c/coreboot/+/63888/comment/c37dd945_547f074c PS1, Line 62: // Wait for MDIO frame transfer complete before reading MDIO DATA register > Please use the propper comment style here. Done https://review.coreboot.org/c/coreboot/+/63888/comment/46e51238_dbc62e16 PS1, Line 65: die > Maybe die() is a bit to hard here. Let's try to continue as far as possible while throwing an error. Done https://review.coreboot.org/c/coreboot/+/63888/comment/2bccfb56_0496857a PS1, Line 68: BIOS_INFO > This one should be on DEBUG level (or even on SPEW) I guess, or? Done https://review.coreboot.org/c/coreboot/+/63888/comment/b23e8814_0bcb5bbe PS1, Line 73: phy_add, uint8_t reg_add > pyh_adr and reg_adr Done https://review.coreboot.org/c/coreboot/+/63888/comment/e3e51cb8_56bffe8c PS1, Line 77: Status > status Done https://review.coreboot.org/c/coreboot/+/63888/comment/d031aee2_2975be5e PS1, Line 87: // Wait for MDIO frame transfer complete before reading MDIO DATA register > Please use the proper comment style. Done https://review.coreboot.org/c/coreboot/+/63888/comment/2898dd5b_cea4adcd PS1, Line 88: Status > status Done https://review.coreboot.org/c/coreboot/+/63888/comment/f10f1bf3_0c820ba5 PS1, Line 90: die("TSN GMII Busy. MIDO phy_add: 0x%x, Register 0x%x read invalid\n", : phy_add, reg_add); > Again, die() is a bit too hard here. Done https://review.coreboot.org/c/coreboot/+/63888/comment/f88e01f8_da4c1653 PS1, Line 93: BIOS_INFO > DEBUG or even SPEW would be better here. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63888 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia314014c7cacbeb72629c773c8c0bb5f002a3f54 Gerrit-Change-Number: 63888 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 03 May 2022 07:27:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel: Return ACPI_S4 as previous sleep state
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Evan Green. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64002 ) Change subject: soc/intel: Return ACPI_S4 as previous sleep state ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/64002/comment/dfd9ff5e_6cb64ebf PS1, Line 8: Mention the problem, that suspend to disk currently does not(?) work? https://review.coreboot.org/c/coreboot/+/64002/comment/c037d647_be467b3b PS1, Line 10: acpi_sleep_from_pm1() Nit: Fits on the line above. -- To view, visit https://review.coreboot.org/c/coreboot/+/64002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3fb3dc428a749db80293e51a04a2096514a7b689 Gerrit-Change-Number: 64002 Gerrit-PatchSet: 1 Gerrit-Owner: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Comment-Date: Tue, 03 May 2022 07:24:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Provide ability to update TSN GbE MAC addresses
by Mario Scheithauer (Code Review) 03 May '22

03 May '22

Attention is currently required from: Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63863 ) Change subject: soc/intel/elkhartlake: Provide ability to update TSN GbE MAC addresses ...................................................................... Patch Set 3: (3 comments) File src/soc/intel/elkhartlake/tsn_gbe.c: https://review.coreboot.org/c/coreboot/+/63863/comment/8d313aaf_13fc97d9 PS2, Line 11: adr_to_set > Maybe just call it 'mac' here to shorten down the name a bit? Done https://review.coreboot.org/c/coreboot/+/63863/comment/340017b7_9790aebd PS2, Line 16: printk(BIOS_ERR, "TSN GbE: No valid MAC address found\n"); > I wouldn't print that with ERROR level as there are valid cases where the mainboard code does not pr […] Done https://review.coreboot.org/c/coreboot/+/63863/comment/49514650_23710615 PS2, Line 25: *mac_p = (*mac_p & 0xFFFF0000) | (adr_to_set[5] << 8) | adr_to_set[4]; > How about uing clrsetbits32() from device/mmio.h here? Could look like: […] Great idea. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/63863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2303a64cfd09fa02734ca9452d26591af2a76221 Gerrit-Change-Number: 63863 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 03 May 2022 07:22:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: (only for test) crossgcc: Update to GCC 11.3
by Paul Menzel (Code Review) 03 May '22

03 May '22

Attention is currently required from: Elyes Haouas. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64021 ) Change subject: (only for test) crossgcc: Update to GCC 11.3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Duplicate of https://review.coreboot.org/c/coreboot/+/63807? -- To view, visit https://review.coreboot.org/c/coreboot/+/64021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27a2a16c2aa1cda36d7e8cb4dc48057fc210d110 Gerrit-Change-Number: 64021 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 03 May 2022 07:20:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2022