Attention is currently required from: Michał Żygowski, Michał Kopeć, Paul Menzel, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63310 )
Change subject: superiotool/ite: add IT8265E EC registers
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63310/comment/0e4da8fb_52526f40
PS2, Line 7: IT8265E
Two numbers are flipped: s/26/62
--
To view, visit https://review.coreboot.org/c/coreboot/+/63310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68aad90097206c6b8ef40075530c00809d9511e2
Gerrit-Change-Number: 63310
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 03 Apr 2022 10:04:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Damien Zammit, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62808 )
Change subject: mb/hp/z220_series: Convert z220_sff_workstation into variant
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62808/comment/5ce09b92_e5d99bbc
PS3, Line 17: Flashed bios region internally, mainboard also has FDO
: (flash descriptor override) jumper that allows r/w to whole flash.
> For another commit: This is something worth adding to the documentation.
Ah, CB:63318 already exists.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6aaac75216b2d7c8bb48801454ce616ace3b1422
Gerrit-Change-Number: 62808
Gerrit-PatchSet: 3
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Sun, 03 Apr 2022 10:03:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Damien Zammit, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63318 )
Change subject: doc/mb/hp/z220_sff: Add flash override jumper info
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File Documentation/mainboard/hp/z220_sff.md:
https://review.coreboot.org/c/coreboot/+/63318/comment/7d89ee74_21129066
PS1, Line 43: However, there is a jumper on the board marked `FDO` (flash descriptor override).
> Nit: Please do not wrap lines after sentences.
I think the line breaking is reasonable. If the first line being shorter than the others is too visually unappealing, I'd simply replace `descriptor` with `descriptor region`.
https://review.coreboot.org/c/coreboot/+/63318/comment/6dc7b6fb_16ad2ac2
PS1, Line 43: there is a jumper on the board
> Maybe give a rough location (bottom-right or next to CPU socket).
IIRC, on the SFF board it's somewhere between the PCH and the rear I/O ports. No idea where it is on the CMT board.
https://review.coreboot.org/c/coreboot/+/63318/comment/7c26c8e6_663528ee
PS1, Line 44: Setting the jumper gives you unrestricted r/w access to the whole flash internally.
I remember seeing that vendor firmware on this board uses protected ranges to write-protect parts of the BIOS region, except when the FDO jumper is set. I'd mention this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63318
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia23f73d97d2fab0c561b33656a09709d42cb2f73
Gerrit-Change-Number: 63318
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 03 Apr 2022 10:02:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Maulik V Vaghela, Christian Walter, Tim Wawrzynczak, Meera Ravindranath, Arthur Heymans, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63303 )
Change subject: soc/intel/alderlake: Add VrPowerDeliveryDesign to chip options
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/63303/comment/a9314088_135d4b22
PS1, Line 445: enum
Would be nice to have this enum in the code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63303
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74859e6735e59a15084a9e690b43f68341862833
Gerrit-Change-Number: 63303
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Sun, 03 Apr 2022 09:55:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Maulik V Vaghela, Christian Walter, Tim Wawrzynczak, Meera Ravindranath, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63302 )
Change subject: soc/intel/alderlake: Add new CPU ID
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63302
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I280da46e5fdd3792df50556e2804b3bcb346eee3
Gerrit-Change-Number: 63302
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Sun, 03 Apr 2022 09:54:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Damien Zammit, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62808 )
Change subject: mb/hp/z220_series: Convert z220_sff_workstation into variant
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62808/comment/a3a67ab0_b9133a54
PS3, Line 17: Flashed bios region internally, mainboard also has FDO
: (flash descriptor override) jumper that allows r/w to whole flash.
For another commit: This is something worth adding to the documentation.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6aaac75216b2d7c8bb48801454ce616ace3b1422
Gerrit-Change-Number: 62808
Gerrit-PatchSet: 3
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Sun, 03 Apr 2022 09:49:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Damien Zammit, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62809 )
Change subject: mb/hp/z220_series: Add Z220 CMT Workstation variant
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Patchset:
PS5:
Jenkins isn't happy for some reason
File src/mainboard/hp/z220_series/variants/z220_cmt_workstation/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62809/comment/c93012bf_1484fde6
PS3, Line 5: subsystemid 0x103c 0x1791 inherit
> As per previous commit, yes this line is required to continue the inheritance of the subsystemids.
Hmmm, interesting. Do you mean that, without this line, the devices in the overridetree have the wrong subsystem ID? Interesting.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62809
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b298921e6f509440ec7b049e086c0878f708bd3
Gerrit-Change-Number: 62809
Gerrit-PatchSet: 5
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Sun, 03 Apr 2022 09:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Damien Zammit
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Paul Menzel, Rizwan Qureshi, Tim Wawrzynczak.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63316 )
Change subject: soc/intel/alderlake: Add HID for DPTF Battery Participant
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63316/comment/9e04aeaa_67b51a13
PS3, Line 8:
> Please document, where that HID is defined.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63316
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1fff53f938a5f13423e360c24c7181fa7613492
Gerrit-Change-Number: 63316
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Sun, 03 Apr 2022 07:18:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment